Re: cvs2cl: --utc --accum keeps including old changes

Greetings Arthur,

On Sat, Apr 12, 2003 at 11:12:47PM +0200, Arthur de Jong wrote:
> > Could you please send me a small chunk of cvs log (i.e., simply redirect
> > the output of cvs log to a file), that demonstrates this bug. Then I
> > might be able to look into it.
>
> Sure.

Thanks very much for that.

> I tried it fist on a repository that didn't have any files in them that I
> modified today and that didn't show the problem. The problem may come from
> the time check since I noticed that the double entries all are within an
> hour.
>
> After going over the perl script I think the problem is in
> maybe_grab_accumulation_date() where the retrieved date/time is not
> converted from utc to the local timezone if $UTC_Times is set. cvs seems
> to use the local timezone for the -d option (although the rlog manual page
> suggests otherwise).
>
> So another option might be to use $accumulation_date (converted to utc) in
> the loop when reading the output from 'cvs log' also to check if the log
> messages are really the right ones.
>
> Looking at it I think this patch fixes the problem:

[snip]

And thanks even more for this. Even with the log, it's a pain to test because
of the fact that a date is involved --- and --stdin and -l don't play
together. But your patch looks good, and doesn't disturb any other tests, so
I've folded it in; it'll be in 2.49, which should appear within the next week.

Your time and code is much appreciated.

Mx.
Received on Sun Jun 15 08:49:19 2003