[svnbook commit] r1904 - in trunk/src/en: . book

[Max Bowsher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

C. Michael Pilato wrote:
> maxb wrote:
> 
>> +  * Either of the Python bindings examples are easily able to cause an
>> +    is_canonical assert.  To be fair, this is more the fault of the
>> bindings
>> +    than of the examples, but I'm noting the issue here since it does
>> affect
>> +    first impressions of the book.
> 
> 
> Perhaps we should just add os.path.normpath() wrappers to the sample
> code and be done with it?

os.path.normpath() doesn't have quite the same definition of
'canonical', as Subversion does, so it is not enough. '.' vs '' is one
example.

We probably need to wrap and expose svn_path_canonicalize(), or make the
bindings auto-canonicalize input paths.

Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFDo+iYfFNSmcDyxYARAmaGAKDVhn7naiff8n/zMcgmbx3KuQifSwCfWz8G
E64F6MnwNLdEry4HsSBeQJI=
=3WTx
-----END PGP SIGNATURE-----