[PATCH] Add local customization layers for all languages

Max Bowsher maxb1 at ukf.net
Fri Aug 11 05:54:28 CDT 2006

Øyvind A. Holm wrote:
> * src/tools/Makefile.base-rules
>   ($XSL_DIR): New variable.

Just '(XSL_DIR)', please. $XSL_DIR isn't actually valid make syntax 
anyway, so it looks weird in a log message about a makefile.

> +XSL_DIR := $(shell if test -d "stylesheets"; then \
> +           echo stylesheets; else echo $(TOOLS_DIR); fi)

$(shell ...) is a GNUism, as is := .

Based on bin/find-xsl.py, we do have BSD users who would be a little 
annoyed by this change.

Instead, use something like:

XSL_DIR = `[ -d stylesheets ] && echo stylesheets || echo $(TOOLS_DIR)`


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 188 bytes
Desc: OpenPGP digital signature
URL: <http://www.red-bean.com/pipermail/svnbook-dev/attachments/20060811/9a8bb08f/attachment.sig>

More information about the svnbook-dev mailing list