Alexander Sinyushkin <Alexander.Sinyushkin@svnkit.com>


Found Patch Suggested
r866509, r862846, r858360, r858294 r872277, r871634 r866842, r866841

r872277 | hwright | 2008-07-21 11:16:36 -0500 (Mon, 21 Jul 2008)

Fix double occurrence of the same commit path in commit items array which
takes place in 'svn cp --parent url/src url/dst' command where src exists
and dst does not.

Patch by: Alexander Sinyushkin <Alexander.Sinyushkin@svnkit.com>
          me

* subversion/libsvn_client/copy.c
  (repos_to_repos_copy):  When finding parents for copying, do not add
    a directory twice when it is immediately below the common source and
    destination root.

* subversion/tests/cmdline/copy_tests.py
  (double_parents_with_url): New test
  (test_list): Add test.


r871634 | kfogel | 2008-06-02 21:16:03 -0500 (Mon, 02 Jun 2008)

Make various SVNKit-related fixes to the test suite.

Patch by: Alexander Sinyushkin <Alexander.Sinyushkin@svnkit.com>

* subversion/tests/cmdline/svntest/main.py
  (use_jsvn): Make use_jsvn a global variable that reflects whether
    --use-jsvn was passed or not; do not set use_jsvn to False at the
    end of the 'if use_jsvn:' clause.
  (copy_repos): Close dump_in just after the first call to
    open_pipe(), since we don't use it after that.
  (run): If use_jsvn, set SVN_CURRENT_TEST environment variable to the
    test currently being run.
  (run_tests): If use_jsvn, make svndumpfilter_binary point to
    jsvndumpfilter binary .


r866842 | dlr | 2007-09-24 15:15:13 -0500 (Mon, 24 Sep 2007)

A follow-up to r26767 and r26568, properly correcting a conditional
for the fix for a bug with 'svn commit --changelist=...' where a
conflicted path not referenced by the changelist causes the commit to
fail.

* subversion/libsvn_client/commit_util.c
  (IS_COMMITTABLE): New macro replacing CHANGELIST_MATCHES(), which
   checks that either we aren't using a changelist, or that the entry
   being considered matches our changelist.
  (harvest_committables): Correctly ignore conflicted paths which are
   not part of a specified changelist.  Leverage IS_COMMITTABLE()
   where applicable.

Suggested by: Alexander Sinyushkin


r866841 | dlr | 2007-09-24 14:48:17 -0500 (Mon, 24 Sep 2007)

A follow-up to r26568, correcting a conditional for the fix for a bug
with 'svn commit --changelist=...' where a conflicted path not
referenced by the changelist causes the commit to fail.

* subversion/libsvn_client/commit_util.c
  (harvest_committables): Correctly ignore conflicted paths which are
   not part of a specified changelist.

Suggested by: Alexander Sinyushkin
Reviewed by: sussman


r866509 | kfogel | 2007-09-02 14:17:05 -0500 (Sun, 02 Sep 2007)

* subversion/libsvn_repos/rev_hunt.c
  (get_merged_path_revisions): Decrement the revnum, not the path
    pointer (oops!), when obtaining mergeinfos for comparison.

Found by: Alexander Sinyushkin <Alexander.Sinyushkin@svnkit.com>


r862846 | dlr | 2006-12-20 10:51:06 -0600 (Wed, 20 Dec 2006)

Fix error reporting for 'svnlook propget -t TXN_NAME'.

* subversion/svnlook/main.c
  (do_pget): When a property value cannot be retrieved, output an
   error message appropriate for each of our parameter permutations.

* subversion/tests/cmdline/svnlook_tests.py
  (test_misc): Increase test coverage for 'propget' to cover error
   reporting verification for non-revprops.

Found by: Alexander Sinyushkin <Alexander.Sinyushkin@svnkit.com>
          ehu


r858360 | kfogel | 2006-01-29 18:37:57 -0600 (Sun, 29 Jan 2006)

Fix some bogus error codes that probably crept in through cut-and-paste.

Found by: Alexander Sinyushkin <sa@tmate.org>

* subversion/libsvn_fs_base/dag.c
  (svn_fs_base__dag_set_entry): Return SVN_ERR_FS_NOT_MUTABLE for an
  immutable node, not SVN_ERR_FS_NOT_DIRECTORY.

* subversion/libsvn_fs_fs/dag.c
  (svn_fs_fs__dag_set_entry): Same.


r858294 | ringstrom | 2006-01-25 06:53:25 -0600 (Wed, 25 Jan 2006)

Return the correct error message in FSFS when trying to fetch a dead
transaction.

Found by: Alexander Sinyushkin <sa@tmate.org>

* subversion/libsvn_fs_fs/revs-txns.c
  (get_txn): If the transaction is dead, return SVN_ERR_FS_TRANSACTION_DEAD,
  not SVN_ERR_FS_TRANSACTION_NOT_DEAD.