Barry Scott <barry@barrys-emacs.org>


Found Patch Review Suggested
r1181155, r1146781, r1141695, r869282, r867693, r867667 r1488878 r847423 r867692

r1488878 | philip | 2013-06-03 03:01:43 -0500 (Mon, 03 Jun 2013)

* subversion/libsvn_wc/tree_conflicts.c
  (svn_wc__get_tree_conflict): Don't leave return value uninitialised.

Patch by: Barry Scott <barry{_AT_}barrys-emacs.org>


r1181155 | hwright | 2011-10-10 14:23:04 -0500 (Mon, 10 Oct 2011)

* INSTALL: Remove more references to the -deps tarballs, which aren't shipping
    with 1.7.0.

Found by: Barry Scott <barry@barrys-emacs.org>


r1146781 | julianfoad | 2011-07-14 11:28:47 -0500 (Thu, 14 Jul 2011)

Fix a bug in subtree merging.  See email thread by Barry Scott, 2011-07-02,
"Assert in svn-1.7-alpha2 svn_client_merge3",
<http://svn.haxx.se/dev/archive-2011-07/0052.shtml>.

Found by: Barry Scott <barry{_AT_}barrys-emacs.org>

* subversion/libsvn_client/merge.c
  (adjust_deleted_subtree_ranges): Don't pass an empty rangelist to
    svn_rangelist_intersect(), because that's invalid and throws an
    assertion failure; instead, construct the result manually.


r1141695 | hwright | 2011-06-30 15:12:50 -0500 (Thu, 30 Jun 2011)

Remove mention of now-defunct deps tarball from configure output and INSTALL.

Found by: Barry Scott <barry@barrys-emacs.org>

* build/ac-macros/sqlite.m4:
  Don't mention the deps tarball.

* INSTALL:
  Remove text noting the deps tarball.


r869282 | hwright | 2008-02-06 09:13:42 -0600 (Wed, 06 Feb 2008)

Delete svn_client_propget3() and rename svn_client_propget4() to
svn_client_propget3().

* subversion/include/svn_client.h
  (svn_client_propget3): Delete and recreate from ...
  (svn_client_propget4): ... here.

* subversion/libsvn_client/prop_commands.c
  (svn_client_propget3): Delete and recreate from ...
  (svn_client_propget4): ... here.
  (remote_propget): Update doc string.
  (svn_client_propget2): Update call to svn_client_propget3().

* subversion/libsvn_client/client.h
  (svn_client__get_prop_from_wc): Update doc string.

* subversion/svn/propedit-cmd.c
  (svn_cl__propedit):
* subversion/svn/propget-cmd.c
  (svn_cl__propget):
* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::propertyGet):
  Call svn_client_propget3().

Found by: Barry Scott <barry@barrys-emacs.org>
Patch by: arfrever


r867693 | djames | 2007-11-06 11:14:32 -0600 (Tue, 06 Nov 2007)

* autogen.py: Add helpful note when ctypesgen subdirectory is missing.

Found by: Barry Scott <barry@barrys-emacs.org>


r867692 | djames | 2007-11-06 11:10:05 -0600 (Tue, 06 Nov 2007)

* autogen.py: Use apu-1-config to calculate include paths and link paths for
  apr-util. Add new '--apu-config' option for specifying path to apu-config
  script.

Suggested by: Barry Scott <barry@barrys-emacs.org>


r867667 | hwright | 2007-11-05 09:10:13 -0600 (Mon, 05 Nov 2007)

In the command line client, don't reference a pointer to a local variable
outside of its declared scope.

Found by: Barry Scott <barry@barrys-emacs.org>
Patch by: Stefan Sperling <stsp@elego.de>

* subversion/svn/copy-cmd.c
  (svn_cl__copy): Allocate the peg revision for each copy source on the heap,
  instead of just using a pointer to the loop variable (which changes each time
  through the loop).


r847423 | rey4 | 2003-10-08 00:56:28 -0500 (Wed, 08 Oct 2003)

Handle svn_wc_status_func_t callback, also fixed a comment in svn_client.i
Missing callback was pointed out by Barry Scott <barry@barrys-emacs.org>
on the users list. He also posted a little script to test it.

Review by: Barry Scott <barry@barrys-emacs.org>

* subversion/bindings/swig/svn_client.i
  (svn_wc_status_func_t status_func, void *status_baton):
    new typemap

* subversion/bindings/swig/swigutil_py.h
  (svn_swig_py_status_func):
    new thunk declaration

* subversion/bindings/swig/swigutil_py.c
  (svn_swig_py_status_func):
    new thunk definition

  (make_ob_status):
    new static function used by svn_swig_py_status_func