Bhuvaneswaran A <bhuvan@apache.org> (bhuvan)


Found Patch Review Suggested
r871742 r1292103, r915254, r893418, r887496, r887178, r886819, r886816, r884740, r884394, r884002, r880303, r880302, r880261, r879970, r879969, r879961, r876678, r874691, r870035, r870022, r869942, r869803, r867119, r867037, r867036, r866082, r865558, r865528, r865513, r865406, r865322, r865247, r864820, r864660, r864601, r864491, r864473, r864449, r864424, r864389, r864388, r864146, r864062, r863278, r863091, r863007, r862586, r862518, r862351, r862085, r862083, r861678, r861569, r861440, r861439, r861438, r861392, r861343, r861336, r861335, r861334, r861324 r866084 r920074, r869971, r865513, r861569

r861324 | bhuvan | 2006-08-24 18:19:59 +0000 (Thu, 24 Aug 2006)

* COMMITTERS
  (bhuvan): Add myself as partial committer for the svn2feed.py.



r861334 | bhuvan | 2006-08-25 15:10:36 +0000 (Fri, 25 Aug 2006)

Approved by: cmpilato

* contrib/hook-scripts/check-case-insensitive.py
  (__main__): Include the script's name in the usage statement.



r861335 | bhuvan | 2006-08-25 15:15:13 +0000 (Fri, 25 Aug 2006)

Approved by: cmpilato

De-"string"-ify the script.

* contrib/hook-scripts/check-case-insensitive.py
  (global): Do not import "string" library.
  (Editor.add_directory, Editor.add_file, CheckCase.showfile): Fix uses
  of deprecated string methods.



r861336 | bhuvan | 2006-08-25 15:19:10 +0000 (Fri, 25 Aug 2006)

Approved by: cmpilato
Suggested by: Kamesh Jayachandran <kamesh@collab.net>

Fix the unpythonic "if" conditions.
* contrib/hook-scripts/check-case-insensitive.py
  (CheckCase.showfile): Fix the unpythonic "if" conditions.



r861343 | bhuvan | 2006-08-26 16:36:48 +0000 (Sat, 26 Aug 2006)

Approved by: djames

Do not import "string" library when it is not used.
[in subversion/tests/cmdline/]
* revert_tests.py
* trans_tests.py
* externals_tests.py
* lock_tests.py
* history_tests.py
* switch_tests.py
* copy_tests.py
* stat_tests.py
* schedule_tests.py
* prop_tests.py
* export_tests.py
* utf8_tests.py
* merge_tests.py
* getopt_tests.py
  Do not import "string" library when it is not used.


r861392 | bhuvan | 2006-08-30 18:40:44 +0000 (Wed, 30 Aug 2006)

De-string-ify the python scripts.

Patch by: me
Approved by: cmpilato

[in subversion/tests/cmdline]
* import_tests.py
  (global): Do not import "string" library.
  (import_executable, import_ignores, import_no_ignores): Fix uses of
  deprecated string methods.
* autoprop_tests.py
  (global): Do not import "string" library.
  (check_proplist): Fix uses of deprecated string method.
* basic_tests.py
  (global): Do not import "string" library.
  (basic_import, basic_add_no_ignores, uri_syntax): Fix uses of
  deprecated string methods.


r861438 | bhuvan | 2006-09-06 08:43:31 +0000 (Wed, 06 Sep 2006)

Suggested by: maxb
Approved by: dlr
Thread: http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=118024

svn2feed.py:
  * Include copyright text. It is basically a ground work to move this
    script to tools/hook-scripts directory.


r861439 | bhuvan | 2006-09-06 09:02:42 +0000 (Wed, 06 Sep 2006)

contrib/hook-scripts/svn2feed.py:
  * Move it to tools/hook-scripts directory.


r861440 | bhuvan | 2006-09-06 09:06:26 +0000 (Wed, 06 Sep 2006)

www/tools_contrib.html:
 * (hook-scripts): Update the path of svn2feed.py script.


r861569 | bhuvan | 2006-09-14 09:54:33 +0000 (Thu, 14 Sep 2006)

As per this thread [1], rename the script server-vsn.py to
server-version.py.
[1]
http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=499692

Patch by: me
Suggested by: me
Approved by: julianfoad
             dlr

* tools/client-side/server-vsn.py: Rename...
* tools/client-side/server-version.py: ...to this, updating internal
  references to the script name.
* www/tools_contrib.html: Update.


r861678 | bhuvan | 2006-09-22 03:41:56 +0000 (Fri, 22 Sep 2006)

If path is a copy/move, add '+' character to the log message displayed
in SVN_EDITOR.

Patch by: djames
          Kamesh Jayachandran <kamesh@collab.net>
          dlr
          me

subversion/svn/util.c:
  * (svn_cl__get_log_message): If path is a copy/move, add '+' character
    to the log message displayed in SVN_EDITOR.


r862083 | bhuvan | 2006-10-17 22:40:58 +0000 (Tue, 17 Oct 2006)

Patch by: me
Approved by: kfogel

* www/project_license.html
  Automatically redirect the requests to license-1.html after 5 seconds.
  Print the redirect message and provide a link to actual license page.


r862085 | bhuvan | 2006-10-18 00:03:27 +0000 (Wed, 18 Oct 2006)

* www/project_tools.html
* www/faq.html
* www/index.html
  Change all occurrences of "project_license.html" to "license-1.html".

Approved by: kfogel


r862351 | bhuvan | 2006-11-11 02:59:49 +0000 (Sat, 11 Nov 2006)

* tools/hook-scripts/svn2feed.py
  (Svn2Feed._get_item_dict): Place item description between <pre> and
  </pre> tags.


r862518 | dlr | 2006-11-27 18:15:43 +0000 (Mon, 27 Nov 2006)

Avoid importing unused Python libraries in the black box regression
tests.

[ in subversion/tests/cmdline/ ]

* autoprop_tests.py
* basic_tests.py
* copy_tests.py
* export_tests.py
* externals_tests.py
* history_tests.py
* lock_tests.py
* log_tests.py
* prop_tests.py
* revert_tests.py
* schedule_tests.py
* stat_tests.py
* svnadmin_tests.py
* svnsync_tests.py
* switch_tests.py
* trans_tests.py
* utf8_tests.py
  Do not import unused libraries.

* diff_tests.py
  Do not import unused libraries.
  (check_diff_output): Use the string itself when invoking the
   replace() function.

* svnlook_tests.py
  Do not import unused libraries.
  (delete_file_in_moved_dir): Use the string itself when invoking the
   strip() function.

* update_tests.py
  Do not import unused libraries.
  (update_wc_on_windows_drive): Use the string itself when invoking
   the splitfields() function.

Patch by: bhuvan
(Tweaked by me.)


r862586 | bhuvan | 2006-11-30 03:35:58 +0000 (Thu, 30 Nov 2006)

Avoid importing unused python libraries in the black box regression
tests.

[ in subversion/tests/cmdline/svntest ]
* testcase.py
  Do not import unused libraries.
  (TestCase.check_description): Use the string itself when invoking the
  lower() function.

* tree.py 
  Do not import unused libraries.
  (create_from_path, dump_tree): Use the string itself when invoking the
  replace() function.
  (get_props): Use the string itself when invoking the strip() function.

* actions.py
  Do not import unused libraries.
  (setup_pristine_repository, run_and_verify_commit): Use the string
  itself when invoking strip() function.

* main.py
  Do not import unused libraries.
  Use the string itself when invoking replace() function.
  (Sandbox._set_name, run_tests): Use the string itself when invoking
  replace() function.

Patch by: me
Approved by: dlr


r863007 | ehu | 2007-01-08 21:12:38 +0000 (Mon, 08 Jan 2007)

Destroy the APR subpool before every successful return statement.

* subversion/libsvn_client/diff.c
 (merge_props_changed, merge_file_changed, merge_file_added,
  merge_file_deleted, merge_dir_added, merge_dir_deleted): Destroy the APR
   subpool before returning succesfully to prevent iterative pool creation.

Patch by: bhuvan


r863091 | dlr | 2007-01-15 18:24:15 +0000 (Mon, 15 Jan 2007)

Reduce lifetime/size of memory footprint for 'proplist'.

* subversion/libsvn_client/prop_commands.c
  (svn_client_proplist2): Destroy sub-pool after use.

Patch by: bhuvan
(Tweaked by me.)
Reviewed by: lundblad


r863278 | bhuvan | 2007-01-24 07:35:25 +0000 (Wed, 24 Jan 2007)

Destroy the APR subpool before every successful return statement.

[in subversion/libsvn_client/]
* delete.c
  (delete_urls):
* repos_diff.c
  (svn_client__get_diff_editor):
* externals.c
  (switch_external):
* list.c
  (get_dir_contents):
  Destroy the APR subpool before returning successfully to prevent 
  iterative pool creation.

Approved by: dlr
Patch by: me


r864062 | ehu | 2007-03-21 23:18:29 +0000 (Wed, 21 Mar 2007)

Replace hacky l10n status reporting shell scripts with a python script.

* tools/po/svn-po-status-report.sh
* tools/po/svn-po-status-run.sh
  Delete (now obsolete).

* tools/po/l10n-report.py
  New. Replaces the above 2.

Patch by: bhuvan
Suggested by: maxb
Tweaked by: me
Closes: issue #2614


r864146 | bhuvan | 2007-03-24 03:19:35 +0000 (Sat, 24 Mar 2007)

Include the link for new python script l10n-report.py in
tools_contrib.html document.

* www/tools_contrib.html
  Indicate shell scripts svn-po-status-report.sh and 
  svn-po-status-run.sh are replaced by python script l10n-report.py.

Patch by: me
Approved by: dlr


r864388 | bhuvan | 2007-04-02 03:51:36 +0000 (Mon, 02 Apr 2007)

Include the link for po-update.sh script used to generate Subversion pot
files and update locales in tools and contrib document.

* www/tools_contrib.html
  Include the link for po-update.sh script in "po" group.

Patch by: me
Approved by: dlr


r864389 | bhuvan | 2007-04-02 04:18:55 +0000 (Mon, 02 Apr 2007)

Fix the description for po-update.sh script in "po" group.

* www/tools_contrib.html
  (po): Fix the description for po-update.sh script.
    
Suggested by: dlr
Patch by: me


r864424 | dlr | 2007-04-02 22:35:53 +0000 (Mon, 02 Apr 2007)

Initial framework to share the utility functions used by FSFS and BDB
file systems, with the goal of avoiding duplicate code in FS backend
implementations.

It includes a new libsvn_fs_util library to define the functions used by
both FSFS and BDB file systems. For now, svn_fs__canonicalize_abspath()
function, a replacement for svn_fs_fs__canonicalize_abspath() and
svn_fs_base__canonicalize_abspath() functions is defined here.  It
should be extended for other shared functions as well.

* subversion/libsvn_fs_base/tree.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (open_path, get_dag, add_change, change_txn_merge_info,
   base_node_history): Rename svn_fs_base__canonicalize_abspath() function
   as svn_fs__canonicalize_abspath() function.

* subversion/libsvn_fs_base/fs.c
  svn_fs_base__canonicalize_abspath(): Remove.

* subversion/libsvn_fs_base/fs.h
  Bump copyright year to 2007.
  svn_fs_base__canonicalize_abspath(): Remove.

* subversion/libsvn_fs_base/lock.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (svn_fs_base__lock, svn_fs_base__unlock, svn_fs_base__get_lock,
   svn_fs_base__get_locks): Rename svn_fs_base__canonicalize_abspath()
   function as svn_fs__canonicalize_abspath() function.

* subversion/libsvn_fs_base/dag.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (svn_fs_base__dag_copy): Rename svn_fs_base__canonicalize_abspath()
   function as svn_fs__canonicalize_abspath() function.

* subversion/libsvn_fs_util/fs-util.c
  New library for defining the functions which could be used by FSFS and
  BDB libraries. For now, we have defined svn_fs__canonicalize_abspath()
  function.

* subversion/include/private/svn_fs_util.h
  New header file for declaring the functions which could be used by
  FSFS and BDB file systems. For now, we have declared
  svn_fs__canonicalize_abspath() function used to canonicalize the
  absolute path.

* subversion/tests/libsvn_fs_base/fs-base-test.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (canonicalize_abspath): Rename svn_fs_base__canonicalize_abspath()
   function as svn_fs__canonicalize_abspath() function and correct the
   msg appropriately.

* subversion/libsvn_fs_fs/tree.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (open_path, get_dag, add_change, fs_change_node_prop, copy_helper,
   fs_node_history): Rename svn_fs_fs__canonicalize_abspath() function as
   svn_fs__canonicalize_abspath() function.

* subversion/libsvn_fs_fs/fs.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  svn_fs_fs__canonicalize_abspath(): Remove.

* subversion/libsvn_fs_fs/fs.h
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  svn_fs_fs__canonicalize_abspath(): Remove.

* subversion/libsvn_fs_fs/lock.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (svn_fs_fs__allow_locked_operation, svn_fs_fs__lock,
   svn_fs_fs__unlock, svn_fs_fs__get_lock, svn_fs_fs__get_locks): Rename
   svn_fs_fs__canonicalize_abspath() function as
   svn_fs__canonicalize_abspath() function.

Patch by: bhuvan
Suggested by: kameshj


r864449 | bhuvan | 2007-04-03 10:11:54 +0000 (Tue, 03 Apr 2007)

Make the file system check function consistent across FSFS and BDB
implementation.

* subversion/libsvn_fs_fs/err.c
  (svn_fs_fs__check_fs): Check for fs->fsap_data variable to make it 
  consistent with the BDB counterpart.

Patch by: kameshj
          me
Approved by: malcolm


r864473 | bhuvan | 2007-04-04 03:47:51 +0000 (Wed, 04 Apr 2007)

Specify that the fs-base-test test case is dependent on libsvn_fs_util
library.

* build.conf
  (fs-base-test): Add libsvn_fs_util library as one of dependencies.

Patch by: me
Approved by: dlr


r864491 | bhuvan | 2007-04-04 13:14:29 +0000 (Wed, 04 Apr 2007)

Efficiently use the APR subpool where necessary, either by destroying
them before the successful return statement or allocating them when they
are used. In addition, bump the copyright year to 2007 where it is
appropriate. 

* subversion/svnadmin/main.c
  (subcommand_rmlocks): Destroy the APR subpool before the successful
  return statement.
* subversion/svnsync/main.c
  (do_synchronize): Bump the copyright year to 2007 and destroy the APR
  subpool before the successful return statement.
* subversion/libsvn_repos/log.c
  (get_history): If the history item predates the START revision, then
  destroy the APR subpool and info->oldpool.
* subversion/libsvn_delta/path_driver.c
  (svn_delta_path_driver): Bump the copyright year to 2007 and allocate
  subpool, iterpool and item after the check for paths->nelts.

Approved by: cmpilato


r864601 | jszakmeister | 2007-04-11 08:51:01 +0000 (Wed, 11 Apr 2007)

Remove an unused function which was intended to be used when trying
to change the unchangeable named transaction in the filesystem.

* subversion/libsvn_fs_fs/err.c
  svn_fs_fs__err_txn_not_mutable(): Remove.
* subversion/libsvn_fs_fs/err.h
  svn_fs_fs__err_txn_not_mutable(): Remove.

Patch by: bhuvan
Reviewed by: jszakmeister


r864660 | bhuvan | 2007-04-16 14:27:07 +0000 (Mon, 16 Apr 2007)

Move re-usable functions from err.c file in libsvn-fs-fs and
libsvn-fs-base libraries to fs-util.c file in libsvn-fs-util library.

* subversion/include/private/svn_fs_util.h
* subversion/libsvn_fs_util/fs-util.c
  (svn_fs__check_fs, svn_fs__err_not_mutable,
  svn_fs__err_not_directory, svn_fs__err_not_file,
  svn_fs__err_no_such_lock, svn_fs__err_lock_expired,
  svn_fs__err_no_user, svn_fs__err_lock_owner_mismatch,
  svn_fs__err_path_already_locked): New functions, the result of a
    merger from similar functions redundantly defined in both FS backend
    modules.

* subversion/libsvn_fs_base/err.c
* subversion/libsvn_fs_base/err.h
  (svn_fs_base__check_fs, svn_fs_base__err_not_mutable,
  svn_fs_base__err_not_directory, svn_fs_base__err_not_file,
  svn_fs_base__err_no_such_lock, svn_fs_base__err_lock_expired,
  svn_fs_base__err_no_user, svn_fs_base__err_lock_owner_mismatch,
  svn_fs_base__err_path_already_locked): Relocated to (and renamed
    in) svn_fs_util.

* subversion/libsvn_fs_fs/err.c
* subversion/libsvn_fs_fs/err.h
  (svn_fs_fs__check_fs, svn_fs_fs__err_not_mutable,
  svn_fs_fs__err_not_directory, svn_fs_fs__err_not_file,
  svn_fs_fs__err_no_such_lock, svn_fs_fs__err_lock_expired,
  svn_fs_fs__err_no_user, svn_fs_fs__err_lock_owner_mismatch,
  svn_fs_fs__err_path_already_locked): Relocated to (and renamed
    in) svn_fs_util.

* subversion/libsvn_fs_base/tree.c,
* subversion/libsvn_fs_base/bdb/locks-table.c,
* subversion/libsvn_fs_base/bdb/lock-tokens-table.c,
* subversion/libsvn_fs_base/bdb/rev-table.c,
* subversion/libsvn_fs_base/uuid.c,
* subversion/libsvn_fs_base/fs.c,
* subversion/libsvn_fs_base/revs-txns.c,
* subversion/libsvn_fs_base/lock.c,
* subversion/libsvn_fs_fs/tree.c,
* subversion/libsvn_fs_fs/fs_fs.c,
* subversion/libsvn_fs_fs/lock.c
  Include new library "private/svn_fs_util.h".  Update references to
  relocated (and renamed) error-generation functions.

Approved by: cmpilato


r864820 | dlr | 2007-04-24 00:24:20 +0000 (Tue, 24 Apr 2007)

Consolidate the next_entry_name() function in the libsvn_fs_util
library.

* subversion/include/private/svn_fs_util.h
* subversion/libsvn_fs_util/fs-util.c
  (svn_fs__next_entry_name): Add API factored out of FSFS and BDB
   backend FS modules.

* subversion/libsvn_fs_fs/tree.c
* subversion/libsvn_fs_base/tree.c
  (next_entry_name): Move to libsvn_fs_util library.

Patch by: bhuvan
(Tweaked by me.)


r865247 | bhuvan | 2007-05-28 11:49:44 +0000 (Mon, 28 May 2007)

Follow-up fix for r25172. Remove unnecessary print statement and do not
tweak the revision for expected status, as it is already tweaked to that
revision.

* subversion/tests/cmdline/basic_tests.py
  (basic_rm_urls_multi_repos): Remove a print statement.
  Do not tweak the revision for expected status of wc dir and other wc
  dir.

Suggested by: kameshj


r865322 | bhuvan | 2007-06-01 02:24:51 +0000 (Fri, 01 Jun 2007)

Rename "--merge-sensitive" to "--use-merge-history" in all referring
documents.

* www/svn_1.5_releasenotes.html
* www/merge-tracking/func-spec.html
  Rename "--merge-sensitive" to "--use-merge-history".

Approved by: dlr


r865406 | kameshj | 2007-06-08 13:55:10 +0000 (Fri, 08 Jun 2007)

Convert the error functions in libsvn-fs-util library as macros, so it
will return errors with more useful line number in them.

* subversion/libsvn_fs_util/fs-util.c
  (svn_fs__err_not_mutable, svn_fs__err_not_directory,
   svn_fs__err_not_file, svn_fs__err_no_such_lock,
   svn_fs__err_lock_expired, svn_fs__err_no_user,
   svn_fs__err_lock_owner_mismatch, svn_fs__err_path_already_locked):
   Remove definition for error functions. 

* subversion/include/private/svn_fs_util.h
  (svn_fs__err_not_mutable, svn_fs__err_not_directory,
   svn_fs__err_not_file, svn_fs__err_no_such_lock,
   svn_fs__err_lock_expired, svn_fs__err_no_user,
   svn_fs__err_lock_owner_mismatch, svn_fs__err_path_already_locked):
  Remove declaration for error functions and define new macro which
  allows them to return error with more useful line number in them.
  (): Include svn_private_config.h header file.

* subversion/libsvn_fs_base/tree.c
* subversion/libsvn_fs_base/bdb/locks-table.c
* subversion/libsvn_fs_base/bdb/lock-tokens-table.c
* subversion/libsvn_fs_base/lock.c
* subversion/libsvn_fs_fs/lock.c
* subversion/libsvn_fs_fs/tree.c
  Use new macros.

Suggested by: dlr
              malcolm

Patch by: bhuvan
(Tweaked by me).


r865513 | bhuvan | 2007-06-18 03:30:46 +0000 (Mon, 18 Jun 2007)

Move and rename set of macros from BDB and FSFS backends to
libsvn-fs-util library.  In addition, convert a function in FSFS backend
as macro and move it to libsvn-fs-util library.

* subversion/libsvn_fs_fs/tree.c
 (already_exists, not_txn): Remove the functions.
 (NOT_FOUND): Remove the macro.
 (fs_change_merge_info, fs_change_node_prop, fs_merge, fs_delete_node,
 fs_revision_link, fs_make_dir, fs_make_file): Use new macros.

* subversion/libsvn_fs_base/tree.c
 (ALREADY_EXISTS, NOT_TXN, NOT_FOUND): Remove the macros.

* subversion/include/private/svn_fs_util.h
 (SVN_FS__ALREADY_EXISTS, SVN_FS__NOT_TXN, SVN_FS__NOT_FOUND): Define
 new macros.
 (open_path, base_node_history, base_change_merge_info,
 base_change_node_prop, base_merge, base_make_dir, txn_body_delete,
 copy_helper): Use new macros.
  
Suggested by: dlr
              me
Approved by: kameshj


r865528 | bhuvan | 2007-06-19 06:13:02 +0000 (Tue, 19 Jun 2007)

This is a follow-up fix for r25450. As per r25450, check_prop() function
was moved to svntest.actions library. Modify the lock test case to refer
to this function.

* subversion/tests/cmdline/lock_tests.py
  Do not import check_prop() function from prop_tests library.
  (enforce_lock): Refer to check_prop() function in svntest.actions
  library.

Approved by: kameshj


r865558 | bhuvan | 2007-06-21 02:53:45 +0000 (Thu, 21 Jun 2007)

Do not define SVNTreeUnequal exception handler in svntest.main library.
It can be used directly from svntest.tree library, where it is
originally defined.

* subversion/tests/cmdline/svntest/main.py
  Do not import "tree" library and do not define SVNTreeUnequal exception
  handler here.
* subversion/tests/cmdline/merge_tests.py
  (merge_singleton_handler): Raise tree.SVNTreeUnequal() exception.
* subversion/tests/cmdline/update_tests.py
  (detect_extra_files): raise tree.SVNTreeUnequal() exception.

Approved by: dlr


r866082 | bhuvan | 2007-08-09 11:14:13 +0000 (Thu, 09 Aug 2007)

Fix the regression caused by r25988.

* www/faq.html: Fix a typo (obvious fix rule) in the directory name.


r866084 | dlr | 2007-08-09 13:00:52 +0000 (Thu, 09 Aug 2007)

A follow-up to r26007, improving the error code and message spit out
when 'switch --relocate' is attempted with --depth.

* subversion/svn/main.c
  (main): Change error code from SVN_ERR_CL_OBSCURE_ARGS to
   SVN_ERR_CL_MUTUALLY_EXCLUSIVE_ARGS, and make error message
   consistent with other usages of SVN_ERR_CL_MUTUALLY_EXCLUSIVE_ARGS
   in this source file.

* subversion/include/svn_error_codes.h
  (SVN_ERR_CL_OBSCURE_ARGS): Remove unused error code.

Reviewed by: kameshj
             bhuvan


r867036 | dlr | 2007-10-05 21:15:18 +0000 (Fri, 05 Oct 2007)

Perform argument validation.

* build/getversion.py
  (__main__): Check arguments, and exit with error status and a usage
   message if a sufficient number of them aren't provided, or if we
   can't find/parse specified the header file.
  (usage_and_exit): New helper routine which prints usage instructions
   to stderr, and exits with error status.

Patch by: bhuvan
          me


r867037 | bhuvan | 2007-10-06 00:21:25 +0000 (Sat, 06 Oct 2007)

In FSFS libraries, for few functions, do not pass txn_id parameter when 
it is not used.

* subversion/libsvn_fs_fs/dag.h
  (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
  Update the comment to reflect this change.
* subversion/libsvn_fs_fs/dag.c
  (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
* subversion/libsvn_fs_fs/tree.c
  (update_ancestry): Remove txn_id argument.
  (merge, text_stream_closer): Adjust the callers.

Patch by: bhuvan
Approved by: dlr


r867119 | bhuvan | 2007-10-09 13:34:05 +0000 (Tue, 09 Oct 2007)

Fix typo, under "obvious fix" rule.

* notes/test-writing: Fix typo.
* subversion/libsvn_fs_fs/fs_fs.c: Fix typo in a comment for macros
  dealing with ESTALE.


r869803 | bhuvan | 2008-03-05 17:07:24 +0000 (Wed, 05 Mar 2008)

If an invalid repository path is passed to the script, display the error
message instead of a traceback.

* tools/hook-scripts/svn2feed.py
  (main): The revision number can not be determined, if an invalid
  repository path is passed. If this is the case, display an error
  message.


r869942 | kfogel | 2008-03-12 01:11:37 +0000 (Wed, 12 Mar 2008)

* CHANGES (1.5.0): Insert preliminary list of changes.

Patch by: Augie Fackler <durin42@gmail.com>
          Greg Lutz <greg@nearspace.com>
          Gavin 'Beau' Baumanis <gavin@thespidernet.com>
          Hilco Wijbenga <hilco.wijbenga@gmail.com>
          Tuomas Koski <koski.tuomas@gmail.com>
          Daniel Torreblanca <regulatethis@gmail.com>
          Stephen Butler <sbutler@elego.de>
          Wouter van der Horst <w.vanderhorst@gmail.com>
          offby1
          bhuvan
          lgo
          stylesen
          khmarbaise
          kfogel

See the 'manyhands' mailing list for details.


r869971 | glasser | 2008-03-13 17:26:54 +0000 (Thu, 13 Mar 2008)

Adjust a comment.

* subversion/libsvn_wc/update_editor.c
  (add_file_with_history): Don't say "we need to copy working props"
   in a block that doesn't do that (since that work was done above).

Suggested by: bhuvan


r870022 | bhuvan | 2008-03-19 12:50:54 +0000 (Wed, 19 Mar 2008)

Display a better error message, if working copy dependent revision kind
is passed for 'svn log url -rXXX' command. Add svn_opt_revision_working
to list of revision kinds we should check.

* subversion/include/svn_client.h
  (SVN_CLIENT_IS_WC_DEPENDENT_REVKIND): New macro.
* subversion/libsvn_client/log.c
  (svn_client_log4): Use the new macro. If start/end revision kind 
  is dependent on working copy, display an error message.

Approved by: kameshj


r870035 | bhuvan | 2008-03-19 17:48:51 +0000 (Wed, 19 Mar 2008)

This is a follow-up for r29948. Rename the macro which checks if
revision kind is dependent on a WC. Use the new macro wherever it is
applicable. 
 
* subversion/include/svn_client.h
  (SVN_CLIENT_IS_WC_DEPENDENT_REVKIND): Move this macro ...
* subversion/libsvn_client/client.h
  (SVN_CLIENT__REVKIND_NEEDS_WC) ... to here and rename it.
* subversion/libsvn_client/copy.c
  (setup_copy): Use the macro.
* subversion/libsvn_client/log.c
  (svn_client_log4): Use the new macro.

Suggested by: kfogel
Approved by: kfogel


r871742 | kfogel | 2008-06-10 04:01:55 +0000 (Tue, 10 Jun 2008)

* www/index.html
  (help): Remove a repeated word.

Found by: bhuvan


r874691 | gstein | 2008-12-09 03:28:07 +0000 (Tue, 09 Dec 2008)

Remove svn_wc__adm_{get,save}_pristine_path functions and cover a TODO
item for SVN 1.6 release.

Patch by: bhuvan
  (slightly modified by gstein)

* subversion/libsvn_wc/lock.h:
  (svn_wc__adm_get_pristine_path, svn_wc__adm_save_pristine_path):
    Remove these functions.

* subversion/libsvn_wc/lock.c:
  (struct svn_wc__adm_shared_t): remove NEW_PRISTINES field
  (svn_wc__adm_get_pristine_path, svn_wc__adm_save_pristine_path):
    Remove these functions.

* TODO-1.6:
  Remove the TODO item corresponding to this back-out task.


r876678 | hwright | 2009-03-16 20:18:57 +0000 (Mon, 16 Mar 2009)

* CHANGES: Initial pass for 1.6.0.

Patch by: khmarbaise
          bhuvan
          Edmund <edmund@belfordhk.com>
          Thomas Koski <koski.tuomas@gmail.com>


r879961 | bhuvan | 2009-10-09 05:43:35 +0000 (Fri, 09 Oct 2009)

This fix adds the ability to print the time taken to execute each test.
The time taken is printed in the log file, if specified; otherwise in
the stdout interface. 
  
* build/run_tests.py
  import time
  (TestHarness._run_test): Print the time taken by each test using
  following format:
  ELAPSED: test_name HH:MM:SS

Reviewed by: julianfoad
             brane


r879969 | bhuvan | 2009-10-09 12:37:30 +0000 (Fri, 09 Oct 2009)

* STATUS: Nominate r39887 for backport to 1.6.6 release. Include
  nomination for Branko as well.


r879970 | bhuvan | 2009-10-09 12:45:18 +0000 (Fri, 09 Oct 2009)

* STATUS: Move r39887 from "Approved changes" section to "Candidate
  changes" section.


r880261 | bhuvan | 2009-10-22 15:52:38 +0000 (Thu, 22 Oct 2009)

New script to generate the junit reports for Subversion test cases. The
junit reports can be used by continuous integration tools like Hudson
for building and testing Subversion.

* tools/dev/gen_junit_report.py
  The junit reports are generated by parsing the tests log file,
  tests.log. The test results, PASS, FAIL and SKIP are marked as
  appropriate in the junit reports. The XFAIL tests are considered as
  PASS. This script can take options: --log-file and --output-dir.
 
  The value for --log-file option denotes the log file to parse for
  generating the junit reports.
 
  The value for --output-dir option denotes the directory to store the
  junit reports. A separate file is created in this directory for each
  test case.

Approved by: hwright


r880302 | bhuvan | 2009-10-27 01:25:15 +0000 (Tue, 27 Oct 2009)

Rightly process the elapsed time, including the milliseconds.

* tools/dev/gen_junit_report.py
  (update_stat): Use float type while calculating the time taken for 
  individual tests.
  (main): The seconds field may contain milli seconds, do not cast as 
  int type. If so, do it as float.

Approved by: mphippard


r880303 | bhuvan | 2009-10-27 03:38:19 +0000 (Tue, 27 Oct 2009)

While running the test suite, even the microseconds are accountable.

* build/run_tests.py
  import datetime
  (_run_test): Include microseconds while printing the time taken to
  execute each test. Use datetime library instead of time library.

Reviewed by: brane


r884002 | bhuvan | 2009-11-25 07:28:27 +0000 (Wed, 25 Nov 2009)

Follow-up for r883916. Fix a typo.

* subversion/libsvn_subr/utf.c
  (fuzzy_escape): Fix typo in a comment.


r884394 | bhuvan | 2009-11-26 03:40:37 +0000 (Thu, 26 Nov 2009)

Follow-up for r884002.

* subversion/libsvn_subr/utf.c
  (fuzzy_escape): Fix a comment to denote NUL character.

Found by: Kannan R <kannanr@collab.net>
Suggested by: stsp


r884740 | bhuvan | 2009-11-27 02:36:07 +0000 (Fri, 27 Nov 2009)

The configuration files for Hudson jobs added in Apache build farm.

* build/hudson/README
  Document the configuration of Hudson jobs.

* build/hudson/jobs/subversion-trunk-ubuntu/config.xml
  The configuration file specific to building Subversion in trunk on
  Ubuntu system.

* build/hudson/jobs/subversion-1.6.x-ubuntu/config.xml
  The configuration file specific to building Subversion in "1.6.x"
  branch on Ubuntu system.

Approved by: hwright


r886816 | bhuvan | 2009-12-03 15:27:38 +0000 (Thu, 03 Dec 2009)

This commit adds the Hudson configuration files to build Subversion on
Solaris10 system.

* build/hudson/jobs/subversion-trunk-solaris/config.xml
  The configuration file specific to building Subversion in trunk on
  Solaris10 system.

* build/hudson/jobs/subversion-1.6.x-solaris/config.xml
  The configuration file specific to building Subversion in 1.6.x branch
  on Solaris10 system.


r886819 | bhuvan | 2009-12-03 15:33:02 +0000 (Thu, 03 Dec 2009)

* COMMITTERS
  Extending Bhuvan's commit access to build/hudson area.


r887178 | bhuvan | 2009-12-04 12:50:45 +0000 (Fri, 04 Dec 2009)

Fix for issue 3541. When generating junit reports, escape special
characters, if any, from test failure messages.

* tools/dev/gen_junit_report.py
  ASCII_TABLE: Global variable to define list of ascii characters.
  CHARS_TO_REMOVE: Global variable to define list of ascii values
  to remove from failure messages.
  (escape_special_characters): New method to escape special characters.
  (junit_testcase_fail, junit_testcase_xfail): Use 
  escape_special_characters() method to escape special characters in 
  test failure messages.

Approved by: julianfoad
Reviewed by: julianfoad
             brane


r887496 | bhuvan | 2009-12-05 05:09:09 +0000 (Sat, 05 Dec 2009)

This commit adds Hudson jobs to build API documentation including doxygen
and javadoc. The jobs are executed every day at 2300 UTC. The API 
documentation are available here:

doxygen: http://hudson.zones.apache.org/hudson/userContent/subversion/doxygen/index.html
javadoc: http://hudson.zones.apache.org/hudson/userContent/subversion/javadoc/index.html

Why do we need 2 jobs? Each job can publish documentation files from only 
one location. The subversion-doxygen job publish the documentation in 
doc/doxygen/html directory, while subversion-javadoc job publish the
documentation in doc/javadoc directory.

* build/hudson/jobs/subversion-doxygen/config.xml
   The configuration file specific to building doxygen documentation.

* build/hudson/jobs/subversion-javadoc/config.xml
   The configuration file specific to building javahl documentation.


r893418 | bhuvan | 2009-12-23 07:48:21 +0000 (Wed, 23 Dec 2009)

Fix the checkout URLs, they are no more in svn.collab.net.

* INSTALL
  The repository is now in svn.apache.org.

Approved by: kameshj


r915254 | bhuvan | 2010-02-23 09:23:28 +0000 (Tue, 23 Feb 2010)

Fix for issue 3579.  Reschedule hudson jobs to execute every 1hour.

* build/hudson/jobs/subversion-trunk-ubuntu/config.xml
* build/hudson/jobs/subversion-1.6.x-solaris/config.xml
* build/hudson/jobs/subversion-1.6.x-ubuntu/config.xml
* build/hudson/jobs/subversion-trunk-solaris/config.xml
  Poll subversion repository every 1hour.

* build/hudson/README
  Fix the setup notes.


r920074 | rdonch | 2010-03-07 19:52:49 +0000 (Sun, 07 Mar 2010)

[in subversion/bindings/swig/python/tests]

* core.py,
  delta.py,
  pool.py,
  wc.py,
  mergeinfo.py,
  run_all.py,
  auth.py,
  ra.py: Fix some code style issues found by pylint. This mostly includes
   inserting whitespace, removing unneeded imports and semicolons, and
   renaming identifiers colliding with reserved names.

Suggested by: bhuvan



r1292103 | bhuvan | 2012-02-22 01:06:31 +0000 (Wed, 22 Feb 2012)

COMMITTERS: Update my email address.