Bhuvaneswaran <bhuvan@collab.net> (bhuvan)


Found Patch Review Suggested
r31668 r29868, r26963, r26962, r25332, r24746, r24527, r24399, r24375, r24350, r24315, r24314, r24072, r23988, r23204, r23017, r22933, r22512, r22444, r22009, r21715, r21604, r21495, r21318, r21246, r20992, r20991, r20902, r20870, r20821, r20807, r20760, r20757, r20376, r20309, r20219, r20147, r20146, r20004 r26010 r29897, r25439, r21495, r20990

r31668 | kfogel | 2008-06-09 23:01:55 -0500 (Mon, 09 Jun 2008)

* www/index.html
  (help): Remove a repeated word.

Found by: bhuvan


r29897 | glasser | 2008-03-13 12:26:54 -0500 (Thu, 13 Mar 2008)

Adjust a comment.

* subversion/libsvn_wc/update_editor.c
  (add_file_with_history): Don't say "we need to copy working props"
   in a block that doesn't do that (since that work was done above).

Suggested by: bhuvan


r29868 | kfogel | 2008-03-11 20:11:37 -0500 (Tue, 11 Mar 2008)

* CHANGES (1.5.0): Insert preliminary list of changes.

Patch by: Augie Fackler <durin42@gmail.com>
          Greg Lutz <greg@nearspace.com>
          Gavin 'Beau' Baumanis <gavin@thespidernet.com>
          Hilco Wijbenga <hilco.wijbenga@gmail.com>
          Tuomas Koski <koski.tuomas@gmail.com>
          Daniel Torreblanca <regulatethis@gmail.com>
          Stephen Butler <sbutler@elego.de>
          Wouter van der Horst <w.vanderhorst@gmail.com>
          offby1
          bhuvan
          lgo
          stylesen
          khmarbaise
          kfogel

See the 'manyhands' mailing list for details.


r26963 | bhuvan | 2007-10-05 19:21:25 -0500 (Fri, 05 Oct 2007)

In FSFS libraries, for few functions, do not pass txn_id parameter when 
it is not used.

* subversion/libsvn_fs_fs/dag.h
  (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
  Update the comment to reflect this change.
* subversion/libsvn_fs_fs/dag.c
  (svn_fs_fs__dag_finalize_edits): Remove txn_id argument.
* subversion/libsvn_fs_fs/tree.c
  (update_ancestry): Remove txn_id argument.
  (merge, text_stream_closer): Adjust the callers.

Patch by: bhuvan
Approved by: dlr


r26962 | dlr | 2007-10-05 16:15:18 -0500 (Fri, 05 Oct 2007)

Perform argument validation.

* build/getversion.py
  (__main__): Check arguments, and exit with error status and a usage
   message if a sufficient number of them aren't provided, or if we
   can't find/parse specified the header file.
  (usage_and_exit): New helper routine which prints usage instructions
   to stderr, and exits with error status.

Patch by: bhuvan
          me


r26010 | dlr | 2007-08-09 08:00:52 -0500 (Thu, 09 Aug 2007)

A follow-up to r26007, improving the error code and message spit out
when 'switch --relocate' is attempted with --depth.

* subversion/svn/main.c
  (main): Change error code from SVN_ERR_CL_OBSCURE_ARGS to
   SVN_ERR_CL_MUTUALLY_EXCLUSIVE_ARGS, and make error message
   consistent with other usages of SVN_ERR_CL_MUTUALLY_EXCLUSIVE_ARGS
   in this source file.

* subversion/include/svn_error_codes.h
  (SVN_ERR_CL_OBSCURE_ARGS): Remove unused error code.

Reviewed by: kameshj
             bhuvan


r25439 | bhuvan | 2007-06-17 22:30:46 -0500 (Sun, 17 Jun 2007)

Move and rename set of macros from BDB and FSFS backends to
libsvn-fs-util library.  In addition, convert a function in FSFS backend
as macro and move it to libsvn-fs-util library.

* subversion/libsvn_fs_fs/tree.c
 (already_exists, not_txn): Remove the functions.
 (NOT_FOUND): Remove the macro.
 (fs_change_merge_info, fs_change_node_prop, fs_merge, fs_delete_node,
 fs_revision_link, fs_make_dir, fs_make_file): Use new macros.

* subversion/libsvn_fs_base/tree.c
 (ALREADY_EXISTS, NOT_TXN, NOT_FOUND): Remove the macros.

* subversion/include/private/svn_fs_util.h
 (SVN_FS__ALREADY_EXISTS, SVN_FS__NOT_TXN, SVN_FS__NOT_FOUND): Define
 new macros.
 (open_path, base_node_history, base_change_merge_info,
 base_change_node_prop, base_merge, base_make_dir, txn_body_delete,
 copy_helper): Use new macros.
  
Suggested by: dlr
              me
Approved by: kameshj


r25332 | kameshj | 2007-06-08 08:55:10 -0500 (Fri, 08 Jun 2007)

Convert the error functions in libsvn-fs-util library as macros, so it
will return errors with more useful line number in them.

* subversion/libsvn_fs_util/fs-util.c
  (svn_fs__err_not_mutable, svn_fs__err_not_directory,
   svn_fs__err_not_file, svn_fs__err_no_such_lock,
   svn_fs__err_lock_expired, svn_fs__err_no_user,
   svn_fs__err_lock_owner_mismatch, svn_fs__err_path_already_locked):
   Remove definition for error functions. 

* subversion/include/private/svn_fs_util.h
  (svn_fs__err_not_mutable, svn_fs__err_not_directory,
   svn_fs__err_not_file, svn_fs__err_no_such_lock,
   svn_fs__err_lock_expired, svn_fs__err_no_user,
   svn_fs__err_lock_owner_mismatch, svn_fs__err_path_already_locked):
  Remove declaration for error functions and define new macro which
  allows them to return error with more useful line number in them.
  (): Include svn_private_config.h header file.

* subversion/libsvn_fs_base/tree.c
* subversion/libsvn_fs_base/bdb/locks-table.c
* subversion/libsvn_fs_base/bdb/lock-tokens-table.c
* subversion/libsvn_fs_base/lock.c
* subversion/libsvn_fs_fs/lock.c
* subversion/libsvn_fs_fs/tree.c
  Use new macros.

Suggested by: dlr
              malcolm

Patch by: bhuvan
(Tweaked by me).


r24746 | dlr | 2007-04-23 19:24:20 -0500 (Mon, 23 Apr 2007)

Consolidate the next_entry_name() function in the libsvn_fs_util
library.

* subversion/include/private/svn_fs_util.h
* subversion/libsvn_fs_util/fs-util.c
  (svn_fs__next_entry_name): Add API factored out of FSFS and BDB
   backend FS modules.

* subversion/libsvn_fs_fs/tree.c
* subversion/libsvn_fs_base/tree.c
  (next_entry_name): Move to libsvn_fs_util library.

Patch by: bhuvan
(Tweaked by me.)


r24527 | jszakmeister | 2007-04-11 03:51:01 -0500 (Wed, 11 Apr 2007)

Remove an unused function which was intended to be used when trying
to change the unchangeable named transaction in the filesystem.

* subversion/libsvn_fs_fs/err.c
  svn_fs_fs__err_txn_not_mutable(): Remove.
* subversion/libsvn_fs_fs/err.h
  svn_fs_fs__err_txn_not_mutable(): Remove.

Patch by: bhuvan
Reviewed by: jszakmeister


r24399 | bhuvan | 2007-04-03 22:47:51 -0500 (Tue, 03 Apr 2007)

Specify that the fs-base-test test case is dependent on libsvn_fs_util
library.

* build.conf
  (fs-base-test): Add libsvn_fs_util library as one of dependencies.

Patch by: me
Approved by: dlr


r24375 | bhuvan | 2007-04-03 05:11:54 -0500 (Tue, 03 Apr 2007)

Make the file system check function consistent across FSFS and BDB
implementation.

* subversion/libsvn_fs_fs/err.c
  (svn_fs_fs__check_fs): Check for fs->fsap_data variable to make it 
  consistent with the BDB counterpart.

Patch by: kameshj
          me
Approved by: malcolm


r24350 | dlr | 2007-04-02 17:35:53 -0500 (Mon, 02 Apr 2007)

Initial framework to share the utility functions used by FSFS and BDB
file systems, with the goal of avoiding duplicate code in FS backend
implementations.

It includes a new libsvn_fs_util library to define the functions used by
both FSFS and BDB file systems. For now, svn_fs__canonicalize_abspath()
function, a replacement for svn_fs_fs__canonicalize_abspath() and
svn_fs_base__canonicalize_abspath() functions is defined here.  It
should be extended for other shared functions as well.

* subversion/libsvn_fs_base/tree.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (open_path, get_dag, add_change, change_txn_merge_info,
   base_node_history): Rename svn_fs_base__canonicalize_abspath() function
   as svn_fs__canonicalize_abspath() function.

* subversion/libsvn_fs_base/fs.c
  svn_fs_base__canonicalize_abspath(): Remove.

* subversion/libsvn_fs_base/fs.h
  Bump copyright year to 2007.
  svn_fs_base__canonicalize_abspath(): Remove.

* subversion/libsvn_fs_base/lock.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (svn_fs_base__lock, svn_fs_base__unlock, svn_fs_base__get_lock,
   svn_fs_base__get_locks): Rename svn_fs_base__canonicalize_abspath()
   function as svn_fs__canonicalize_abspath() function.

* subversion/libsvn_fs_base/dag.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (svn_fs_base__dag_copy): Rename svn_fs_base__canonicalize_abspath()
   function as svn_fs__canonicalize_abspath() function.

* subversion/libsvn_fs_util/fs-util.c
  New library for defining the functions which could be used by FSFS and
  BDB libraries. For now, we have defined svn_fs__canonicalize_abspath()
  function.

* subversion/include/private/svn_fs_util.h
  New header file for declaring the functions which could be used by
  FSFS and BDB file systems. For now, we have declared
  svn_fs__canonicalize_abspath() function used to canonicalize the
  absolute path.

* subversion/tests/libsvn_fs_base/fs-base-test.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (canonicalize_abspath): Rename svn_fs_base__canonicalize_abspath()
   function as svn_fs__canonicalize_abspath() function and correct the
   msg appropriately.

* subversion/libsvn_fs_fs/tree.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (open_path, get_dag, add_change, fs_change_node_prop, copy_helper,
   fs_node_history): Rename svn_fs_fs__canonicalize_abspath() function as
   svn_fs__canonicalize_abspath() function.

* subversion/libsvn_fs_fs/fs.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  svn_fs_fs__canonicalize_abspath(): Remove.

* subversion/libsvn_fs_fs/fs.h
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  svn_fs_fs__canonicalize_abspath(): Remove.

* subversion/libsvn_fs_fs/lock.c
  Include the private/svn_fs_util.h header file, and bump copyright year
  to 2007.
  (svn_fs_fs__allow_locked_operation, svn_fs_fs__lock,
   svn_fs_fs__unlock, svn_fs_fs__get_lock, svn_fs_fs__get_locks): Rename
   svn_fs_fs__canonicalize_abspath() function as
   svn_fs__canonicalize_abspath() function.

Patch by: bhuvan
Suggested by: kameshj


r24315 | bhuvan | 2007-04-01 23:18:55 -0500 (Sun, 01 Apr 2007)

Fix the description for po-update.sh script in "po" group.

* www/tools_contrib.html
  (po): Fix the description for po-update.sh script.
    
Suggested by: dlr
Patch by: me


r24314 | bhuvan | 2007-04-01 22:51:36 -0500 (Sun, 01 Apr 2007)

Include the link for po-update.sh script used to generate Subversion pot
files and update locales in tools and contrib document.

* www/tools_contrib.html
  Include the link for po-update.sh script in "po" group.

Patch by: me
Approved by: dlr


r24072 | bhuvan | 2007-03-23 22:19:35 -0500 (Fri, 23 Mar 2007)

Include the link for new python script l10n-report.py in
tools_contrib.html document.

* www/tools_contrib.html
  Indicate shell scripts svn-po-status-report.sh and 
  svn-po-status-run.sh are replaced by python script l10n-report.py.

Patch by: me
Approved by: dlr


r23988 | dionisos | 2007-03-21 18:18:29 -0500 (Wed, 21 Mar 2007)

Replace hacky l10n status reporting shell scripts with a python script.

* tools/po/svn-po-status-report.sh
* tools/po/svn-po-status-run.sh
  Delete (now obsolete).

* tools/po/l10n-report.py
  New. Replaces the above 2.

Patch by: bhuvan
Suggested by: maxb
Tweaked by: me
Closes: issue #2614


r23204 | bhuvan | 2007-01-24 01:35:25 -0600 (Wed, 24 Jan 2007)

Destroy the APR subpool before every successful return statement.

[in subversion/libsvn_client/]
* delete.c
  (delete_urls):
* repos_diff.c
  (svn_client__get_diff_editor):
* externals.c
  (switch_external):
* list.c
  (get_dir_contents):
  Destroy the APR subpool before returning successfully to prevent 
  iterative pool creation.

Approved by: dlr
Patch by: me


r23017 | dlr | 2007-01-15 12:24:15 -0600 (Mon, 15 Jan 2007)

Reduce lifetime/size of memory footprint for 'proplist'.

* subversion/libsvn_client/prop_commands.c
  (svn_client_proplist2): Destroy sub-pool after use.

Patch by: bhuvan
(Tweaked by me.)
Reviewed by: lundblad


r22933 | dionisos | 2007-01-08 15:12:38 -0600 (Mon, 08 Jan 2007)

Destroy the APR subpool before every successful return statement.

* subversion/libsvn_client/diff.c
 (merge_props_changed, merge_file_changed, merge_file_added,
  merge_file_deleted, merge_dir_added, merge_dir_deleted): Destroy the APR
   subpool before returning succesfully to prevent iterative pool creation.

Patch by: bhuvan


r22512 | bhuvan | 2006-11-29 21:35:58 -0600 (Wed, 29 Nov 2006)

Avoid importing unused python libraries in the black box regression
tests.

[ in subversion/tests/cmdline/svntest ]
* testcase.py
  Do not import unused libraries.
  (TestCase.check_description): Use the string itself when invoking the
  lower() function.

* tree.py 
  Do not import unused libraries.
  (create_from_path, dump_tree): Use the string itself when invoking the
  replace() function.
  (get_props): Use the string itself when invoking the strip() function.

* actions.py
  Do not import unused libraries.
  (setup_pristine_repository, run_and_verify_commit): Use the string
  itself when invoking strip() function.

* main.py
  Do not import unused libraries.
  Use the string itself when invoking replace() function.
  (Sandbox._set_name, run_tests): Use the string itself when invoking
  replace() function.

Patch by: me
Approved by: dlr


r22444 | dlr | 2006-11-27 12:15:43 -0600 (Mon, 27 Nov 2006)

Avoid importing unused Python libraries in the black box regression
tests.

[ in subversion/tests/cmdline/ ]

* autoprop_tests.py
* basic_tests.py
* copy_tests.py
* export_tests.py
* externals_tests.py
* history_tests.py
* lock_tests.py
* log_tests.py
* prop_tests.py
* revert_tests.py
* schedule_tests.py
* stat_tests.py
* svnadmin_tests.py
* svnsync_tests.py
* switch_tests.py
* trans_tests.py
* utf8_tests.py
  Do not import unused libraries.

* diff_tests.py
  Do not import unused libraries.
  (check_diff_output): Use the string itself when invoking the
   replace() function.

* svnlook_tests.py
  Do not import unused libraries.
  (delete_file_in_moved_dir): Use the string itself when invoking the
   strip() function.

* update_tests.py
  Do not import unused libraries.
  (update_wc_on_windows_drive): Use the string itself when invoking
   the splitfields() function.

Patch by: bhuvan
(Tweaked by me.)


r22009 | bhuvan | 2006-10-17 17:40:58 -0500 (Tue, 17 Oct 2006)

Patch by: me
Approved by: kfogel

* www/project_license.html
  Automatically redirect the requests to license-1.html after 5 seconds.
  Print the redirect message and provide a link to actual license page.


r21715 | rooneg | 2006-09-29 09:29:21 -0500 (Fri, 29 Sep 2006)

Fix busted link.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>

* www/faq.html:
  Fix the broken link to webdav-protocol document. As per revision
  r18739 the document subversion/libsvn_ra_dav/protocol was moved to
  notes/webdav-protocol.


r21604 | bhuvan | 2006-09-21 22:41:56 -0500 (Thu, 21 Sep 2006)

If path is a copy/move, add '+' character to the log message displayed
in SVN_EDITOR.

Patch by: djames
          Kamesh Jayachandran <kamesh@collab.net>
          dlr
          me

subversion/svn/util.c:
  * (svn_cl__get_log_message): If path is a copy/move, add '+' character
    to the log message displayed in SVN_EDITOR.


r21495 | bhuvan | 2006-09-14 04:54:33 -0500 (Thu, 14 Sep 2006)

As per this thread [1], rename the script server-vsn.py to
server-version.py.
[1]
http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=499692

Patch by: me
Suggested by: me
Approved by: julianfoad
             dlr

* tools/client-side/server-vsn.py: Rename...
* tools/client-side/server-version.py: ...to this, updating internal
  references to the script name.
* www/tools_contrib.html: Update.


r21318 | bhuvan | 2006-08-30 13:40:44 -0500 (Wed, 30 Aug 2006)

De-string-ify the python scripts.

Patch by: me
Approved by: cmpilato

[in subversion/tests/cmdline]
* import_tests.py
  (global): Do not import "string" library.
  (import_executable, import_ignores, import_no_ignores): Fix uses of
  deprecated string methods.
* autoprop_tests.py
  (global): Do not import "string" library.
  (check_proplist): Fix uses of deprecated string method.
* basic_tests.py
  (global): Do not import "string" library.
  (basic_import, basic_add_no_ignores, uri_syntax): Fix uses of
  deprecated string methods.


r21246 | cmpilato | 2006-08-24 10:36:57 -0500 (Thu, 24 Aug 2006)

Place item author and date information in feed metadata.

* contrib/hook-scripts/svn2feed.py
  (global): Remove the TODO item.
  (Svn2Feed._get_item_dict): Remove the date information from desc to
    avoid redundancy.  Strip the newline and store the author information
    in data structure.
  (Svn2Feed._format_update_ts): New helper function.
  (Svn2RSS._make_rss_item): Pass author information to RSSItem function.
  (Svn2Atom._make_atom_item): Create a new tag for author and append it
    to the entry.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>

r20992 | maxb | 2006-08-05 12:31:57 -0500 (Sat, 05 Aug 2006)

* tools/examples/svnshell.py
  (SVNShell.do_ls): Sacrifice the angle brackets around node-rev-ids to gain
    two more characters of horizontal space for the node-rev-id field.
  (SVNShell.do_setrev): Stop dying on invalid input.
    Accept 'HEAD' as a parameter.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
          me


r20991 | maxb | 2006-08-05 12:13:52 -0500 (Sat, 05 Aug 2006)

* contrib/hook-scripts/svn2feed.py (Svn2Atom.add_revision_item):
  Make style more Pythonic.
  Avoid depending on ordering of XML elements for correct behaviour.
  Fix off-by-one error in item pruning.
  Fix pruning of only a single item, not properly obeying max_items if it
    is decreased from the value previously used with a pre-existing feed.

Patch by: me
          Bhuvaneswaran Arumugam <bhuvan@collab.net>


r20990 | maxb | 2006-08-05 11:30:31 -0500 (Sat, 05 Aug 2006)

Contribulyzer: avoid using tags within HTML <title>, since browsers do not
display that properly.

* tools/dev/contribulyze.py (html_spam_guard): Add a reduced obfuscation mode
    which uses entities only.
  (html_header): Take title and page heading values separately.
  (Contributor.big_name): New parameter for requesting entities-only HTML,
    by invoking html_spam_guard() appropriately.
  (Contributor.html_out): Use the new support in big_name to give a tag-less
    title.

Suggested by: Bhuvaneswaran Arumugam <bhuvan@collab.net>


r20902 | julianfoad | 2006-07-29 15:23:06 -0500 (Sat, 29 Jul 2006)

In 'server-vsn.py', support 'https:' URLs.  Also handle redirect requests
(302), if the requested resource resides temporarily under a different URL.

Also use better Python APIs.  In httplib, the HTTP and HTTPS functions are
included just for backward compatibility.  Moreover, HTTPS support is only
available if the socket module is compiled with SSL support.  So, use
HTTPConnection and HTTPSConnection functions instead.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>

* tools/client-side/server-vsn.py
  Do not import "string" library as it is not necessary.
  (print_version): Handle the HTTPS scheme.  Use 'HTTPConnection' and
    'HTTPSConnection' instead of 'HTTP' and 'HTTPS' functions.  Do not
    regard a '302' redirect as an error, use its header info anyway.


r20870 | cmpilato | 2006-07-26 10:24:23 -0500 (Wed, 26 Jul 2006)

Update the bindings INSTALL document to note check-swig-py make
target.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
(Tweaked by cmpilato.)

* subversion/bindings/swig/INSTALL:
  Update the document to include the "make check-swig-py" command to
  test python bindings and quote the commands where it was missing.


r20821 | rooneg | 2006-07-21 13:48:17 -0500 (Fri, 21 Jul 2006)

Insert the "entry" element before all other "entry" elements and remove
the elements from the feed file if it reaches --max-items.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>

* contrib/hook-scripts/svn2feed.py
 (Svn2Atom.add_revision_item): Locate the "author" element (last
  non-entry element) and insert the new element after it's next sibling.

  Calculate the total "entry" elements and remove the last child if the
  total is greater than the --max-items.


r20807 | maxb | 2006-07-20 14:40:28 -0500 (Thu, 20 Jul 2006)

Based on a patch submission that created a 'svn2atom.py', instead add Atom
support to the existing 'svn2rss.py' (which will soon be renamed to a more
appropriate name).

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
          me

Note: Atom support currently has a known bug: Expiration of old items from
the feed file is not implemented.

* contrib/hook-scripts/svn2rss.py
  (usage message): Document added Atom support.
  (Svn2Atom): New class, roughly paralleling Svn2RSS.
  (main): Plug the new class into the dictionary of available classes.


r20760 | maxb | 2006-07-19 13:52:07 -0500 (Wed, 19 Jul 2006)

A few more fixes to svn2rss.py deriving from Bhuvaneswaran Arumugam's
svn2atom.py submission, and some fixes of my own found whilst examining them.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
          me

* contrib/hook-scripts/svn2rss.py:
  Add missing \n at end of Python version error.
  (Svn2RSS.__init__): Stop setting unused member variable 'rss_item_desc'.
  (Svn2RSS.make_rss_item_desc): Rename...
  (Svn2RSS.make_item_desc): ...to this, since it is not RSS-specific.
    Change callers.
  (main): Fix erroneous block nesting, and remove duplication of a string
    constant.


r20757 | maxb | 2006-07-19 13:12:34 -0500 (Wed, 19 Jul 2006)

Merge some of the fixes in Bhuvaneswaran Arumugam's svn2atom.py submission into
svn2rss.py.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
          me

* contrib/hook-scripts/svn2rss.py (usage message): Improvements.
  (global scope): PEP 8 enhancements.
  (usage_and_exit): Clarify conditional.
  (SVN2RSS): Rename class...
  (Svn2RSS): ...to this, for PEP 8 compliance.
  (Svn2RSS.make_rss_item_desc): Clarify variable names.
    Rewrite code building the description string entirely.
  (Svn2RSS.make_rss): Say 'Subversion', not 'SVN'.
  (main): Initialize URL paramters with "", not None.
    Make an if condition more Pythonic.
    Clarify variable names.


r20376 | cmpilato | 2006-07-03 12:42:04 -0500 (Mon, 03 Jul 2006)

Rename svn2rss.py's --url option to --item-url, and add support for
--feed-url.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
(Tweaked by me.)

* contrib/hook-scripts/svn2rss.py
  (__doc__): Change to note new/tweaked options.
  (check_url): New function to validate urls
  (__main__): Parse new --item-url and --feed-url options, using
    check_url() to validate the input.  Also, stop recognizing --url options.
  (SVN2RSS.__init__): Accept and store 'feed_url' parameter.  Rename
    'url' parameter to 'item_url'.
  (SVN2RSS.make_rss_item): Use self.item_url now in the item's RSS chunk.
  (SVN2RSS.make_rss): Use self.feed_url when generating the feed, and use
    the basename of the repository path in the feed's title.


r20309 | cmpilato | 2006-06-30 10:38:41 -0500 (Fri, 30 Jun 2006)

Support ranges of revisions in svn2rss.py.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
(Tweaked by me.)

* contrib/hook-scripts/svn2rss.py
  (__init__): Add 'try' block and handle ValueError for revision. Here,
    if the revision is not set, set it to the youngest one. Handle one
    and range of revisions. Finally, for each revision, add the rss feed
    to the file.
  (SVN2RSS.__init__): Keep only max_items items in the feed.



r20219 | rooneg | 2006-06-22 12:13:11 -0500 (Thu, 22 Jun 2006)

Fix usage for header_wrappers.py.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>

* build/generator/swig/header_wrappers.py
  (__main__): include basename of the script in Usage statement.


r20147 | dlr | 2006-06-16 11:58:55 -0500 (Fri, 16 Jun 2006)

Removed Makefile.in targets that refer to the `doc/design' directory.

* Makefile.in
  (doc-design, doc-design-html, doc-design-pdf, doc-design-ps): Deleted.
  (doc): Removed dependency on doc-design.
  (doc-all-html): Removed dependency on doc-design-html.
  (doc-all-pdf): Removed dependency on doc-design-pdf.
  (doc-all-ps): Removed dependency on doc-design-ps.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
Suggested by: madanus
Review by: madanus
           me


r20146 | cmpilato | 2006-06-16 11:09:28 -0500 (Fri, 16 Jun 2006)

Add --max-items option to svn2rss.py.

Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
Suggested by: cmpilato

* svn2rss.py
  (__doc__): Note new --max-items options
  (__init__): Add handling for --max-items option.
  (SVN2RSS.__init__): Accept new 'max_items' parameter, used to
    populate the previously hard-coded self.max_items variable.


r20004 | dlr | 2006-06-08 11:04:48 -0500 (Thu, 08 Jun 2006)

* contrib/hook-scripts/svn2rss.py
  Add single character command-line options.

  Move help usage text into __doc__, and add a description for each
  option.

  Correctly write usage() info to stderr when the script is invoked
  incorrectly.


Patch by: Bhuvaneswaran Arumugam <bhuvan@collab.net>
(Tweaked by me.)