Chia-liang Kao <clkao@clkao.org> (clkao)

r32778 | kfogel | 2008-08-28 00:00:23 -0500 (Thu, 28 Aug 2008)

Enable pre-lock hook to specify the lock-token via stdout.

   ***********************************************************************
   ***                                                                 ***
   ***                            NOTE:                                ***
   ***                                                                 ***
   ***  Existing pre-lock hooks that print to stdout are incompatible  ***
   ***  with this change.  Such output was previously discarded, but   ***
   ***  now it will affect the names of lock tokens.                   ***
   ***                                                                 ***
   ***  This should be mentioned in CHANGES and in the release notes.  ***
   ***                                                                 ***
   ***********************************************************************

Patch by: clkao

* subversion/include/svn_repos.h
* subversion/libsvn_repos/fs-wrap.c
  (svn_repos_fs_lock): Handle returned new_token from pre-lock hook.

* subversion/libsvn_repos/repos.h
  (svn_repos__hooks_pre_lock): New result parameter 'token' to allow
    lock-token to be returned by reference.

* subversion/libsvn_repos/hooks.c
  (run_hook_cmd): New return parameter 'result' allows stdout of hook
    to be captured and returned.  Update all callers.
  (svn_repos__hooks_pre_lock): Get token from run_hook_cmd.

* subversion/libsvn_repos/repos.c: Document this feature for pre-lock.

r32564 | kfogel | 2008-08-19 16:16:22 -0500 (Tue, 19 Aug 2008)

Make pre-commit hook take lock tokens associated with the commit from stdin.

Patch by: clkao
(Documentation and log message tweaks by me.)

* subversion/include/svn_fs_private.h: Include svn_fs.h.
  (svn_fs__access_get_lock_tokens): New prototype.

* subversion/include/svn_fs.h
  (svn_fs_locks Filesystem locks): Document that lock tokens cannot
   contain newlines. 
  (svn_fs_access_add_lock_token2): New prototype; replaces 
   svn_fs_access_add_lock_token and takes a new path parameter.
  (svn_fs_access_add_lock_token): Deprecate.

* subversion/libsvn_fs/access.c
  (svn_fs_access_add_lock_token2): New function.
  (svn_fs_access_add_lock_token): Deprecate.
  (svn_fs__access_get_lock_tokens): New function.

* subversion/libsvn_ra_local/ra_plugin.c
  (svn_ra_local__get_commit_editor): Call svn_fs_access_add_lock_token2
   instead, with the full paths in repository.

* subversion/libsvn_repos/hooks.c: Include private/svn_fs_private.h.
  (lock_token_content): New function, turns path->lock-token hashes
   into a serialized format used by pre-commit hook.
  (svn_repos__hooks_pre_commit): If there are lock tokens, pass them to
   the pre-commit hook via stdin.

* subversion/libsvn_repos/repos.c
  (create_hooks): Update the pre-commit template to document that
   lock tokens are now passed on stdin.

* subversion/mod_dav_svn/repos.c
  (get_resource): Call svn_fs_access_add_lock_token2 instead.

* subversion/mod_dav_svn/version.c
  (dav_svn__push_locks): Call svn_fs_access_add_lock_token2 instead.

* subversion/svnserve/serve.c
  (add_lock_tokens): Call svn_fs_access_add_lock_token2 instead.

r31620 | stsp | 2008-06-07 05:36:30 -0500 (Sat, 07 Jun 2008)

* subversion/libsvn_repos/hooks.c
  (svn_repos__hooks_start_commit): Don't blindly assume that the
    capabilities parameter is non-NULL. It is NULL if the client
    does not bother to call svn_repos_remember_client_capabilities(),
    which does not seem to be required.
    Also, the private API doc for svn_repos_t says it can be NULL.

Patch by: clkao
(log message tweaked by me)

Review by: danielsh
           me

r23440 | glasser | 2007-02-20 14:12:00 -0600 (Tue, 20 Feb 2007)

Make FSFS's implementation of svn_fs_change_rev_prop use the FSFS
write lock, to avoid a race condition.

* subversion/libsvn_svn_fs/fs_fs.c:
  (change_rev_prop_baton): New baton type for change_rev_prop_body.
  (change_rev_prop_body): New function, formerly the guts 
   of svn_fs_fs__change_rev_prop.
  (svn_fs_fs__change_rev_prop): Replace guts with a write-lock-wrapped
   call to change_rev_prop_body.

Found by: clkao
Suggested by: sussman
              malcolm

r22609 | cmpilato | 2006-12-08 10:06:24 -0600 (Fri, 08 Dec 2006)

Make svn_repos_replay2 able to send deltas when used with txn roots.

* subversion/libsvn_repos/replay.c:
  (svn_repos_replay2) When used with a txn root, set compare_root in
    the path-driver callback baton to a revision root built on the
    txn's base revision.

Patch by: Chia-liang Kao <clkao@clkao.org>
(Tweaked by me.)

r18514 | rooneg | 2006-02-17 18:15:03 -0600 (Fri, 17 Feb 2006)

Unbreak Perl bindings, fs->config can be null according to svn_fs.h.

Patch by: clkao
(Ported to libsvn_fs_base by me.)

* subversion/libsvn_fs_fs/fs_fs.c
  (svn_fs_fs__create): Don't assume fs->config is non-null.
   Also remove a variable that is only used in the same test.

* subversion/libsvn_fs_base/fs.c
  (base_create): Ditto.

r16953 | lundblad | 2005-10-24 00:58:36 -0500 (Mon, 24 Oct 2005)

Follow-up to r16046.  Fix regression, making the case where
passing a transaction to svn_repos_get_commit_editor4 didn't work, because
the transaction couldn't be comittted while closing the edit.

Suggested by: clkao

* subversion/tests/libsvn_repos/repos-test.c (dummy_commit_cb): New function.
  (commit_continue_txn): New test.
  (test_funcs): Add it.

* subversion/libsvn_repos/commit.c (close_edit): Don't error if we aren't the
  owner of the transaction.

r16369 | maxb | 2005-09-30 03:51:15 -0500 (Fri, 30 Sep 2005)

Fix API NULL-tolerance as per its documentation.
Revealed by crashes in check-swig-pl, check-swig-py.

Patch by: clkao

* subversion/libsvn_repos/repos.c
  (svn_repos_create): Allow fs_config argument to be NULL, as the API promises.

r16366 | dlr | 2005-09-30 02:50:26 -0500 (Fri, 30 Sep 2005)

A follow-up to r16365, aligning it with the version of the patch which
I actually proposed on the dev list.

* subversion/libsvn_repos/repos.c
  (svn_repos_create): Allow fs_config to be NULL, yet pay attention to
   any file system type configuration it contains when it is not null.

Patch by: me
          clkao
Review by: djames

r16365 | djames | 2005-09-30 01:45:25 -0500 (Fri, 30 Sep 2005)

Fix check-swig-py and check-swig-pl failures.

* subversion/libsvn_repos/repos.c
  (create_svn_repos_t): Set repos->fs_type to DEFAULT_FS_TYPE.
  (svn_repos_create): Allow fs_config to be NULL, as documented in svn_repos.h.

Patch by: dlr
          clkao

r16097 | cmpilato | 2005-09-09 04:30:51 -0500 (Fri, 09 Sep 2005)

Finish issue #1970 ("History-following algorithm incomplete").

Implement svn_fs_closest_copy(), and use it to fix a correctness bug
in the history-following.

Patch by: ghudson
          cmpilato
          clkao
          kfogel

* subversion/include/svn_fs.h, 
* subversion/libsvn_fs/fs-loader.c
  (svn_fs_closest_copy): New function.

* subversion/libsvn_fs/fs-loader.h
  (root_vtable_t): Add closest_copy entry.

* subversion/libsvn_fs_fs/tree.c
  (fs_closest_copy): New function to implement the new API.
  (root_vtable): Insert fs_closest_copy.

* subversion/libsvn_fs_base/tree.c
  (closest_copy_args, txn_body_closest_copy, base_closest_copy): New
    functions and batons to implement the new API.
  (root_vtable): Insert base_closest_copy.

* subversion/libsvn_repos/rev_hunt.c: Include svn_path.h.
  (svn_repos_trace_node_locations): Rewrite copy-tracing logic to skip
  unrelated interloper node revisions, by using svn_fs_closest_copy.

* subversion/tests/clients/cmdline/history_tests.py
  (test_list): No longer expect cat_avoids_false_identities() to fail.

* subversion/tests/libsvn_fs/fs-test.c
  (test_closest_copy_pair): New helper.
  (closest_copy_test): New test.
  (test_funcs): Add reference to closest_copy_test().

* subversion/bindings/swig/perl/native/Fs.pm
  Make closest_copy() a method of svn_fs_root.

r10433 | breser | 2004-07-27 18:20:05 -0500 (Tue, 27 Jul 2004)

The new VCP destination driver based on svk is now on CPAN.
Update links accordingly.

Patch by: Chia-liang Kao <clkao@clkao.org>

* www/project_links.html
* www/project_faq.html
  Per clkao's request move links from his web page to CPAN for VCP.

r7852 | cmpilato | 2003-11-26 02:04:15 -0600 (Wed, 26 Nov 2003)

Keep dir-delta from producing no-op apply_textdelta()s when ignoring
ancestry.  This makes many things work better in the case of two
mutually merged branches, since editors now know the source and target
stream are the same without having to construct the fulltext from the
noop txdelta.  As a result, 'svn diff' between the two branches will
no longer show a lot of empty diffs.

Patch by: Chia-liang Kao <clkao@clkao.org>
(Tweaked by me.)

* subversion/libsvn_repos/delta.c
  (compare_files): New.
  (delta_files): Use the new compare_files() instead of
    svn_fs_contents_changed() when ignore_ancestry is on.

r4680 | kfogel | 2003-01-30 17:14:03 -0600 (Thu, 30 Jan 2003)

Update cvs2svn for revision 4570.

Patch by: Chia-liang Kao <clkao@clkao.org>
          Marshall White <cscidork@yahoo.com>
(Both submitted the same patch independently.)

* tools/cvs2svn/cvs2svn.py:
  Replace calls to svn_stream_from_stdio with svn_stream_from_aprfile.

Found	Patch	Suggested
r23440	r32778, r32564, r31620, r22609, r18514, r16369, r16366, r16365, r16097, r10433, r8572, r7957, r7852, r7851, r4680	r16966, r16953