Daniel Shahaf <d.s@daniel.shahaf.co.il>


Found Patch Suggested
r30744, r30714, r30713, r30708, r30703, r30631, r29034, r24516 r30760, r30684, r30666, r29671, r29559 r30804, r30796, r30737, r30731, r30717, r30710, r30709

r30804 | arfrever | 2008-04-27 11:28:30 -0500 (Sun, 27 Apr 2008)

On the 'kwallet' branch:

* configure.ac: Clarify that only KDE 4 is supported.

Suggested by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30796 | arfrever | 2008-04-26 10:29:00 -0500 (Sat, 26 Apr 2008)

On the 'kwallet' branch:

* subversion/libsvn_subr/simple_providers.h
* subversion/libsvn_subr/simple_providers.c
  (svn_simple_providers__password_get_t): Renamed from ...
  (password_get_t): ... this.
  (svn_simple_providers__password_set_t): Renamed from ...
  (password_set_t): ... this.
  (svn_simple_providers__simple_first_creds_helper): Renamed from ...
  (simple_first_creds_helper): ... this.
  (svn_simple_providers__simple_save_creds_helper): Renamed from ...
  (simple_save_creds_helper): ... this.

* subversion/libsvn_subr/simple_providers.c
  (simple_first_creds, simple_save_creds, windows_simple_first_creds,
   windows_simple_save_creds, keychain_simple_first_creds,
   keychain_simple_save_creds):
* subversion/libsvn_subr/simple_providers_cpp.cpp
  (kwallet_simple_first_creds, kwallet_simple_save_creds):
   Call renamed functions.

* subversion/libsvn_subr/simple_providers.c
  (simple_password_get, simple_password_set, windows_password_encrypter,
   windows_password_decrypter, keychain_password_set, keychain_password_get):
* subversion/libsvn_subr/simple_providers_cpp.cpp
  (kwallet_password_get, kwallet_password_set):
   Update descriptions.

* subversion/include/svn_auth.h
  (svn_auth_get_kwallet_simple_provider):
* subversion/libsvn_subr/simple_providers_cpp.cpp
  (kwallet_password_get, kwallet_password_set):
   s/the KWallet/KWallet/ in descriptions.

Suggested by: stsp
              Daniel Shahaf <d.s@daniel.shahaf.co.il>
(s/the KWallet/KWallet/ suggested only by stsp.)


r30760 | kfogel | 2008-04-23 08:44:42 -0500 (Wed, 23 Apr 2008)

Fix a couple of bugs in username/password caching.

Patch by: Daniel Shahaf <d.s@daniel.shahaf.co.il>
(Only stylistic tweaks by me.)

Suggested by: stsp

* subversion/libsvn_subr/simple_providers.c
  (simple_save_creds_helper):
    Cache the username even if we're not allowed to cache the password.
    Also, respect SVN_AUTH_PARAM_NO_AUTH_CACHE.  We hadn't been before,
    but because the caller also happened to check it, there was no
    user-visible problem, just a masked violation of the provider API.


r30744 | stsp | 2008-04-21 17:04:35 -0500 (Mon, 21 Apr 2008)

On the dont-save-plaintext-passwords-by-default branch:

* subversion/include/svn_cmdline.h
  (svn_cmdline_auth_plaintext_prompt): Does use baton argument
   now, so remove contradicting statement in docstring (which in
   hindsight should never have been there in the first place).

* subversion/libsvn_subr/config_file.c
  (svn_config_ensure): Split a 160 characters long line into two.

Found by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30737 | kfogel | 2008-04-21 11:07:30 -0500 (Mon, 21 Apr 2008)

* STATUS: Add r30726 to the r30666, r30684 group.

Suggested by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30731 | stsp | 2008-04-21 08:17:56 -0500 (Mon, 21 Apr 2008)

On the dont-save-plaintext-passwords-by-default branch,
tell the user exactly which file to edit during the prompt.

* subversion/include/svn_config.h
  (svn_config_get_user_config_path): Declare and document.

* subversion/include/svn_cmdline.h
  (svn_cmdline_prompt_baton2_t): Extends svn_cmdline_prompt_baton_t,
   now has a member pointing to the path to the configuration
   directory.
  (svn_cmdline_prompt_baton_t): Deprecate.

* subversion/libsvn_subr/config_file.c
  (svn_config__user_config_path): Rename to ...
  (svn_config_get_user_config_path): ... this and make public.
   Also, put the return value into the first parameter.
  (svn_config_ensure): Track rename and argument order change.

* subversion/libsvn_subr/config.c
  (get_category_config): Track rename and argument order change.

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton2): Use svn_cmdline_prompt_baton2_t.

* subversion/libsvn_subr/prompt.c
  (svn_cmdline_auth_plaintext_prompt): Print the name of the
   configuration file, retrieved from the baton.

* subversion/libsvn_subr/config_auth.c
  (auth_file_path): Track rename and argument order change.

* TODO.branch: Remove, this was the last item.

Suggested by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30717 | stsp | 2008-04-19 17:04:07 -0500 (Sat, 19 Apr 2008)

On the dont-save-plaintext-passwords-by-default branch:

* subversion/libsvn_subr/prompt.c
  (svn_cmdline_auth_plaintext_prompt): Use a single function call to
   print the warning, and print it to stderr.

Suggested by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30714 | stsp | 2008-04-19 14:25:35 -0500 (Sat, 19 Apr 2008)

On the dont-save-plaintext-passwords-by-default branch:

* subversion/libsvn_subr/simple_providers.c
  (simple_save_creds_helper): Fix involuntary whitespace change.

Found by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30713 | stsp | 2008-04-19 14:18:36 -0500 (Sat, 19 Apr 2008)

On the dont-save-plaintext-passwords-by-default branch:

* subversion/libsvn_subr/prompt.c
  (svn_cmdline_auth_plaintext_prompt): Remove superfluous invocations
    of svn_cmdline_printf.

* subversion/libsvn_subr/simple_providers.c
  (simple_save_creds_helper): Whitespace fix.

* subversion/svn/cl.h
 (svn_cl__opt_state_t): Get rid of store_plaintext_passwords member.

Found by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30710 | stsp | 2008-04-19 09:23:23 -0500 (Sat, 19 Apr 2008)

On the dont-save-plaintext-passwords-by-default branch:

* subversion/libsvn_subr/config.c
  (svn_config_get_bool2): Allow the default_value_was_used parameter
   to be NULL.
     
* subversion/include/svn_config.h
  (svn_config_get_bool2): Update docstring.

Suggested by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30709 | stsp | 2008-04-19 09:02:28 -0500 (Sat, 19 Apr 2008)

On the dont-save-plaintext-passwords-by-default:

* subversion/include/svn_config.h
  (svn_config_get_bool2): Enhance docstring.

Suggested by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30708 | stsp | 2008-04-19 08:52:50 -0500 (Sat, 19 Apr 2008)

On the dont-save-plaintext-passwords-by-default branch:

* subversion/libsvn_subr/config.c
  (svn_config_get_bool2): Initialise *default_value_was_used.

Found by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30703 | stsp | 2008-04-19 07:18:24 -0500 (Sat, 19 Apr 2008)

On the dont-save-plaintext-passwords-by-default branch:

* subversion/libsvn_subr/simple_providers.c
  (simple_save_creds_helper): may_save_plaintext could be used
   uninitialised if b->plaintext_prompt_func was NULL.

Found by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r30684 | kfogel | 2008-04-18 11:56:09 -0500 (Fri, 18 Apr 2008)

Check repository UUID when creating an RA session.  This fixes an
issue where "svn update" would silently overwrite the UUID of a
working copy if the repository UUID had changed.  Several tests in
svnadmin_tests which silently took advantage of this are fixed too.

This patch was filed as issue #3177.

Patch by: Daniel Shahaf <d.s@daniel.shahaf.co.il>
(Tweaked by me to use the new API everywhere, fix up comments, etc.)

* subversion/include/svn_ra.h, subversion/libsvn_ra/ra_loader.c
  (svn_ra_open3): New API, deprecates svn_ra_open2.  Adjust comments.

* subversion/libsvn_client/ra.c
  (svn_client__open_ra_session_internal): When having a working copy,
    pass its uuid to svn_ra_open3().

* subversion/include/svn_error_codes.h
  (SVN_ERR_RA_UUID_MISMATCH): New error.

* subversion/tests/libsvn_ra_local/ra-local-test.c
  (make_and_open_local_repos): Call svn_ra_open3, but pass NULL for uuid.

* subversion/svnsync/main.c
  (do_initialize, initialize_cmd, synchronize_cmd, copy_revprops_cmd):
    Call svn_ra_open3.
  (open_source_session): Call svn_ra_open3, pass the expected uuid to it,
    and eliminate the code that compared uuids by hand.

* subversion/include/svn_client.h
  (svn_client_open_ra_session): Adjust comment.

* subversion/libsvn_client/client.h
  (svn_client__default_walker_error_handler): Adjust comment.

* subversion/libsvn_client/copy.c
  (repos_to_repos_copy): Adjust comment.

* subversion/tests/cmdline/update_tests.py
  (update_uuid_changed): New test.
  (test_list): Run it.

* subversion/tests/cmdline/switch_tests.py
  (switch_change_repos_root): Change expected error message.

* subversion/tests/cmdline/svnadmin_tests.py
  (extra_headers, extra_blockcontent, empty_date):
    Load dumpfile with '--ignore-uuid' in order to not change the repository
    uuid, since a working copy already has been checked out from it.


r30666 | kfogel | 2008-04-17 14:27:12 -0500 (Thu, 17 Apr 2008)

In ra_neon, cache starting props when first seen, to reduce round trips.

Patch by: Daniel Shahaf <d.s@daniel.shahaf.co.il>
(Tweaked by me.)

* subversion/libsvn_ra_neon/ra_neon.h
  (svn_ra_neon__session_t):  New member 'vcc'.
  (svn_ra_neon__get_starting_props,
   svn_ra_neon__search_for_starting_props): Document the caching
     behavior, because it's visible and we now depend on it.

* subversion/libsvn_ra_neon/props.c
  (svn_ra_neon__get_starting_props):  Cache VCC and UUID in the session.
  (svn_ra_neon__get_vcc):  Look in the cache first.
  (svn_ra_neon__get_baseline_props):
    Call __get_vcc() to get the VCC.
    Change local variable 'vcc' to 'const char *' from 'svn_string_t *'.
  (svn_ra_neon__get_baseline_info):
    Call __get_starting_props() instead of calling
    svn_ra_neon__get_props_resource() directly.

* subversion/libsvn_ra_neon/session.c
  (svn_ra_neon__open):  Initialize cached fields to NULL.
  (svn_ra_neon__do_get_uuid):  Rely on __get_starting_props() to cache
    the UUID.

* subversion/libsvn_ra_neon/commit.c (apply_revprops):
    Call __get_vcc() to get the VCC, to take advantage of the cache.


r30631 | hwright | 2008-04-16 10:49:23 -0500 (Wed, 16 Apr 2008)

* www/svn_1.5_releasenotes.html:
  Followup to r30600: Fix a mismatched closing div tag.

Found by: Daniel Shahaf <d.s@daniel.shahaf.co.il>


r29671 | cmpilato | 2008-03-03 10:35:14 -0600 (Mon, 03 Mar 2008)

Finish issue #3114 by raising 'skip' notifications when adding
directories to a changelist.  This tweaks the test framework to
gracefully deal with the new notifications, but does not add testing
of the actual notifications generated.

* subversion/libsvn_client/changelist.c
  (set_entry_changelist): On directories, raise svn_wc_notify_skip.

* subversion/tests/cmdline/changelist_tests.py
  (verify_changelist_output): New 'expected_skips' optional parameter.
  (_re_cl_skip): New regular expression for verify_changelist_output().
  (add_remove_changelists): Add 'skip' notifications infrastructure, unused.

Patch by: Daniel Shahaf <d.s{_AT_}daniel.shahaf.co.il>
          me
(I merely outpaced Daniel in writing the C part)


r29559 | lgo | 2008-02-23 02:50:14 -0600 (Sat, 23 Feb 2008)

Fix copy_tests.py on Windows where cleanup of the test working copy fails.

Patch by: Daniel Shahaf <d.s{_AT_}daniel.shahaf.co.il> 

* subversion/tests/cmdline/copy_tests.py
  (replaced_local_source_for_incoming_copy): replace shutil.rmtree with the 
   more effective safe_rmtree.


r29034 | cmpilato | 2008-01-25 08:06:52 -0600 (Fri, 25 Jan 2008)

Fix a use of an uninitialized variable in the new FSFS node-origins code.

* subversion/libsvn_fs_fs/fs_fs.c
  (svn_fs_fs__get_node_origin): Initialize return variable so it isn't
    full of random gunk in the early return case.

Found by: Daniel Shahaf <d.s{_AT_}daniel.shahaf.co.il>


r24516 | dlr | 2007-04-10 14:19:03 -0500 (Tue, 10 Apr 2007)

Fix 'svnversion --version' segfault portion of issue #2757 (which had
similar problems as those for 'svnserve --version', fixed in r24385
and r24418).

* subversion/svnserve/svnserve.c
  (version): Remove the apr_getopt_t * parameter.  Because we always
   call this helper function with this parameter as NULL, we don't
   need to pass it at all.
  (main): Adjust the call to version() to use the new arguments.

Found by: Daniel Shahaf <danielsh@tigris.org>