Dave Lawrence <dlawrence@ad-holdings.co.uk>


Found Patch
r868405 r869871

r869871 | djh | 2008-03-08 13:36:22 -0600 (Sat, 08 Mar 2008)

Fix sample VC6 build script.

* build/win32/vc6-build.bat.in:
  Correct zlibstaterr label name to match the goto,
  and use setlocal / endlocal to limit the environment changes to the
  duration of the script.

Patch by: Dave Lawrence <dlawrence@ad-holdings.co.uk>


r868405 | dlr | 2007-12-07 15:58:46 -0600 (Fri, 07 Dec 2007)

Fix a bug where the svn:eol-style property could be set to a bogus
value (e.g. via propset/propedit), with annoying repercussions.

Originally reported against TortoiseSVN at
<http://tortoisesvn.tigris.org/servlets/ReadMsg?list=users&msgNo=8535>:

  "When somebody went to switch from trunk to a tag (the tag did not
  have the property), SVN failed at the point that it tried to remove
  the property from their working copy (the error was something like
  "invalid eol-style").  So I removed this property from trunk, got
  the user to manually remove the property from their working copy and
  then they could switch successfully (the property is just merged
  away at that point)."

  But then things got much worse.  Now anyone on trunk who tries to
  update to the head revision is faced with the same error.  The
  work-around of course is that they must all manually delete this
  property."

Subsequently reported against Subversion's own libraries at
<http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=133402>.

* subversion/libsvn_wc/props.c
  (svn_wc_canonicalize_svn_prop): Error out if the value of the
   svn:eol-style property is set, but isn't recognized.

* subversion/tests/cmdline/prop_tests.py
  (inappropriate_props): Extend test to check that an invalid value
   for the svn:eol-style property results in an error.

Found by: Dave Lawrence <dlawrence@ad-holdings.co.uk>
          Stefan Kueng <tortoisesvn@gmail.com>
Reviewed by: Stefan Kueng <tortoisesvn@gmail.com>
             sussman
             ehu
             glasser