Edmund Wong <ed@kdtc.net>


Found Patch
r877229 r901304, r880521, r880445, r879359, r879207, r879205, r879064, r879057, r878742, r878686, r878649, r877861, r877262, r877169, r877125, r877045, r876949, r876678

r901304 | lgo | 2010-01-20 11:51:14 -0600 (Wed, 20 Jan 2010)

* subversion/libsvn_subr/win32_crashrpt.c
  (CRASHREPORT_EMAIL): Update email address to the new apache.org domain.

Patch by: Edmund Wong <ed{_AT_}kdtc.net>


r880521 | julianfoad | 2009-11-10 18:30:04 -0600 (Tue, 10 Nov 2009)

Initialize an array with character constants rather than a string constant,
to avoid a compiler warning about not having room for a terminating null
character.

* subversion/libsvn_delta/svndiff.c
  (window_handler): Change "SVN\0" to {'S','V','N','\0'}, where the final
    character is a version number and not a string terminator.

Patch by: Edmund Wong <ed{_AT_}kdtc.net>
          me
Suggested by: rhuijben


r880445 | julianfoad | 2009-11-04 04:57:29 -0600 (Wed, 04 Nov 2009)

Put some code that is unused on Windows into a '#ifndef WIN32' block, to
avoid 'unreachable code' warnings.

* subversion/libsvn_subr/prompt.c
  (wait_for_input): As above.

Patch by: Edmund Wong <ed{_AT_}kdtc.net>
(tweaked by me)


r879359 | gstein | 2009-09-13 23:33:57 -0500 (Sun, 13 Sep 2009)

Fixed gen_win.py such that it checks for the presence of the Serf library
(which it does prior to this patch) and also outputs the library version
(which is what this patch does). It also checks if the serf version >=
0.3.0.  If not, ra_serf is not built.

* build/generator/gen_win.py:
  (_get_serf_version): New function to return the serf library version.
  (_find_serf): Added a version check and if a valid version is found,
    ra_serf is built; otherwise, it isn't.  If the version cannot be
    determined, ra_serf will still be built. The user is the informed of
    the results.

Patch by: Edmund Wong <ed@kdtc.net>
Suggested by: danielsh
Patch heavily tweaked by: gstein


r879207 | julianfoad | 2009-09-03 19:35:49 -0500 (Thu, 03 Sep 2009)

Fix issue #3436: add a short option for --ignore-externals.

Instead of using the suggested -i, markphip suggested --ie
which is what is implemented, in accordance to the discussion at
<http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=2370618&dsForumId=462>.

* subversion/svn/main.c
  (svn_cl__options): Add a new option "--ie" as an alias of
    "--ignore-externals", and mention it in the option's help text.

* subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout
     Adjust the expected help text accordingly.

Patch by: Edmund Wong <ed{_AT_}kdtc.net>
Suggested by: markphip
              danielsh
              stsp
              me


r879205 | julianfoad | 2009-09-03 19:04:38 -0500 (Thu, 03 Sep 2009)

Changed the rep-cache.h header to reflect the right file name and description.

Patch by: Edmund Wong <ed{_AT_}kdtc.net>

* subversion/libsvn_fs_fs/rep-cache.h
  Changed "id.h : interface to node ID functions, private to libsvn_fs_fs" to
  "rep-cache.h : interface to rep cache db functions".


r879064 | stsp | 2009-08-31 05:10:54 -0500 (Mon, 31 Aug 2009)

Follow-up to r38983: The new eol functions are supposed to be private,
not public, so rename them accordingly.

* subversion/libsvn_subr/eol.c,
  subversion/include/private/svn_eol_private.h
  (svn_eol_find_eol_start, svn_eol_detect_eol,
   svn_eol_detect_file_eol): Renamed from these ...
  (svn_eol__find_eol_start, svn_eol__detect_eol,
   svn_eol__detect_file_eol): ... to these.

* subversion/libsvn_diff/diff_file.c,
  subversion/tests/libsvn_subr/eol-test.c,
  subversion/libsvn_client/patch.c: Track renames.

Patch by: Edmund Wong <ed@kdtc.net>
Found by: arfrever


r879057 | stsp | 2009-08-28 09:01:09 -0500 (Fri, 28 Aug 2009)

Move functions concerned with EOL parsing from libsvn_subr/subst.c
to libsvn_subr/eol.c. This allows further consolidation of code
concerned with EOL-parsing instead of being all over the place.

Note that functions concerned with the svn:eol-style property are not
affected by this change.

[ Note from the future: The change to build.conf was accidentally not
  committed, and was instead committed in r38984. ]
* build.conf:
  (subst-test): Rename to ...
  (eol-test): ... this.
  (__ALL_TESTS__): Track renamed test.
  (msvc-export): Add private\svn_eol_private.h.

* subversion/include/private/svn_eol_private.h: New.

* subversion/libsvn_subr/subst.c,
  subversion/include/svn_subst.h
  (svn_subst_find_eol_start, svn_subst_detect_eol,
   svn_subst_detect_file_eol): Move these functions from here ...

* subversion/libsvn_subr/eol.c,
  subversion/include/private/svn_eol_private.h
  (svn_eol_find_eol_start, svn_eol_detect_eol,
   svn_eol_detect_file_eol): ... to these new files and rename them.

* subversion/libsvn_client/patch.c,
  subversion/libsvn_diff/diff-file.c: Track renamed functions.

* subversion/tests/libsvn_subr/subst-test.c: Rename to ...

* subversion/tests/libsvn_subr/eol-test.c: ... this, and track renamed
   functions.

Patch by: Edmund Wong <ed{_AT_}kdtc.net>
Suggested by: stsp


r878742 | stylesen | 2009-08-11 01:44:28 -0500 (Tue, 11 Aug 2009)

Change the license type from BSD-Style to Apache License, Version 2.0.

* www/hacking.html
  s/a BSD-style/an Apache License, Version 2.0/

Patch by: Edmund Wong <ed{_AT_}kdtc.net>


r878686 | stsp | 2009-08-07 05:04:43 -0500 (Fri, 07 Aug 2009)

Fix typo in command message that gets written to the test log.
A space was missing between the command and its arguments:
"svnadmindump" -> "svnadmin dump"

* subversion/tests/cmdline/svntest/main.py:
  (copy_repos): Put spaces between format strings.

Patch by: Edmund Wong <ed{_AT_}kdtc.net>
(log message and indentation tweaks by me)


r878649 | stylesen | 2009-08-06 03:54:15 -0500 (Thu, 06 Aug 2009)

Fix a typo.

* subversion/tests/libsvn_wc/db-test.c
  (svn_test_descriptor_t): s/fromat/format/

Patch by: Edmund Wong <ed{_AT_}kdtc.net>


r877861 | stsp | 2009-05-21 05:07:59 -0500 (Thu, 21 May 2009)

* subversion/include/svn_wc.h: Fix typos in various docstrings.

Patch by: Edmund Wong <ed@kdtc.net>


r877262 | gstein | 2009-04-12 13:07:22 -0500 (Sun, 12 Apr 2009)

Completed the TODO as stated in svn_io.h for svn_stream_copy3().

* subversion/libsvn_subr/stream.c:
  (svn_stream_copy3): Even on error exit, the two files from and to are
  closed.

Patch by: Edmund Wong <edmund{_at_}belfordhk.com>

Review by: mf
           gstein


r877229 | brane | 2009-04-10 06:42:49 -0500 (Fri, 10 Apr 2009)

* subversion/libsvn_client/merge.c (ENSURE_VALID_REVISION_KINDS): Remove.
  Was cruft left over from who knows when.

Found by: Edmund Wong <ed{_at_}kdtc.net>


r877169 | stylesen | 2009-04-08 01:42:31 -0500 (Wed, 08 Apr 2009)

Fix typos in comments.

* subversion/include/svn_io.h
  (svn_stream_open_unique): s/possibly/possible/
  (svn_io_write_unique): s/possibly/possible/

Patch by: Edmund Wong <edmund@belfordhk.com>


r877125 | stylesen | 2009-04-07 04:14:57 -0500 (Tue, 07 Apr 2009)

Fix a typo in comment.

* subversion/include/svn_io.h
  (svn_io_open_unique_file3): s/possibly/possible/

Patch by: Edmund Wong <edmund@belfordhk.com>
(log message tweaked by me)


r877045 | stsp | 2009-04-03 11:02:49 -0500 (Fri, 03 Apr 2009)

Fix issue #3207, "svn rm error message clarification for added files".

* subversion/svn/util.c
  (svn_cl__may_need_force): In error message, mention that local modifications
   may be lost of --force is used.

* subversion/libsvn_client/delete.c
  (find_undeletables): In error message, suggest to commit or revert changes
   before trying to repeat the desired operation.

Patch by: Edmund Wong <edmund@belfordhk.com>
Suggested by: Braden Anderson <bander@tigris.org>
(initial patch tweaked by me, with help from Edmund)


r876949 | stsp | 2009-03-30 17:45:11 -0500 (Mon, 30 Mar 2009)

Followup to r36302.

Modified change-svn-wc-format.py to create or update format file in
the .svn folder.

* tools/client-side/change-svn-wc-format.py
 (WCFormatConverter: write_dir_format): Added a check if the entries
  file was parsed properly.  If so, the format file is also created
  (if it does not exist in the .svn folder) or updated with the given
  format_nbr value as given by the write_dir_format parameter.
 (Format): Added new class to take care of the .svn/format file.

Patch by: Edmund Wong <edmund@belfordhk.com>
Reviewed by: me
             arfrever
             danielsh
(Log message reformatted but otherwise left intact by me.)


r876678 | hwright | 2009-03-16 15:18:57 -0500 (Mon, 16 Mar 2009)

* CHANGES: Initial pass for 1.6.0.

Patch by: khmarbaise
          bhuvan
          Edmund <edmund@belfordhk.com>
          Thomas Koski <koski.tuomas@gmail.com>