Jelmer Vernooij <jelmer@samba.org> (jrvernooij)


Found Patch Review
r31837, r28485, r28356 r20230, r20227, r20158, r20157, r20110, r20107, r20102, r20095, r20094, r19860, r19718, r19616, r19607, r19566, r19413 r28544

r31837 | kfogel | 2008-06-21 22:22:00 -0500 (Sat, 21 Jun 2008)

* subversion/libsvn_subr/path.c
  (svn_path_canonicalize): Take an early out if path is "", to avoid
    accessing uninitialized memory later when we look at *(dst - 1).

Found by: Jelmer Vernooij <jelmer@samba.org>
(Discussed with him in IRC and dev@ posts right before this commit.)


r28544 | djames | 2007-12-18 19:10:36 -0600 (Tue, 18 Dec 2007)

Fix a major memory leak in the Python object duplication code.

Review by: jrvernooij

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (make_ob_txdelta_window, make_ob_log_changed_path,
   make_ob_wc_status, make_ob_lock, make_ob_auth_ssl_server_cert_info,
   make_ob_info, make_ob_location_segment, make_ob_commit_info,
   make_ob_wc_notify): Fix memory leak.



r28485 | epg | 2007-12-14 11:36:43 -0600 (Fri, 14 Dec 2007)

* subversion/bindings/swig/python/svn/core.py
  (SubversionException._new_from_err_list): Follow-up to r28356: I failed
    to adapt this constructor to __init__'s new argument order.

Found by: jrvernooij


r28356 | epg | 2007-12-09 14:57:11 -0600 (Sun, 09 Dec 2007)

* subversion/bindings/swig/python/svn/core.py
  (SubversionException): Improve 1.4 compatibility.

* subversion/bindings/swig/python/tests/core.py
  Add core testing module, just testing SubversionException for now.

* subversion/bindings/swig/python/tests/run_all.py
  Run new core tests.

Found by: jrvernooij


r20230 | djames | 2006-06-23 13:23:47 -0500 (Fri, 23 Jun 2006)

Fix Python bindings for svn.wc.crawl_revisions2().

Patch by: jrvernooij
          me
Review by: madanus

[ In subversion/bindings/swig ]

 * svn_ra.i: Add Python typemap for svn_ra_reporter2_t.

 * svn_wc.i: Add Python typemap for svn_wc_notify_func2_t.

 * tests/wc.py
   (setUp): Open working copy subdirectories.
   (test_crawl_revisions2): Add test for svn.wc.crawl_revisions2() and
    svn_ra_reporter2_t implementations.

 * python/libsvn_swig_py/swigutil_py.c
   (make_ob_wc_notify): Add function.
   (svn_swig_py_notify_func2): Add Python wrapper for svn_wc_notify_func2_t.
   (reporter_set_path): Add function.
   (reporter_delete_path): Add function.
   (reporter_link_path): Add function.
   (reporter_abort_report): Add function.
   (reporter_finish_report): Add function.
   (swig_py_ra_reporter2): Add Python wrapper for svn_ra_reporter2_t.

 * python/libsvn_swig_py/swigutil_py.h
   (swig_py_ra_reporter2): Add extern.
   (svn_swig_py_notify_func2): Add prototype.



r20227 | rooneg | 2006-06-23 10:04:46 -0500 (Fri, 23 Jun 2006)

Return error code for unversioned files in svn_wc_crawl_revisions2()
rather than crashing.

Patch by: Jelmer Vernooij <jelmer@samba.org>
Tweaked by: me

* subversion/libsvn_wc/adm_crawler.c
  (svn_wc_crawl_revisions2): Return error for unversioned files.


r20158 | djames | 2006-06-18 11:32:25 -0500 (Sun, 18 Jun 2006)

Fix Python bindings for svn.ra.get_file_revs().

Patch by: jrvernooij
          me
Review by: me

 * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
   (svn_swig_py_ra_file_rev_handler_func): Add Python wrapper for
   svn_ra_file_rev_handler_t.
   (proparray_to_dict): New function.

 * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
   (svn_swig_py_ra_file_rev_handler_func): New function.

 * subversion/bindings/swig/svn_ra.i: Add typemap for
   svn_ra_file_rev_handler_t.

 * subversion/bindings/swig/python/tests/ra.py
   (test_get_file_revs): Add test for svn.ra.get_file_revs().



r20157 | jrvernooij | 2006-06-17 17:34:55 -0500 (Sat, 17 Jun 2006)

Cleanup wc in the svn.wc python binding test script.

Patch by: madanus
          me

 * subversion/bindings/swig/python/tests/wc.py
   (global): Import shutil.
   (setUp): Generate random name for wc directory instead of fixed location.
   (tearDown): Cleanup wc path after the tests.


r20110 | djames | 2006-06-14 17:53:51 -0500 (Wed, 14 Jun 2006)

Improve test coverage for Python bindings to svn.wc.

Patch by: Jelmer Vernooij <jelmer@samba.org>
          me

 * subversion/bindings/swig/python/tests/wc.py
   (test_get_ancestry): Add test for get_ancestry().
   (test_status): Add basic test for status().
   (test_is_normal_prop): Add test for is_normal_prop().
   (test_is_wc_prop): Add test for is_wc_prop().
   (test_is_entry_prop): Add test for is_entry_prop().
   (test_get_pristine_copy_path): Add test for get_pristine_copy_path().



r20107 | djames | 2006-06-14 17:25:35 -0500 (Wed, 14 Jun 2006)

Improve test coverage of the Python bindings for svn.client.

Patch by: Jelmer Vernooij <jelmer@samba.org>
          me

 * subversion/bindings/swig/python/tests/client.py
   (test_checkout): Add test for checkout2().
   (test_uuid_from_url): Add test for uuid_from_url().
   (test_url_from_path): Add test for url_from_path().
   (test_uuid_from_path): Add test for uuid_from_path().
   (test_open_ra_session): Add test for open_ra_session().



r20102 | rooneg | 2006-06-14 14:20:16 -0500 (Wed, 14 Jun 2006)

More test coverage for the svn.wc Python bindings.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/python/tests/wc.py
  (setUp): Acquire write lock on wc
  (tearDown): Explicitly close wc
  (test_lock): Add tests for add_lock and remove_lock
  (test_version): Add test for version()
  (test_is_adm_dir): Add test for is_adm_dir()
  (test_get_adm_dir): Add test for get_adm_dir()
  (test_set_adm_dir): Add test for set_adm_dir()
  (test_init_traversal_info): Add test for init_traversal_info()
  (test_create_notify): Add test for create_notify()
  (test_check_wc): Add test for test_wc()


r20095 | rooneg | 2006-06-14 12:16:17 -0500 (Wed, 14 Jun 2006)

Don't crash when NULL revisions are passed to the python bindings.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/svn_client.i:
  Disallow passing NULL revision and peg_revision arguments.


r20094 | rooneg | 2006-06-14 10:21:10 -0500 (Wed, 14 Jun 2006)

Add initial testsuite for the Python bindings to svn.wc.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/python/tests/run_all.py
  (suite): Add working copy testsuite.

* subversion/bindings/swig/python/tests/wc.py: Add test suite for svn.wc.


r19860 | djames | 2006-05-30 19:06:27 -0500 (Tue, 30 May 2006)

Add tests for Python bindings to svn_ra_get_commit_editor2() and
svn_ra_do_update().

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/python/tests/ra.py
  (test_commit): Use returned delta editor and close commit.
  (test_update): Add simple testcase for svn.ra.do_update().



r19718 | djames | 2006-05-18 15:30:31 -0500 (Thu, 18 May 2006)

Create typemaps for the input arguments of svn.ra.get_commit_editor2().

TODO: Add typemaps for the return value of this function as well.

Patch by: Jelmer Vernooij <jelmer@samba.org>
          me

* subversion/bindings/swig/svn_ra.i:
  Mark const svn_delta_editor ** as out argument

* subversion/bindings/swig/python/tests/ra.py:
  (test_commit): Add test for svn.ra.get_commit_editor2()

* subversion/bindings/swig/include/svn_types.swg
  subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
  subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_commit_callback2): Add Python wrapper for
   svn_commit_callback2_t()



r19616 | rooneg | 2006-05-11 13:08:32 -0500 (Thu, 11 May 2006)

Make svn_ra_get_dir2 work in the python bindings by adding some typemaps.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/svn_ra.i
  (apr_hash_t **DIRENTHASH): Add typemap.

* subversion/bindings/swig/include/apr.swg
  (apr_hash_t **DIRENTHASH): Add typemap.
  (apr_hash_t **PROPHASH): Allow use in tuples.

* subversion/bindings/swig/python/tests/ra.py
  (SubversionRepositoryTestCase.test_get_dir2): Add test for svn.ra.get_dir2()


r19607 | rooneg | 2006-05-10 16:37:54 -0500 (Wed, 10 May 2006)

Make the SWIG bindings throw an exception whenever a svn_ra_callbacks2_t
argument is NULL, and allow the user to pass in a Python object for the
callbacks.

Patch by: Jelmer Vernooij <jelmer@samba.org>
Tweaked by: me

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_setup_ra_callbacks): New helper function.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
  (svn_swig_py_setup_ra_callbacks): New prototype.

* subversion/bindings/swig/python/tests/ra.py
  (SubversionRepositoryTestCase.setUp): Do not pass None for callbacks
   argument to svn.ra.open2()

* subversion/bindings/swig/svn_ra.i: Forbid passing NULL for
  svn_ra_callbacks2_t arguments, add Python typemap for svn_ra_callbacks2_t


r19566 | rooneg | 2006-05-08 17:21:16 -0500 (Mon, 08 May 2006)

Add some tests for the python ra bindings.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/python/tests/run_all.py:
  Import ra module.
  (suite): Add the ra suite.

* subversion/bindings/swig/python/tests/ra.py: New file, holds ra tests.


r19413 | djames | 2006-04-18 14:49:41 -0500 (Tue, 18 Apr 2006)

Update Python bindings to support svn_client_info. Add tests to verify that
svn_client_info works as expected.

Patch by: Jelmer Vernooij <jelmer@samba.org>
          me

* build.conf
  Update libsvn_swig_py to depend on libsvn_client.

[ In subversion/bindings/swig ]

* svn_client.i
  Add Python typemap for svn_info_receiver_t.

* python/libsvn_swig_py/swigutil_py.h, python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_info_receiver_func): New function. Python function wrapper for
  svn_info_receiver_t.

* python/tests/client.py
  Add file. Contains new test case for svn_client library and svn_client_info
  function.

* python/tests/run_all.py
  (suite): Add new client test to list of tests.