Jelmer Vernooij <jelmer@samba.org> (jrvernooij)


Found Patch Review
r871911, r868559, r868430 r876627, r876626, r876625, r876624, r876623, r876622, r876621, r876620, r876619, r876618, r876617, r876616, r876615, r876614, r870643, r870640, r870639, r870638, r868443, r868436, r868425, r868424, r868386, r865902, r865879, r865876, r860591, r860524, r860483, r860365, r860321, r860316, r860304, r860301, r860234, r860232, r860231, r860188, r860184, r860181, r860176, r860169, r860168, r859934, r859792, r859690, r859681, r859640, r859487 r868618

r876627 | jrvernooij | 2009-03-14 10:17:58 -0500 (Sat, 14 Mar 2009)

Add tag 0.33.1

r876626 | jrvernooij | 2009-03-14 10:17:54 -0500 (Sat, 14 Mar 2009)

Add tag 0.33.0

r876625 | jrvernooij | 2009-03-14 10:17:51 -0500 (Sat, 14 Mar 2009)

Add tag 0.31.0

r876624 | jrvernooij | 2009-03-14 10:17:47 -0500 (Sat, 14 Mar 2009)

Add tag 0.27.0

r876623 | jrvernooij | 2009-03-14 10:17:44 -0500 (Sat, 14 Mar 2009)

Add tag 0.18.1

r876622 | jrvernooij | 2009-03-14 10:17:41 -0500 (Sat, 14 Mar 2009)

Add tag 0.20.1

r876621 | jrvernooij | 2009-03-14 10:17:37 -0500 (Sat, 14 Mar 2009)

Add tag 0.17.1

r876620 | jrvernooij | 2009-03-14 10:17:34 -0500 (Sat, 14 Mar 2009)

Add tag 0.19.1

r876619 | jrvernooij | 2009-03-14 10:17:30 -0500 (Sat, 14 Mar 2009)

Add tag 0.35.0

r876618 | jrvernooij | 2009-03-14 10:17:27 -0500 (Sat, 14 Mar 2009)

Add tag 0.22.2

r876617 | jrvernooij | 2009-03-14 10:17:23 -0500 (Sat, 14 Mar 2009)

Add tag 0.37.0

r876616 | jrvernooij | 2009-03-14 10:17:20 -0500 (Sat, 14 Mar 2009)

Add tag 1.0.0

r876615 | jrvernooij | 2009-03-14 10:07:08 -0500 (Sat, 14 Mar 2009)

* subversion/libsvn_ra_neon/util.c(generate_error): Return 
  SVN_ERR_RA_DAV_FORBIDDEN for 403 errors.

Approved by: rhuijben
             dlr


r876614 | jrvernooij | 2009-03-14 10:07:04 -0500 (Sat, 14 Mar 2009)

* subversion/include/svn_error_codes.h: Add error code
  SVN_ERR_RA_DAV_FORBIDDEN.

Approved by: rhuijben
             dlr


r871911 | kfogel | 2008-06-21 22:22:00 -0500 (Sat, 21 Jun 2008)

* subversion/libsvn_subr/path.c
  (svn_path_canonicalize): Take an early out if path is "", to avoid
    accessing uninitialized memory later when we look at *(dst - 1).

Found by: Jelmer Vernooij <jelmer@samba.org>
(Discussed with him in IRC and dev@ posts right before this commit.)


r870643 | jrvernooij | 2008-04-12 21:06:25 -0500 (Sat, 12 Apr 2008)

Fix SubversionExceptions.args to be consistent with 1.4 when an error number 
but no message is specified. 

* subversion/bindings/swig/python/tests/core.py
  (test_SubversionException): Add test for creating exception with only apr_err.
* subversion/bindings/swig/python/svn/core.py
  (SubversionException.__init__): Fix value of self.args when only apr_err is 
	present.

Review by: epg



r870640 | jrvernooij | 2008-04-12 16:59:52 -0500 (Sat, 12 Apr 2008)

Add support for setting auth parameters with svn_auth_ssl_server_cert_info_t
values and add test for svn.auth.get_ssl_server_trust_prompt_provider.

* subversion/bindings/swig/core.i
  (svn_auth_set_parameter): Support svn_auth_ssl_server_cert_info_t values.
* subversion/bindings/swig/python/tests/auth.py
  (test_set_parameter): Add test for svn_auth_ssl_server_cert_info_t values.
  (test_credentials_get_ssl_server_trust): Add test for 
    svn.auth.get_ssl_server_trust_prompt_provider.


r870639 | jrvernooij | 2008-04-12 16:43:00 -0500 (Sat, 12 Apr 2008)

Allow setting apr_uint32_t pointer auth parameter values from Python rather 
than direct longs since that's what all current integer auth parameters use.

* subversion/bindings/swig/core.i
  (svn_auth_set_parameter): Accept Python integers as apr_uint32_t pointers.
* subversion/bindings/swig/python/tests/auth.py
  (test_set_parameter): Add test setting parameter with integer value.



r870638 | jrvernooij | 2008-04-12 16:15:13 -0500 (Sat, 12 Apr 2008)

Allow None as value for auth parameters set from Python.

* subversion/bindings/swig/python/core.i:
  Remove double comment opening.
  (svn_auth_set_parameter): Allow None as value.
* subversion/bindings/swig/python/tests/auth.py
  (test_set_parameter): Check None is accepted as input value.


r868618 | djames | 2007-12-18 19:10:36 -0600 (Tue, 18 Dec 2007)

Fix a major memory leak in the Python object duplication code.

Review by: jrvernooij

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (make_ob_txdelta_window, make_ob_log_changed_path,
   make_ob_wc_status, make_ob_lock, make_ob_auth_ssl_server_cert_info,
   make_ob_info, make_ob_location_segment, make_ob_commit_info,
   make_ob_wc_notify): Fix memory leak.



r868559 | epg | 2007-12-14 11:36:43 -0600 (Fri, 14 Dec 2007)

* subversion/bindings/swig/python/svn/core.py
  (SubversionException._new_from_err_list): Follow-up to r28356: I failed
    to adapt this constructor to __init__'s new argument order.

Found by: jrvernooij


r868443 | jrvernooij | 2007-12-09 22:27:35 -0600 (Sun, 09 Dec 2007)

* subversion/bindings/swig/INSTALL: Remove note about svn.ra Python


r868436 | jrvernooij | 2007-12-09 15:59:39 -0600 (Sun, 09 Dec 2007)

Add tests for the python bindings of svn.core.svn_mime_type_{validate,is_binary}.

* subversion/bindings/swig/python/tests/core.py
  (test_mime_type_validate, test_mime_type_is_binary): New functions.


r868430 | epg | 2007-12-09 14:57:11 -0600 (Sun, 09 Dec 2007)

* subversion/bindings/swig/python/svn/core.py
  (SubversionException): Improve 1.4 compatibility.

* subversion/bindings/swig/python/tests/core.py
  Add core testing module, just testing SubversionException for now.

* subversion/bindings/swig/python/tests/run_all.py
  Run new core tests.

Found by: jrvernooij


r868425 | jrvernooij | 2007-12-09 11:28:55 -0600 (Sun, 09 Dec 2007)

Add tests for the Python bindings of various auth prompt providers.

* subversion/bindings/swig/python/tests/auth.py
  (test_invalid_cred_kind, test_credentials_get_username,
  test_credentials_get_simple, test_credentials_get_ssl_client_cert,
  test_credentials_get_ssl_client_cert_pw): New functions.


r868424 | jrvernooij | 2007-12-09 09:13:12 -0600 (Sun, 09 Dec 2007)

Start testsuite for the Python bindings of svn_auth_*.

* subversion/bindings/swig/python/tests/run_all.py: Run auth tests.
* subversion/bindings/swig/python/tests/auth.py: New file.


r868386 | jrvernooij | 2007-12-06 14:48:50 -0600 (Thu, 06 Dec 2007)

Add tests for Python binding of svn.ra.has_capability().

* subversion/bindings/swig/python/tests/ra.py 
  (test_has_capability): New function.


r865902 | jrvernooij | 2007-07-23 22:29:40 -0500 (Mon, 23 Jul 2007)

Fix Python bindings for svn.ra.lock().

* subversion/bindings/swig/include/svn_containers.swg: Add Python 
  typemap for apr_hash_t *path_revs.

* subversion/bindings/swig/svn_ra.i
  (svn_ra_lock_callback_t): Add Python typemap

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_path_revs_hash_from_dict): Add function for converting 
  from dictionaries to apr_hash_t * mapping paths to revnums.
 
  (svn_swig_py_ra_lock_callback): Add Python wrapper for 
  svn_ra_lock_callback_t

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_path_revs_hash_from_dict): Add prototype.

  (svn_swig_py_ra_lock_callback): Add prototype.

* subversion/bindings/swig/python/tests/ra.py
  (test_lock): Add test for svn.ra.lock()


r865879 | jrvernooij | 2007-07-20 19:13:48 -0500 (Fri, 20 Jul 2007)

Accidental empty commit.


r865876 | jrvernooij | 2007-07-20 08:15:13 -0500 (Fri, 20 Jul 2007)

Fix Python bindings for svn.wc.get_prop_diffs().

* subversion/bindings/swig/include/svn_containers.swg:
  Add Python typemap for apr_array_header_t * of svn_prop_t *.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_proparray_to_dict): Rename from proparray_to_dict and
  make public.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
  (svn_swig_py_proparray_to_dict): Add public prototype.
  
* subversion/bindings/swig/python/tests/wc.py
  (test_get_prop_diffs): Add unit test for svn.wc.get_prop_diffs()


r860591 | jrvernooij | 2006-07-10 15:55:08 -0500 (Mon, 10 Jul 2006)

 * COMMITTERS (jrvernooij): Move myself to partial committer for the Python bindings.


r860524 | jrvernooij | 2006-07-06 09:10:13 -0500 (Thu, 06 Jul 2006)

Allow some callbacks in svn_ra_callbacks2_t() to be implemented in
Python.

These callbacks are only used by svn_ra_dav. The Python bindings testsuite 
does not set up a webdav server yet, but a manual test that proves these 
bindings work is available at http://svn.haxx.se/dev/archive-2006-07/0126.shtml.

Review by: djames

 * subversion/bindings/swig/svn_ra.i: Fix typemap for const svn_ra_callbacks2_t.

 * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
   (svn_swig_py_setup_ra_callbacks): Fill in callback function pointer
	for open_tmp_file and auth_baton.
   (ra_callbacks_open_tmp_file): Add wrapper for Python callback.



r860483 | jrvernooij | 2006-07-03 20:02:40 -0500 (Mon, 03 Jul 2006)

Fix Python bindings to svn.ra.get_commit_editor().

Review by: djames

[ in subversion/bindings/swig ]

* python/tests/ra.py
  (test_commit): Rename to test_commit2.
  (test_commit): Add new function that tests svn.ra.get_commit_editor().

* python/libsvn_swig_py/swigutil_py.[ch]
  (svn_swig_py_commit_callback): Add new function.

* include/svn_types.swg: Add Python typemap for svn_commit_callback.


r860365 | jrvernooij | 2006-06-29 05:37:55 -0500 (Thu, 29 Jun 2006)

Allow the text_checksum argument to svn.delta.editor_invoke_close_file()
to be None (as the API allows).

 * subversion/bindings/swig/svn_delta.i: Apply MAY_BE_NULL to text_checksum.


r860321 | jrvernooij | 2006-06-25 17:47:45 -0500 (Sun, 25 Jun 2006)

Fix Python bindings to svn.wc.get_ignores().

Review by: djames

[ in subversion/bindings/swig ]

* svn_wc.i: Add Python typemap for `patterns'.

* python/tests/wc.py 
 (test_get_ignores): Add test for svn.wc.get_ignores().



r860316 | jrvernooij | 2006-06-24 15:49:19 -0500 (Sat, 24 Jun 2006)

Add test for svn.wc.entries_read().

 * subversion/bindings/swig/python/tests/wc.py
   (test_entries_read): Add test for svn.wc.entries_read().



r860304 | djames | 2006-06-23 13:23:47 -0500 (Fri, 23 Jun 2006)

Fix Python bindings for svn.wc.crawl_revisions2().

Patch by: jrvernooij
          me
Review by: madanus

[ In subversion/bindings/swig ]

 * svn_ra.i: Add Python typemap for svn_ra_reporter2_t.

 * svn_wc.i: Add Python typemap for svn_wc_notify_func2_t.

 * tests/wc.py
   (setUp): Open working copy subdirectories.
   (test_crawl_revisions2): Add test for svn.wc.crawl_revisions2() and
    svn_ra_reporter2_t implementations.

 * python/libsvn_swig_py/swigutil_py.c
   (make_ob_wc_notify): Add function.
   (svn_swig_py_notify_func2): Add Python wrapper for svn_wc_notify_func2_t.
   (reporter_set_path): Add function.
   (reporter_delete_path): Add function.
   (reporter_link_path): Add function.
   (reporter_abort_report): Add function.
   (reporter_finish_report): Add function.
   (swig_py_ra_reporter2): Add Python wrapper for svn_ra_reporter2_t.

 * python/libsvn_swig_py/swigutil_py.h
   (swig_py_ra_reporter2): Add extern.
   (svn_swig_py_notify_func2): Add prototype.



r860301 | rooneg | 2006-06-23 10:04:46 -0500 (Fri, 23 Jun 2006)

Return error code for unversioned files in svn_wc_crawl_revisions2()
rather than crashing.

Patch by: Jelmer Vernooij <jelmer@samba.org>
Tweaked by: me

* subversion/libsvn_wc/adm_crawler.c
  (svn_wc_crawl_revisions2): Return error for unversioned files.


r860234 | jrvernooij | 2006-06-18 12:43:57 -0500 (Sun, 18 Jun 2006)

Add test for Python bindings to svn.ra.get_locations().

 * subversion/bindings/swig/python/tests/ra.py
   (test_get_locations): Add test for svn.ra.get_locations()


r860232 | djames | 2006-06-18 11:32:25 -0500 (Sun, 18 Jun 2006)

Fix Python bindings for svn.ra.get_file_revs().

Patch by: jrvernooij
          me
Review by: me

 * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
   (svn_swig_py_ra_file_rev_handler_func): Add Python wrapper for
   svn_ra_file_rev_handler_t.
   (proparray_to_dict): New function.

 * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
   (svn_swig_py_ra_file_rev_handler_func): New function.

 * subversion/bindings/swig/svn_ra.i: Add typemap for
   svn_ra_file_rev_handler_t.

 * subversion/bindings/swig/python/tests/ra.py
   (test_get_file_revs): Add test for svn.ra.get_file_revs().



r860231 | jrvernooij | 2006-06-17 17:34:55 -0500 (Sat, 17 Jun 2006)

Cleanup wc in the svn.wc python binding test script.

Patch by: madanus
          me

 * subversion/bindings/swig/python/tests/wc.py
   (global): Import shutil.
   (setUp): Generate random name for wc directory instead of fixed location.
   (tearDown): Cleanup wc path after the tests.


r860188 | jrvernooij | 2006-06-15 03:45:07 -0500 (Thu, 15 Jun 2006)


* COMMITTERS: Add myself to the committers list.



r860184 | djames | 2006-06-14 17:53:51 -0500 (Wed, 14 Jun 2006)

Improve test coverage for Python bindings to svn.wc.

Patch by: Jelmer Vernooij <jelmer@samba.org>
          me

 * subversion/bindings/swig/python/tests/wc.py
   (test_get_ancestry): Add test for get_ancestry().
   (test_status): Add basic test for status().
   (test_is_normal_prop): Add test for is_normal_prop().
   (test_is_wc_prop): Add test for is_wc_prop().
   (test_is_entry_prop): Add test for is_entry_prop().
   (test_get_pristine_copy_path): Add test for get_pristine_copy_path().



r860181 | djames | 2006-06-14 17:25:35 -0500 (Wed, 14 Jun 2006)

Improve test coverage of the Python bindings for svn.client.

Patch by: Jelmer Vernooij <jelmer@samba.org>
          me

 * subversion/bindings/swig/python/tests/client.py
   (test_checkout): Add test for checkout2().
   (test_uuid_from_url): Add test for uuid_from_url().
   (test_url_from_path): Add test for url_from_path().
   (test_uuid_from_path): Add test for uuid_from_path().
   (test_open_ra_session): Add test for open_ra_session().



r860176 | rooneg | 2006-06-14 14:20:16 -0500 (Wed, 14 Jun 2006)

More test coverage for the svn.wc Python bindings.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/python/tests/wc.py
  (setUp): Acquire write lock on wc
  (tearDown): Explicitly close wc
  (test_lock): Add tests for add_lock and remove_lock
  (test_version): Add test for version()
  (test_is_adm_dir): Add test for is_adm_dir()
  (test_get_adm_dir): Add test for get_adm_dir()
  (test_set_adm_dir): Add test for set_adm_dir()
  (test_init_traversal_info): Add test for init_traversal_info()
  (test_create_notify): Add test for create_notify()
  (test_check_wc): Add test for test_wc()


r860169 | rooneg | 2006-06-14 12:16:17 -0500 (Wed, 14 Jun 2006)

Don't crash when NULL revisions are passed to the python bindings.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/svn_client.i:
  Disallow passing NULL revision and peg_revision arguments.


r860168 | rooneg | 2006-06-14 10:21:10 -0500 (Wed, 14 Jun 2006)

Add initial testsuite for the Python bindings to svn.wc.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/python/tests/run_all.py
  (suite): Add working copy testsuite.

* subversion/bindings/swig/python/tests/wc.py: Add test suite for svn.wc.


r859934 | djames | 2006-05-30 19:06:27 -0500 (Tue, 30 May 2006)

Add tests for Python bindings to svn_ra_get_commit_editor2() and
svn_ra_do_update().

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/python/tests/ra.py
  (test_commit): Use returned delta editor and close commit.
  (test_update): Add simple testcase for svn.ra.do_update().



r859792 | djames | 2006-05-18 15:30:31 -0500 (Thu, 18 May 2006)

Create typemaps for the input arguments of svn.ra.get_commit_editor2().

TODO: Add typemaps for the return value of this function as well.

Patch by: Jelmer Vernooij <jelmer@samba.org>
          me

* subversion/bindings/swig/svn_ra.i:
  Mark const svn_delta_editor ** as out argument

* subversion/bindings/swig/python/tests/ra.py:
  (test_commit): Add test for svn.ra.get_commit_editor2()

* subversion/bindings/swig/include/svn_types.swg
  subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
  subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_commit_callback2): Add Python wrapper for
   svn_commit_callback2_t()



r859690 | rooneg | 2006-05-11 13:08:32 -0500 (Thu, 11 May 2006)

Make svn_ra_get_dir2 work in the python bindings by adding some typemaps.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/svn_ra.i
  (apr_hash_t **DIRENTHASH): Add typemap.

* subversion/bindings/swig/include/apr.swg
  (apr_hash_t **DIRENTHASH): Add typemap.
  (apr_hash_t **PROPHASH): Allow use in tuples.

* subversion/bindings/swig/python/tests/ra.py
  (SubversionRepositoryTestCase.test_get_dir2): Add test for svn.ra.get_dir2()


r859681 | rooneg | 2006-05-10 16:37:54 -0500 (Wed, 10 May 2006)

Make the SWIG bindings throw an exception whenever a svn_ra_callbacks2_t
argument is NULL, and allow the user to pass in a Python object for the
callbacks.

Patch by: Jelmer Vernooij <jelmer@samba.org>
Tweaked by: me

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_setup_ra_callbacks): New helper function.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
  (svn_swig_py_setup_ra_callbacks): New prototype.

* subversion/bindings/swig/python/tests/ra.py
  (SubversionRepositoryTestCase.setUp): Do not pass None for callbacks
   argument to svn.ra.open2()

* subversion/bindings/swig/svn_ra.i: Forbid passing NULL for
  svn_ra_callbacks2_t arguments, add Python typemap for svn_ra_callbacks2_t


r859640 | rooneg | 2006-05-08 17:21:16 -0500 (Mon, 08 May 2006)

Add some tests for the python ra bindings.

Patch by: Jelmer Vernooij <jelmer@samba.org>

* subversion/bindings/swig/python/tests/run_all.py:
  Import ra module.
  (suite): Add the ra suite.

* subversion/bindings/swig/python/tests/ra.py: New file, holds ra tests.


r859487 | djames | 2006-04-18 14:49:41 -0500 (Tue, 18 Apr 2006)

Update Python bindings to support svn_client_info. Add tests to verify that
svn_client_info works as expected.

Patch by: Jelmer Vernooij <jelmer@samba.org>
          me

* build.conf
  Update libsvn_swig_py to depend on libsvn_client.

[ In subversion/bindings/swig ]

* svn_client.i
  Add Python typemap for svn_info_receiver_t.

* python/libsvn_swig_py/swigutil_py.h, python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_info_receiver_func): New function. Python function wrapper for
  svn_info_receiver_t.

* python/tests/client.py
  Add file. Contains new test case for svn_client library and svn_client_info
  function.

* python/tests/run_all.py
  (suite): Add new client test to list of tests.