Kalle Olavi Niemitalo <kon@iki.fi> (kon)


Patch Review Suggested
r15969, r15589, r15588, r15024 r5684 r17549, r6102, r5813, r5688

r17549 | dlr | 2005-11-29 00:08:02 -0600 (Tue, 29 Nov 2005)

Add the Last-Modified HTTP header to the response as encouraged by
section 13.3.4 of RFC 2616.


* subversion/mod_dav_svn/repos.c
  (RESOURCE_LACKS_ETAG_POTENTIAL): A new macro which returns whether
   the DAV resource lacks potential for generation of an ETag.

  (get_last_modified): A new function used when setting HTTP headers
   in preparation for generating the response which includes the last
   modification time of the requested resource.

  (dav_svn_getetag): Factored complex conditional out into the
   RESOURCE_LACKS_ETAG_POTENTIAL() macro, which is also used by the
   new get_last_modified() function as the heuristic in determining
   whether the Last-Modified header is generated.

  (dav_svn_set_headers): Use httpd's API for setting the modification
   time for request_rec, and its corresponding Last-Modified header.


Suggested by: Sergey Proskurnya <alaley@gmail.com>
              kon
              gstein
              Michael Sinz <Michael.Sinz@sinz.org>


r15969 | xsteve | 2005-08-29 15:29:10 -0500 (Mon, 29 Aug 2005)


Fix bogus comparisons of buffers to strings.

Patch by: Kalle Olavi Niemitalo <kon@iki.fi>

* contrib/client-side/psvn/psvn.el
  (svn-status-show-process-output): Don't compare the current buffer to
    the value of svn-status-buffer-name; it'd never match, because the
    buffer object is not a string.  Compare the name of the buffer instead.
  (svn-status-show-process-buffer-internal): Likewise, except the original
    code compared the buffer to a *constant* string.


r15589 | xsteve | 2005-08-04 14:58:29 -0500 (Thu, 04 Aug 2005)

Adjust docstrings in psvn.el: add info, fix typos.

Patch by: Kalle Olavi Niemitalo <kon@iki.fi>

* contrib/client-side/psvn/psvn.el
  (svn-status-hide-unknown, svn-status-hide-unmodified): More documentation.
  (svn-status-directory-history): No longer a user option.
  (svn-status-negate-meaning-of-arg-commands, svn-status-window-alist,
   svn-status-short-mod-flag-p): Typo fix.
  (svn-status-svn-environment-var-list): Added a TODO comment.


r15588 | xsteve | 2005-08-04 14:17:31 -0500 (Thu, 04 Aug 2005)

Let browse-url-browser-function changes take effect after psvn has been loaded.

Patch by: Kalle Olavi Niemitalo <kon@iki.fi>

* contrib/client-side/psvn/psvn.el
  (svn-browse-url-function): Default to nil, rather than to the
    load-time value of browse-url-browser-function.
  (svn-browse-url): If svn-browse-url-function is nil, use the value
    of browse-url-browser-function instead.

  (svn-browse-url-function): More documentation.


r15024 | xsteve | 2005-06-10 14:38:42 -0500 (Fri, 10 Jun 2005)

Display svn-global-keymap in the describe-bindings output

Patch by: Kalle Olavi Niemitalo <kon@iki.fi>

* trunk/contrib/client-side/psvn/psvn.el:


r6102 | rooneg | 2003-05-30 20:26:59 -0500 (Fri, 30 May 2003)

* INSTALL: clarify our dependency on neon.  it is now only required if you 
  wish to connect to a server over ra_dav.

Suggested by: Kalle Olavi Niemitalo <kon@iki.fi>


r5813 | cmpilato | 2003-05-05 16:12:30 -0500 (Mon, 05 May 2003)

* subversion/libsvn_subr/path.c
  (svn_path_is_uri_safe): Disallow '%%' in tests for URI-safety.

Suggested by: Kalle Olavi Niemitalo <kon@iki.fi>


r5688 | kfogel | 2003-04-21 17:52:47 -0500 (Mon, 21 Apr 2003)

* tools/client-side/vc-svn.el
  (vc-svn-diff): Don't quote the error condition, and pass nil
    instead of `ignored' for the unused error data variable.

Suggested by: Kalle Olavi Niemitalo <kon@iki.fi>


r5684 | kfogel | 2003-04-21 10:52:57 -0500 (Mon, 21 Apr 2003)

More robust fix for issue #1250, replacing revision 5682:

* tools/client-side/vc-svn.el
  (vc-svn-diff): Don't bother to check the Emacs version, just handle
    the exception if it arises.

Review by: Kalle Olavi Niemitalo <kon@iki.fi>
(He tested and discovered some intermediate versions of Emacs where
the previous code would still fail.)