Matt Kraai <kraai@alumni.cmu.edu> (kraai)


Patch
r5514, r5164, r5011, r4337, r3827, r3661, r3602, r3588, r3526, r3466, r3372, r691, r412, r406, r315, r306, r303

r5514 | cmpilato | 2003-04-01 14:50:36 -0600 (Tue, 01 Apr 2003)

* subversion/bindings/swig/svn_types.i
  Add a typemap for svn_filesize_t.  

Patch by: Matt Kraai <kraai@alumni.cmu.edu>
(Above change only.)

* subversion/bindings/swig/svn_wc.i
  Treat the int * used by svn_wc_check_wc() correctly.


r5164 | philip | 2003-03-01 12:47:09 -0600 (Sat, 01 Mar 2003)

Fix SWIG VPATH build.

Patch by: Matt Kraai <kraai@alumni.cmu.edu>
(Tweaked by me.)

* build/gen_make.py (SWIGObject): Set source_generated attribute.

* build/gen_make.py (Generator.write): Add top_srcdir to RUN_SWIG command,
  adjust build_cmd based on source_generated attribute.


r5011 | philip | 2003-02-21 17:24:33 -0600 (Fri, 21 Feb 2003)

* configure.in: Arrange for SVN_CLIENT_EDITOR to be undefined if
  --with-editor is not used.

Patch by: Matt Kraai <kraai@alumni.cmu.edu>


r4337 | gstein | 2003-01-10 20:56:57 -0600 (Fri, 10 Jan 2003)

Optionally deliver the output via SMTP to a host.

Patch by: Matt Kraai <kraai@alumni.cmu.edu>
          me
(This patch was based on Matt Kraai's original.)

* hook-scripts/mailer.py:
  (main): call new determine_output() function to figure out what kind
    of output to deliver the message to. then send it there.
  (determine_output): new function to say where to send the message
  (class SMTPOutput): output generator for delivery to an SMTP host
  (class StandardOutput): output generator for sys.stdout
  (generate_content): take a changes dict rather than an editor
  (generate_list): rename 'changes' param to 'changelist'

* hook-scripts/mailer.conf.example: add example config for an SMTP
    hostname and from/to addresses


r3827 | blair | 2002-11-18 19:16:25 -0600 (Mon, 18 Nov 2002)

* configure.in:
  Fix issue #998.  Add missing "$" to MAKEINFO test.

Patch by: Matt Kraai <kraai@ftbfs.org>


r3661 | sussman | 2002-11-05 13:37:19 -0600 (Tue, 05 Nov 2002)

A change on the road to issue #911.  On my system, this seems to work
correctly.  Namely, apr and apr-util are now located in this order:

     1. the value of --with-apr[-util] is passed to ./configure
     2. looking for apr[-util] in the subversion source tree
     3. looking for previously installed versions in the system

Patch by: Matt Kraai <kraai@alumni.cmu.edu>

* ac-helpers/apr.m4:  check for installed APR.

* ac-helpers/aprutil.m4:  check for installed APRUTIL.

* ac-helpers/find_apr.m4:  prefer in-tree to installed APR.

* ac-helpers/find_apu.m4:  prefer in-tree  to installed APRUTIL.


r3602 | cmpilato | 2002-10-31 18:07:40 -0600 (Thu, 31 Oct 2002)

* subversion/bindings/swig/swigutil_py.c
  (svn_swig_py_notify_func): Invert a backwards test.

Patch by: Matt Kraai <kraai@alumni.cmu.edu>


r3588 | fitz | 2002-10-30 19:34:40 -0600 (Wed, 30 Oct 2002)

The following patch cleans up some texinfo artifacts.

Patch by: Matt Kraai <kraai@alumni.cmu.edu>

* doc/book/book/ch03.xml: Clean up texinfo artifacts.

* doc/book/book/ch04.xml: Clean up texinfo artifacts.

* doc/book/book/ch05.xml: Clean up texinfo artifacts.


r3526 | kfogel | 2002-10-28 01:01:48 -0600 (Mon, 28 Oct 2002)

Patch by: Matt Kraai <kraai@alumni.cmu.edu>

For issue #949:

* ac-helpers/swig.m4
  Unquote AC_HELP_STRING.
  
* ac-helpers/berkeley-db.m4
  Remove extra backslashes and reformat help string.

* ac-helpers/svn-apache.m4
  Use AC_HELP_STRING.

* ac-helpers/neon.m4
  Unquote AC_HELP_STRING.

* configure.in
  Use AC_HELP_STRING.

* subversion/mod_dav_svn/static/config.m4
  Use AC_HELP_STRING.


r3466 | brane | 2002-10-23 16:13:17 -0500 (Wed, 23 Oct 2002)

* INSTALL: Correct misspelling of `bootstrapping'.

Patch by: Matt Kraai <kraai@alumni.cmu.edu>


r3372 | kfogel | 2002-10-15 21:04:35 -0500 (Tue, 15 Oct 2002)

* www/project_status.html: Link to the open issues for each milestone.

Patch by: Matt Kraai <kraai@alumni.cmu.edu>


r691 | kfogel | 2001-12-20 10:53:33 -0600 (Thu, 20 Dec 2001)

* INSTALL: Fix misspelling and add missing article.

Patch by: Matt Kraai <kraai@alumni.carnegiemellon.edu>


r412 | cmpilato | 2001-11-06 15:45:43 -0600 (Tue, 06 Nov 2001)

The following patch changes the svn_fs_change_{node,rev,txn}_prop
family of functions to use a const char * as the property name.

Patch by: Matt Kraai <kraai@alumni.carnegiemellon.edu>

* subversion/svnadmin/main.c

  (main): Update call to svn_fs_change_rev_prop.

* subversion/include/svn_fs.h

  (svn_fs_change_node_prop): Change name to const char *.
  (svn_fs_change_rev_prop): Change name to const char *.
  (svn_fs_change_txn_prop): Change name to const char *.

* subversion/libsvn_fs/proplist.c

  (set_fs__set_prop): Change name to const char *.

* subversion/libsvn_fs/proplist.h

  (set_fs__set_prop): Change name to const char *.

* subversion/libsvn_fs/dag.c

  (txn_body_dag_init_fs, svn_fs__dag_commit_txn): Update calls to
  svn_fs__set_rev_prop.

* subversion/libsvn_fs/txn-table.c

  (svn_fs_change_txn_prop): Change name to const char *.

* subversion/libsvn_fs/tree.c

  (svn_fs_change_node_prop): Change name to const char *.

* subversion/libsvn_fs/txn.c

  (svn_fs_begin_txn): Update call to svn_fs_change_txn_prop.

* subversion/libsvn_fs/rev-table.c

  (svn_fs__set_rev_prop, svn_fs_change_rev_prop): Change name to
  const char *.

* subversion/libsvn_fs/rev-table.h

  (svn_fs__set_rev_prop): Change name to const char *.

* subversion/libsvn_ra_local/commit_editor.c

  (change_file_prop, change_dir_prop): Update calls to
  svn_fs_change_node_prop.

* subversion/mod_dav_svn/deadprops.c

  (save_value, dav_svn_db_remove): Update calls to svn_fs_change_txn_prop 
  and svn_fs_change_node_prop.

* subversion/tests/libsvn_fs/fs-test.c

  (call_functions_with_unopened_fs): Update call to svn_fs_change_rev_prop.
  (revision_props): Update calls to svn_fs_change_rev_prop.
  (transaction_props): Update calls to svn_fs_change_txn_prop.
  (node_props): Update calls to svn_fs_change_node_prop.

* subversion/tests/libsvn_repos/dir-delta-editor.c

  (test_change_file_prop, test_change_dir_prop): Update calls to
  svn_fs_change_node_prop.

* subversion/libsvn_repos/hooks.c

  (svn_repos_fs_begin_txn_for_commit): Update calls to svn_fs_change_txn_prop.
  (svn_repos_fs_begin_txn_for_update): Update call to svn_fs_change_txn_prop.


r406 | cmpilato | 2001-11-06 13:09:40 -0600 (Tue, 06 Nov 2001)

This is the second in the series of patches from by Matt Kraai
<kraai@alumni.carnegiemellon.edu> to fix issue #406.  It converts the
argument types of svn_fs_{node,txn,revision}_prop.  I made some minor
changes/additions to this patch in order to accommodate the moving
target known as our source codebase :-)

Patch by: Matt Kraai <kraai@alumni.carnegiemellon.edu>
(Tweaked by me.)

* subversion/svnadmin/main.c

  (main): Use svn_string_t instead of svn_stringbuf_t for properties.

* subversion/include/svn_fs.h

  (svn_fs_txn_prop, svn_fs_node_prop, svn_fs_revision_prop):
  Convert "propname" to const char * and "value_p" to svn_string_t **.

* subversion/include/svn_time.h

  (svn_time_to_nts): Renamed from svn_time_to_string(), and returns
  const char * now instead of svn_stringbuf_t *.  Callers changed.  
  (svn_time_from_nts): New.
  (svn_time_from_string): Removed.

* subversion/include/svn_xml.h

  (svn_xml_escape_string, svn_xml_unescape_string): New.

* subversion/libsvn_fs/proplist.c

  (svn_fs__get_prop): Convert "name" to const char * and "value_p" to
  svn_string_t **.

* subversion/libsvn_fs/proplist.h

  (svn_fs__get_prop): Convert "name" to const char * and "value_p" to
  svn_string_t **.

* subversion/libsvn_fs/txn-table.c

  (struct txn_prop_args, svn_fs_txn_prop): Convert "propname" to
  const char * and "value_p" to svn_string_t **, and update call to
  svn_fs__get_prop().

* subversion/libsvn_fs/tree.c

  (struct node_prop_args, svn_fs_node_prop): Convert "propname" to
  const char * and "value_p" to svn_string_t **, and update call to
  svn_fs__get_prop().

* subversion/libsvn_fs/rev-table.c

  (struct revision_prop_args, svn_fs_revision_prop): Convert propname to
  const char * and value_p to svn_string_t ** and update call to
  svn_fs__get_prop().

* subversion/libsvn_subr/time.c

  (svn_time_to_nts): Renamed from svn_time_to_string(), and now
  returns const char * instead of svn_stringbuf_t *.
  (svn_time_from_nts): Was svn_time_from_string(), now accepts const
  char *, and is public.  Callers changed.

* subversion/libsvn_wc/entries.c

  (svn_wc__atts_to_entry): Use svn_time_from_nts().
  (normalize_entry): Update call to svn_time_to_nts().

* subversion/libsvn_wc/questions.c

  (timestamps_equal_p): Update calls to svn_time_to_nts() and 
  svn_time_from_nts().

* subversion/libsvn_subr/xml.c

  (svn_xml_escape_data_and_len): New.
  (svn_xml_escape_string): Accept svn_string_t and call
  svn_xml_escape_data_and_len().
  (svn_xml_escape_stringbuf, svn_xml_unescape_string): New.
  (svn_xml_make_open_tag_hash): Call svn_xml_escape_stringbuf().

* subversion/svnlook/main.c

  (get_property): Change "prop_value" to an svn_string_t * and "prop_name" to 
  a const char *.
  (do_log): Update call to get_property().
  (do_date): Update call to get_property().
  (do_author): Update call to get_property().

* subversion/mod_dav_svn/deadprops.c

  (get_repos_propname): Change "repos_propname" to a char **.
  (get_value): Change "pvalue" to a svn_string_t **, and update calls
  to get_repos_propname(), svn_fs_txn_prop(), svn_fs_revision_prop(), and
  svn_fs_node_prop().
  (save_value): Update call to get_repos_propname().
  (dav_svn_db_output_value): Update call to get_value().
  (dav_svn_db_remove): Update call to get_repos_propname().
  (dav_svn_db_exists): Update calls to get_repos_propname(),
  svn_fs_txn_prop(), svn_fs_revision_prop(), and svn_fs_node_prop().
  (dav_svn_db_get_rollback): Update call to get_value().

* subversion/tests/libsvn_fs/fs-test.c

  (call_functions_with_unopened_fs): Update call to svn_fs_revision_prop().
  (revision_props): Update call to svn_fs_revision_prop().
  (transaction_props): Update call to svn_fs_txn_prop().
  (node_props): Update call to svn_fs_node_prop().
  (commit_date): Update call to svn_fs_revision_prop().

* subversion/libsvn_repos/rev_hunt.c

  (get_time): Update call to svn_fs_revision_prop().

* subversion/libsvn_repos/log.c

  (svn_repos_get_logs): Update call to svn_fs_revision_prop().

* subversion/libsvn_fs/txn.c

  (svn_fs_begin_txn): Update call to svn_time_to_nts().

* subversion/libsvn_fs/dag.c

  (txn_body_dag_init_fs, svn_fs__dag_commit_txn): Update call to
  svn_time_to_nts().


r315 | cmpilato | 2001-10-25 18:39:52 -0500 (Thu, 25 Oct 2001)

Work on issue #406.

Patch by: Matt Kraai <kraai@alumni.carnegiemellon.edu>
(Not all his patches were applied in this revision, see also r406.
Yes, coincidentally that is the same as the issue number.)

* subversion/include/svn_string.h

  (svn_string_compare_stringbuf): New.

* subversion/include/svn_fs.h

  (svn_fs_node_proplist, svn_fs_txn_proplist, svn_fs_revision_proplist):
  Note that the hash table contains pointers to svn_string_t objects.

* subversion/libsvn_fs/this-branch.txt

  (svn_fs_node_proplist): Note that the hash table contains pointers to
  svn_string_t objects.

* subversion/libsvn_fs/proplist.c

  (svn_fs__make_prop_hash): Insert svn_string_t * into the hash table.

* subversion/libsvn_fs_proplist.h

  (svn_fs__make_prop_hash): Note that the hash table contains pointers
  to svn_string_t objects.

* subversion/libsvn_subr/svn_string.c

  (svn_string_compare_stringbuf): New.

* subversion/libsvn_ra_local/checkout.c

  (set_any_props): Construct svn_stringbuf_t.

* subversion/tests/libsvn_fs/fs-test.c

  (revision_props, transaction_props, node_props): Use svn_string_t.

* subversion/libsvn_repos/delta.c

  (delta_proplists): Construct svn_stringbuf_t, use
  svn_string_compare_stringbuf, and remove unused svn_stringbuf_t.


r306 | joe | 2001-10-25 11:32:19 -0500 (Thu, 25 Oct 2001)

* configure.in: Fix passing through CFLAGS from neon.

Patch by: Matt Kraai <kraai@alumni.carnegiemellon.edu>
          Sander Striker <striker@apache.org>


r303 | cmpilato | 2001-10-24 20:26:32 -0500 (Wed, 24 Oct 2001)

Get us up to speed on the latest APR apr_proc_wait() interface
modifications.

Patch by: Matt Kraai <kraai@alumni.carnegiemellon.edu>

* subversion/include/svn_io.h

  Include apr_thread_proc.h.

  (svn_io_run_cmd): Remove status parameter and add exitcode and
  exitwhy parameters.

* subversion/libsvn_wc/log.c

  (log_do_run_cmd): Update call to svn_io_run_cmd.

* subversion/libsvn_wc/get_editor.c

  (close_file): Update call to apr_proc_wait.

* subversion/libsvn_subr/io.c

  (svn_io_run_cmd): Remove status parameter and add exitcode and
  exitwhy parameters.  Update call to apr_proc_wait.

* subversion/svnlook/main.c

  (print_diff_tree): Update call to svn_io_run_cmd.

* subversion/clients/cmdline/diff.c

  (svn_cl__print_file_diff): Update call to svn_io_run_cmd.

* subversion/libsvn_repos/hooks.c

  (run_cmd_with_output): Remove status parameter and add exitcode
  and exitwhy parameters.  Update call to svn_io_run_cmd.

  (run_start_commit_hook): Update call to run_cmd_with_output.

  (run_pre_commit_hook): Update call to run_cmd_with_output.
  Check exitwhy to ensure process exited normally.

  (run_post_commit_hook): Update call to run_cmd_with_output.