Marcus Comstedt <marcus@mc.pp.se>


Patch Suggested
r845241, r845236, r844181, r844180, r843066, r842944, r842702, r842697, r842515, r841105, r841083 r840709

r845241 | gstein | 2003-03-01 15:31:30 -0600 (Sat, 01 Mar 2003)

Patch by: Marcus Comstedt <marcus@mc.pp.se>

* build/ac-macros/neon.m4: propagate Neon-specific includes into
    Subversion. this solves the case where OpenSSL has been installed
    into a non-standard location and requires special -I directives to
    reach them. libsvn_ra_dav includes Neon headers which includes
    the OpenSSL headers, so SVN needs the -I directives, too.


r845236 | gstein | 2003-03-01 08:46:11 -0600 (Sat, 01 Mar 2003)

Patch by: Marcus Comstedt <marcus@mc.pp.se>

* libsvn_ra_dav/session.c (get_server_settings): don't try passing a
    NULL cfg to svn_config_find_group.


r844181 | kfogel | 2002-12-12 14:14:21 -0600 (Thu, 12 Dec 2002)

* subversion/libsvn_repos/repos.c
  (create_locks, create_hooks, svn_repos_create): Use
  svn_io_dir_make() instead of apr_dir_make(), so that the paths are
  properly translated from UTF-8.

Patch by: Marcus Comstedt <marcus@mc.pp.se>


r844180 | kfogel | 2002-12-12 14:10:45 -0600 (Thu, 12 Dec 2002)

* subversion/libsvn_subr/io.c 
  (svn_io_copy_file): Corrected some improper use of native vs UTF-8
  pathnames.

Patch by: Marcus Comstedt <marcus@mc.pp.se>


r843066 | cmpilato | 2002-08-20 09:11:38 -0500 (Tue, 20 Aug 2002)

Added a missing UTF-8 conversion in the command line client.

Patch by: Marcus Comstedt <marcus@mc.pp.se>

* subversion/clients/cmdline/info-cmd.c
  (svn_cl__info): convert "target" to native character encoding
    before printing it.


r842944 | philip | 2002-08-03 10:11:55 -0500 (Sat, 03 Aug 2002)

Fix issue 809.

Patch by: Marcus Comstedt <marcus@mc.pp.se>

* subversion/clients/cmdline/util.c
  (svn_cl__edit_externally): Avoid the need to put base_dir into the
  tmpfile filename by doing a cd there first.  Fixes issue #809.
  Fixed problem in cleanup code with using tmpfile_native, which may
  not have been initialized yet.
  Fixed one spelling error.


r842702 | kfogel | 2002-07-22 16:36:09 -0500 (Mon, 22 Jul 2002)

Patch by: Marcus Comstedt <marcus@mc.pp.se>

  > From: Marcus Comstedt <marcus@mc.pp.se>
  > Subject: [PATCH] mod_dav_svn directory listing i18n fix, and odd bug
  > To: dev@subversion.tigris.org
  > Date: 22 Jul 2002 19:36:26 +0200
  > 
  > Ok, my DAV i18n testing has begun, and so far mostly so good.  The
  > directory listing generated when browsing the repository with a web
  > browser fails to set a charset, though.  Since the default charset for
  > HTML is ISO-8859-1, filenames do not get displayed correctly.  This
  > patch fixes the problem: [...]

* subversion/mod_dav_svn/repos.c
  (dav_svn_set_headers): Set charset to UTF-8 in HTML case.


r842697 | cmpilato | 2002-07-22 10:45:08 -0500 (Mon, 22 Jul 2002)

Fix some URI-encoding/decoding buglets.

Patch by: Marcus Comstedt <marcus@mc.pp.se>

* subversion/libsvn_subr/path.c
  (char_is_uri_safe): Make 'c' an int instead of a char.
  (svn_path_uri_encode, svn_path_uri_decode): Fix use of char_is_uri_safe.


r842515 | cmpilato | 2002-07-08 22:04:23 -0500 (Mon, 08 Jul 2002)

More work on Issue #494.  

Patch by: Marcus Comstedt <marcus@mc.pp.se>
(Tweaked by me to get the patch to apply cleanly to the current codebase.)

--

Adapt the cmdline client, svnadmin and svnlook to the notion that
textual information exchanged with the svn libraries should be UTF-8
encoded.  

* subversion/clients/cmdline/props.c
  (svn_cl__print_prop_hash, svn_cl__print_prop_names): Convert
    properties from UTF-8 to native character encoding before printing
    them to stdout.

* subversion/clients/cmdline/cl.h
  (svn_cl__opt_state_t): Added comments to mark which text strings
    will always contain UTF-8 encoded characters, even in the client layer.
  (svn_cl__args_to_target_array): Added comment about result being
    UTF-8 encoded.
  (svn_cl__print_prop_hash, svn_cl__print_prop_names): Changed
    prototype to return svn_error_t *.

* subversion/clients/cmdline/propdel-cmd.c
  (svn_cl__propdel): Convert property name and pathname from UTF-8 to
    native character encoding before printing them to stdout.

* subversion/clients/cmdline/util.c
  (array_push_str_utf8): New function used by svn_cl__parse_num_args
    and svn_cl__parse_all_args.
  (svn_cl__parse_num_args, svn_cl__parse_all_args): Convert args to
    UTF-8 as they are parsed, using array_push_str_utf8.
  (parse_path): Mark the "path" argument as being UTF-8 encoded.
    Convert the revision suffix before passing it to
    svn_cl__parse_revision, which works on the native character encoding.
  (svn_cl__args_to_target_array): Convert target names to UTF-8.
  (svn_cl__edit_externally): Convert UTF-8 text to native character
    encoding before passing it to the editor, then convert the result
    back.  Also, convert the UTF-8 pathname generated by
    svn_io_open_unique_file before using it.
  (log_msg_baton, svn_cl__make_log_msg_baton): Mark "base_dir" as
    being UTF-8 encoded.
  (svn_cl__get_log_message): Convert log message to UTF-8 before
    returning it.

* subversion/clients/cmdline/prompt.c
  (svn_cl__prompt_user): Convert prompt from UTF-8 before printing
    it.  Convert user input to UTF-8 before returning it.

* subversion/clients/cmdline/propget-cmd.c
  (svn_cl__propget): Convert properties from UTF-8 to native character
    encoding before printing them to stdout.

* subversion/clients/cmdline/log-cmd.c
  (log_message_receiver): Convert log message text and changed
    pathnames from UTF-8 to native character encoding before printing them
    to stdout.

* subversion/clients/cmdline/status.c
  (svn_cl__print_status_list): Convert the paths in the statusarray
    from UTF-8 to native character encoding.

* subversion/clients/cmdline/help-cmd.c
  (print_version_info): Convert RA modules description text from UTF-8
    to native character encoding before printing it.
  (svn_cl__help): Convert back arguments that have previously been
    UTF-8 converted by svn_cl__args_to_target_array.

* subversion/clients/cmdline/propset-cmd.c
  (svn_cl__propset): Convert property value to UTF-8 if taken from a
    file (command line arguments are already converted); convert property
    name and pathname to native character encoding for status printout.

* subversion/clients/cmdline/proplist-cmd.c
  (svn_cl__proplist): Convert properties from UTF-8 to native
    character encoding before printing them to stdout.

* subversion/clients/cmdline/main.c
  (main): Enable LC_CTYPE locale settings.  Convert command line
    arguments to UTF-8 before using them with svn_error_createf.  Convert
    --xml-file, -d, --username, --password, and -x parameters to UTF-8
    before storing them in opt_state.  Convert argment of -F to UTF-8
    before using it with svn_string_from_file and svn_wc_entry.  Convert
    both pathname and contents of --targets to UTF-8.

* subversion/clients/cmdline/feedback.c
  (notify): Convert pathname from UTF-8 to native character encoding
    before printing it.

* subversion/clients/cmdline/propedit-cmd.c
  (svn_cl__propedit): Convert property name and pathname from UTF-8 to
    native character encoding before printing them to stdout.

* subversion/clients/cmdline/info-cmd.c
  (svn_cl__info): Convert all textual information about the target
    from UTF-8 to native character encoding before printing it.

* subversion/svnadmin/svnadmin.h
  (shctx_t): Added a comment about the cwd parameter always being
    UTF-8 encoded.

* subversion/svnadmin/main.c
  (print_tree): Convert entry names from UTF-8 to native character set
    before printing them.
  (main): Enable LC_CTYPE locale settings.  Convert repository path,
    lscr path, setlog path, deltify path, and any txn names to UTF-8.
    Convert txn and revision descriptions to native character encoding
    before printing them.

* subversion/svnadmin/shell.c
  (path_stat, compute_new_path, print_dirent): Added comments about
    pathname arguments being UTF-8 encoded.
  (print_dirent): Convert entry names from UTF-8 to native character
    encoding before printing them.
  (cd, ls): Convert user supplied pathname to UTF-8.
  (display_prompt): Convert name of cwd from UTF-8 to native character
    encoding before printing it.
  (svnadmin_run_shell): Handle possible errors from display_prompt.

* subversion/svnlook/main.c
  (svnlook_ctxt_t): Added comment about the txn_name parameter always
    being UTF-8 encoded.
  (get_property, print_dirs_changed_tree, print_changed_tree,
    open_writable_binary_file, dump_contents, print_diff_tree,
    print_ids_tree): Added comments about some arguments being UTF-8
    encoded. 
  (print_dirs_changed_tree, print_changed_tree, print_ids_tree,
    print_tree): Changed prototype to return svn_error_t *.  Convert
    pathnames to native character encoding before printing them.
  (print_diff_tree): Convert pathnames from UTF-8 before printing
    them.  Use wrappers for deleting temporary files, since they have
    UTF-8 encoded pathnames.
  (open_writable_binary_file): Use wrappers to open file since
    pathname is UTF-8 encoded.
  (do_log): Convert log message text from UTF-8 to native character
    encoding before printing it.
  (do_author): Convert author name from UTF-8 to native character
    encoding before printing it.
  (do_dirs_changed, do_changed, do_tree): Handle possible errors from
    functions which have changed their prototype.
  (main): Enable LC_CTYPE locale settings.  Convert repository path
    and txn name to UTF-8.


r841105 | cmpilato | 2002-01-23 14:28:40 -0600 (Wed, 23 Jan 2002)

Bash-ism fix.

Patch by: Marcus Comstedt <marcus@mc.pp.se>

* ac-helpers/neon.m4: Use proper escaping for nested quotes.


r841083 | philip | 2002-01-21 16:58:31 -0600 (Mon, 21 Jan 2002)

Patch by: Marcus Comstedt <marcus@mc.pp.se>

* subversion/tests/clients/cmdline/xmltests/svn-test.sh:
  change $(cmd) to `cmd` for Solaris /bin/sh

* subversion/tests/clients/cmdline/xmltests/svn-test2.sh:
  change $(cmd) to `cmd` for Solaris /bin/sh


r840709 | kfogel | 2001-12-12 01:02:49 -0600 (Wed, 12 Dec 2001)

(SVN_FIND_APR): Put quotes around argument to `test'.

Suggested by: Marcus Comstedt <marcus@mc.pp.se>