Martin Furter <mf@rola.ch> (mf)


Patch Review
r24240, r24212, r23200, r23193, r23191, r21106, r7310, r7059, r6023 r19568

r24240 | lgo | 2007-03-28 15:38:28 -0500 (Wed, 28 Mar 2007)

Add tests for failing start-commit and pre-commit hooks.

Patch by: mf

* subversion/tests/cmdline/commit_tests.py
  (start_commit_hook_test, pre_commit_hook_test): New tests.
  (test_list): Run the new tests.


r24212 | lgo | 2007-03-27 17:47:36 -0500 (Tue, 27 Mar 2007)

Fix the hook_test: from each tested hook write some data to a log file, then 
compare that log file with the expected data.

Patch by: mf
(Tweaked by me.)

* subversion/tests/cmdline/commit_tests.py
  (hook_test): Let the hooks write to a logfile and check its content.
  (test_files): test is passing now, remove XFail

* subversion/tests/cmdline/svntest/main.py
  (create_python_hook_script): pass the parameters from the windows hook.bat 
   file through to the python hook script

r23200 | dlr | 2007-01-23 19:21:01 -0600 (Tue, 23 Jan 2007)

A follow-up to r23191, fixing incorrect tweaks to Martin Furter's
patch which I somehow managed to commit.

* subversion/tests/cmdline/export_tests.py
  (export_nonexistent_url): Correct local variable nonexistent_url.

Patch by: mf


r23193 | dlr | 2007-01-23 16:21:07 -0600 (Tue, 23 Jan 2007)

Fix attempts to export a nonexistent URL to return an error.

* subversion/libsvn_client/export.c
  (svn_client_export3): Handle nonexistent URLs by returning an error.

* subversion/tests/cmdline/export_tests.py
  (test_list): Unmark export_nonexistent_url() as XFAIL.

Patch by: mf
(Tweaked by me.)


r23191 | dlr | 2007-01-23 15:43:07 -0600 (Tue, 23 Jan 2007)

Add test for attempts to export a nonexistent URL.

* subversion/tests/cmdline/export_tests.py
  (export_nonexistent_url): Add test which verifies that attempts to
   export a nonexistent URL produce an error.
  (test_list): Add export_nonexistent_url() to the list.

Patch by: mf
(Tweaked by me.)


r21106 | cmpilato | 2006-08-17 02:15:25 -0500 (Thu, 17 Aug 2006)

Finish issue #2592 (prevent unnecessary user effort for propedits
that won't "take" due to an invalid property name).

Make svn_prop_name_is_valid() public, and teach the command-line
client's 'propedit' subcommand to use it for property name validation
before firing up $EDITOR.

Patch by: Martin Furtur <mf@rola.ch>
(Tweaked by me.)

* subversion/include/svn_props.h
  (svn_prop_name_is_valid): New.

* subversion/libsvn_client/prop_commands.c
  (is_valid_prop_name): Move this function to properties.c, renaming
    it to svn_prop_name_is_valid().
  (svn_client_propset2, svn_client_revprop_set): Use svn_prop_name_is_valid()
    instead of is_valid_prop_name().

* subversion/libsvn_subr/properties.c
  (svn_prop_name_is_valid): Was prop_commands.c:is_valid_prop_name().

* subversion/svn/propedit-cmd.c
  (svn_cl__propedit): Check property name validity before firing up $EDITOR.


r19568 | nori | 2006-05-08 20:28:13 -0500 (Mon, 08 May 2006)

Supply missing entries for psvn.el, vc-svn.el, and mod_dontdothat.c for
www/tools_contrib.html.

Reviewed by: mf
             rooneg
Approved by: rooneg

* www/tools_contrib.html
  (Index by keyword): Add two categories, 'apache' for mod_dontdothat.c
  and 'emacs' for psvn.el and vc-svn.el.
  (psvn_el): A new entry for psvn.el.
  (vc_svn_el): A new entry for vc-svn.el.
  (mod_dontdothat_c): A new entry for mod_dontdothat.c.


r7310 | cmpilato | 2003-10-05 16:29:23 -0500 (Sun, 05 Oct 2003)

Solve the python 2.1 incompatibility introduced in rev 7295.

Patch by: Martin Furter <mf@rola.ch>

* build/generator/gen_base.py
  (Generator.find_sections): Use 'x.has_key(y)' instead of 'y in x'.


r7059 | mbk | 2003-09-14 17:08:27 -0500 (Sun, 14 Sep 2003)

Update example C client application to match various recent API changes.
Minor refactoring of line reading code.

Patch by: Martin Furter <mf@rola.ch>
          me

* tools/examples/minimal_client.c
  (my_prompt_callback): removed
  (prompt_and_read_line): new function.
  (my_simple_prompt_callback): new function.
  (my_username_prompt_callback): new function.
  (main): pass new callbacks where appropriate, and use the updated
   svn_config API.


r6023 | kfogel | 2003-05-23 11:05:21 -0500 (Fri, 23 May 2003)

* tools/cvs2svn/cvs2svn.1: Bring up to date.

Patch by: Martin Furter <mf@rola.ch>