Martin Furter <mf@apache.org> (mf)


Patch Review
r1417757, r1050062, r1050061, r1049944, r915036, r910216, r909157, r909145, r908556, r878200, r874642, r871561, r864579, r864314, r864286, r863635, r863274, r863267, r863265, r862852, r861180, r859917, r859915, r859556, r859028, r859026, r858451, r858450, r858449, r847384, r847133, r846097 r877262, r859642

r1417757 | mf | 2012-12-06 01:54:23 -0600 (Thu, 06 Dec 2012)

* COMMITTERS: Update my email address.

r1050062 | cmpilato | 2010-12-16 11:20:29 -0600 (Thu, 16 Dec 2010)

Use svn_io_start_cmd2 in run_hook_cmd.

* subversion/libsvn_repos/hooks.c
  (run_hook_cmd): Use svn_io_start_cmd2. 

Patch by:  Martin Furter <mf@rola.ch>


r1050061 | cmpilato | 2010-12-16 11:18:43 -0600 (Thu, 16 Dec 2010)

Rev the svn_io_start_cmd() API, adding pipe support.

* subversion/libsvn_subr/io.c
  (svn_io_start_cmd2): New revision of svn_io_start_cmd(), adding
    booleans to indicate where pipes should be used instead of file
    handles.
  (svn_io_start_cmd): Moved to deprecated.c.

* subversion/libsvn_subr/deprecated.c
  (svn_io_start_cmd): Moved here from io.c, and reduced to a mere
    wrapper around svn_io_start_cmd2().

* subversion/include/svn_io.h
  (svn_io_start_cmd2): New revision of svn_io_start_cmd2().
  (svn_io_start_cmd): Deprecate this function.

Patch by:  Martin Furter <mf@rola.ch>
           (Tweaked by cmpilato.)


r1049944 | mf | 2010-12-16 06:26:13 -0600 (Thu, 16 Dec 2010)

Generate build/transform_libtool_scripts.sh from gen-make.py using
information read from build.conf.

* build/generator/gen_make.py
  (write_transform_libtool_scripts,_get_all_lib_deps):
    New functions which generate transform_libtool_scripts.sh.
  (write): Call write_transform_libtool_scripts.
* build/transform_libtool_scripts.sh
  Delete.

Approved-by: philip


r915036 | mf | 2010-02-22 13:47:55 -0600 (Mon, 22 Feb 2010)

Fix many of the links pointing to subversion.tigris.org or svn.collab.net.

Approved by: cmpilato

* BUGS,
* CHANGES,
* COMMITTERS,
* INSTALL,
* build/win32/make_gem.rb,
* configure.ac,
* contrib/client-side/emacs/psvn.el,
* notes/commit-access-templates/full-committer.tmpl,
* notes/commit-access-templates/partial-committer.tmpl,
* notes/fsfs,
* notes/l10n-problems,
* notes/merge-tracking/requirements.html,
* packages/python-windows/setup.py,
* packages/solaris/pkginfo.in,
* subversion/bindings/ctypes-python/setup.py,
* subversion/bindings/javahl/src/org/tigris/subversion/javahl/package.html,
* subversion/bindings/swig/python/__init__.py,
* subversion/bindings/swig/python/svn/__init__.py,
* subversion/bindings/swig/python/svn/client.py,
* subversion/bindings/swig/python/svn/core.py,
* subversion/bindings/swig/python/svn/delta.py,
* subversion/bindings/swig/python/svn/diff.py,
* subversion/bindings/swig/python/svn/fs.py,
* subversion/bindings/swig/python/svn/ra.py,
* subversion/bindings/swig/python/svn/repos.py,
* subversion/bindings/swig/python/svn/wc.py,
* subversion/include/svn_props.h,
* subversion/libsvn_repos/repos.c,
* subversion/svn/svn.1,
* subversion/svnadmin/svnadmin.1,
* subversion/svndumpfilter/svndumpfilter.1,
* subversion/svnlook/svnlook.1,
* subversion/svnsync/svnsync.1,
* subversion/svnversion/svnversion.1,
* subversion/tests/cmdline/authz_tests.py,
* subversion/tests/cmdline/autoprop_tests.py,
* subversion/tests/cmdline/basic_tests.py,
* subversion/tests/cmdline/blame_tests.py,
* subversion/tests/cmdline/cat_tests.py,
* subversion/tests/cmdline/changelist_tests.py,
* subversion/tests/cmdline/checkout_tests.py,
* subversion/tests/cmdline/commit_tests.py,
* subversion/tests/cmdline/copy_tests.py,
* subversion/tests/cmdline/depth_tests.py,
* subversion/tests/cmdline/diff_tests.py,
* subversion/tests/cmdline/entries_tests.py,
* subversion/tests/cmdline/export_tests.py,
* subversion/tests/cmdline/externals_tests.py,
* subversion/tests/cmdline/getopt_tests.py,
* subversion/tests/cmdline/history_tests.py,
* subversion/tests/cmdline/import_tests.py,
* subversion/tests/cmdline/info_tests.py,
* subversion/tests/cmdline/lock_tests.py,
* subversion/tests/cmdline/log_tests.py,
* subversion/tests/cmdline/merge_authz_tests.py,
* subversion/tests/cmdline/merge_tests.py,
* subversion/tests/cmdline/mergeinfo_tests.py,
* subversion/tests/cmdline/obliterate_tests.py,
* subversion/tests/cmdline/patch_tests.py,
* subversion/tests/cmdline/prop_tests.py,
* subversion/tests/cmdline/resolve_tests.py,
* subversion/tests/cmdline/resolved_tests.py,
* subversion/tests/cmdline/revert_tests.py,
* subversion/tests/cmdline/schedule_tests.py,
* subversion/tests/cmdline/special_tests.py,
* subversion/tests/cmdline/stat_tests.py,
* subversion/tests/cmdline/svnadmin_tests.py,
* subversion/tests/cmdline/svndumpfilter_tests.py,
* subversion/tests/cmdline/svneditor.py,
* subversion/tests/cmdline/svnlook_tests.py,
* subversion/tests/cmdline/svnsync_tests.py,
* subversion/tests/cmdline/svnversion_tests.py,
* subversion/tests/cmdline/switch_tests.py,
* subversion/tests/cmdline/trans_tests.py,
* subversion/tests/cmdline/tree_conflict_tests.py,
* subversion/tests/cmdline/update_tests.py,
* subversion/tests/cmdline/upgrade_tests.py,
* subversion/tests/cmdline/utf8_tests.py,
* tools/backup/hot-backup.py.in,
* tools/dev/contribulyze.py,
* tools/dist/gen_nightly_ann.py,
* tools/dist/write-announcement.py,
* tools/po/po-update.sh
  Fix broken links.


r910216 | mf | 2010-02-15 07:17:25 -0600 (Mon, 15 Feb 2010)

Replace links pointing to the svn.collab.net repository by apache.org links.

* site/publish/faq.html
  Fix broken links.


r909157 | mf | 2010-02-11 15:31:31 -0600 (Thu, 11 Feb 2010)

Follow up to 909145: Replace the title attributes which haven't
been caught by the script.

* docs/release-notes/1.5.html,
* faq.html,
* faq.ja.html,
* faq.zh.html,
  Remove title attributes and add section links to headers.

Approved by: julianfoad, cmpilato


r909145 | mf | 2010-02-11 15:04:38 -0600 (Thu, 11 Feb 2010)

Replace title attributes by section links which show up when hovering
over the enclosing header.

* style/site.css
  (.sectionlink): New class.

* contributing.html,
* docs/community-guide/building.part.html,
* docs/community-guide/conventions.part.html,
* docs/community-guide/debugging.part.html,
* docs/community-guide/general.part.html,
* docs/community-guide/index.html,
* docs/community-guide/issues.part.html,
* docs/community-guide/l10n.part.html,
* docs/community-guide/mailing-lists.part.html,
* docs/community-guide/releasing.part.html,
* docs/community-guide/roles.part.html,
* docs/index.html,
* docs/release-notes/1.2.html,
* docs/release-notes/1.3.html,
* docs/release-notes/1.4.html,
* docs/release-notes/1.5.html,
* docs/release-notes/1.6.html,
* docs/release-notes/1.6.zh.html,
* faq.html,
* faq.ja.html,
* faq.zh.html,
* index.html,
* issue-tracker.html,
* mailing-lists.html,
* news.html,
* packages.html,
* roadmap.html,
* source-code.html
  Remove title attributes and add section links to headers.

Approved by: julianfoad, cmpilato


r908556 | mf | 2010-02-10 09:59:00 -0600 (Wed, 10 Feb 2010)

Minor whitespace changes to make the formatting more consistent.

This should also fix some failures of my 'title' conversion script.

* site/publish/features.html
  Whitespace changes.


r878200 | arfrever | 2009-06-20 18:52:46 -0500 (Sat, 20 Jun 2009)

* subversion/libsvn_ra_neon/props.c
  (svn_ra_neon__get_one_prop): Add URL to the error message.

Patch by: mf


r877262 | gstein | 2009-04-12 13:07:22 -0500 (Sun, 12 Apr 2009)

Completed the TODO as stated in svn_io.h for svn_stream_copy3().

* subversion/libsvn_subr/stream.c:
  (svn_stream_copy3): Even on error exit, the two files from and to are
  closed.

Patch by: Edmund Wong <edmund{_at_}belfordhk.com>

Review by: mf
           gstein


r874642 | mf | 2008-12-04 15:31:38 -0600 (Thu, 04 Dec 2008)

* contrib/server-side/svnmirror-test.sh: Add license and small description.


r871561 | mf | 2008-05-27 19:56:30 -0500 (Tue, 27 May 2008)

Add a note to the help texts of checkout and switch about where to find the
action characters.

* subversion/svn/main.c
  (svn_cl__cmd_table."checkout"): Add 'see also update' note.
  (svn_cl__cmd_table."switch"):   Ditto.

* subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout:
  Ditto.

Approved by: danielsh



r864579 | mf | 2007-04-09 14:34:47 -0500 (Mon, 09 Apr 2007)

* www/links.html
  (misc_utils): Update link to svndumptool.


r864314 | lgo | 2007-03-28 15:38:28 -0500 (Wed, 28 Mar 2007)

Add tests for failing start-commit and pre-commit hooks.

Patch by: mf

* subversion/tests/cmdline/commit_tests.py
  (start_commit_hook_test, pre_commit_hook_test): New tests.
  (test_list): Run the new tests.


r864286 | lgo | 2007-03-27 17:47:36 -0500 (Tue, 27 Mar 2007)

Fix the hook_test: from each tested hook write some data to a log file, then 
compare that log file with the expected data.

Patch by: mf
(Tweaked by me.)

* subversion/tests/cmdline/commit_tests.py
  (hook_test): Let the hooks write to a logfile and check its content.
  (test_files): test is passing now, remove XFail

* subversion/tests/cmdline/svntest/main.py
  (create_python_hook_script): pass the parameters from the windows hook.bat 
   file through to the python hook script

r863635 | mf | 2007-03-04 12:26:50 -0600 (Sun, 04 Mar 2007)

Use the real filename possibly including zip extension for transfers too.

Found by: David Rice <dr-svn@jcuz.com>

* tools/server-side/svn-backup-dumps.py
  (SvnBackupOutput.__init__, SvnBackupOutputPlain.__init__,
   SvnBackupOutputGzip.__init__, SvnBackupOutputBzip2.__init__):
  Replace absfilename by abspath and filename.
  (SvnBackupOutputPlain.open, SvnBackupOutputGzip.open,
   SvnBackupOutputBzip2.open): Open absfilename.
  (SvnBackupOutput.get_absfilename): New function.
  (SvnBackup.create_dump): Cleanup the use of realfilename and absfilename.


r863274 | dlr | 2007-01-23 19:21:01 -0600 (Tue, 23 Jan 2007)

A follow-up to r23191, fixing incorrect tweaks to Martin Furter's
patch which I somehow managed to commit.

* subversion/tests/cmdline/export_tests.py
  (export_nonexistent_url): Correct local variable nonexistent_url.

Patch by: mf


r863267 | dlr | 2007-01-23 16:21:07 -0600 (Tue, 23 Jan 2007)

Fix attempts to export a nonexistent URL to return an error.

* subversion/libsvn_client/export.c
  (svn_client_export3): Handle nonexistent URLs by returning an error.

* subversion/tests/cmdline/export_tests.py
  (test_list): Unmark export_nonexistent_url() as XFAIL.

Patch by: mf
(Tweaked by me.)


r863265 | dlr | 2007-01-23 15:43:07 -0600 (Tue, 23 Jan 2007)

Add test for attempts to export a nonexistent URL.

* subversion/tests/cmdline/export_tests.py
  (export_nonexistent_url): Add test which verifies that attempts to
   export a nonexistent URL produce an error.
  (test_list): Add export_nonexistent_url() to the list.

Patch by: mf
(Tweaked by me.)


r862852 | mf | 2006-12-21 08:46:07 -0600 (Thu, 21 Dec 2006)

Rudimentary windows port of svn-backup-dumps.py.

* tools/server-side/svn-backup-dumps.py
  (header): Update description. Increase version to 0.5.
  (imports): Do not import fcntl and select on windows.
  (exec_cmd): Renamed to exec_cmd_unix.
  (exec_cmd_nt): New function doing almost the same as exec_cmd_unix.
  (exec_cmd): New function calling exec_cmd_unix or exec_cmd_nt.

* www/tools_contrib.html:
  (svn_backup_dumps_py): Update description.


r861180 | cmpilato | 2006-08-17 02:15:25 -0500 (Thu, 17 Aug 2006)

Finish issue #2592 (prevent unnecessary user effort for propedits
that won't "take" due to an invalid property name).

Make svn_prop_name_is_valid() public, and teach the command-line
client's 'propedit' subcommand to use it for property name validation
before firing up $EDITOR.

Patch by: Martin Furtur <mf@rola.ch>
(Tweaked by me.)

* subversion/include/svn_props.h
  (svn_prop_name_is_valid): New.

* subversion/libsvn_client/prop_commands.c
  (is_valid_prop_name): Move this function to properties.c, renaming
    it to svn_prop_name_is_valid().
  (svn_client_propset2, svn_client_revprop_set): Use svn_prop_name_is_valid()
    instead of is_valid_prop_name().

* subversion/libsvn_subr/properties.c
  (svn_prop_name_is_valid): Was prop_commands.c:is_valid_prop_name().

* subversion/svn/propedit-cmd.c
  (svn_cl__propedit): Check property name validity before firing up $EDITOR.


r859917 | mf | 2006-05-28 10:25:03 -0500 (Sun, 28 May 2006)

* STATUS (r19841): Nominate.


r859915 | mf | 2006-05-27 10:02:29 -0500 (Sat, 27 May 2006)

Check cmdline arguments and report errors in svn-backup-dumps.py.

Suggested by: Masaru Tsuchiyama <tsuchiyama@asahi-net.email.ne.jp>

* tools/server-side/svn-backup-dumps.py
  (__version): Increased to 0.4.
  (SvnBackupException) New class.
  (SvnBackup.__init__): Check arguments and options.
  (SvnBackup.transfer_ftp): Catch exception and report error.
  (SvnBackup.create_dump): Replaced exists() by os.path.exists().
  ('__main__'): Catch SvnBackupException and report error.


r859642 | nori | 2006-05-08 20:28:13 -0500 (Mon, 08 May 2006)

Supply missing entries for psvn.el, vc-svn.el, and mod_dontdothat.c for
www/tools_contrib.html.

Reviewed by: mf
             rooneg
Approved by: rooneg

* www/tools_contrib.html
  (Index by keyword): Add two categories, 'apache' for mod_dontdothat.c
  and 'emacs' for psvn.el and vc-svn.el.
  (psvn_el): A new entry for psvn.el.
  (vc_svn_el): A new entry for vc-svn.el.
  (mod_dontdothat_c): A new entry for mod_dontdothat.c.


r859556 | mf | 2006-05-01 13:18:20 -0500 (Mon, 01 May 2006)

Added tools_contrib.html listing almost all scripts in tools and contrib.
Removed the content of four READMEs to prevent duplication of the
documentation.

Approved by: dlr

* trunk/www/tools_contrib.html: New file.

* trunk/www/project_tools.html: Added link to tools_contrib.html.

* trunk/contrib/README, trunk/contrib/hook-scripts/README,
  trunk/tools/README, trunk/tools/hook-scripts/README:
  Removed all the text and added a reference to tools_contrib.html.


r859028 | mf | 2006-03-18 19:31:45 -0600 (Sat, 18 Mar 2006)

Add svn-backup-dumps.py, a tool to make various kinds of svn dumps.

* tools/server-side/svn-backup-dumps.py: New file.

Approved by: kfogel


r859026 | mf | 2006-03-18 19:30:02 -0600 (Sat, 18 Mar 2006)

* COMMITTERS
  (mf): Added svn-backup-dumps.py to my list of files.


r858451 | mf | 2006-02-07 15:38:50 -0600 (Tue, 07 Feb 2006)

Add new script svnmirror-test.sh for testing svnmirror.sh.

Review by:  Markus Rueckert <darix@irssi.org>

* contrib/server-side/svnmirror-test.sh: New script.


r858450 | mf | 2006-02-07 15:36:09 -0600 (Tue, 07 Feb 2006)

Add svndumpfilter support to svnmirror.sh.

Suggested by: Loic Calvez <l.calvez@openchange.org>
Review by:    Markus Rueckert <darix@irssi.org>

* contrib/server-side/svnmirror.sh:
  Added support for svndumpfilter.


r858449 | mf | 2006-02-07 15:30:53 -0600 (Tue, 07 Feb 2006)

* COMMITTERS:
  (mf) Add myself as partial committer for svnmirror.sh.


r847384 | cmpilato | 2003-10-05 16:29:23 -0500 (Sun, 05 Oct 2003)

Solve the python 2.1 incompatibility introduced in rev 7295.

Patch by: Martin Furter <mf@rola.ch>

* build/generator/gen_base.py
  (Generator.find_sections): Use 'x.has_key(y)' instead of 'y in x'.


r847133 | mbk | 2003-09-14 17:08:27 -0500 (Sun, 14 Sep 2003)

Update example C client application to match various recent API changes.
Minor refactoring of line reading code.

Patch by: Martin Furter <mf@rola.ch>
          me

* tools/examples/minimal_client.c
  (my_prompt_callback): removed
  (prompt_and_read_line): new function.
  (my_simple_prompt_callback): new function.
  (my_username_prompt_callback): new function.
  (main): pass new callbacks where appropriate, and use the updated
   svn_config API.


r846097 | kfogel | 2003-05-23 11:05:21 -0500 (Fri, 23 May 2003)

* tools/cvs2svn/cvs2svn.1: Bring up to date.

Patch by: Martin Furter <mf@rola.ch>