Dmitry Pavlenko <pavlenko@tmatesoft.com>


Found Patch Suggested
r1481095, r1348822, r1329876 r1736086, r1361123, r1353572, r1351772, r1349215, r1335555 r1361256, r1338688

r1736086 | stsp | 2016-03-21 15:23:09 -0500 (Mon, 21 Mar 2016)

Rename parameter ignoreLocal to onDisk (like at r1583335).

* subversion/bindings/javahl/src/org/apache/subversion/javahl/ISVNClient.java
  (ISVNClient): Rename parameter ignoreLocal to onDisk.

Patch by: Dmitry Pavlenko <pavlenko@tmatesoft.com>


r1481095 | julianfoad | 2013-05-10 11:58:21 -0500 (Fri, 10 May 2013)

Minor simplification. No functional change.

Found by: Dmitry Pavlenko <pavlenko{_AT_}tmatesoft.com>

* subversion/libsvn_wc/merge.c
  (merge_text_file): Remove a redundant 'if' condition, and simplify the
    associated flow of control a little.

r1361256 | rhuijben | 2012-07-13 10:03:34 -0500 (Fri, 13 Jul 2012)

Make 'svn rm' remove externals registrations below its targets.

We allow deleting parents of file externals (as we allow deleting
directories that contain switched paths) and directories that have
directory externals somewhere below them.

This patch removes the registration in the EXTERNALS table and for
file externals the entire file external so the next update will find
a normal working copy.

The new behavior is more what users expect, reduces the number of strange
database states and resolves some regressions since 1.6.

Suggested by: Dmitry Pavlenko <pavlenko{_AT_}tmatesoft.com>

* subversion/libsvn_wc/adm_ops.c
  (svn_wc__delete_internal): Update caller.

* subversion/libsvn_wc/update_editor.c
  (delete_entry): Update caller.

* subversion/libsvn_wc/wc-queries.sql
  (STMT_DELETE_FILE_EXTERNALS,
   STMT_DELETE_FILE_EXTERNAL_REGISTATIONS,
   STMT_DELETE_EXTERNAL_REGISTATIONS): New statements.

* subversion/libsvn_wc/wc_db.c
  (op_delete_baton_t): Add delete_dir_externals.
  (delete_node): Delete externals if necessary.
  (op_delete_many_txn): Update caller.
  (svn_wc__db_op_delete): Pass delete_dir_externals.

* subversion/libsvn_wc/wc_db.h
  (svn_wc__db_op_delete): Add delete_dir_externals argument and update
    documentation.
  (svn_wc__db_op_delete_many): Update documentation.

* subversion/tests/libsvn_wc/op-depth-test.c
  (do_delete): Update caller.
  (copy_file_externals): Update expected result.


r1361123 | rhuijben | 2012-07-13 04:23:36 -0500 (Fri, 13 Jul 2012)

Fix potential situation in which credentials are not saved to cache when
they have changed.

If cached username and new username differ but passwords are the same,
'need_to_save' flag will be overwritten to FALSE, and new credentials
fill not be saved.

* subversion/libsvn_subr/simple_providers.c
(svn_auth__simple_creds_cache_get): Stop setting need_to_save to FALSE.

Patch by: Dmitry Pavlenko <pavlenko{_AT_}tmatesoft.com>


r1353572 | stsp | 2012-06-25 09:27:16 -0500 (Mon, 25 Jun 2012)

Fix a typo that could lead to wrong translated_size value. If svn:eol-style
is locally changed and svn:keywords is not, translated_size wasn't reset.

* subversion/libsvn_wc/props.c
  (do_propset): SVN_PROP_EOL_STYLE value should be checked, not
   SVN_PROP_KEYWORDS.

Patch by: Dmitry Pavlenko <pavlenko@tmatesoft.com>


r1351772 | stsp | 2012-06-19 11:39:14 -0500 (Tue, 19 Jun 2012)

In JavaHL, add missing 'replaced' value to ConflictDescriptor.Reason,
corresponding to svn_wc_conflict_reason_replaced; and add 'replace' to
ConflictDescriptor.Action, corresponding to svn_wc_conflict_action_replace.

These values are new in Subversion 1.7 but we forgot to add them to JavaHL.

* subversion/bindings/javahl/src/org/apache/subversion/javahl/ConflictDescriptor.java
  (Action): Add 'replace'.
  (Reason): Add 'replaced'.

Patch by: Dmitry Pavlenko <pavlenko@tmatesoft.com>
          me


r1349215 | cmpilato | 2012-06-12 04:40:44 -0500 (Tue, 12 Jun 2012)

Add a regression test for r1348822.

* subversion/tests/cmdline/stat_tests.py
  (status_depth_update_local_modifications): Add a test for "svn
    status -u" call with different --depth values on a working copy
    with local modifications.

Patch by: Dmitry Pavlenko <pavlenko{_AT_}tmatesoft.com>

r1348822 | stsp | 2012-06-11 07:34:00 -0500 (Mon, 11 Jun 2012)

Fix "svn status --update --depth=empty FILE", which was not showing the
status of FILE.

* subversion/libsvn_client/status.c
  (svn_client_status5): If the status -u target is a file, the status editor
   is rooted at the file's parent. Upgrade depth from 'empty' to 'files' in
   this case, to ensure that the target itself escapes depth filtering.

Found by: Dmitry Pavlenko <pavlenko@tmatesoft.com>


r1338688 | stsp | 2012-05-15 08:20:34 -0500 (Tue, 15 May 2012)

* subversion/libsvn_client/diff.c
  (make_regular_props_hash): New helper that filters non-regular props.
  (diff_repos_repos_added_or_deleted_file,
   diff_repos_repos_added_or_deleted_dir): Filter non-regular props from
    properties hashes passed to file_deleted() and dir_props_changed()
    diff callbacks.

Suggested by: Dmitry Pavlenko <pavlenko@tmatesoft.com>


r1335555 | stsp | 2012-05-08 09:49:22 -0500 (Tue, 08 May 2012)

Fix python tests execution for jsvn.

* subversion/tests/cmdline/svntest/main.py
  (execute_tests): svnversion_binary variable was used instead of svnmucc_binary

Patch by: Dmitry Pavlenko <pavlenko@tmatesoft.com>


r1329876 | rhuijben | 2012-04-24 12:33:08 -0500 (Tue, 24 Apr 2012)

Make svn update notify on just removing locks on files.

* subversion/tests/cmdline/lock_tests.py
  (update_locked_deleted): Update expected output.
  
* subversion/libsvn_wc/update_editor.c
  (close_file): Report files as modified when an existing lock is removed.
  
Found by: Dmitry Pavlenko <pavlenko{_AT_}tmatesoft.com>