Peter Samuelson <peter@p12n.org>


Found Patch Suggested
r31130, r30117, r24167, r21899, r20583 r31782, r28695, r27698, r24936, r24539, r22367, r21306, r19445, r18642, r18550, r18062, r17768, r16035 r23365, r22486, r21514, r18397, r18255

r31782 | kfogel | 2008-06-18 22:07:10 -0500 (Wed, 18 Jun 2008)

Copyedit r31779 a little.

* www/svn_1.5_releasenotes.html
  (Known Issues): Use <code> for literal commands.

Patch by: Peter Samuelson <peter@p12n.org>
(The original patch did more, but r31780 outdated the other hunk.)


r31130 | kfogel | 2008-05-12 01:15:48 -0500 (Mon, 12 May 2008)

* STATUS: Vote for r31126, and fix its description (copy-&-pasto in r31127).

Found by: Peter Samuelson <peter@p12n.org>
(That is, he noticed the description problem -- he didn't "find" my vote!)


r30117 | dionisos | 2008-03-30 13:02:32 -0500 (Sun, 30 Mar 2008)

* notes/sasl.txt: EXAMPLE>COM -> EXAMPLE.COM

Found by: Peter Samuelson <peter@p12n.org>


r28695 | brane | 2007-12-28 15:46:46 -0600 (Fri, 28 Dec 2007)

Simplify case-folding comparison.

* subversion/libsvn_subr/ctype.c (casefold_table): Replace logic from
   code in svn_ctype_casecmp with a more appropriate static table.
  (svn_ctype_casecmp): Simplify.

Patch by: Peter Samuelson <peter@p12n.org>
          me


r27698 | blair | 2007-11-07 21:42:12 -0600 (Wed, 07 Nov 2007)

* tools/hook-scripts/commit-email.pl.in:
  Exit with an error if we cannot connect to the SMTP server.

Patch by: Peter Samuelson <peter@p12n.org>


r24936 | zhakov | 2007-05-04 13:54:40 -0500 (Fri, 04 May 2007)

Followup to r24861: replace a docstring with a brief comment.

* subversion/libsvn_repos/repos.c
* subversion/libsvn_subr/config_file.c
* subversion/tests/libsvn_diff/diff-diff3-test.c
* subversion/tests/libsvn_repos/repos-test.c
  (NL) Replace docstring with a brief comment.

Patch by: Peter Samuelson <peter@p12n.org> 


r24539 | dlr | 2007-04-11 16:41:52 -0500 (Wed, 11 Apr 2007)

Remove useless "\" line continuations from C code.

* subversion/libsvn_subr/win32_crashrpt.c (svn__unhandled_exception_filter)
* subversion/libsvn_client/merge.c (do_merge, discover_and_merge_children)
* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
  (svn_swig_rb_to_depth, svn_swig_rb_get_commit_log_func,
   svn_swig_rb_auth_simple_prompt_func,
   svn_swig_rb_auth_ssl_client_cert_prompt_func,
   svn_swig_rb_auth_ssl_client_cert_pw_prompt_func)
* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (svn_swig_py_auth_simple_prompt_func, svn_swig_py_auth_username_prompt_func,
   svn_swig_py_auth_ssl_client_cert_prompt_func,
   svn_swig_py_auth_ssl_client_cert_pw_prompt_func)
* subversion/mod_dav_svn/reports/update.c (dav_svn__update_report)
* subversion/mod_dav_svn/reports/file-revs.c (dav_svn__file_revs_report):
  Remove unnecessary trailing \ characters.

Patch by: Peter Samuelson <peter@p12n.org>


r24167 | dlr | 2007-03-26 14:42:01 -0500 (Mon, 26 Mar 2007)

On the 1.4.x branch: Revert an unintential portion of r24135.

* subversion/libsvn_ra_dav/util.c
  (parsed_request): Revert handling for NULL BODY parameter.

Found by: Peter Samuelson <peter@p12n.org>


r23365 | kfogel | 2007-02-07 02:51:20 -0600 (Wed, 07 Feb 2007)

* www/faq.html (net-trace): Identify the command-line version as "tshark".

Suggested by: Peter Samuelson <peter@p12n.org>


r22486 | dlr | 2006-11-28 13:47:09 -0600 (Tue, 28 Nov 2006)

A follow-up to r22207, fixing Bourne shell portability.

* subversion/tests/cmdline/davautocheck.sh
  Use 'unset' instead of 'export -n'.

Suggested by: Peter Samuelson <peter@p12n.org>
Review by: blair


r22367 | dlr | 2006-11-20 11:49:12 -0600 (Mon, 20 Nov 2006)

* contrib/client-side/svn-clean
  (pod page): Replace inappropriate UTF-8 apostrophe character.

Patch by: Peter Samuelson <peter@p12n.org>


r21899 | dlr | 2006-10-12 10:03:31 -0500 (Thu, 12 Oct 2006)

* Makefile.in
  (clean-javahl): Remove ":$(libdir)" string from the @JAVAHL_OBJDIR@
   element in the list of paths to delete.

Found by: Peter Samuelson <peter@p12n.org>


r21514 | djames | 2006-09-16 09:59:28 -0500 (Sat, 16 Sep 2006)

* dist.sh: Fix a typo introduced in r21502.

Suggested by: Peter Samuelson <peter@p12n.org>


r21306 | kfogel | 2006-08-28 17:28:53 -0500 (Mon, 28 Aug 2006)

* www/faq.html
  (single-file-checkout): Recommend 'svn export' instead of 'svn cat'.

Patch by: Peter Samuelson <peter@p12n.org>


r20583 | madanus | 2006-07-12 07:49:14 -0500 (Wed, 12 Jul 2006)

A follow-up to r20316.

Found by: Peter Samuelson <peter@p12n.org>

 * www/faq.html: Fix typo.


r19445 | lundblad | 2006-04-21 15:30:49 -0500 (Fri, 21 Apr 2006)

Make locale handling more forgiving in the clients.

Patch by: Peter Samuelson <peter@p12n.org>
(Style tweak by me.)

* subversion/libsvn_subr/cmdline.c (svn_cmdline_init): Try setting both
  LC_ALL and LC_CTYPE locale variables, warning only if both fail.
  Do not consider this a fatal error.


r18642 | kfogel | 2006-02-27 16:02:49 -0600 (Mon, 27 Feb 2006)

* www/faq.html (version-value-in-source): Use := in example Makefile
  for efficiency.  Clarify use of GNU-make-ism.

Patch by: Peter Samuelson <peter@p12n.org>
(Inspired by philip's observations about r18636.)


r18550 | blair | 2006-02-22 01:12:15 -0600 (Wed, 22 Feb 2006)

Educate svn_load_dirs.pl to support symlinks.  Closes issue #2478.

Patch by: Tilman Koschnick <til@subnetz.org>
          Peter Samuelson <peter@p12n.org>
(Tweaked by me.)

* contrib/client-side/svn_load_dirs.pl.in:
  Import and correct update symlinks ($source_type 'l').


r18397 | dlr | 2006-02-08 19:36:05 -0600 (Wed, 08 Feb 2006)

A follow-up to r18382 to improve code cleanliness.

* subversion/tests/cmdline/switch_tests.py
  (relocate_beyond_repos_root): Move 'URL: ' portion of the regex used
   to verify that the switch worked outside of the call to re.escape()
   to improve comprehensibility (and insignificantly, performance).

Suggested by: Peter Samuelson <peter@p12n.org>
Review by: lundblad


r18255 | dlr | 2006-01-26 17:59:06 -0600 (Thu, 26 Jan 2006)

Make 'svn log target@N' consistent with the peg revision operations of
other commands (e.g. 'svn cat target@N'), where the specified peg
revision becomes the virtual HEAD.  See
http://svn.haxx.se/dev/archive-2006-01/0352.shtml for related
discussion, or http://svn.collab.net/viewcvs/svn?rev=18179&view=rev
for a related patch (to 'svn blame').  Because peg revision handling
for 'svn log' is new in Subversion 1.4, there are no compatibility
concerns here.


* subversion/tests/cmdline/log_tests.py
  (log_wc_with_peg_revision): New function testing log of a WC target
   with a peg revision.

  (url_missing_in_head): Remove redundant -rN from command (now
   implied by @N peg revision on URI), and improve validation by
   parsing the log output.

  (test_list): Add log_wc_with_peg_revision() to the list.


* subversion/svn/log-cmd.c
  (svn_cl__log): When OPT_STATE->START_REVISION is not specified and
   START_REVISION PEG_REVISION is specified, set
   OPT_STATE->START_REVISION to PEG_REVISION.


Suggested by: malcolm
              Peter Samuelson


r18062 | julianfoad | 2006-01-10 18:46:56 -0600 (Tue, 10 Jan 2006)

Remove bash completion support for "svn ?" and "svnadmin ?", which
interact badly with file globbing and cannot benefit from completion.

Patch by: Peter Samuelson <peter@p12n.org>

* tools/client-side/bash_completion
  (_svn, _svnadmin): Remove "?" from the lists of svn and svnadmin subcommands.

* tools/client-side/bash_completion_test
  Override locale settings to prevent spurious test failures.
  (get_svn_subcommands): Ignore "?" in subcommand autodetection.
  Remove the test for "?".
  Remove an erroneous test for "h" that was passing due to matching "?".


r17768 | malcolm | 2005-12-13 16:49:12 -0600 (Tue, 13 Dec 2005)

Eliminate the use of 'test -a' and 'test -o' from configure.

These operators are not POSIX compliant and apparently have strange
operator precedence issues in some environments.  No functional changes.

Patch by: Peter Samuelson <peter@p12n.org>

* configure.in
  Replace 'test -a' and 'test -o' with '&& test' and '|| test'
  respectively.

[in build/ac-macros]
* apr.m4, aprutil.m4, java.m4, neon.m4, svn-apache.m4, swig.m4
  Likewise.


r16035 | maxb | 2005-09-03 12:21:50 -0500 (Sat, 03 Sep 2005)

Fix all incorrect C format strings currently in .po files.

Patch by: Peter Samuelson <peter@p12n.org>
          me
(Initial patch fixed 3 strings, caused me to search, and find more errors.)

* subversion/po/es.po, subversion/po/fr.po, subversion/po/it.po,
  subversion/po/pl.po, subversion/po/pt_BR.po, subversion/po/zh_TW.po:
  Fix incorrect C format strings. Where I do not know whether I have
  invalidated the grammar of the translated strings, add a "fuzzy" flag to
  draw translator attention.