Роман Донченко <DXDragon@yandex.ru> (rdonch)

r920074 | rdonch | 2010-03-07 13:52:49 -0600 (Sun, 07 Mar 2010)

[in subversion/bindings/swig/python/tests]

* core.py,
  delta.py,
  pool.py,
  wc.py,
  mergeinfo.py,
  run_all.py,
  auth.py,
  ra.py: Fix some code style issues found by pylint. This mostly includes
   inserting whitespace, removing unneeded imports and semicolons, and
   renaming identifiers colliding with reserved names.

Suggested by: bhuvan

r911617 | rdonch | 2010-02-18 16:21:43 -0600 (Thu, 18 Feb 2010)

Move the build log for the __CONFIG__ VS 200x project into the top-level
Debug/Release directories, so that it's automatically svn:ignored.

* build/generator/svn_config.vcproj.ezt: Change IntermediateDirectory (whose
   sole inhabitant is the build log).

* build/win32/ (svn:ignore): Remove BuildLog.htm, which no longer exists.

r911536 | rdonch | 2010-02-18 13:31:59 -0600 (Thu, 18 Feb 2010)

Finish the refactoring started in r901007. The new version no longer
leaks svn_auth_provider_object_t references during the call to svn_auth_open;
r911236 ensures backwards-compatible behavior.

* subversion/bindings/swig/include/svn_containers.swg: Replace the body of the
   Python apr_array_header_t *providers input typemap with a call to
   svn_swig_py_seq_to_array.

r911480 | rdonch | 2010-02-18 10:44:48 -0600 (Thu, 18 Feb 2010)

* subversion/bindings/swig/core.i: Fix an indentation error from r911236.
   This also works around a bug in old SWIGs, which don't auto-correct
   indentation in %pythonappend blocks.

r911236 | rdonch | 2010-02-17 18:34:29 -0600 (Wed, 17 Feb 2010)

SWIG/Python: make the auth baton reference its providers, so that it remains
valid even if the user didn't keep any references himself.
Note: currently, it remains valid as well, but that's because of an object
leak in a typemap, which will be fixed shortly.

* subversion/bindings/swig/core.i: Insert a helper that stores a reference
   to providers in the auth baton wrapper after svn_auth_open.

r910102 | rdonch | 2010-02-14 16:37:49 -0600 (Sun, 14 Feb 2010)

* src-trunk/subversion/bindings/swig/python/tests/ra.py:
  (SubversionRepositoryAccessTestCase.setUp): alter the call to ra.open2 in
   order to better test functionality implemented in r909644 (and remove an
   extraneous None argument).

r910052 | rdonch | 2010-02-14 11:40:09 -0600 (Sun, 14 Feb 2010)

Add a test to the Python bindings' testsuite which tests functionality
implemented in r907788 (and r909644, indirectly).

* subversion/bindings/swig/python/tests/pool.py:
  (PoolTestCase.test_object_hash_struct_members): New function.

r909644 | rdonch | 2010-02-12 16:42:32 -0600 (Fri, 12 Feb 2010)

* subversion/bindings/swig/include/svn_containers.swg: Add typemaps that are
   necessary to translate an APR hash of svn_config_t* into a Python dict,
   and vice versa.

r908275 | rdonch | 2010-02-09 17:12:51 -0600 (Tue, 09 Feb 2010)

Expand/fix r907788, so that the even Righter Thing is done.

* subversion/bindings/swig/include/proxy.swg:
  (_copy_metadata): Rename to _copy_metadata_deep, add a docstring and fix
   a silly bug in the dict branch.
  (_assert_valid_deep): New function.
  (<proxy>.__getattr__): Use the new names/functions.

r908216 | rdonch | 2010-02-09 15:03:03 -0600 (Tue, 09 Feb 2010)

* subversion/bindings/swig/include/proxy.swg: Following up on r908153, drop
   the ABC shenanigans completely. They're not worth the trouble in this case.

r908153 | rdonch | 2010-02-09 12:43:36 -0600 (Tue, 09 Feb 2010)

* subversion/bindings/swig/include/proxy.swg: Restore compatibility with
   older Pythons by restricting abstract base class usage to versions that
   support them (>= 2.6).

r907822 | rdonch | 2010-02-08 16:12:15 -0600 (Mon, 08 Feb 2010)

* subversion/bindings/swig/python/tests/pool.py:
  (PoolTestCase.test_object_struct_members),
  (PoolTestCase.test_assert_valid): client.ctx_t.config is to become a dict
    soon, making it unsuitable for these tests; use a different member
    (auth_baton) instead.

r907800 | rdonch | 2010-02-08 15:16:02 -0600 (Mon, 08 Feb 2010)

* subversion/bindings/swig/python/svn/__init__.py: Add 'diff' to the public
   name list.

r907788 | rdonch | 2010-02-08 14:56:13 -0600 (Mon, 08 Feb 2010)

SWIG/Python: improve the proxy class template, so that the Right Thing is done
with array/hash members on attribute retrieval.

* subversion/bindings/swig/include/proxy.swg:
  (_copy_metadata): New function.
  (<proxy>.__getattr__): Update to use _copy_metadata.

r907526 | rdonch | 2010-02-07 18:22:22 -0600 (Sun, 07 Feb 2010)

[in subversion/bindings/swig/include]

* proxy.swg,
  proxy_apr.swg,
  svn_global.swg: Set svn:eol-style=native.

r906188 | rdonch | 2010-02-03 13:19:26 -0600 (Wed, 03 Feb 2010)

It's New Year all over again.

* NOTICE: Bump copyright year.

Approved by: stsp

r906165 | rdonch | 2010-02-03 12:33:17 -0600 (Wed, 03 Feb 2010)

Clean up the Python bindings testsuite's licensing, remove references that
are no longer valid.
 
* NOTICE: Reference the top-level LICENSE file instead of the now-removed
   one and list all copyright holders for the BSD-licensed code.
 
* LICENSE: Remove comment marks and list all copyright holders for the
   BSD-licensed code.
 
* subversion/bindings/swig/python/tests/trac/versioncontrol/tests/svn_fs.py,
  subversion/bindings/swig/python/tests/trac/versioncontrol/svn_fs.py,
  subversion/bindings/swig/python/tests/trac/versioncontrol/main.py,
  subversion/bindings/swig/python/tests/trac/test.py: Replace references
   to LICENSE_FOR_PYTHON_BINDINGS with the full license text; add the ASF
   blurb where it's missing.

Approved by: cmpilato

r906147 | rdonch | 2010-02-03 11:36:04 -0600 (Wed, 03 Feb 2010)

* subversion/bindings/swig/svn_client.i: Amend a change from r901007 that the
   Perl bindings were not quite ready for.

r904298 | rdonch | 2010-01-28 17:14:21 -0600 (Thu, 28 Jan 2010)

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c:
  (svn_swig_py_unwrap_struct_ptr): Correct brace style.

r904290 | rdonch | 2010-01-28 16:58:31 -0600 (Thu, 28 Jan 2010)

Mild libsvn_swig_py refactoring.

[in subversion/bindings/swig]

* python/libsvn_swig_py/swigutil_py.c,
  python/libsvn_swig_py/swigutil_py.h:
  (svn_swig_py_changed_path_hash_from_dict): Generalize to work with any
   struct and allow null pointers in the resulting hash. Rename to 
   svn_swig_py_struct_ptr_hash_from_dict, accordingly.

* include/svn_containers.swg: Use the new name (and syntax).

r901315 | cmpilato | 2010-01-20 12:25:25 -0600 (Wed, 20 Jan 2010)

* site/publish/docs/community-guide/index.html
  Bump to XHTML 1.1 DTD.

Suggested by: rdonch

r901312 | cmpilato | 2010-01-20 12:20:02 -0600 (Wed, 20 Jan 2010)

* site/publish/security/index.html
  Fix some validation and content issues.

Patch by: Роман Донченко <DXDragon@yandex.ru>
          (Tweaked by me.)

r901007 | rdonch | 2010-01-19 17:51:24 -0600 (Tue, 19 Jan 2010)

Refactor various routines that transform Python sequences into APR arrays
and associated typemaps to reduce code duplication.

[in subversion/bindings/swig]

* python/libsvn_swig_py/swigutil_py.c,
  python/libsvn_swig_py/swigutil_py.h:
  (svn_swig_py_rangelist_to_array),
  (svn_swig_py_strings_to_array),
  (svn_swig_py_revnums_to_array),
  (svn_swig_py_struct_ptr_list_to_array): Remove.
  (svn_swig_py_object_unwrap_t): New typedef.
  (svn_swig_py_unwrap_string),
  (svn_swig_py_unwrap_revnum),
  (svn_swig_py_unwrap_struct_ptr),
  (svn_swig_py_seq_to_array): New functions to replace the ones removed.
  (svn_swig_py_mergeinfo_from_dict): Update to use the new functions.

* include/svn_containers.swg: Adjust typemaps that were using the old
   functions. Delete the STRINGLIST_MAY_BE_NULL typemap for Python, as it
   behaves the same as STRINGLIST.

* svn_client.i,
  svn_wc.i: Make STRINGLIST_MAY_BE_NULL usage Ruby-specific; if not building
   for Ruby, use STRINGLIST instead.

r880016 | rdonch | 2009-10-11 08:49:21 -0500 (Sun, 11 Oct 2009)

* subversion/bindings/swig/python/tests/repository.py:
  (SubversionRepositoryTestCase.test_create): Fix another case of passing
    native paths to Subversion API.

r879987 | rhuijben | 2009-10-09 16:56:23 -0500 (Fri, 09 Oct 2009)

Following up on r39749, pass the right baton to the cancel function.

* subversion/libsvn_wc/diff.c
  (directory_elements_diff, report_wc_directory_as_added):
    Pass cancel baton instead of callback baton.

Found by: rdonch

r879923 | rdonch | 2009-10-07 16:42:52 -0500 (Wed, 07 Oct 2009)

* subversion/bindings/swig/tests/trac/versioncontrol/tests/svn_fs.py:
   Call svn_dirent_internal_style on REPOS_PATH, as it's passed to the SVN API.

r879918 | rdonch | 2009-10-07 15:25:27 -0500 (Wed, 07 Oct 2009)

* subversion/bindings/swig/include/svn_containers.swg:
   For now, remove one of the checks introduced by r39838, as is requires
   Py_ssize_t, which is apparently not provided by the combination of old SWIG
   and Python 2.4 which is used by the win32-xp VS2005 buildbot.

r879912 | rdonch | 2009-10-07 13:10:34 -0500 (Wed, 07 Oct 2009)

Add checks for two pathological cases to several Python typemaps/utility
functions.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c:
  (svn_swig_py_rangelist_to_array),
  (svn_swig_py_strings_to_array),
  (svn_swig_py_revnums_to_array),
  (svn_swig_py_struct_ptr_list_to_array),

* subversion/bindings/swig/include/svn_containers.swg:
   Check that we successfully retrieved the sequence length, and that it
   fits into an int.

r879861 | rdonch | 2009-10-05 12:28:46 -0500 (Mon, 05 Oct 2009)

Add a test for svn.client.merge_peg3 to confirm that it was indeed
fixed by r39635.

* subversion/bindings/swig/python/tests/client.py:
  (SubversionClientTestCase.test_merge_peg3): New function.

r879791 | rdonch | 2009-09-30 13:26:31 -0500 (Wed, 30 Sep 2009)

In the svn-python testsuite, use the svn_dirent functions instead of the
svn_path ones, and internal_style instead of canonicalize.
Besides getting rid of deprecated function calls, this also fixes several WC
testcases that were failing on Windows.

* subversion/bindings/swig/python/tests/client.py:
  (SubversionClientTestCase.allocate_temp_dir): use svn_dirent_internal_style
    instead of svn_path_internal_style.

* subversion/bindings/swig/python/tests/wc.py:
  (SubversionWorkingCopyTestCase.setUp): use svn_dirent_internal_style instead
    of svn_path_canonicalize.

r879789 | rdonch | 2009-09-30 12:23:51 -0500 (Wed, 30 Sep 2009)

Make functions from svn_dirent_uri.h available from the SWIG bindings,
minus ones that don't work correctly yet.

* subversion/bindings/swig/core.i: Include the svn_dirent_uri.h functions.
   Ignore the ones that we didn't yet teach SWIG to deal with.

r879767 | rhuijben | 2009-09-30 05:00:30 -0500 (Wed, 30 Sep 2009)

Make svn_dirent_canonicalize() do what it's documentation says it does:
make all drive letters upper case on Windows. To do this without breaking
compatibility svn_dirent_is_canonical will still return TRUE for paths
with lower case drive letters.

As an added bonus svn_dirent_is_canonical stops allocating memory for
the common path formats.

Found by: rdonch

* subversion/include/svn_dirent_uri.h
  (svn_relpath_is_canonical): Update argument name to match documentation.

* subversion/libsvn_subr/dirent_uri.c
  (local_style): Correctly switch code between dirents and relpaths.
     Remove obsolete comment.
  (canonicalize): Upper case drive letters for dirents.
  (svn_dirent_canonicalize): Upper case drive letter in special case.
  (svn_dirent_is_canonical): Use specific implementation for the common
    path formats.

* subversion/tests/libsvn_subr/dirent_uri-test.c
  (test_dirent_canonicalize): Add test values on defined behavior.
  (test_dirent_local_style,
   test_dirent_internal_style): Add test values for new behavior and
     update expected values for non canonical paths.

r879764 | rhuijben | 2009-09-30 03:08:37 -0500 (Wed, 30 Sep 2009)

Make svn_dirent_is_absolute() only return true when
svn_dirent_get_absolute() called on that same path returns the same value.
This resolves an issue with lower cased drive letters in Windows, that
where found.

Found by: rdonch

* subversion/libsvn_subr/dirent_uri.c
  (svn_dirent_is_absolute): Don't assume a lowercase drive letter is absolute.

* subversion/tests/libsvn_subr/dirent_uri-test.c
  (test_dirent_is_absolute): Add two test values, verifying the new behavior and
    add verification on svn_dirent_get_absolute() value being the same for absolute
    paths.
  (test_dirent_get_absolute): Add three test values.

r879726 | rdonch | 2009-09-28 10:28:40 -0500 (Mon, 28 Sep 2009)

As a follow-up to r39635, add a test for svn.client.log5, which should
now be working.

* subversion/bindings/swig/python/tests/client.py:
  (SubversionClientTestCase.log_entry_receiver),
  (SubversionClientTestCase.test_log5): New functions.

r879711 | rdonch | 2009-09-27 16:54:30 -0500 (Sun, 27 Sep 2009)

* subversion/bindings/swig/include/svn_containers.swg:
  In the Python typemap for REVISION_RANGE_LIST, strip the const qualifier
  from the result explicitly to avoid compiler warnings.

r879709 | rdonch | 2009-09-27 15:21:10 -0500 (Sun, 27 Sep 2009)

SWIG/Python: add a typemap for APR arrays of svn_opt_revision_range_t *.
This fixes svn.client.log5 and probably svn.client.merge_peg3 too.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c:
  (svn_swig_py_struct_ptr_list_to_array): New function.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h:
  (svn_swig_py_struct_ptr_list_to_array): New function.

* subversion/bindings/swig/include/svn_containers.swg:
  Add a Python typemap for apr_header_t *REVISION_RANGE_LIST.

* subversion/bindings/swig/svn_client.i:
  Apply the new typemap to the revision_ranges argument. Enable it
  for Python.

Found by: blair

r879456 | rdonch | 2009-09-16 16:29:19 -0500 (Wed, 16 Sep 2009)

In the SWIG/Python testsuite, made the libsvn_client tests clean up after themselves, properly.

* subversion/bindings/swig/python/tests:
  (SubversionClientTestCase.allocate_temp_dir): New method.
  (SubversionClientTestCase.setUp): Add storage for cleanup info.
  (SubversionClientTestCase.tearDown): Actually clean up. New method.
  (SubversionClientTestCase.test_checkout):
  (SubversionClientTestCase.test_url_from_path):
  (SubversionClientTestCase.test_uuid_from_path):
  (SubversionClientTestCase.test_info_file): Use allocate_temp_dir to ensure cleanup.

r879352 | rdonch | 2009-09-13 18:26:53 -0500 (Sun, 13 Sep 2009)

* subversion/include/svn_wc.h:
  (svn_wc_adm_close): Expand the comment into a proper docstring.
    Obvious fix.

r879330 | rdonch | 2009-09-12 10:11:04 -0500 (Sat, 12 Sep 2009)

In the SWIG/Python bindings, work around the deprecation of
BaseException.message, to quench the warning appearing when
SubversionException is used.

* subversion\bindings\swig\python\svn\core.py:
  (SubversionException): override BaseException.message with an attribute of
    our own when running on Python 2.6.

r879028 | rdonch | 2009-08-26 11:35:43 -0500 (Wed, 26 Aug 2009)

* build/win32/ (svn:ignore): Add 'BuildLog.htm', since it doesn't look like
    there's a better place for that file.

Approved by: danielsh
             rhuijben

r878836 | rhuijben | 2009-08-16 11:11:52 -0500 (Sun, 16 Aug 2009)

* build/generator/serf.vcproj.ezt
* build/generator/neon.vcproj.ezt
* build/generator/zlib.vcproj.ezt
  Add ManagedExtensions="1" value to these three makefile projects to reduce
  the number of build warnings produced when building with Visual C++/MSBuild.
  
  As these projects are build via a referenced makefile instead of the vcproj
  file, this doesn't change the buildresult in any way.
  
Patch by: rdonch

r878704 | rdonch | 2009-08-07 15:38:11 -0500 (Fri, 07 Aug 2009)

* build/generator/svn_locale.vcproj.ezt: Specify the correct output directory
   and add an actual clean command. A side effect worth noting is that the build
   log from the project moves to an svn:ignored location.

Approved by: rhuijben

r878669 | rdonch | 2009-08-06 13:53:35 -0500 (Thu, 06 Aug 2009)

* build/generator/svn_locale.vcproj.ezt: remove repetition by adding a loop for configs.

Approved by: rhuijben

r878585 | rdonch | 2009-07-31 09:24:21 -0500 (Fri, 31 Jul 2009)

Make the SWIG/Python bindings installer generator use the correct version
number automatically.

packages/python-windows/setup.py: Replace the hardcoded version number
 with svn.core.SVN_VER_NUMBER.

packages/python-windows/README.txt: Remove the step telling the user to
 correct said version number.

Approved by: djames

r878559 | rdonch | 2009-07-28 15:02:38 -0500 (Tue, 28 Jul 2009)

* subversion/bindings/swig/core.i: Add the definition of APR_STRINGIFY, so  
  SWIG can parse SVN_VER_NUM and dependent macros. Remove explicit  
  definitions of said macros from the Ruby-specific code.

Approved by: cmpilato

r878548 | rdonch | 2009-07-23 09:26:28 -0500 (Thu, 23 Jul 2009)

Ensure the dumps in the Python bindings tests are treated as binary files
(which they are).

[in subversion/bindings/swig/python/tests]

* mergeinfo.py:
  (SubversionMergeinfoTestCase.setUp): Open the dump in binary mode.

* trac/versioncontrol/tests/svn_fs.py:
  (SubversionRepositoryTestSetup.setUp): Ditto.

* trac/versioncontrol/tests/svnrepos.dump (svn:eol-style): Remove the
  property.

r878547 | rdonch | 2009-07-23 07:47:29 -0500 (Thu, 23 Jul 2009)

Give the svn_wc_diff_callbacks*_t wrappers more descriptive names.

* subversion/libsvn_wc/deprecated.c: rename callbacks*_wrapper_baton to
    diff_callbacks*_wrapper_baton, callbacks*_wrapper to
    diff_callbacks*_wrapper and the wrapper functions to wrap_?to*_<basename>.

Approved by: stsp

r878485 | arfrever | 2009-07-12 12:42:33 -0500 (Sun, 12 Jul 2009)

Update the Python bindings installer generator documentation.

* packages/python-windows/README.txt: Bump the version numbers. Update the
   list of files to match the current state of affairs. Miscellaneous tweaks
   on the text.

Patch by: Роман Донченко <DXDragon@yandex.ru>
(Tweaked by me.)

r878410 | djames | 2009-07-04 19:26:21 -0500 (Sat, 04 Jul 2009)

Fix test_lock in the Python bindings testsuite.

* subversion/bindings/swig/python/tests/wc.py:
  (SubversionWorkingCopyTestCase.test_lock): Assign the lock a token, and
  lock /trunk/README.txt instead of /.

Patch by: Roman <DXDragon@yandex.ru>

r878395 | hwright | 2009-07-02 16:07:36 -0500 (Thu, 02 Jul 2009)

* ^/trunk:
  Add 'serf' to svn:ignore.

Suggested by: Роман Донченко <DXDragon@yandex.ru>

r878381 | hwright | 2009-07-02 10:40:01 -0500 (Thu, 02 Jul 2009)

Create proper wrapper functions for svn_wc_diff_callbacks3_t and use them.  
Also change the misleading comments on the old wrappers.

* subversion/libsvn_wc/deprecated.c
  (file_changed, file_deleted, dir_deleted, dir_props_changed, dir_opened,  
   dir_closed): Relabel as svn_wc_diff_callbacks3_t functions, since that's  
    what they're used as.
  (file_changed3, file_deleted3, dir_deleted3, dir_props_changed3,  
   dir_opened2, dir_closed2): New functions.
  (callbacks3_wrapper): Use the new functions above.

Patch by: Роман Донченко <DXDragon@yandex.ru>

r878192 | djames | 2009-06-20 14:43:49 -0500 (Sat, 20 Jun 2009)

* subversion/bindings/swig/python/tests/client.py
  (testBatonPlay): Redesign test to avoid depending on SWIG's sometimes-buggy
  stringification behavior. Instead, use weak references.

Found by: Roman <DXDragon@yandex.ru>

r878116 | djames | 2009-06-15 08:05:37 -0500 (Mon, 15 Jun 2009)

Fix the python-windows installer generator by making it include the .dll
files in the installer. That list originally consisted only of "*.dll".
When the build system was modified to generate .pyd files for the binary
modules, it was changed to "*.pyd". The Subversion libraries and the
dependencies are still .dll files, though, so "*.dll" needs to be brought
back.

* packages/python-windows/setup.py: Add *.dll to the list of package data.

Patch by: <DXDragon@yandex.ru>

Found	Patch	Suggested
r879987, r879767, r879764, r878192	r920133, r920074, r911617, r911536, r911480, r911236, r910102, r910052, r909644, r908275, r908216, r908153, r907822, r907800, r907788, r907526, r906188, r906165, r906147, r904298, r904290, r901312, r901007, r880016, r879923, r879918, r879912, r879862, r879861, r879791, r879789, r879755, r879726, r879711, r879709, r879456, r879352, r879330, r879028, r878836, r878704, r878669, r878585, r878559, r878548, r878547, r878543, r878485, r878410, r878381, r878116	r901315, r878395