S. Ramaswamy <srsy70@gmail.com>


Patch Review Suggested
r862971, r858359, r858253, r856045, r855076, r855075, r854726, r854447, r854367, r853973, r850927, r850147, r850143, r849514, r849419, r849348 r854957 r851593, r849720

r862971 | hwright | 2007-01-03 19:55:33 -0600 (Wed, 03 Jan 2007)

Fix Issue #2304. Default to configured mime-type instead of text/plain.

* subversion/mod_dav_svn/liveprops.c
  Include 'http_core.h'
  (dav_svn_insert_prop): Use ap_default_type() to set mime-type.

* subversion/mod_dav_svn/repos.c
  (dav_svn_set_headers): Use ap_default_type() to set mime-type.

Patch by:  S. Ramaswamy <srsy70@gmail.com>
           me
(S. Ramaswamy and I independently came up with the same solution, see issue
for details.)


r858359 | kfogel | 2006-01-29 10:21:12 -0600 (Sun, 29 Jan 2006)

* www/project_links.html (misc_utils): Add SvnReporter.

Patch by: S. Ramaswamy <srsy70@gmail.com>
(Lightly edited by me to fix HTML formatting.)


r858253 | dlr | 2006-01-19 16:13:28 -0600 (Thu, 19 Jan 2006)

Fix issue #2287, adding support for peg revisions to 'svn log' and its
underlying API.


* subversion/libsvn_client/log.c
  (svn_client_log3): New function based on the previous incarnation of

   svn_client_log2() which accepts a peg revision argument.
   Highlights of this refactoring removed any meaningful use of
   BASE_URL (now IGNORED_URL), and added a block which chooses the
   appropriate (youngest) revision to use when opening a RA session.

  (svn_client_log2): Delegate to svn_client_log3(), passing a
   PEG_REVISION argument with a KIND of svn_opt_revision_unspecified.


* subversion/include/svn_client.h
  (svn_client_log3): New declaration based on the previous incarnation
   of svn_client_log2() which accepts a peg revision argument.

  (svn_client_log2): Deprecated, and adjusted doc string.


* subversion/svn/log-cmd.c
  (svn_cl__log): Remove extraneous comment, strip any peg revision off
   of the end of the URI (storing it for later use), and update API to
   svn_client_log3().


* subversion/tests/cmdline/log_tests.py
  (url_missing_in_head): Add peg revision to URI.

  (log_through_copyfrom_history): Add peg revision to URI, and command
   output.


Patch by: me
          S. Ramaswamy <srsy70@gmail.com>

Review by: lundblad
           julianfoad
           kfogel


r856045 | kfogel | 2005-08-29 15:50:55 -0500 (Mon, 29 Aug 2005)

* contrib/hook-scripts/svn2rss.py: New file.  Generates a RSS 2.0 file
  containing commit information.

Patch by:  S. Ramaswamy <srsy70@gmail.com>
(Tweaked by me to have a more descriptive usage message.)


r855076 | julianfoad | 2005-06-07 12:41:22 -0500 (Tue, 07 Jun 2005)

Fix issue #2105: add "--no-ignore" switch to 'svn import' and 'svn add'.

Patch by: S. Ramaswamy <ramaswamy@collab.net>

* subversion/include/svn_client.h
  (svn_client_import2): New prototype.
  (svn_client_import): Deprecate.
  (svn_client_add3): New prototype.
  (svn_client_add2): Deprecate.

* subversion/libsvn_client/commit.c
  (svn_client_import2): New function. Similar to svn_client_import() but
    takes an additional boolean parameter 'no_ignore'.
  (svn_client_import): Re-implemented using svn_client_import2().
  (import_dir, import): Take new 'no_ignore' parameter.

* subversion/libsvn_client/add.c
  (add_dir_recursive): New boolean parameter 'no_ignore'.
  (add): Take new boolean parameter 'no_ignore' to function and
    pass it along to add_dir_recursive().
  (svn_client_add3): New function. Similar to svn_client_add2()
    except for the additional boolean parameter 'no_ignore'.
  (svn_client_add2, svn_client_add): Re-implemented using
    svn_client_add3().
  (svn_client_mkdir): Use new function svn_client_add3().

* subversion/clients/cmdline/import-cmd.c
  (svn_cl__import): Call svn_client_import2().

* subversion/libsvn_subr/config_file.c
  (svn_config_ensure): Update template for user level 'config' file to
    indicate that 'global-ignores' apply to 'import' and 'add' as well.

* subversion/clients/cmdline/add-cmd.c
  (svn_cl_add): Call svn_client_add3().

* subversion/clients/cmdline/main.c
  (svn_cl__cmd_table): New '--no-ignore' option for import and add.

* subversion/tests/clients/cmdline/import_tests.py
  (import_no_ignores): New test.
  (test_list): Run it.

* subversion/tests/clients/cmdline/basic_tests.py
  (basic_add_no_ignores): New test.
  (test_list): Run it.


r855075 | julianfoad | 2005-06-07 11:38:36 -0500 (Tue, 07 Jun 2005)

First attempt to fix issue #2243 (make 'svn add' honor svn:ignore property).

Patch by: S. Ramaswamy <ramaswamy@collab.net>

See r15004 for follow-up fix.

* subversion/include/svn_wc.h
  (svn_wc_get_ignores): New function.

* subversion/libsvn_wc/status.c
  (svn_wc_get_ignores): New function.
  (collect_ignore_patterns): Allocate patterns in pool.
  (get_dir_status): Stop allocating patterns.

* subversion/libsvn_client/add.c
  (add_dir_recursive): Use the new function svn_wc_get_ignores()
    to get the default and local ignore patterns.

* subversion/libsvn_client/clients/cmdline/basic_tests.py
  (basic_add_local_ignores): New test.
  (test_list): Run it.


r854957 | kfogel | 2005-05-30 14:04:35 -0500 (Mon, 30 May 2005)

Make 'svn proplist' skip unversioned targets with just a warning.
This is part of issue #2030.

Review by: S. Ramaswamy <ramaswamy@collab.net>

* subversion/clients/cmdline/cl.h
  (SVN_CL__TRY): Handle SVN_ERR_ENTRY_NOT_FOUND too.  Also, take a
  'quiet' parameter indicating whether or not to print a warning if a
  skippable error is encountered.

* subversion/clients/cmdline/propdel-cmd.c
  (svn_cl__propdel): Pass opt_state->quiet to SVN_CL__TRY.

* subversion/clients/cmdline/propset-cmd.c
  (svn_cl__propset): Pass opt_state->quiet to SVN_CL__TRY.

* subversion/clients/cmdline/proplist-cmd.c
  (svn_cl__proplist): Use SVN_CL__TRY to skip unversioned as well as
  non-existent targets.


r854726 | cmpilato | 2005-05-09 12:07:57 -0500 (Mon, 09 May 2005)

Fix issue #2296 by adding auth options to the 'svn info' command.

Patch by: S. Ramaswamy <ramaswamy@collab.net>

* subversion/clients/cmdline/main.c
  (svn_cl__cmd_table): Add auth-related command-line options to
    'svn info' ('--username', '--password', '--non-interactive',
    and '--no-auth-cache').


r854447 | ghudson | 2005-04-21 14:29:06 -0500 (Thu, 21 Apr 2005)

Pass all of the hostinfo part of a provided svn+ssh URL to the tunnel
agent; some versions of ssh support a ":port" designation.

Patch by: S. Ramaswamy <ramaswamy@collab.net>

* subversion/libsvn_ra_svn/client.c
  (find_tunnel_agent): Accept hostinfo instead of user and host; pass
   it to the tunnel agent.
  (ra_svn_open): Pass the hostinfo part of the URI to
   find_tunnel_agent, rather than the user and host.


r854367 | cmpilato | 2005-04-18 11:01:10 -0500 (Mon, 18 Apr 2005)

Prevent 'svn import' from creating empty revisions, and organize
import tests into their own test script.

Patch by: S. Ramaswamy <ramaswamy@collab.net>
(Tweaked by me.)

* subversion/libsvn_client/commit.c
  (import_ctx_t): New import context struct.
  (import_dir, import_file): Add 'import_ctx' parameter, and set its
    repos_changed member to TRUE if file or directories are added to
    the repository.
  (import): Set repos_changed in the import_ctx to TRUE if parent
    directories are added.  Update calls to import_file() and
    import_dir().  Abort an edit if no files or directories were added
    to the repository.

* build.conf
  Add import_tests.py to the list of test scripts.

* subversion/tests/clients/cmdline/basic_tests.py
  (basic_import_executable, basic_import_ignores): Moved to import_tests.py.
  (test_list): Remove 'basic_import_executable' and
    'basic_import_ignores' from the list of tests.

* subversion/tests/clients/cmdline/import_tests.py : New.
  (import_executable): Was basic_import_executable() in basic_tests.py.
  (import_ignores): Was basic_import_ignores() in basic_tests.py.
  (import_avoid_empty_revision): New test.
  (test_list): Add 'import_executable', 'import_ignores',
    and 'import_avoid_empty_revisions' to the list of tests.


r853973 | fitz | 2005-04-04 09:49:25 -0500 (Mon, 04 Apr 2005)

Locking tests to verify output of 'svn status' and 'svn status -u'.

Patch by: S. Ramaswamy <ramaswamy@collab.net>

* subversion/tests/clients/cmdline/lock_tests.py (lock_status) :
  New. Verify 'svn status' from the working copy having a representation
  of the lock and another working copy.

  (stolen_lock_status) : New. Verify 'svn status' after stealing the
  lock from another working copy.

  (broken_lock_status) : New. Verify 'svn status' after breaking the
  lock from another working copy.

  (test_list) : Added lock_status, stolen_lock_status, and
  broken_lock_status to the list of tests.


r851593 | kfogel | 2004-10-20 15:14:46 -0500 (Wed, 20 Oct 2004)

* www/project_links.html: Add Eric3 IDE entry.

Suggested by: S. Ramaswamy <ramaswamy@collab.net>


r850927 | kfogel | 2004-09-08 15:15:02 -0500 (Wed, 08 Sep 2004)

Fix issue #2030: Allow 'svn propset' to skip unversioned files and
continue.  

Patch by: S. Ramaswamy <ramaswamy@collab.net>
(Tweaked by me to abstract into a reusable macro.)

[But note that the macro abstraction was reverted in r12774, because
it hampered control over notification.  See issue #2030 for details.]

* subversion/clients/cmdline/cl.h
  (SVN_CL__TRY): New macro.  Tests for SVN_ERR_UNVERSIONED_RESOURCE,
    continues with warning if so.  Exits on any other error, and
    continues if no error.

* subversion/clients/cmdline/propset-cmd.c
  (svn_cl__propset): Use above instead of SVN_ERR.


r850147 | sussman | 2004-06-25 08:27:54 -0500 (Fri, 25 Jun 2004)

Fix issue #1769: allow merge to add directory, even if 'deleted'.

Patch by: S. Ramaswamy <ramaswamy@collab.net>

* subversion/libsvn_client/diff.c
  (merge_dir_added) : Change 'show_hidden' to FALSE to prevent 'entry'
    from being returned when directory is 'deleted', and allow svn merge
    to continue.


r850143 | sussman | 2004-06-24 10:26:44 -0500 (Thu, 24 Jun 2004)

Fix Issue #1793: Stop 'svn up' from deleting schedule-add target directory.

Patch by: S. Ramaswamy <ramaswamy@collab.net>
(I wrote the regression test.)

* libsvn_wc/adm_crawler.c
  (svn_wc_crawl_revisions):  if update target is a schedule-add
      directory, then send an essentially no-op report to server.

* test/clients/cmdline/update_tests.py 
  (update_schedule_add_dir): new regression test.


r849720 | kfogel | 2004-05-07 09:37:25 -0500 (Fri, 07 May 2004)

Fix doc typo.

Suggested by: S. Ramaswamy <ramaswamy@collab.net>

* doc/user/svn-best-practices.html: It's "may" not "main".


r849514 | jszakmeister | 2004-04-19 19:00:44 -0500 (Mon, 19 Apr 2004)

Fix Issue #1777: 'svn blame' should default to the working revision,
when no revision is specified.

* subversion/clients/cmdline/blame-cmd.c
  (svn_cl__blame): Set end revision to svn_opt_revision_base if
  the target is a working copy, and to svn_opt_revision_head if
  the target is a URL.

Patch by: S. Ramaswamy <ramaswamy@collab.net>


r849419 | kfogel | 2004-04-13 13:15:09 -0500 (Tue, 13 Apr 2004)

Fix Issue #1806: 'svn up' should continue after deleting unversioned
or locally modified items.

Patch by: Patch by: S. Ramaswamy <ramaswamy@collab.net>
Review by: rooneg
(He reminded about clearing an error.)
(Regression test by me.)

* subversion/libsvn_wc/log.c
  (log_do_delete_entry): Pass FALSE for 'instant_error' param to
    svn_wc_remove_from_revision_control, to allow unversioning of
    files/dirs even if there are local modifications.  Trap error
    SVN_ERR_WC_LEFT_LOCAL_MOD so that updates can continue.

* subversion/libsvn_wc/update_editor.c
  (do_entry_deletion): Remove section that does not allow updates to
    proceed if there are local modifications.

* subversion/subversion/tests/clients/cmdline/update_tests.py
  (update_delete_modified_files): Don't expect update to stop.

* subversion/subversion/tests/clients/cmdline/switch_tests.py
  (failed_anchor_is_target): Don't expect switch to stop.


r849348 | kfogel | 2004-04-02 07:57:41 -0600 (Fri, 02 Apr 2004)

Fix issue #1552: inconsistent notification for url->wc copies.

Patch by: S. Ramaswamy <ramaswamy@collab.net>

* subversion/libsvn_client/copy.c
  (repos_to_wc_copy): Call the notification function when doing a
    repos-to-wc copy of a single file.