Jeff Trawick <>

Patch Review
r1391641, r1033547 r1232267

r1391641 | cmpilato | 2012-09-28 15:34:50 -0500 (Fri, 28 Sep 2012)

* subversion/libsvn_subr/cache-memcache.c
  (add_memcache_server): Convert time-to-live value from seconds to
    the expected microseconds.

Patch by: Jeff Trawick <trawick{_AT_}>
          (Tweaked by me.)

r1232267 | danielsh | 2012-01-16 20:17:21 -0600 (Mon, 16 Jan 2012)

Follow-up to r1033547: track mod_dav API change.

In r882274, the mod_dav API changed in two ways: the signatures of
dav_new_error() and dav_new_error_tag() changed, and 'struct dav_error'
changed its errno number member into an apr_status_t.  r1033547 tracked
the former change but not the latter.

Review by: Jeff Trawick

* subversion/mod_dav_svn/util.c
  (dav_svn__log_err): Track the change to 'struct dav_error'.

r1033547 | cmpilato | 2010-11-10 10:00:56 -0600 (Wed, 10 Nov 2010)

Wrap mod_dav_svn's use of the mod_dav error APIs with a compatibility
shim to enable compilation against Apache trunk (2.4-to-be).  (This
patch was tracked in issue #3548.)

NOTE: I didn't attempt to correct indentation in this commit.  Will do
a whitepace-only followup commit.

* subversion/mod_dav_svn/dav_svn.h,
* subversion/mod_dav_svn/util.c
  (dav_svn__new_error): New compatibility wrapper function for
    dav_new_error().  (All consumers of the latter tweaked to use the former.)
  (dav_svn__new_error_tag): Add compile-time compatibility codepaths
    to handle changes in the dav_new_error_tag() API.

* subversion/mod_dav_svn/activity.c,
* subversion/mod_dav_svn/deadprops.c,
* subversion/mod_dav_svn/lock.c,
* subversion/mod_dav_svn/repos.c,
* subversion/mod_dav_svn/version.c,
* subversion/mod_dav_svn/reports/dated-rev.c,
* subversion/mod_dav_svn/reports/deleted-rev.c,
* subversion/mod_dav_svn/reports/get-locks.c
  Update caller of dav_new_error() to use dav_svn__new_error().

Patch by: Jeff Trawick <>
          (Tweaked by me.)