Uwe Stuehler <uwe@bsdx.de>


Patch Review
r1087635, r997777, r997741, r965551, r963741 r1304332

r1304332 | stsp | 2012-03-23 08:23:33 -0500 (Fri, 23 Mar 2012)

Japanese translation update.  Update human_timestamp_format_suffix
string (see subversion/libsvn_subr/time.c:85) to be consistent with the
way the date and day of week are normally presented.

* subversion/po/ja.po: Update msgstr.

Patch by: Berin Babcock-McConnell <spectre683@users.sourceforge.net>
Review by: Uwe Stuehler <uwe@bsdx.de>

I don't know any Japanese myself but the above two people do :)


r1087635 | rhuijben | 2011-04-01 04:58:38 -0500 (Fri, 01 Apr 2011)

Fix cmdline tests when configured without --enable-maintainer-mode.

* subversion/tests/cmdline/cat_tests.py
  (cat_skip_uncattable): Ignore additional lines of output from
  error reporting in maintainer mode.
* subversion/tests/cmdline/basic_tests.py
  (ls_multiple_and_non_existent_targets, add_multiple_targets,
  info_multiple_targets, blame_multiple_targets): Ignore additional
  lines of output from error reporting in maintainer mode.

Patch by: Uwe Stuehler <subversion-lists(_AT_)bsdx.de>


r997777 | cmpilato | 2010-09-16 10:03:15 -0500 (Thu, 16 Sep 2010)

Follow-up to r965551 on issue #3620: svn add ^/ triggers assertion
failure

* subversion/libsvn_client/cleanup.c
  (svn_client_upgrade): Check that path isn't a URL.

Patch by: Uwe Stuehler <uwe@bsdx.de>

r997741 | cmpilato | 2010-09-16 08:26:14 -0500 (Thu, 16 Sep 2010)

Follow-up to r965551 on issue #3620: svn add ^/ triggers assertion
failure

* subversion/svn/upgrade-cmd.c
  (svn_cl__upgrade): Check that target arguments aren't URLs before
    upgrading.

* subversion/tests/cmdline/input_validation_tests.py: New test for
    "upgrade".

Patch by: Uwe Stuehler <uwe@bsdx.de>

r965551 | stsp | 2010-07-19 11:27:09 -0500 (Mon, 19 Jul 2010)

As part of addressing issue #3620, make 'svn add' properly validate targets.
This fixes a user-triggerable assertion.

This is just a small start of a comprehensive path/URL input validation audit
that needs to be performed to properly fix issue #3620. So similar commits
for other subcommands will follow.

Also, introduce a new regression test suite for testing input validation.
This only tests 'svn add' for now, but more tests will follow.

Input validation is done both right beneath the client API layer and
within the CLI client. This makes sure that our CLI client behaves well,
i.e. it won't ask the client library to perform operations it knows might
fail due to invalid input. The checks within the client library help third-
party clients which don't perform proper input validation even though they
should.

* subversion/libsvn_client/add.c
  (svn_client_add4): Raise an error if the path to be added looks like a URL.

* subversion/svn/add-cmd.c
  (svn_cl__add): Raise an error if any of the targets supplied by the
   user look like URLs. Heed our own API requirements by canonicalizing
   paths before passing them to the client library [Note from the future:
   This part was reverted in r965854 because paths were already canonicalized].
   Rename a subpool to iterpool while here, since the pool is used in a loop.

* subversion/tests/cmdline/input_validation_tests.py: New.

Patch by: Uwe Stuehler <subversion-lists@bsdx.de>
          me


r963741 | stsp | 2010-07-13 09:46:05 -0500 (Tue, 13 Jul 2010)

* subversion/libsvn_client/cmdline.c:
  (check_root_url_of_target): Catch SVN_ERR_WC_PATH_NOT_FOUND in addition
  to other similar error codes, allowing argument processing to continue
  as expected.

Patch by: Uwe Stuehler <subversion-lists@bsdx.de>
log message tweaked by me