Vijayaguru G <vijay@collab.net>


Found Patch Suggested
r981757 r1237779, r1135651, r1126580, r1088602, r1087666, r1076234, r1058237, r1054115, r1052547, r1052505, r1004306, r993102, r982516 r1050449

r1237779 | cmpilato | 2012-01-30 10:57:23 -0600 (Mon, 30 Jan 2012)

Fix a case of reversed logic.

* subversion/libsvn_repos/load-fs-vtable.c
  (change_rev_prop): Use a libsvn_repos wrapper function if property
    validation is required, its libsvn_fs counterpart otherwise; not
    the reverse.

Patch by: Vijayaguru G <vijay{_AT_}collab.net>


r1135651 | philip | 2011-06-14 10:39:58 -0500 (Tue, 14 Jun 2011)

With ra_neon unlocking a file would succeed on the client side
even if the pre-unlock hook prevents the unlock.  Fix to make sure
failed unlock error is always returned to the user.

* subversion/libsvn_ra_neon/lock.c
  (do_unlock): Always return any error.

* subversion/tests/cmdline/lock_tests.py
  (block_unlock_if_pre_unlock_hook_fails): New test.
  (test_list): Add block_unlock_if_pre_unlock_hook_fails to the list.

Patch by: Vijayaguru G <vijay{_AT_}collab.net>


r1126580 | cmpilato | 2011-05-23 11:56:25 -0500 (Mon, 23 May 2011)

Reduce number of RA requests during 'svnsync info'.  (This is the
follow-up to r1126441.)

* subversion/svnsync/main.c
  (info_cmd): Retrieve three properties using one svn_ra_rev_proplist()
    call instead of requesting them one by one.

Patch by:  Vijayaguru G <vijay{_AT_}collab.net>
Inspired by:  ivan

r1088602 | kameshj | 2011-04-04 07:55:38 -0500 (Mon, 04 Apr 2011)

Fix the regression issue triggered by r917523.
The revision r917523 do some url encodings to the paths and uris which are
not url-encoded. But there is one additional url-encoding of an uri which is
already encoded. With this extra encoding, committing a path to slave which has
space in it fails.

* subversion/tests/cmdline/dav-mirror-autocheck.sh
  Add a testcase for a regression issue triggered by r917523.

* subversion/mod_dav_svn/mirror.c
  (dav_svn__location_header_filter): Remove redundant url-encoding of new_uri.

Patch by: Vijayaguru G <vijay{_AT_}collab.net>                                     


r1087666 | philip | 2011-04-01 07:03:52 -0500 (Fri, 01 Apr 2011)

* tools/client-side/svnmucc/svnmucc.c
  (main): Add a 'break' statement to the switch case 'config_inline_opt'

Patch by: Vijayaguru G <vijay{_AT_}collab.net>


r1076234 | kameshj | 2011-03-02 08:47:34 -0600 (Wed, 02 Mar 2011)

Update log_access_verdict to make it work with HTTPD 2.3.x as well as older
server versions with reference to [1]. The function is being called
with APLOG_MARK in few places. The macro APLOG_MARK expands to 2 arguments 
till HTTPD-2.2.x but 3 arguments in HTTPD-2.3-dev, which causes failure
while compiling with HTTPD-2.3-dev. So we need to handle both the cases.

case 1 HTTPD 2.3:
----------------
1.APLOG_USE_MODULE is used to indirectly set APLOG_MODULE_INDEX and APLOG_MARK.
2.The macros LOG_ARGS_SIGNATURE and LOG_ARGS_CASCADE are expanded as formal and
actual arguments to log_access_verdict with respect to APLOG_MARK which has
one additonal parameter module_index through which we can take the advantage of
per-module loglevel configuration introduced in HTTPD 2.3.

case 2 pre-HTTPD 2.3:
--------------------
The macros LOG_ARGS_SIGNATURE and LOG_ARGS_CASCADE expand to FILE and LINE to
make the code compatible with older server versions.

* subversion/mod_authz_svn/mod_authz_svn.c
  (log_access_verdict): Make the macro LOG_ARGS_SIGNATURE as formal parameter
   and use LOG_ARGS_CASCADE as actual parameter from the callers.
 
[1] http://httpd.apache.org/docs/trunk/developer/new_api_2_4.html#upgrading_logging

Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Suggested by: kameshj


r1058237 | stsp | 2011-01-12 11:10:52 -0600 (Wed, 12 Jan 2011)

Pass SCRATCH_POOL to svn_dirent_condense_targets/svn_uri_condense_targets
wherever it is applicable.

* subversion/libsvn_client/delete.c:
  (delete_urls): Pass subpool in the call to svn_uri_condense_targets.
* subversion/libsvn_client/locking_commands.c:
  (organize_lock_targets): Pass subpool in the call to
    svn_uri_condense_targets and svn_dirent_condense_targets.

Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Suggested by: kameshj


r1054115 | kameshj | 2010-12-31 08:24:13 -0600 (Fri, 31 Dec 2010)

Prefix an underscore to the error messages to make it visible to the
translator.

* subversion/libsvn_subr/auth.c
* subversion/svn/util.c
* subversion/svn/propget-cmd.c
* subversion/libsvn_client/delete.c
* subversion/libsvn_client/repos_diff.c
* subversion/svnlook/main.c
* subversion/libsvn_ra_serf/auth_digest.c
* subversion/libsvn_ra_serf/auth.c
* subversion/libsvn_ra_serf/util.c
* subversion/libsvn_ra_serf/win32_auth_sspi.c
* subversion/libsvn_ra_serf/commit.c
* subversion/libsvn_ra_neon/util.c

Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Suggested by: kameshj
Tweaked by: kameshj


r1052547 | kameshj | 2010-12-24 12:33:36 -0600 (Fri, 24 Dec 2010)

Reslove some deprecation warnings:
Make use of 'svn_uri_condense_targets' or 'svn_dirent_condense_targets'
instead of deprecated 'svn_path_condense_targets'.

* subversion/libsvn_client/log.c:
 (svn_client_log5): Use 'svn_uri_condense_targets()' and
  'svn_dirent_condense_targets()'.

* subversion/svn/commit-cmd.c:
  (svn_cl__commit): Use 'svn_dirent_condense_targets()'.
                    
Patch by: Vijayaguru G <vijay{_AT_}collab.net>
Suggested by: kameshj
              Noorul Islam K M <noorul{_AT_}collab.net>


r1052505 | hwright | 2010-12-24 08:00:43 -0600 (Fri, 24 Dec 2010)

Copy *PCOMMON from SCRATCH_POOL to RESULT_POOL in svn_uri_condense_targets()
since we are exiting early when there is exactly one target to work on.

* subversion/libsvn_subr/dirent_uri.c:
  (svn_uri_condense_targets): Copy *PCOMMON into RESULT_POOL for single
    target case.

Patch by: Vijayaguru G <vijay{_AT_}collab.net>


r1050449 | julianfoad | 2010-12-17 10:56:23 -0600 (Fri, 17 Dec 2010)

* subversion/svnversion/main.c
  (help): Update the help text, following the changes of output from
    'exported' to more specific messages that were made in r877617, r935177.

Suggested by: Vijayaguru G <vijay{_AT_}collab.net>

r1004306 | kameshj | 2010-10-04 11:14:17 -0500 (Mon, 04 Oct 2010)

Pass NULL pointer to svn_relpath_basename wherever the returned 
basename need not be allocated in pool.
            
  * subversion/mod_dav_svn/reports/update.c
    (absent_helper, upd_delete_entry):
  * subversion/libsvn_wc/update_editor.c
    (delete_entry):
  * subversion/svnlook/main.c
    (print_tree):
  * subversion/libsvn_client/repos_diff.c
    (absent_directory):
  * subversion/libsvn_ra_neon/commit.c
    (commit_delete_entry):
  * subversion/libsvn_ra_serf/commit.c
    (checkout_dir):
  * subversion/libsvn_repos/node_tree.c
    (add_open_helper):
        Pass NULL pointer to svn_relpath_basename wherever the returned
        basename need not be persistent.

Patch by: Vijayaguru G <vijay_at_collab.net>
Suggested by: me


r993102 | artagnon | 2010-09-06 12:27:59 -0500 (Mon, 06 Sep 2010)

* subversion/svnrdump/svnrdump.c
  (main): Dump only the single specified revision number when only one
  is passed to the '-r' option.
  (svnrdump__cmd_table, svnrdump__options): Track this change in the
  usage strings.

Patch by: Vijayaguru G <vijay@collab.net>


r982516 | stylesen | 2010-08-05 04:30:12 -0500 (Thu, 05 Aug 2010)

Test export of externals (directory/file) with `--native-eol' option which
was having a *bug* and got fixed in r966747 and r981757.

* subversion/tests/cmdline/export_tests.py
  (export_externals_with_native_eol): New test case.
  (test_list): Add the above test.

Patch by: Vijayaguru G <vijay@collab.net>

Tweaked by me (formatting only).


r981757 | rhuijben | 2010-08-03 01:34:50 -0500 (Tue, 03 Aug 2010)

Export with `--native-eol' doesn't work for file externals, while it
did for directory externals. This patch fixes that.

* subversion/libsvn_client/externals.c
   (handle_external_item_change): Make the `--native-eol' work for
    export of file externals by passing the argument obtained, missed
    in r966747.

Found by: Vijayaguru G <vijay{_AT_}collab.net>
Patch by: Kannan R <kannanr{_AT_}collab.net>