Vivek Chenecharry <vivek@collab.net>


Found Patch Suggested
r859877 r862851, r859877, r855145, r855117, r855066, r854973, r854769, r854479, r854360 r855142

r862851 | djh | 2006-12-20 21:57:56 -0600 (Wed, 20 Dec 2006)

On the merge tracking branch: Improve the error message when the path
to sqlite is not passed.

Patch by: Vivek Chenecharry <vivek@collab.net>

* build/generator/gen_win.py
  (parse_options): Make sure the path to sqlite is specified.



r859877 | dlr | 2006-05-24 13:04:16 -0500 (Wed, 24 May 2006)

Fix a hard JVM crash in JavaHL bindings due to a segfault in the C++
code which occurs when a null value is passed from Java-land into the
SVNClient.username() or SVNClient.password() method.

Gory details: The JNI C code (the glue between Java and C++) creates a
JNIStringHolder object, which is implicitly cast to a const char *
when invoking the SVNClient::username() or password() method, which
implicitly invokes a std::string constructor which accepts a const
char * parameter during an "=" assignment, which ends up trying to do
a string length calculation on a NULL value.  Boom!

[ in subversion/bindings/java/javahl/ ]

* native/SVNClient.cpp
  (SVNClient::username, SVNClient::password): When the argument is
   NULL, use the empty string to avoid a segfault.

* src/org/tigris/subversion/javahl/SVNClientInterface.java
  (username, password): Document handling of null argument values.

Patch by: Vivek Chenecharry <vivek@collab.net>
          me
Found by: Vivek Chenecharry <vivek@collab.net>


r855145 | kfogel | 2005-06-16 11:30:08 -0500 (Thu, 16 Jun 2005)

More progress on issue #2030: fix 'svn cat' to skip uncattable items.

Patch by: Vivek C. <vivek@collab.net>
(Tweaked by me.)

* subversion/clients/cmdline/cat-cmd.c
  (svn_cl__cat): Skip unversioned items and directories.

* subversion/tests/clients/cmdline/cat_tests.py
  (cat_skip_uncattable): New test.
  (test_list): Run it.


r855142 | cmpilato | 2005-06-16 01:12:34 -0500 (Thu, 16 Jun 2005)

Minor comment tweak.

* subversion/clients/cmdline/notify.c
  Update the file description comment to refer to "notify.c" instead of the
  old "feedback.c".  

Suggested by: Vivek C. <vivek@collab.net>


r855117 | julianfoad | 2005-06-13 12:43:02 -0500 (Mon, 13 Jun 2005)

Make "svn add" skip nonexistent items with a warning.  Use svn_cl__try to
simplify the handling of warnings.  This is part of issue #2030: "Errorful
targets should be skipped, not end the entire operation".

Patch by: Vivek C. <vivek@collab.net>

* subversion/clients/cmdline/add-cmd.c
  (svn_cl__add): Warn if path not found; use svn_cl__try.


r855066 | lundblad | 2005-06-07 02:03:10 -0500 (Tue, 07 Jun 2005)

Use updated interface of svn_cl__try in proplist command.

Patch by: Vivek C. <vivek@collab.net>

* subversion/clients/cmdline/proplist-cmd.c
  (svn_cl__proplist): Remove the variable ignored_success.  Pass NULL
  as the second parameter to svn_cl__try.


r854973 | kfogel | 2005-05-31 17:00:07 -0500 (Tue, 31 May 2005)

Test multiline log messages in the regression suite.

Patch by: Vivek C. <vivek@collab.net>
From issue #2300.

* subversion/tests/clients/cmdline/log_tests.py
 (guarantee_repos_and_wc): Use multiline log messages for
 even-numbered commits.
 (parse_log_output): Store the log message lines in the hash under the
 new key 'lines'.
 (check_log_chain): Check the log message here.
 (log_through_copyfrom_history): Use multiline log messages here.


r854769 | brane | 2005-05-11 13:31:25 -0500 (Wed, 11 May 2005)

Add a regression test for issue #876.

Patch by: Vivek C. <vivek@collab.net>

* subversion/tests/clients/cmdline/revert_tests.py
  (revert_moved_file) A new function to test a moved and
  then reverted file.


r854479 | lundblad | 2005-04-22 08:51:36 -0500 (Fri, 22 Apr 2005)

Fix svn help update to show documentation on broken and stolen locks.

Patch by: Vivek C. <vivek@collab.net>
(Tweaked by me.)

* subversion/clients/cmdline/main.c 
  (svn_cl__cmd_table): Add info to update description.


r854360 | lundblad | 2005-04-18 06:49:35 -0500 (Mon, 18 Apr 2005)

Fix davautocheck.sh failures caused by looking for mod_dav_svn.so
in invalid location.  Add authentication directives to httpd
configuration for lock-tests in 'make davautocheck'.

Patch by: Vivek C. <vivek@collab.net>
          VK Sameer <sameer@collab.net>
(Tweaked by me.)
Review by: Markus Rückert <darix@web.de>
           Max Bowsher <maxb@ukf.net>

* subversion/tests/clients/cmdline/davautocheck.sh
  Docstring fixes.
  (APXS): variable for apxs (value may be from --with-apxs)
  (HTPASSWD): new variable for htpasswd
  (HTTPD): modified to use apxs to locate httpd
  (HTTPD_CFG): add authentication directives for locking tests
  (HTTPD_USERS): new password file variable
  (get_loadmodule_config): use apxs to find LIBEXECDIR instead of
  hard-coding Apache modules directory