Mathias Weinert <wein@mccw.de> (wein)


Patch
r861769, r861758, r861700, r861682, r861681, r861575, r861574, r861542, r861541, r861539, r861512, r861511, r861510, r861509, r861496, r861384, r861227, r861176, r860161, r860136, r860135, r860134, r860113, r860112, r859976, r859973, r859576, r858242, r858215, r858214, r858213, r858212, r858171, r857644, r854050

r861769 | wein | 2006-09-28 14:39:23 -0500 (Thu, 28 Sep 2006)

Some minor corrections regarding property handling in mailer.py's
commit messages.

* tools/hook-scripts/mailer/mailer.conf.example
  Change default values of the property handling parameters
  show_props, ignore_props, generate_propdiffs and ignore_propdiffs
  to show no property changes summary, to show diffs for all property
  changes and to not ignore any property names (and correct a typo).

* tools/hook-scripts/mailer/mailer.py
  (DiffGenerator.__getitem__),
  (PropDiffGenerator._get_diff):
    Change format of the date of /dev/null
    in diffs (which stands for empty/new files and properties).
  (TextCommitRenderer._render_props):
    Move adding of trailing '/' to directory paths out of a if clause
    to ensure that it is applied for every property.
  (TextCommitRenderer._render_propdiffs):
    Use count variables instead of length of list to check if there are
    properties to generate diffs for.

* tools/hook-scripts/mailer/tests/mailer.conf
  Set show_props to an empty value for one group and correct a typo.

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Reflect changes in /dev/null date format in diffs and new show_props
  value for on group in test output.

r861758 | wein | 2006-09-27 14:56:57 -0500 (Wed, 27 Sep 2006)

Add property handling to mailer.py's commit messages.

It is now possible to also report changes of properties (including
diffs) with a commit message. Therefore several new classes were
added to mailer.py. To configure the reporting of property changes
four new parameters are added to mailer.conf. Without adding these
parameters to an existing configuration file no property changes
will be reported.

New configuration parameters:
show_props              configure which property changes to report
                        (valid options are any combination of
                        'add_path add copy_path modify delete_path
                        delete')
ignore_props            configure which property names shall be ignored
                        in the list of changed properties
generate_propdiffs      configure for which property changes diffs
                        shall be created
                        (valid options are any combination of
                        'add_path add copy_path modify delete_path
                        delete')
ignore_propdiffs        configure which property names shall be ignored
                        when creating diffs for changed properties

* tools/hook-scripts/mailer/mailer.py
  New classes:
    PropSelections
    PropDiffSelections
    PropDiffGenerator.
  New functions:
    TextCommitRenderer._get_prop_list
    TextCommitRenderer._render_props
    TextCommitRenderer.__render_props
    TextCommitRenderer._render_propdiffs
    TextCommitRenderer.__render_propdiffs.
  Several appropriate changes to other classes and functions.

* tools/hook-scripts/mailer/mailer.conf.example
  New parameters show_props, ignore_props, generate_propdiffs and
  ignore_propdiffs.

* tools/hook-scripts/mailer/tests/mailer.conf
  New parameters show_props, ignore_props, generate_propdiffs and
  ignore_propdiffs.

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Now containing property changes.

r861700 | wein | 2006-09-24 15:30:52 -0500 (Sun, 24 Sep 2006)

Enhance labels of diffs in mailer.py to contain more information and to
be of better use for patch programs:
- always show the according revision number in brackets after the date
- if available show date and time of the file
  (e. g. for source of modified file)
- add more and specific hints about the file included in brackets after
  the date (e. g. show special texts for copied files)
- use /dev/null and 00:00:00 1970 for empty files so that patch programs
  recognize that the file is new/deleted
  
* tools/hook-scripts/mailer/mailer.py
  (DiffGenerator.__getitem__):
    Get date of base revision (if available) and enhance diff labels with
    more information (as listed above).
  (Repository.get_rev_prop):
    Add optional second parameter to specify a revision for which the
    revision property shall be fetched (default: current revision).

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Adjust to new diff labels.

r861682 | wein | 2006-09-22 14:42:31 -0500 (Fri, 22 Sep 2006)

Improve output of mailer.py by removing carriage returns to avoid
duplicated line breaks and displaying 'Binary file (source and/or
target)' instead of 'Binary files' if a diff of two files contains
binary ones.

* tools/hook-scripts/mailer/mailer.py
  (DiffContent.__getitem__):
    Remove carriage returns (0x0D) from the line to avoid duplicated
    line breaks.
  (TextCommitRenderer._render_diffs):
    - Immediately return if no diff is provided.
    - If a diff contains binary files we don't know for sure if both are
      binary or not, so display 'Binary file (source and/or target)'
      instead of 'Binary files'.

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Now saying 'Binary file (source and/or target). No diff available.'
  for diffs of two files where at least one file is binary.

r861681 | wein | 2006-09-22 14:40:19 -0500 (Fri, 22 Sep 2006)

Cosmetic changes to mailer.py (and the conf file in the test directory).
  
* tools/hook-scripts/mailer/mailer.py
  (Commit.__init__),
  (DiffURLSelections._get_url):
    Shorten lines which are too long.
  (TextCommitRenderer._render_diffs):
    Correct typo in comment for this function.

* tools/hook-scripts/mailer/tests/mailer.conf
  Remove duplicate blank from comment for generate_diffs.

r861575 | wein | 2006-09-14 14:58:13 -0500 (Thu, 14 Sep 2006)

Enhance test t1 for mailer.py by adding two additional configuration
groups with restricted for_path and show_nonmatching_paths set to 'no'
in one group.

* tools/hook-scripts/mailer/tests/mailer.conf
  Add three groups to mailer.py configuration:
  - [All] (replacing default)
  - [file plus other areas] (for_paths = file.*)
  - [file] (for_paths = file.* and show_nonmatching_paths = no)

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Adjust to new configuration groups.

r861574 | wein | 2006-09-14 14:53:17 -0500 (Thu, 14 Sep 2006)

Enhance test t1 for mailer.py:
- Add, copy, modify and delete properties
- Add and modify binary file

* tools/hook-scripts/mailer/tests/mailer-init.sh
  Add commands which do add, copy, modify and delete properties
  and add and modify a binary file.

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Adjust to new repository content/history.

r861542 | wein | 2006-09-12 15:51:23 -0500 (Tue, 12 Sep 2006)

Add support for replaced paths to mailer.py. These paths are now
reported as 'Replaced' and not as 'Added' any more.

* tools/hook-scripts/mailer/mailer.py
  (generate_content):
    Add separate lists for replaced paths.
  (generate_list):
    Add changekind 'R' for replaced paths.
  (TextCommitRenderer.render):
    Add rendering of lists of replaced paths.

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Replaced path in revision 7 now appears as 'Replaced' instead of
  'Added'.

r861541 | wein | 2006-09-12 15:45:44 -0500 (Tue, 12 Sep 2006)

Use new parameter action of class ChangedPath instead of parameter
added and other parameters.

* tools/hook-scripts/mailer.py
  (generate_list)
  (DiffGenerator.__getitem__)

r861539 | wein | 2006-09-12 15:22:16 -0500 (Tue, 12 Sep 2006)

Set property svn:eol-style to native for tools/hook-scripts/mailer/tests/mailer-t1.output to avoid problems with line ending styles.

r861512 | wein | 2006-09-11 14:26:27 -0500 (Mon, 11 Sep 2006)

Remove leading and trailing whitespaces from the log message.

* tools/hook-scripts/mailer.py
  (TextCommitRenderer.render):
    print stripped log message.

r861511 | wein | 2006-09-11 14:24:20 -0500 (Mon, 11 Sep 2006)

Remove a given split character from from_addr and reply_to which is defined
by a leading '[.]' where '.' is the character that should be used instead
of the default whitespaces. This functionality was introduced in revision
21153 for the to_addrs and may also appear with from_addr and/or reply_to
if one map is used for all to_addr, from_addr and/or reply_to.

* tools/hook-scripts/mailer.py
  (MailedOutput.start):
    - Remove a given split character from from_addr and reply_to.
    - Minor changes to comment for splitting of to_addrs.


r861510 | wein | 2006-09-11 14:22:28 -0500 (Mon, 11 Sep 2006)

Remove leading slashes in several paths in output from mailer.py.

* tools/hook-scripts/mailer.py
  (remove_leading_slashes):
    New global function to remove leading slashes from paths (strings).
  (generate_list):
    Apply remove_leading_slashes to base_path.
  (DiffGenerator.__getitem__):
    Apply remove_leading_slashes to several paths.

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Remove all leading slashes in paths.

r861509 | wein | 2006-09-11 14:09:42 -0500 (Mon, 11 Sep 2006)

* tools/hook-scripts/mailer/tests/mailer.conf
  Adopt the changes made to tools/hook-scripts/mailer/mailer.example.conf
  in revisions 21153, 21310 and 21333.

r861496 | rooneg | 2006-09-11 10:43:31 -0500 (Mon, 11 Sep 2006)

Add new 'svnadmin create' option --pre-1.4-compatible to bash_completion.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>
Tweaked by: me

* tools/client-side/bash_completion: Add --pre-1.4-compatible.


r861384 | wein | 2006-08-29 15:12:13 -0500 (Tue, 29 Aug 2006)

Change the interpretation of the generate_diffs option in mailer.py.
'copy' now means 'path is copied and not changed afterwards' and
'modify' now means 'path is modified or a copy of another path that
was modified after copying'.
With this change 'modify' shows *all* modified paths whereas 'copy'
now allows to see diffs for copied paths (which is the whole path (file)
like it is for 'add').

* tools/hook-scripts/mailer/mailer.py
  Interpret the values 'modify' and 'copy' of the generate_diffs option
  as described above. Therefor introduce a new diff kind 'W' for paths
  that were copied and modified afterwards.

* tools/hook-scripts/mailer/mailer.conf.example
  - Add explanation of the possible values of the generate_diffs option
    according to the change described above.
  - Minor corrections in text.

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Reflect change described above.

r861227 | wein | 2006-08-21 13:46:15 -0500 (Mon, 21 Aug 2006)

* tools/hook-scripts/mailer/mailer.py
  Extend to_addr parsing by the possibility to specify a different split
  character by enhancing the to_addr parameter with a leading '[.]'
  where '.' is the character that should be used instead of the default
  whitespaces.

* tools/hook-scripts/mailer/mailer.conf.example
  Add a note to the comment for the to_addr parameter to reflect the
  above mentioned extension of this parameter.

r861176 | cmpilato | 2006-08-17 01:24:41 -0500 (Thu, 17 Aug 2006)

Replace implementation details and user visibility instances of
"remove" with "delete" in mailer.py.  This is partially motivated by a
desire for consistency ("delete" is used more often than "remove"),
and partially to free up namespace of actions-beginning-with-R so that
support for showing "replaced" (that is, deleted and added anew) items
can be added later.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>

* tools/hook-scripts/mailer/mailer.py
  Replace several occurences of "remove" with "delete" as used in
  variable names or script output; also replace the action code 'R' with 'D'.

* tools/hook-scripts/mailer/tests/mailer-t1.output
  Reflect aforementioned mailer.py change in expected output.


r860161 | wein | 2006-06-13 15:06:43 -0500 (Tue, 13 Jun 2006)

Make mailer-init.sh and mailer-t1.sh independent from calling directory.

* tools/hook-scripts/mailer/tests/mailer-init.sh
* tools/hook-scripts/mailer/tests/mailer-t1.sh

r860136 | wein | 2006-06-12 15:28:34 -0500 (Mon, 12 Jun 2006)

* tools/hook-scripts/mailer/tests/mailer-t1.output
  update to current output of mailer.py.

r860135 | wein | 2006-06-12 15:27:22 -0500 (Mon, 12 Jun 2006)

Make diff of mailer.py's output more robust by doing additional
standardizations.

* tools/hook-scripts/mailer/tests/mailer-tweak.py:
  do also tweak author to make output from mailer.py better comparable.

* tools/hook-scripts/mailer/tests/mailer-t1.sh:
  Set time zone to GST to ensure that mailer.py everywhere reports the
    same commit times.
  Convert output from mailer.py to Unix EOL style to make the output
    better comparable.


r860134 | wein | 2006-06-12 15:22:17 -0500 (Mon, 12 Jun 2006)

Add configuration file for mailer.py tests.

* tools/hook-scripts/mailer/tests/mailer.conf:
  Add configuration file to ensure that mailer.py uses the expected
    configuration.

* tools/hook-scripts/mailer/tests/mailer-t1.sh:
  Use provided mailer.conf to ensure that expected configuration
    options are used.


r860113 | wein | 2006-06-10 13:57:47 -0500 (Sat, 10 Jun 2006)

Merge r20038 from trunk to the 1.4.x branch.

* CHANGES
  - correct name of the log-police.py script
  - adjust category of two server side scripts

Approved by: lundblad


r860112 | wein | 2006-06-10 13:43:56 -0500 (Sat, 10 Jun 2006)

* CHANGES
  - correct name of the log-police.py script
  - adjust category of two server side scripts

r859976 | wein | 2006-06-01 14:14:36 -0500 (Thu, 01 Jun 2006)

* tools/hook-scripts/mailer/mailer.py:
  It's now possible to use capital letters in option values which
    will be passed through a map.

* tools/hook-scripts/mailer/mailer.conf.example:
  Add two notes to the description of the mapping process (use of
    names only differing in case, colon ':' is also used as separator)


r859973 | wein | 2006-06-01 13:47:22 -0500 (Thu, 01 Jun 2006)

* COMMITTERS
  (wein): Add myself as partial committer for mailer.

r859576 | djames | 2006-05-03 11:18:28 -0500 (Wed, 03 May 2006)

* tools/hook-scripts/mailer.py
  (TextCommitRenderer.render): Show log message before changed paths, instead
  of after.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>
 


r858242 | maxb | 2006-01-19 08:43:38 -0600 (Thu, 19 Jan 2006)

Mailer.py cleanups.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>

[in tools/hook-scripts/mailer]

* mailer.py: Comment typo fix.
* mailer.conf.example: Add missing full stops.
  (suppress_deletes): Comment out deprecated option.


r858215 | maxb | 2006-01-17 21:07:00 -0600 (Tue, 17 Jan 2006)

Avoid printing 'Diffs of changes in other areas also in this revision:'
when no diffs follow.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>
          me

* tools/hook-scripts/mailer/mailer.py
  (TextCommitRenderer.render): Delegate printing of the diff section header
    to _render_diffs.
  (TextCommitRenderer._render_diffs): Take a section header parameter and
    print it before printing the first diff.


r858214 | maxb | 2006-01-17 20:48:31 -0600 (Tue, 17 Jan 2006)

Fix mailer.py broken feature - for_paths and show_nonmatching_paths=yes.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>
          me

* tools/hook-scripts/mailer/mailer.py (generate_content):
    Remove comma causing erroneous contruction of tuple.
    Change [ ] to None to avoid giving false impression that a sequence is
    required.


r858213 | maxb | 2006-01-17 20:32:14 -0600 (Tue, 17 Jan 2006)

In mailer.py, clarify that we mean revprops, not nodeprops.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>

* tools/hook-scripts/mailer/mailer.py (usage): s/PROPNAME/REVPROPNAME/.


r858212 | maxb | 2006-01-17 20:23:25 -0600 (Tue, 17 Jan 2006)

Avoid possibility of is_canonical assertions caused by mailer.py invocation.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>
          me

* tools/hook-scripts/mailer/mailer.py (canonicalize_for_svn): New.
  (if __name__ == '__main__'): Canonicalize the repository path.


r858171 | malcolm | 2006-01-13 15:51:59 -0600 (Fri, 13 Jan 2006)

Clarify help for the '--clean-logs' option of 'svnadmin hotcopy'.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>
(Tweaked by me.)

Review by: Michael W Thelen <mike@pietdepsi.com>

* subversion/svnadmin/main.c
  (options_table): Make it clear that the --clean-logs option applies
    only to Berkeley DB repositories.


r857644 | dlr | 2005-11-30 15:47:17 -0600 (Wed, 30 Nov 2005)

* contrib/hook-scripts/README
  Add pre-lock-require-needs-lock.py and svn2rss.py.

* tools/hook-scripts/README
  Add commit-email.rb, verify-po.py and path to mailer.py.


Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>
          me


r854050 | philip | 2005-04-06 11:25:01 -0500 (Wed, 06 Apr 2005)

Add option '--full-paths' for 'svnlook tree'.

Patch by: Mathias Weinert <Mathias.Weinert@gfa-net.de>
(Tweaked by me.)

* subversion/svnlook/main.c
  (anonymous enum, options_table, cmd_table, struct svnlook_opt_state,
   struct svnlook_ctxt_t): Add full-paths entries.
  (print_tree, do_tree, get_ctxt_baton, subcommand_tree, main): Add
   full_paths handling.

* subversion/tests/clients/cmdline/svnlook_tests.py
  (test_misc): Compare output with and without --full-paths.