Re: [PATCH] Remove duplicate filenames

Greetings,

On Sun, Feb 09, 2003 at 12:06:13PM +0100, Simon Josefsson wrote:
> Quick'n'dirty patch that replaces entries such as:

A patch to achieve this has been applied. It differs from the one you
supplied because that would blow out duplicate filenames with differing
versions numbers even when version numbers are specified. The patch applied
instead will preserve such duplicates. E.g., what was

------------------------------------

2000-04-14 18:03 tdraier

        * Persistent.java, Persistent.java: debugged setNew()

2000-04-14 17:36 tdraier

        * Persistent.java, Persistent.java: debugged setNew()

2000-04-13 18:06 tdraier

        * Persistent.java, Persistent.java: debugged the setRestoring state

------------------------------------

is now

------------------------------------

2000-04-14 18:03 tdraier

        * Persistent.java: debugged setNew()

2000-04-14 17:36 tdraier

        * Persistent.java: debugged setNew()

2000-04-13 18:06 tdraier

        * Persistent.java: debugged the setRestoring state

------------------------------------

but

------------------------------------

2000-04-14 18:03 tdraier

        * Persistent.java (1.34), Persistent.java (1.6.2.31): debugged
        setNew()

2000-04-14 17:36 tdraier

        * Persistent.java (1.33), Persistent.java (1.6.2.30): debugged
        setNew()

2000-04-13 18:06 tdraier

        * Persistent.java (1.32), Persistent.java (1.6.2.29): debugged the
        setRestoring state

------------------------------------

Remains. I trust this is good for you. I've logged a bug (#31) that the
version numbers for Persistent.java should be collected together.

> Hm, now that I see the entry, I see that it doesn't handle reverting
> back to "reference/libidn-docs.sgml" when there is only one filename:
>
> * reference/libidn-docs.sgml:
>
> Reorder.
>
> Argh. But when there are more than one file, or if it is in the top
> directory, it works. Maybe the second version isn't as bad.

I've opened a separate bug for this (#30), that remains open for now. I will
try to fix it, but as I think you've seen, it's not trivial...

If you have a smallish cvs log that demonstrates this, it would be handy for
testing if you could send it to me.

> OTOH it would be nice to be able to disable the common_dir stuff, the
> colon in the line confuses Emacs' font-lock which makes it highlight
> badly. Indeed, this was the reason I chosed to use --separate-header
> which is non-standard thing too. OK, I added --no-common-dir (second
> patch below) and with it it all looks quite nice even without
> --separate-header.

This has been added verbatim. Cheers!

> Is cvs2cl a GNU package? Perhaps the defaults should be set up to
> generate ChangeLog's according to the FSF Coding Standard. I.e., make
> --no-times --no-common-dir the default.

I've added a --FSF option. Whilst I'd prefer this to be the default, there's
enough cvs2cl users out there that I don't want to change the default format
under them. I hope this is good for you.

All the above changes will appear in 2.47, at a red-bean near you RSN!

Thanks again for your efforts,

Mx.
Received on Tue Mar 11 08:41:32 2003