[svnbook commit] r1902 - trunk/src/en

maxb svnbook-dev at red-bean.com
Sun Dec 11 14:52:26 CST 2005


Author: maxb
Date: Sun Dec 11 14:52:22 2005
New Revision: 1902

Modified:
   trunk/src/en/TODO

Log:
* en/TODO: Register TODO item on example 8.5.


Modified: trunk/src/en/TODO
==============================================================================
--- trunk/src/en/TODO	(original)
+++ trunk/src/en/TODO	Sun Dec 11 14:52:22 2005
@@ -57,6 +57,12 @@
 NEEDED SOMETIME (NOT VERSION-SPECIFIC)
 ============================================================================
 
+  * Example 8.5 (pool usage) is very odd.  It uses svn_pool_foo() wrappers,
+    yet uses apr_status_t, not svn_error_t, error handling.  This is weird.
+    Since it is attempting to demonstrate proper Subversion pool coding style,
+    it ought to be using SVN_ERR() and svn_error_t everywhere.  Might also
+    want to use APR_ARRAY_PUSH().
+    
   * Fill in the "### boilerplate" stuff we left for O'Reilly.  No
     reason for the book, printed or otherwise, to not include
     information about feeding bugs back into the svnbook OS community.




More information about the svnbook-dev mailing list