[svnbook commit] r1448 - trunk/src/en/book

C. Michael Pilato cmpilato at red-bean.com
Wed Jun 15 17:55:37 CDT 2005

sussman wrote:

>Author: sussman
>Date: Wed Jun 15 16:17:28 2005
>New Revision: 1448
>   trunk/src/en/book/ch07.xml
>* src/en/book/ch07.xml:  continue fleshing out locking section.
>Modified: trunk/src/en/book/ch07.xml
>--- trunk/src/en/book/ch07.xml	(original)
>+++ trunk/src/en/book/ch07.xml	Wed Jun 15 16:17:28 2005
>@@ -1810,11 +1810,11 @@
>     </itemizedlist>
>     <para>Subversion's locking feature is currently limited to files
>-      only; it's not yet possible to recursively reserve access to a
>-      whole directory tree.</para>
>+      only; it's not yet possible to reserve access to a whole
>+      directory tree.</para>

(A good rule of thumb is that a semicolon is a substitute for a comma 
and a conjunction.  In this case, ", and" kiiiinda works, but not really.)

>@@ -1884,8 +1884,15 @@
>         reason for locking the file.  Unlike <command>svn
>         commit</command>, however, <command>svn lock</command> will
>         not demand a message by launching <literal>$EDITOR</literal>
>-        or <literal>$SVN_EDITOR</literal>.  Lock comments are strictly
>-        optional.</para>
>+        or <literal>$SVN_EDITOR</literal>.  Lock comments are
>+        optional, but still recommended to aid communication.</para>
Best to just say "by launching your associated text editor", and leave a 
reference to svn.advanced.confarea.opts.config (which covers the 
"editor-cmd" option, and the environment variables mentioned here).

>+    <sect2 id="svn.advanced.locking.policies">
>+      <title>Locking policies</title>
I'm concerned about this whole section.  There's no precedent for 
detailing the use of repository hooks outside of the repository 
administration chapter.  Perhaps you can find a way to keep the gnarly 
details in the repos admin chapter, but enough fluff in the locking 
section (and pointers to the former) to make sense.  Just a thought.

More information about the svnbook-dev mailing list