[svnbook] r5406 committed - trunk/en/book/ref-svn.xml

[Pavel Lyalyakin]

Fixed in r5410 and r5412.

Thanks for the review. :)

On Fri, Aug 25, 2017 at 1:35 AM, Daniel Shahaf <d.s at daniel.shahaf.name> wrote:
> lyalyakin at users.sourceforge.net wrote on Thu, 24 Aug 2017 11:08 +0000:
>> +++ trunk/en/book/ref-svn.xml 2017-08-24 11:08:57 UTC (rev 5406)
>> @@ -473,6 +473,20 @@
>>          </listitem>
>>        </varlistentry>
>>
>> +      <varlistentry id="svn.ref.svn.sw.force_interactive">
>> +        <term><option>--force-interactive</option></term>
>> +        <listitem>
>> +          <para>Forces <command>svn</command> command-line client to run in
>
> Missing "the" before "svn".
>
>> +            interactive mode when run from scripts and standard input in not
>> +            a terminal device.</para>
>
> I find this sentence confusing.  The command line does not know whether
> it's run from a script or not.  It'd be better to separate the criterion
> ("!isatty(stdin)") from the typical use-case (scripts with no
> controlling tty, such as cron jobs).  Example:
>
>    ... to run in interactive mode when standard input is not a terminal device, ...
>
>> @@ -691,6 +705,13 @@
>>              have Subversion fail than to prompt for more
>>              information.</para>
>>
>> +          <para>Beginning with Subversion 1.8, <command>svn</command>
>> +            command-line client is non-interactive by default when run from
>> +            scripts which are launched in unattended mode.  If standard input
>> +            is not a terminal device, the command-line client runs in
>> +            noninteractive mode.  Pass <option>--force-interactive</option>
>> +            option to make the client run in interactive mode.</para>
>
> Both of the above issues apply to this paragraph as well.
>
> Also, another "the" is needed before the <option/>.
>
> Cheers,
>
> Daniel
>
> _______________________________________________
> svnbook-dev mailing list
> svnbook-dev at red-bean.com
> http://www.red-bean.com/mailman/listinfo/svnbook-dev



-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team