Bert Huijben <>

Found Patch
r29900, r29581 r32497, r32399, r32398, r31846, r31733, r31212, r31211, r31203, r31202, r31174, r31038, r30544, r30091, r28354, r28211, r27955, r26854, r26749, r24449, r23812

r32497 | kfogel | 2008-08-15 14:41:14 -0500 (Fri, 15 Aug 2008)

Make libsvn_ra_neon initialization thread-safe: fix a race condition
where if two neon requests are started at approximately at the same
time, one call starts initializing and the other call thinks
initialization is already completed.

Patch by: Bert Huijben <>
(Minor tweaks by danderson and me.)
Review by: danderson

Bert says "The serf library has a similar race condition; but that is
completely in the serf library code; not in libsvn_ra_serv.  (Already
discussed on irc)".  See the patch thread for more:
   From: "Bert Huijben" <>
   To: <>
   Subject: [Patch] Make neon initialization thread safe
   Date: Fri, 15 Aug 2008 16:11:52 +0200
   Message-ID: \

* subversion/libsvn_ra_neon.c
  (neon_initialized): storage for initialization status
  (initialize_neon): Initialize neon in an atomic context
  (ensure_neon_initialized): Wrapper for calling initialize_neon via
  (svn_ra_neon__open): Call ensure_neon_initialized instead of
    initializing Neon on every request.  

r32399 | kfogel | 2008-08-07 13:11:36 -0500 (Thu, 07 Aug 2008)

* www/getting.html 
  (Windows): Add SlikSVN MSIs.
  (Maintainers): Add Bert Huijben and the SharpSvn project.

Patch by: Bert Huijben <> 

r32398 | kfogel | 2008-08-07 13:10:50 -0500 (Thu, 07 Aug 2008)

* www/links.html (Sites that Offer Subversion Hosting): Add SlikSVN.

Patch by: Bert Huijben <> 

r31846 | kfogel | 2008-06-22 17:22:20 -0500 (Sun, 22 Jun 2008)

Follow up to r31211 and r31212: Always notify valid paths from 
svn_client_lock and svn_client_unlock.

Patch by: Bert Huijben <>

* subversion/libsvn_client/locking_commands.c
  (store_locks_callback): Send the absolute path and directory 
    prefix to the notification handler instead of only the suffix
    of the condensed target.

r31733 | danielsh | 2008-06-14 11:54:39 -0500 (Sat, 14 Jun 2008)

Follow up to r31121: declare NDEBUG when building in release mode on

* build/generator/
  (get_win_defines):  Define NDEBUG when configuration is 'Release'.

Patch by: Bert Huijben <>

r31212 | kfogel | 2008-05-15 13:24:10 -0500 (Thu, 15 May 2008)

* subversion/libsvn_client/commit.c
  (svn_client_commit4): Calculate a new-style notify prefix to pass to
    svn_client__do_commit (no functional change).

Patch by: Bert Huijben <>

r31211 | kfogel | 2008-05-15 12:45:45 -0500 (Thu, 15 May 2008)

Move the creation of final display paths to the CLI notification
handler, to make sure notifications always receive a valid path in the
path field.

Patch by: Bert Huijben <>

* subversion/include/svn_wc.h
  (svn_wc_notify_t): New field path_prefix.

* subversion/libsvn_wc/util.c
  (svn_wc_create_notify, svn_wc_dup_notify): Handle new path_prefix field.

* subversion/libsvn_client/client.h
  (svn_client__do_commit): Document the new handling of notify_path_prefix.

* subversion/libsvn_client/commit_util.c
  (svn_client__do_commit, do_item_commit) Remove local handling of
    notify_path_prefix.  Instead pass path_prefix to the notification

* subversion/svn/notify.c
  (notify): Use the new path_prefix to split the first part of the path
    if it matches the specified prefix.  Don't bother testing for urls
    as the path is documented to be a local path.

r31203 | kfogel | 2008-05-15 11:07:41 -0500 (Thu, 15 May 2008)

* build.conf
  (repos-test): Remove the magic word 'update' from the description to
  allow running the test as non-administrator on Windows Vista.

  Vista checks the file description for specific keywords, such as
  "update", to determine if a file might be a installer and in that
  case prompts the user for administrative privileges.  The
  recommended way to fix this behavior is adding a xml manifest to the
  executable but that would require extensive changes to the build
  scripts. This change is just to stop Vista from being stupid.

Patch by: Bert Huijben <>

r31202 | kfogel | 2008-05-15 11:01:54 -0500 (Thu, 15 May 2008)

* CHANGES (1.5.0): Add line about --with-revprop (issue #1976).

Patch by: Bert Huijben <>
(I tweaked the wording a bit.)

r31174 | kfogel | 2008-05-14 14:44:27 -0500 (Wed, 14 May 2008)

* subversion/include/svn_wc.h
  (svn_wc_notify_t): Document when new fields were added.

Patch by: Bert Huijben <>

r31038 | kfogel | 2008-05-05 20:08:51 -0500 (Mon, 05 May 2008)

* www/links.html (bindings): Add SharpSvn.

Patch by: Bert Huijben <>
(Tweaked by me.)

r30544 | dlr | 2008-04-11 16:52:51 -0500 (Fri, 11 Apr 2008)

A follow-up to r28591 (a fix for issue #3054, 'svn cl foo README; svn
cl foo README' has unexpected output), removing the now-unused
svn_wc_notify_changelist_failed enum element, and changing libsvn_wc
to clear the error it passes to its notification callback. This take
the (undocumented) responsibility for this cleanup off of the library
consumer (who would potentially otherwise leak errors).

* subversion/include/svn_wc.h
  (svn_wc_notify_action_t): Drop svn_wc_notify_changelist_failed.

* subversion/libsvn_wc/adm_ops.c
  (svn_wc_set_changelist): Cleanup the svn_error_t we allocate for the
   svn_wc_notify_changelist_moved case. Rename local variable
   unversioned_err to reassign_err.

* subversion/svn/notify.c
  (notify): Drop handling for the svn_wc_notify_changelist_failed enum
   element, and remove error clearing in the handling for
   svn_wc_notify_changelist_moved (which is now handled by libsvn_wc).

* subversion/bindings/javahl/native/EnumMapper.cpp
  (EnumMapper::mapNotifyAction): Drop handling for the
   svn_wc_notify_changelist_failed enum element.

* subversion/bindings/javahl/src/org/tigris/subversion/javahl/
  (changelist_failed): Remove constant.
  (merge_begin): Renumber constant.

Patch by: Bert Huijben <>
(Tweaked by me.)

r30091 | kfogel | 2008-03-27 13:08:06 -0500 (Thu, 27 Mar 2008)

Make svn_client_propset3 call notify on all updated paths (issue #3147).

Patch by: Bert Huijben <>

* subversion/include/svn_wc.h
  (svn_wc_notify_action_t): Add new enum svn_wc_notify_property_updated.
    Also, add "@since New in 1.5" marker on svn_wc_notify_update_replace.

* subversion/libsvn_client/prop_commands.c
  (propset_walk_baton): Added notify_func and notify_baton.
  (propset_walk_cb): Call notify on all updated paths.
  (svn_client_propset3): Initialize notify_func and notify_baton from
   the client context.

r29900 | lgo | 2008-03-13 16:12:20 -0500 (Thu, 13 Mar 2008)

ra_serf: clean the cached realm string on the session after authentication 
succeeded, so that we know when the server asks credentials the second time. 

Found by: Bert Huijben <>

* subversion/libsvn_ra_serf/util.c
  (handle_response): reset realm string on session.

r29581 | lgo | 2008-02-24 16:57:45 -0600 (Sun, 24 Feb 2008)

ra_serf: Fix authentication fallback mechanism. If the server supports multiple
authentication schemes like NTLM or Basic, just try them one after the other in 
the order as specified by the server in the response headers.

Found by: Bert Huijben <>

* subversion/libsvn_ra_serf/auth.c
  (svn_ra_serf__handle_auth): Parse the Authorization headers in two distinct
   steps, as serf combines them into one separated by comma. Also ignore errors
   in scheme initialisation or handling, instead try the other available 

r28354 | djh | 2007-12-09 14:32:18 -0600 (Sun, 09 Dec 2007)

Only generate X64 platforms on supported visual studio releases (Update
to r26854)

* build/generator/
  (WinGeneratorBase) Only add x64 platform for VS2005 and VS2008
  (move_proj_file) Provide platforms and configs data to project templates.

* build/generator/neon.vcproj.ezt
* build/generator/serf.vcproj.ezt
* build/generator/svn_locale.vcproj.ezt
* build/generator/zlib.vcproj.ezt
  Use platforms to generate project files.

* build/generator/svn_config.vcproj.ezt
  Use platforms and configs data to generate project file.

Patch by: Bert Huijben <>
Found by: Daniel <>

r28211 | djh | 2007-12-03 13:02:22 -0600 (Mon, 03 Dec 2007)

Make generated solution and project files compatible with VS2008 and
MSBuild 3.5 if the --vsnet-version=2008 option is used.

Patch by: Bert Huijben <>

* build/generator/
  Check for new version and use VS2005 solution template

* build/generator/
  Allow more versions and set solution and project version for VS2008
  Fixed a typo in the error case

* build/generator/vc2005_sln.ezt
  Updated to insert "2005" or "2008" based on the selected version.

  Updated --help documentation

r27955 | dlr | 2007-11-20 18:38:35 -0600 (Tue, 20 Nov 2007)

A follow-up to r27572 to fix IPv6 support via apr on Windows.

* subversion/libsvn_subr/win32_crashrpt.c
  Include the winsock2.h header file before windows.h.

Patch by: Bert Huijben <>

r26854 | djh | 2007-09-30 08:29:22 -0500 (Sun, 30 Sep 2007)

Add support for the x64 platform to the Windows build.

* build/generator/
  Added 'x64' platform

* build/generator/neon.vcproj.ezt
* build/generator/serf.vcproj.ezt
* build/generator/svn_config.vcproj.ezt
* build/generator/svn_locale.vcproj.ezt
* build/generator/zlib.vcproj.ezt
  Added 'x64'  debug and release configurations
* build/generator/vcnet_vcproj.ezt
  Fixed platform configuration generation to use [platforms] macro
  instead of 'Win32'
* subversion/libsvn_subr/win32_crashrpt_dll.h
* subversion/libsvn_subr/win32_crashrpt.c
  Use 5.1+ DbgHelp api to enable the crash handler on non x86 cpu's

Patch by: Bert Huijben <>

r26749 | kfogel | 2007-09-22 02:36:29 -0500 (Sat, 22 Sep 2007)

* subversion/include/svn_error_codes.h
  (SVN_ERR_FS_SQLITE_ERROR): Move and renumber, to avoid collision
    with an existing error.

Patch by: Bert Huijben <>

r24449 | dlr | 2007-04-05 11:32:10 -0500 (Thu, 05 Apr 2007)

Fix structure layout of svn_client_ctx_t, which previously resulted in
ABI breakage.

* subversion/include/svn_client.h
  (svn_client_ctx_t): Move log_msg_func3 and log_msg_baton3
   within structure to be compatible with 1.4 and 1.3.

Patch by: Bert Huijben <>
Review by: malcolm

r23812 | zhakov | 2007-03-14 07:19:01 -0500 (Wed, 14 Mar 2007)

Add a new ssl server certificate trust provider for Windows (WinNT and later)
that automatically accepts server certificates with a trusted certificate
chain after validating it with the Windows CryptoApi.

* subversion/include/svn_auth.h
  (svn_auth_get_windows_ssl_server_trust_provider): New prototype.
* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_setup_auth_baton): Register the ssl server trust provider
  on Windows.
* subversion/libsvn_subr/ssl_server_trust_providers.c
  (windows_ssl_server_trust_first_credentials, windows_server_trust_provider,
  svn_auth_get_windows_ssl_server_trust_provider): Implementation of the ssl
  server certificate provider.

Patch by: Bert Huijben <>