Gareth McCaughan <>

Patch Suggested
r845366, r842962 r846665, r846602, r846601

r842962 | kfogel | 2002-08-05 21:57:05 +0000 (Mon, 05 Aug 2002)

Patch by: Gareth McCaughan <>

* key-gen.h
  (SVN_FS__MAX_KEY_SIZE): New #define, to replace the magic number 200
  found in various places. 

* key-gen.c: Include assert.h and string.h.
  (svn_fs__next_key): Add an assertion to ensure that bound is never
  exceeded.  Minor reorganization of the handling of carry-out.

* copies-table.c (svn_fs__reserve_copy_id): Use SVN_FS__MAX_KEY_SIZE.
* nodes-table.c (svn_fs__new_node_id): Same.
* reps-table.c (svn_fs__write_new_rep): Same.
* strings-table.c (get_key_and_bump): Same.
* txn-table.c (allocate_txn_id): Same.

r845366 | kfogel | 2003-03-12 07:36:24 +0000 (Wed, 12 Mar 2003)

Add the --editor-cmd option.  This resolves issue #1180.

Patch by: Gareth McCaughan <>

Gareth's patch added the option for propedit only.  I extended it
after Brane and others pointed out that there's no reason to limit it
to propedit, it should apply to any command needing an editor, such as
ones that use log messages.

* subversion/clients/cmdline/cl.h
  (svn_cl__editor_cmd_opt): New option code in svn_cl__longopt_t.
  (svn_cl__opt_state_t): New field in svn_cl__opt_state_t.
  (svn_cl__edit_externally): New parameter editor_cmd.

* subversion/clients/cmdline/util.c
  (struct log_msg_baton): New field editor_cmd.
  (svn_cl__make_log_msg_baton): Initialize new editor_cmd field.
  (svn_cl__edit_externally): Use new editor_cmd parameter.
  (svn_cl__get_log_message): Take editor_cmd from the log message
    baton, pass it along to svn_cl__edit_externally.

* subversion/clients/cmdline/main.c
  (svn_cl__options): New "editor-cmd" entry.
  (svn_cl__cmd_table): Add the --editor-cmd option to commit,
    copy, delete, import, mkdir, move, and propedit commands.
  (main): Parse the '--editor-cmd' option.

* subversion/clients/cmdline/propedit-cmd.c
  (svn_cl__propedit): Pass opt_state->editor_cmd to

r846601 | fitz | 2003-07-22 04:34:10 +0000 (Tue, 22 Jul 2003)

Convert '...' to real ellipses (&hellip;) in the case where the
ellipsis is not actual Subversion output, input, or part of a command

Suggested by: Gareth McCaughan <>

* appb.xml, ch02.xml, ch04.xml, ch07.xml, ch08.xml: Blah blah blah xml
  blah blah.

r846602 | fitz | 2003-07-22 05:08:17 +0000 (Tue, 22 Jul 2003)

Make capitalization of section titles consistent (follow O'Reilly
style guidelines).

Suggested by: Gareth McCaughan <> 

* appa.xml, appc.xml, appd.xml, ch00.xml, ch01.xml, ch02.xml,
  ch03.xml, ch04.xml, ch05.xml, ch06.xml, ch07.xml, ch08.xml: Blah
  blah blah blah Capitalization blah blah blah consistent blah blah.

r846665 | fitz | 2003-07-28 04:55:49 +0000 (Mon, 28 Jul 2003)

Incorporate a number of book changes.

Suggested by: Gareth McCaughan <>

* doc/book/book/ch03.xml: Changes to 'svn status', 'svn diff', and
  'svn resolve'