Marc Haesen <>

Found Patch Suggested
r1092033, r1076556, r874631, r863223 r877405, r874508, r856376 r856891

r856376 | brane | 2005-09-27 13:02:13 +0000 (Tue, 27 Sep 2005)

Build the Python bindings utility library as a DLL on Windows.

Patch by: Marc Haesen <>
(Tweaked by me.)

* build.conf (libsvn_swig_py): Change msvc-static to 'no'.
* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (SVN_SWIG_SWIGUTIL_PY_C): New define.
* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.h
  (SVN_SWIG_SWIGUTIL_EXPORT): New define for DLL export magic on Windows.
   Use it in every public declaratio in this header.

r856891 | djames | 2005-10-19 14:07:03 +0000 (Wed, 19 Oct 2005)

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (make_ob_pool): Use slightly different syntax to avoid warnings,
  which is more friendly to Visual Studio.

Suggested by: Marc Haesen <>

r863223 | malcolm | 2007-01-21 15:38:57 +0000 (Sun, 21 Jan 2007)

Fix issue #2701: checking out a symlink on Windows fails (regression vs 1.4.x).

Followup to r22720: when creating a symlink on a platform that doesn't
support them, don't use svn_io_file_create() to write out the special
file's contents, since that function won't overwrite an existing file.

Found by: Marc Haesen <>

* subversion/libsvn_subr/subst.c
  (create_special_file_from_stringbuf): Write out the contents of the
    temporary file using the file handle that was originally used to
    create it.
* subversion/tests/cmdline/
  (test_list): checkout_repo_with_symlinks should now pass.

r874508 | hwright | 2008-11-26 17:54:57 +0000 (Wed, 26 Nov 2008)

Fix a misplaced conditional in r34378, and remove the hack in r34398.

Patch by: Marc Haesen <>

* subversion/tests/cmdline/
  (verify_incremental_fsfs): Update expected error output.
* subversion/libsvn_fs_fs/fs_fs.c
  (representation_string): Output the sha1 if our format is greater or equal
    to the supported one, not vice versa.
  (write_final_rev): Remove conditional added in r34398, since the bug is
    no longer present.

r874631 | julianfoad | 2008-12-04 17:28:13 +0000 (Thu, 04 Dec 2008)

Fix a crash (endless loop) introduced in r34480. A reproduction recipe is in

Found by: Marc Haesen <>

* subversion/libsvn_wc/update_editor.c
  (in_skipped_tree): Stop traversing the path upwards when it reaches the
    root directory, as well as when it reaches an empty path.

r877405 | brane | 2009-04-17 17:37:42 +0000 (Fri, 17 Apr 2009)

On Windows, shared libs for Python bindings should be *.pyd not *.dll.

* build/generator/ (TargetSWIG.add_dependencies): Mark Python
  wrapper shared libs as type "pyd" not "lib".
* build/generator/, build/generator/
  (Generator._extension_map): Add mappings for the "pyd" object type.
* packages/python-windows/ (package_data): Search for *.pyd.

Patch by: Marc Haesen <>
(Tweaked by me, from

r1076556 | stefan2 | 2011-03-03 08:44:40 +0000 (Thu, 03 Mar 2011)

As reported here:
the APR does not define APR_SIZEOF_VOIDP properly on Windows x64.
This quickly leads of segfaults.

Therefore, use a chunk data type that is consistent with whatever APR
decides APR_SIZEOF_VOIDP to be.

* subversion/libsvn_diff/diff_file.c:
  (contains_eol, find_identical_prefix, find_identical_suffix):
   replace apr_size_t with apr_uintptr_t
* subversion/libsvn_subr/eol.c:
  (svn_eol__find_eol_start): dito

Reported by:  Marc Haesen <Marc.Haesen{_AT_}> 

r1092033 | rhuijben | 2011-04-14 07:42:51 +0000 (Thu, 14 Apr 2011)

Make the update editor use the right checksum kind for verifying the BASE
pristine when the server does not provide a checksum.

This should resolve the issues
Found by: Marc Haesen <Marc.Haesen{_AT_}>
(which I could not reproduce)

* subversion/libsvn_wc/update_editor.c
  (handler_baton): Document that the source and actual checksum can be of MD5
    or SHA1.
  (window_handler): Update reference.
  (apply_textdelta): Use svn_checksum_t for all checksums to avoid further
    conversions to and from strings. Pass the right checksum kind to