Alexander Thomas <>

Found Patch
r1593916, r872653, r860969 r1446686, r1174761, r1005433, r876374, r875051, r874766, r874765, r873288, r873192, r867592, r857595, r856278, r856088, r855752, r855619, r855592, r855591, r855363, r855139, r854995, r854764, r854475, r854191

r854191 | fitz | 2005-04-11 16:09:28 +0000 (Mon, 11 Apr 2005)

Add test for fail on locking a non-existent file.

Patch by: Alexander Thomas <>
(Tweaked by me.)

* subversion/tests/clients/cmdline/
  (lock_non_existent_file): Added function to test failure on locking
  of non-existent file.

  (test_list): Added lock_non_existent_file to list of tests.

r854475 | jszakmeister | 2005-04-22 10:12:38 +0000 (Fri, 22 Apr 2005)

Fix Issue #2224: "svn copy mydir mydir" in a wc recurses infinitely.

Patch by: Alexander Thomas <>
(Tweaked by me.)

* subversion/libsvn_subr/io.c
  (svn_io_copy_dir_recursively): Limits recursion to one level for
  wc_path copy to itself.

* subversion/tests/clients/cmdline/
  (wc_copy_dir_to_itself): Added function to verify a successful
  copy of a wc path into itself.
  (test_list): Added wc_copy_dir_to_itself.

r854764 | lundblad | 2005-05-11 14:16:51 +0000 (Wed, 11 May 2005)

Add XML output for 'svn blame'.

Patch by: Alexander Thomas <>
(Tweaked by me.)

* subversion/clients/cmdline/blame-cmd.c
  (blame_baton_t): Add sbuf member.
  (blame_receiver_xml, print_header_xml, print_footer_xml): New functions.
  (blame_receiver): Add docstring.
  (svn_cl__blame): Modified for XML output.  Print message about skipped
  binary file to stderr instead of stdout.  Remove error leak.

* subversion/clients/cmdline/main.c
  (svn_cl__cmd_table): Add --xml and --incremental options for blame.

* subversion/clients/cmdline/dtd/blame.dtd: New file.

* subversion/tests/clients/cmdline/
  (blame_binary): Expect warning about skipped file on stderr instead of
  (blame_in_xml): New test.
  (test_list): Add new test.

r854995 | lundblad | 2005-06-01 20:47:41 +0000 (Wed, 01 Jun 2005)

Fix issue 2069 - "svn status" in xml mode.

Patch by: Alexander Thomas <>
(Tweaked by me.)

* subversion/clients/cmdline/cl.h
  (svn_cl__print_status_xml): Added new function prototype.

* subversion/clients/cmdline/status.c
  (generate_status_desc, svn_cl__print_status_xml): New functions.

* subversion/clients/cmdline/main.c
  (svn_cl__cmd_table): Added --incremental and --xml options to
  status subcommand array.

* subversion/clients/cmdline/status-cmd.c
  (struct status_baton): Added new xml_Mode field.
  (print_start_target_xml, print_header_xml, print_footer_xml,
  print_finish_target_xml): New functions.
  (print_status): Print XML in XML mode.
  (svn_cl__status): Print XML in XML mode.  Error if --incremental was used
  without --xml.

* subversion/clients/cmdline/dtd/status.dtd
  New file.

* subversion/tests/clients/cmdline/
  (status_in_xml): New test. 
  (test_list): Added status_in_xml.

* tools/client-side/bash_completion
  (_svn):  Add "--incremental" and "--xml" options to "status"
  for auto-completion.

r855139 | dlr | 2005-06-15 21:21:20 +0000 (Wed, 15 Jun 2005)

* subversion/clients/cmdline/info-cmd.c
  (svn_cl__info): Send warnings to stderr instead of stdout.

Patch by: Alexander Thomas

r855363 | kfogel | 2005-07-07 19:20:02 +0000 (Thu, 07 Jul 2005)

Fix issue #2317: Handle filenames containing '@' compatibly with peg
revision parsing.

Patch by: Alexander Thomas <>

* subversion/libsvn_subr/opt.c
  (svn_opt_parse_path): Treat empty peg revision suffix '@' as
  '@HEAD' or '@BASE', depending on URL or local path respectively.

* subversion/tests/libsvn_subr/opt-test.c
  (test_parse_peg_rev): Expect "foo/bar@" to parse to "foo/bar@BASE".

* subversion/tests/clients/cmdline/
  (basic_peg_revision): New test.
  (test_list): Run it.

r855591 | julianfoad | 2005-07-31 19:32:57 +0000 (Sun, 31 Jul 2005)

Tweak the help for self-consistency.

Patch by: Alexander Thomas <>

* subversion/clients/cmdline/main.c
  (svn_cl__cmd_table): Swap options --incremental and --xml in the help
  output for "blame" for consistency with the other commands that accept them.

r855592 | julianfoad | 2005-07-31 20:38:00 +0000 (Sun, 31 Jul 2005)

Add a regression test for "svn blame" on lines of unknown revision.

Patch by: Alexander Thomas <>

* subversion/tests/clients/cmdline/
  (blame_on_unknown_revision): New test.
  (test_list): Add the test.

r855619 | julianfoad | 2005-08-02 13:22:53 +0000 (Tue, 02 Aug 2005)

Factor out some XML output code in the command-line client.

Patch by: me
          Alexander Thomas <>

* subversion/clients/cmdline/cl.h,
  (svn_cl__xml_tagged_cdata, svn_cl__node_kind_str): New functions.

* subversion/clients/cmdline/blame-cmd.c (blame_receiver_xml),
  subversion/clients/cmdline/log-cmd.c (log_message_receiver_xml),
  subversion/clients/cmdline/status.c (svn_cl__print_status_xml):
    Use svn_cl__xml_tagged_cdata().

* subversion/clients/cmdline/ls-cmd.c
  (kind_str): Remove, to become svn_cl__node_kind_str().
  (print_dirents_xml): Use svn_cl__node_kind_str() and

r855752 | sussman | 2005-08-11 14:02:04 +0000 (Thu, 11 Aug 2005)

Fix issue #2291: 'svn ls -v' should show the existence of repository locks.
Slightly tweaked by sussman.

Patch by:   Alexander Thomas <>
Review by:  sussman

* subversion/include/svn_client.h
  (svn_client_ls3): New prototype.
  (svn_client_ls2): Deprecated.

* subversion/libsvn_client/ls.c
  (svn_client_ls3): Gets lock information and returns it as hash.
  (svn_client_ls2): Modified to call new function.

* subversion/clients/cmdline/ls-cmd.c
  (print_dirents): Print lock information.
  (print_dirents_xml): Print lock information in xml.

* subversion/clients/cmdline/main.c
  Mention locking information in the help text for 'svn ls'.

* subversion/clients/cmdline/dtd/list.dtd
  Updated DTD file.

r856088 | julianfoad | 2005-08-31 13:30:04 +0000 (Wed, 31 Aug 2005)

Add XML output for "svn info".

Patch by: Alexander Thomas <>
(Tweaked by me.)

* subversion/clients/cmdline/dtd/info.dtd
  New DTD.

* subversion/clients/cmdline/main.c
  (svn_cl__cmd_table): Add "--xml" and "--incremental" options for "svn info".

* subversion/clients/cmdline/info-cmd.c
  (print_header_xml): New function.
  (print_footer_xml): New function.
  (schedule_str): New function.
  (print_info_xml): New function.
  (info_receiver): Print XML or traditional output depending on cmdline option.
  (svn_cl__info): Modified for XML output.

* tools/client-side/bash_completion
  (_svn): Add "--xml" and "--incremental" options for "svn info".

r856278 | lundblad | 2005-09-22 13:59:51 +0000 (Thu, 22 Sep 2005)

Fix issue #2276 - 'svn info wcpath@X' or 'svn wcpath -rY' should
return repository lock.

Patch by: Alexander Thomas <>
(Tweaked by me.)

* subversion/libsvn_client/info.c
  (svn_client_info): Check for a repository lock, even if the peg revision
  is not specified or not HEAD.

* subversion/tests/clients/cmdline/
  (repos_lock_with_info): New test.
  (test_list): Add repos_lock_with_info to list of tests.

r857595 | julianfoad | 2005-11-26 17:19:24 +0000 (Sat, 26 Nov 2005)

Fix and improve help text for 'svn propset' and the other prop commands.

Patch by: Alexander Thomas <>
(Corrections by Alex, most other changes by me.)

* subversion/clients/cmdline/main.c
  (svn_cl__cmd_table): Modify help text for pdel, pedit, pget, plist, pset:
    Make their header lines consistent in style with other commands.
    Correct the prop-val syntax for "propset": it's not optional.
    Correct the rev-prop syntax: the target doesn't have to be a URL.
    Mention that the target for a revprop operation is largely irrelevant.
    Use plural "props" in "propget", as in the other commands.

r860969 | ehu | 2006-07-28 21:50:01 +0000 (Fri, 28 Jul 2006)

Prevent failures halfway adding a write-only (sic) file.

Found by: Alexander Thomas <alexander{_AT_}>

* subversion/libsvn_client/add.c
  (add_file): Reorder operations to make sure we fail before adding the
   file (instead of failing *after* addition, but *before* setting

r867592 | kameshj | 2007-10-31 10:21:11 +0000 (Wed, 31 Oct 2007)

Testcase to prove Issue #2973.

* subversion/tests/cmdline/
  (self_reverse_merge): New function.
  (test_list): Add 'self_reverse_merge' as XFail testcase.

Patch by: Alexander Thomas <>
(Tweaked by me.)

r872653 | stylesen | 2008-08-20 12:06:14 +0000 (Wed, 20 Aug 2008)

On the 1.5.x-issue2489 branch:

Backport r32375:32379, r32394, r32396 from trunk to 1.5.x-issue2489 branch
which fixes javahl compilation problems.

Found by: Alexander Thomas <>
Approved by: markphip

r873192 | stylesen | 2008-09-17 07:27:10 +0000 (Wed, 17 Sep 2008)

Remove direct dependency to D-Bus library in GNOME Keyring.

* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
  (gnome_keyring_password_get, gnome_keyring_password_set): Remove
   dbus_bus_get() call.

  Remove checking for dbus library, also remove D-Bus library and
  header from the build.

Patch by: Alexander Thomas <>

*** Reverted in r33182 ***

r873288 | arfrever | 2008-09-20 19:17:34 +0000 (Sat, 20 Sep 2008)

Allow to compile against D-Bus 0.*.

  (GNOME Keyring): Check D-Bus version and append -DDBUS_API_SUBJECT_TO_CHANGE
   to CPPFLAGS when D-Bus 0.* is used.

Patch by: Alexander Thomas <>
(Tweaked by me.)

r874765 | stylesen | 2008-12-12 07:27:01 +0000 (Fri, 12 Dec 2008)

Removes gnome-keyring-result.h to make it compile with
old versions of gnome-keyring.

* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
  Removed reference to the header file.

Patch by: Alexander Thomas <>

r874766 | stylesen | 2008-12-12 07:53:58 +0000 (Fri, 12 Dec 2008)

A negative value to the retry_limit will re-prompt for user credentials
infinite times.

* subversion/libsvn_subr/ssl_client_cert_pw_providers.c
  (ssl_client_cert_pw_prompt_next_cred): Modified not to give up if a
   negative value is given as retry_limit.

* subversion/libsvn_subr/ssl_client_cert_providers.c
  (ssl_client_cert_prompt_next_cred): Modified not to give up if a
   negative value is given as retry_limit.

* subversion/libsvn_subr/username_providers.c
  (username_prompt_next_creds): Modified not to give up if a
   negative value is given as retry_limit.

* subversion/libsvn_subr/simple_providers.c
  (simple_prompt_next_creds): Modified not to give up if a
   negative value is given as retry_limit.

* subversion/include/svn_client.h
* subversion/include/svn_auth.h
  Fix doc to reflect above change.

Patch by: Alexander Thomas <>
Review by: me
(Tweaked by me, only the docs)

r875051 | stylesen | 2008-12-30 10:26:56 +0000 (Tue, 30 Dec 2008)

Prompts for default keyring password if the keyring is locked
and unlocks the keyring.

* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
  (gnome_keyring_baton): New struct.
  (callback_destroy_data_keyring): New helper function to do cleanup.
  (callback_done): New helper function.
  (callback_get_info_keyring): New helper function to handle keyring details.
  (callback_default_keyring): New helper function for getting the default
   keyring name.
  (gnome_keyring_unlock_keyring): New function, which will prompt for
   the keyring password and unlocks the keyring if it is already locked.
  (gnome_keyring_password_get): Use gnome_keyring_unlock_keyring()
   to unlock a keyring and later do the cleanup.
  (gnome_keyring_password_set): Use gnome_keyring_unlock_keyring()
   to unlock a keyring and later do the cleanup.

Patch by: Alexander Thomas <>
(Tweaked by me)

r876374 | stsp | 2009-03-04 11:56:54 +0000 (Wed, 04 Mar 2009)

* build/ 'tr "[:lower:]" "[:upper:]"' is
   locale-dependent and can fail in some cases (seen on Solaris).
   Use [a-z] [A-Z] instead.

Patch by: Alexander Thomas <>
(log message tweaked by me)

r1005433 | stylesen | 2010-10-07 12:47:41 +0000 (Thu, 07 Oct 2010)

On the 'gpg-agent-password-store' branch:

  (SVN_HAVE_GPG_AGENT): Defines when --with-gpg-agent option is passed
   to 'configure'.

Patch by: Alexander Thomas <>

r1174761 | danielsh | 2011-09-23 13:49:03 +0000 (Fri, 23 Sep 2011)

Give a better error message when configured with '--without-zlib'.

* build/ac-macros/zlib.m4
  (SVN_LIB_Z): Look for $withval="no" as well.

Patch by: Alexander Thomas <>
(log message by me)

r1446686 | julianfoad | 2013-02-15 16:57:20 +0000 (Fri, 15 Feb 2013)

Don't break 'make install-tools' if TOOLSDIR is same as BINDIR.

  (INSTALL_EXTRA_TOOLS): Check that target and link_name are not the
    same before creating symlink to svnmucc in BINDIR.

Patch by: Alexander Thomas <alexander{_AT_}>

r1593916 | rhuijben | 2014-05-12 10:00:15 +0000 (Mon, 12 May 2014)

On the 1.7.x-disable_zlib_asm: Disable ZLib assembly optimization on
Windows for whoever enabled it themselves by passing --enable-ml.

* build/generator/templates/build_zlib.ezt
  Remove all support for enabling assembly optimizations.

Found by: Alexander Thomas <alexander{_AT_}>