Bernhard Übelacker <>


r1875680 | jamessan | 2020-03-26 01:44:32 +0000 (Thu, 26 Mar 2020)

Construct KAboutData using QString rather than QStringLiteral

If QStringLiteral is used, then a pointer to the data segment of the
libsvn_auth_kwallet shared library is stored in KAboutData.  On exit, when
KAboutData is being deleted, libsvn_auth_kwallet may have already been
unloaded, causing the destructor to access invalid memory.

* subversion/libsvn_auth_kwallet/kwallet.cpp
  (kwallet_password_get, kwallet_password_set): Replace use of QStringLiteral
   with QString

Patch by: Bernhard Übelacker <bernhardu{_AT_}>