Chris Foote <>

Found Patch Suggested
r875955 r902160, r876941, r876722, r876283, r875813, r875127, r863006, r861001, r858948, r856877, r856782, r847394, r847319, r846517, r846398, r844651 r864363, r849670

r844651 | kevin | 2003-01-24 23:21:42 +0000 (Fri, 24 Jan 2003)

Run hook programs on WIN32. This doesn't quite work right on my XP system,
since I don't actually get the output of a failed pre-commit script.  Instaed I
see "The handle is invalid." Several times.  I thought this was better than the
status quo however, so I'm committing it.

* subversion/libsvn_repos/hooks.c:
  (check_hook_cmd): New function to check for the hook program.
  (svn_repos__hooks_start_commit, svn_repos__hooks_pre_commit,
   svn_repos__hooks_post_commit, svn_repos__hooks_pre_revprop_change,
   svn_repos__hooks_post_revprop_change) : use check_hook_cmd.

Patch by: Chris Foote <>
(Tweaked by me to remove the [admittedly already present] memory leak
if svn_io_check_resolved_path fails.)

r846398 | sussman | 2003-06-24 01:06:50 +0000 (Tue, 24 Jun 2003)

Fix keyword expansion buglet.

Patch by: Chris Foote <>

* subversion/libsvn_wc/translate.c
  (svn_wc__get_keywords): Use the entry->cmt_rev, not entry->revision.

r846517 | philip | 2003-07-10 22:15:51 +0000 (Thu, 10 Jul 2003)

Fix an 'svn cat' bug where keyword expansion substituted values from
the wrong revision.

Patch by: Chris Foote <>
(Regression test by me.)

* subversion/libsvn_client/cat.c (svn_client_cat): Expand keywords
  to the values of the committed revision.

* subversion/tests/clients/cmdline/
  (cat_keyword_expand): New test.

r847319 | rey4 | 2003-09-29 20:43:59 +0000 (Mon, 29 Sep 2003)

Add a windows specific option to gen-make so that the user can specify
a path to the Berkely DB headers and libs.

Patch by: Chris Foote <>

Review by: Branko ─îibej <>
(Pointed out problem using new option on unix.)

  (_usage_exit): Add --with-berkely-db option.
  (__main__): ditto.

* build/generator/
  (parse_options): Add --with-berkely-db option.
  (__init__): Search for libdb4? in the specified dir and then
  the default dirs.
  (map_rootpath): If the path is absolute then use it, else
  prepend the root path.

r847394 | cmpilato | 2003-10-06 22:47:55 +0000 (Mon, 06 Oct 2003)

* doc/book/book/ch05.xml:
  Fix some sample usages of the 'svnadmin dump' commandline.  

Patch by: Chris Foote <>
(Tweaked by me.)

r849670 | jpieper | 2004-05-01 16:25:43 +0000 (Sat, 01 May 2004)

Fix two compiler warnings.

Suggested by: Chris Foote <>

* subversion/libsvn_fs_fs/fs_fs.c
  (hash_read): Remove buf as it is not used in the stream version of

* subversion/libsvn_client/blame.c
  (log_message_receiver): Remove the now unused variable change.

r856782 | djames | 2005-10-14 12:21:01 +0000 (Fri, 14 Oct 2005)

Add a function to duplicate the svn_info_t structure.

* subversion/include/svn_client.h,
  (svn_info_dup): New function to duplicate an svn_info_t.

Patch by: Chris Foote <>
(davidjames made a few minor tweaks)

r856877 | rooneg | 2005-10-18 21:49:03 +0000 (Tue, 18 Oct 2005)

Fix neon warning messages.

Patch by: Chris Foote <>

* build/generator/
  (_find_neon): add newlines to messages that lacked them.

r858948 | dlr | 2006-03-13 19:41:28 +0000 (Mon, 13 Mar 2006)

Add option to archive the backup using gz, bz2 or zip to

* tools/backup/
  Update copyright year, and add imports.

  (archive_map): New dictionary mapping archive types to file

  (usage): New. Print out a usage message.

  Redo command line processing using getopt and add --archive-type
  option to specify the archive type.

  (comparator): If archiving, add the archive extenstion to the regexp
   to find archives as well.

  Step 2, also find archives.
  Step 3, print the error message to stderr.
  Step 4, archive backup.
  Step 5, look for archives to remove as well.

Patch by: Chris Foote <>
(Tweaked by me.)
Review by: me

r861001 | dlr | 2006-08-01 19:48:55 +0000 (Tue, 01 Aug 2006)

Show locking notifications using local path style.

* subversion/svn/notify.c
  (notify): For svn_wc_notify_locked and svn_wc_notify_unlocked, print
   out path_local in the message.

Patch by: Chris Foote <>

r863006 | lgo | 2007-01-08 19:55:26 +0000 (Mon, 08 Jan 2007)

Ensure that the repos path is passed to the hook scripts in local style.

Patch by: Chris Foote <>

* subversion/mod_dav_svn/mod_dav_svn.c
  (dav_svn_path_cmd, dav_svn_parent_path_cmd): Convert the repos path to
    internal style.

* subversion/libsvn_repos/hooks.c
  (svn_repos__hooks_start_commit, svn_repos__hooks_pre_commit,
  svn_repos__hooks_post_commit, svn_repos__hooks_pre_revprop_change,
  svn_repos__hooks_post_revprop_change, svn_repos__hooks_pre_lock,
  svn_repos__hooks_post_lock, svn_repos__hooks_pre_unlock,
  svn_repos__hooks_post_unlock): Convert the repos path to local style.

r864363 | djh | 2007-03-31 02:46:58 +0000 (Sat, 31 Mar 2007)

Replace os.rmtree with the safe_rmtree implementation from the test
suite so that we can remove read-only files on Windows.

Suggested by: Chris Foote <>
              Jens Peters <>

* tools/backup/
  (chmod_tree): New method for setting permissions on a tree.
  (safe_rmtree): New method for dropping possibly read-only directory trees.

r875127 | cmpilato | 2009-01-06 19:34:33 +0000 (Tue, 06 Jan 2009)

Add an 'info' subcommand to svnsync to print the synchronization
information, and also add two tests for it.

* subversion/svnsync/main.c
  (SVNSYNC_OPTS_DEFAULT): Remove 'q' from the default options.
  (svnsync_cmd_table): Add the 'info' subcommand, and add 'q' to the
    list of accepted options for the 'init', 'sync', and 'copy-revprops'
  (info_cmd): New 'info' subcommand handler.

* subversion/tests/cmdline/
  (run_info): New helper function.
  (info_syncronized, info_not_syncronized): New tests.
  (test_list): Add references to new tests.

Patch by: Chris Foote <cafoote{_AT_}>
          (Tweaked by me.)

r875813 | arfrever | 2009-02-08 21:37:46 +0000 (Sun, 08 Feb 2009)

Follow-up to r35665 and r35707:

* subversion/svn_private_config.hw: Move conditional inclusion of Berkeley DB
   header outside of SVN_PRIVATE_CONFIG_HW block.

* subversion/libsvn_fs_base/lock.c:
* subversion/libsvn_fs_base/tree.c: Don't define SVN_WANT_BDB.

Patch by: Chris Foote <>

r875955 | gstein | 2009-02-16 18:18:53 +0000 (Mon, 16 Feb 2009)

When transforming sql files, for the filename parameter, add '.sql' so
that the guard symbols have the proper extension.

* build/generator/
  (WinGeneratorBase._create_sqlite_headers): add .sql to the filename

Found by: Chris Foote <>

r876283 | arfrever | 2009-02-28 20:34:28 +0000 (Sat, 28 Feb 2009)

Follow-up to r35096:
Update paths to svnmucc.

* build/win32/
* tools/client-side/svnmucc/
  (svnmucc_binary, repos_path):
* www/faq.ja.html
* www/faq.zh.html
* www/tools_contrib.html
* www/tools_contrib.zh.html
  (svnmucc_c): Update paths to svnmucc.

Patch by: me
          Chris Foote <>

r876722 | hwright | 2009-03-18 04:29:42 +0000 (Wed, 18 Mar 2009)

  (1.6.0): More editing

Patch by: Chris Foote <>

Found by: Konstantin Kolinko <>

r876941 | hwright | 2009-03-30 20:17:53 +0000 (Mon, 30 Mar 2009)

Remove an include that is not required in svn_wc.h.

Patch by: Chris Foote <>

* subversion/include/svn_wc.h
  Move the include of svn_ra_svn.h to ...
* subversion/libsvn_wc/patch.c
  ... here where it is required.

r902160 | julianfoad | 2010-01-22 16:40:13 +0000 (Fri, 22 Jan 2010)

Make it easy to (re)run specific tests on windows by adding a --test/-t
option. The tests can also specify specific test number(s) to run.

  (_usage_exit): Add the --test/-t option to the help.
  (tests_to_run): New. List of tests to be run by the TestHarness.

* build/
  (_run_test): Break the progname at a '#' and use the rhs as a list of
    test numbers to run.

Patch by: Chris Foote <cafoote{_AT_}>
(tweaked by me)