David Binderman

r1851180, r1836817

r1836817 | brane | 2018-07-27 13:00:44 +0000 (Fri, 27 Jul 2018)

Fix a potential crash in JavaHL.

* subversion/bindings/javahl/native/JNIUtil.cpp
  (JNIUtil::wrappedCreateClientException): Don't store an invalid pointer to
   out-of-scope std::streambuf contents.

Found by: David Binderman
Fixes #4764

r1851180 | brane | 2019-01-12 17:19:56 +0000 (Sat, 12 Jan 2019)

Programming style fixes; no functional change.

* subversion/libsvn_client/upgrade.c (upgrade_externals_from_properties):
   - Rename 'iterpool2' to 'inner_iterpool' to give readers a bit of a semantic
     nudge about its intended use. Also destroy it before the outer iterpool.
   - Move the initialization of externals_parent_url to the point where
     we actually need it, avoiding potentially misleading identical conditional

Found by: David Binderman

(See: https://lists.apache.org/thread.html/02a7cc6a552027fa340428d3dd1781a50024ef18009008e586c7b502@%3Cusers.subversion.apache.org%3E)