Joe Schaefer <joe@sunstarsys.com>


Patch Suggested
r863889 r859639

r863889 | danderson | 2007-03-14 10:51:08 -0500 (Wed, 14 Mar 2007)

Fix a bug in the authz code, related to issue #2388: if the authz global access
check is inconclusive (ie. no decision could be made), access should be denied, 
not authorized.

Patch by: Joe Schaefer <joe@sunstarsys.com>

* subversion/libsvn_repos/authz.c
  (authz_global_parse_section): Continue walking the authz config as long as
    the access is not determined.
  (authz_get_global_access): Return FALSE if the access could not be
    conclusively determined.

* subversion/tests/libsvn_repos/repos-test.c
  (authz): Add a section to the test configuration that triggers the bug. Fix
    the test loop to actually run all unit tests.


r859639 | rooneg | 2006-05-08 16:00:12 -0500 (Mon, 08 May 2006)

Clean up our XML parser via a pool cleanup callback instead of doing it
manually.  This will be more resiliant in the face of errors.

Suggested by: Joe Schaefer <joe@sunstarsys.com>

* contrib/server-side/mod_dontdothat/mod_dontdothat.c
  (dontdothat_filter): Stop cleaning up the parser.
  (clean_up_parser): New helper function.
  (dontdothat_insert_filters): Register a cleanup function to free the
   parser.