julianf


Found Review Suggested
r1661131, r1568349, r1463793, r1412789, r1384392, r1370801, r1329796 r1663837 r1710065, r1476416, r1467326, r1467314, r1412787

r1329796 | danielsh | 2012-04-24 15:34:58 +0000 (Tue, 24 Apr 2012)

* subversion/include/svn_error.h
  (SVN_ERR_ASSERT2): Expand and correct docstring.

Found by: julianf

r1370801 | brane | 2012-08-08 15:13:00 +0000 (Wed, 08 Aug 2012)

* build/transform_config_hw.py (_wincpu_map): s/alfa/alpha/g; add amd64.

Found by: julianf


r1384392 | pburba | 2012-09-13 16:17:26 +0000 (Thu, 13 Sep 2012)

On the inheritable-props branch: Fix linking problem.

Found by: julianf

* subversion/libsvn_ra_svn/client.c
  (parse_iproplist): Instead of svn_ra_get_repos_root2, call its ra_svn
   implmentation ra_svn_get_repos_root to avoid a circular dependency.  See
   http://svn.haxx.se/dev/archive-2012-09/0186.shtml


r1412787 | brane | 2012-11-23 09:04:39 +0000 (Fri, 23 Nov 2012)

* subversion/include/private/svn_string_private.h
  (svn_cstring__similarity): Clarify definition of difference score.

Suggested by: julianf


r1412789 | brane | 2012-11-23 09:06:43 +0000 (Fri, 23 Nov 2012)

* subversion/libsvn_subr/string.c
  (svn_cstring__similarity): Fix svn_string_t initializstion;
   C90 does not allow non-static aggregate initializers.

Found by: julianf


r1463793 | breser | 2013-04-02 23:43:40 +0000 (Tue, 02 Apr 2013)

* subversion/svnserve/serve.c
  (load_authz_config): Fix error leak.

Found by: julianf


r1467314 | danielsh | 2013-04-12 15:40:24 +0000 (Fri, 12 Apr 2013)

* subversion/include/svn_error.h
  (svn_error_symbolic_name): Clarify docstring.

Suggested by: julianf

r1467326 | danielsh | 2013-04-12 15:59:03 +0000 (Fri, 12 Apr 2013)

* subversion/include/svn_error.h
  (svn_error_symbolic_name): Further clarify docstring.

Suggested by: julianf

r1476416 | breser | 2013-04-26 22:07:04 +0000 (Fri, 26 Apr 2013)

Add some comments to the YouCompleteMe changes.

* .ycm_extra_conf.py: Add header mentioning the source and copyright.

* Makefile.in: Comment explaining purpose of compile-commands target.

Suggested by: julianf


r1568349 | breser | 2014-02-14 16:51:18 +0000 (Fri, 14 Feb 2014)

Followup to r1565531, Fix random failure of certs that don't have subjectAltNames.

* subversion/libsvn_ra_serf/util.c
  (ssl_server_cert): Initialize found_san_entry to FALSE.

Found by: julianf
          philip


r1661131 | rhuijben | 2015-02-20 14:26:54 +0000 (Fri, 20 Feb 2015)

Add a regression test for some interesting cases around targets not existing
in specific revisions. Currently accepting this behavior as OK, because this
is how it worked for many revisions.

Found by: julianf

* subversion/tests/cmdline/log_tests.py
  (log_revision_move_copy): New function.
  (test_list): Add log_revision_move_copy.


r1663837 | danielsh | 2015-03-04 01:25:16 +0000 (Wed, 04 Mar 2015)

doxygen: include the svn logo at the top of generated documentation pages.

Review by: julianf

* doc/svn-square.jpg:
    New file.  Alias to site/publish/images/svn-square.jpg, via svn:externals.

* doc/doxygen.conf
  (PROJECT_LOGO): Set to the square logo (was unset).

r1710065 | ivan | 2015-10-22 17:08:26 +0000 (Thu, 22 Oct 2015)

Revv svn_string_from_stream() function and share implementation with
svn_stringbuf_from_stream().

Suggested by: julianf

* subversion/include/svn_io.h
  (svn_string_from_stream2): New.
  (svn_string_from_stream): Deprecate.

* subversion/libsvn_subr/stream.c
  (svn_string_from_stream2): Revv from svn_string_from_stream(): add LEN_HINT
   argument. Use svn_stringbuf_from_stream() as implementation.

* subversion/libsvn_subr/deprecated.c
  (svn_string_from_stream): Call svn_string_from_stream2() with LEN_HINT=0.

* subversion/libsvn_fs_x/reps.c
* subversion/libsvn_wc/old-and-busted.c
* tools/dev/x509-parser.c
  (svn_fs_x__reps_add_base, svn_wc__read_entries_old,
   get_der_cert_from_stream): Use svn_string_from_stream2() with
   LEN_HINT=SVN__STREAM_CHUNK_SIZE. It doesn't increase memory usage because
   we use same pool for SCRATCH and RESULT pool.