Dirck Blaskey <listtarget2@danbala.com>


r873538 | rhuijben | 2008-10-05 21:25:08 +0000 (Sun, 05 Oct 2008)

Use a new filename instead of retrying when opening a unique temporary file
fails on Windows. This removes my favorite example of why retry loops
are evil.

* subversion/libsvn_subr/io.c
  (file_open): Add retry_on_failure argument and only call the 
    WIN32_RETRY_LOOP if its value is TRUE.
  (svn_io_open_unique_file2): Call file_open() with retry_on_failure false to
    retry with a new name on failure.
  (svn_io_file_open): Call file_open with retry_on_failure true to keep the
    original behavior.
Found by: Dirck Blaskey <listtarget2{_AT_}danbala.com>