malcolmr


Suggested
r25555

r25555 | pburba | 2007-06-27 11:27:53 -0500 (Wed, 27 Jun 2007)

Post-bikeshed follow-up to r25554, set TRUE/FALSE, promise only zero/non-zero.

glasser cited Postel's Law: "Be conservative in what you do; be liberal in
what you accept from others."  In other words, only check C-truth-values,
but only set svn_boolean_t values to 0 or 1 in case someone isn't as careful
as you.

Suggested by: malcolmr
              glasser
              cmpilato

* subversion/include/private/svn_wc_private.h
  (svn_wc__props_modified): Clarify docstring, promise only to set switched
  arg to true (non-zero) or false (zero), rather than limiting true values
  to @c TRUE.

* subversion/libsvn_wc/util.c
  (svn_wc__props_modified): Return implementation to something very closely
  resembling pre r25554, but setting switched to only 0 or 1 rather than
  result of strcmp().