Michael W Thelen <mike@pietdepsi.com> (mthelen)

Patch Review Suggested
r861522, r855460, r855202, r854132, r854131, r853342, r852794, r852029, r851868, r851419, r851021, r850803, r850699, r850390, r850258, r850257, r850044, r850043, r850042, r850038, r849970, r849891, r849762, r849698 r858171, r855530 r849308

r849308 | kfogel | 2004-03-30 18:45:22 +0000 (Tue, 30 Mar 2004)

* HACKING: Untabify, and fix a typo.

Suggested by: Michael W Thelen <thelenm@cs.utah.edu>

r849698 | breser | 2004-05-04 23:55:18 +0000 (Tue, 04 May 2004)

Fix typo.

Patch by: Michael W. Thelen <thelenm@cs.utah.edu>

  Typo fix.

r849762 | kfogel | 2004-05-11 22:51:05 +0000 (Tue, 11 May 2004)

Add new FAQ item.

Patch by: Michael W Thelen <thelenm@cs.utah.edu>

* www/project_faq.html
  (change-log-msg): New question and answer on how to change log messages.

r849891 | cmpilato | 2004-05-21 17:06:31 +0000 (Fri, 21 May 2004)

Fix minor sentence structure inconsistencies in the book.  

Patch by: Michael W Thelen <thelenm@cs.utah.edu>

* doc/book/book/ch05.xml
  (svn-ch-5-sect-3.1.2): Change several sentences that begin with
    third-person singular verbs (e.g. "Creates a repository") so they
    start with the verb in the imperative form (e.g. "Create a
    repository").  This is for consistency across all the svnadmin
    subcommand listings.

* doc/book/book/ch06.xml
  (svn-ch-6-table-1): Uncapitalize "viewing" in "Web viewing", for
    consistency with the other items in the table.

* doc/book/book/ch07.xml
  (svn-ch-7-sect-2.3.4): Add a period at the end of the LastChangedBy
    description, for consistency with the other keyword descriptions.

* doc/book/book/ch09.xml:
  (svn-ch-9-sect-1.1): Change imperative verbs to third-person
    singular form, for consistency across all the svn switches.
  (svn-ch-9-sect-1.2): Change third-person singular verbs to
    imperative form, for consistency across all the svn subcommand
    listings.  Also fix missing periods at the ends of sentences.

r849970 | blair | 2004-05-27 04:12:15 +0000 (Thu, 27 May 2004)

Fix typos, missing words, and missing punctuation.

Patch by: Michael W Thelen <thelenm@cs.utah.edu>

* doc/book/book/appb.xml,
* doc/book/book/appc.xml,
* doc/book/book/appd.xml,
* doc/book/book/ch00.xml,
* doc/book/book/ch03.xml,
* doc/book/book/ch04.xml,
* doc/book/book/ch05.xml,
* doc/book/book/ch06.xml,
* doc/book/book/ch07.xml,
* doc/book/book/ch08.xml,
* doc/book/book/ch09.xml:
  Fix minor nits.

r850038 | mthelen | 2004-06-11 07:21:31 +0000 (Fri, 11 Jun 2004)

Add a few missing mentions of first-column 'X' in the svn status output.
This fixes issue #1898.

* doc/book/book/ch03.xml
  (svn-ch-3-sect-4.3.1): Add 'X' to example output of svn status.

* doc/book/book/ch09.xml:
  (svn-ch-9-sect-1.2): Add 'X' to complete svn status reference.

r850042 | mthelen | 2004-06-11 22:44:23 +0000 (Fri, 11 Jun 2004)

Add a sentence to the svnadmin Subcommand Reference.

* doc/book/book/ch09.xml:
  Explicitly state that svnadmin hotcopy is safe to run on a live repository
  that is being accessed by other processes.  The wording is taken almost
  exactly from chapter 5.

r850043 | mthelen | 2004-06-11 22:50:48 +0000 (Fri, 11 Jun 2004)

Fix small inconsistencies in command line examples in the book.

* doc/book/book/appb.xml
  (svn-ap-b-sect-1.2.2): Change 'svn cleanup working-copy' to just 'svn
  cleanup' since the text says to run it from the top of the WC.

* doc/book/book/ch02.xml
  (svn-ch-2-sect-3.1): Change 'ls -a' to 'ls -A' since . and .. are not
  shown in the output.

* doc/book/book/ch03.xml
  (svn-ch-3-sect-4): Change revision 3678 to revision 2499 to be
  consistent with all the other examples.

* doc/book/book/ch04.xml
  (svn-ch-4-sect-2.1): Change trunk/ to trunk because trailing slashes
  are not used that way in other examples.
  (svn-ch-4-sect-6.2): Remove . and .. from ls output (no -a was given).

r850044 | mthelen | 2004-06-11 23:01:02 +0000 (Fri, 11 Jun 2004)

Fix incorrect grammar and awkward phrasing in the book.

* doc/book/book/appb.xml
  (svn-ap-b-sect-1.2.1): Insert a missing "a", and complete an incomplete
  phrase.  Also break up a run-on sentence.
  (svn-ap-b-sect-1.2.8): Remove "which" that breaks the flow of the sentence.

* doc/book/book/ch03.xml
  (svn-ch-3-sect-4.2): Fix an awkward sentence by removing an unnecessary
  parenthetical phrase.
  (svn-ch-3-sect-4.3.1): Change "of file" to "of the file".

* doc/book/book/ch05.xml
  (svn-ch-5-sect-3.1.3): Remove an unnecessary "really" and a redundant "at
  this point".  Rewrite several awkward sentences.

* doc/book/book/ch06.xml
  (svn-ch-6-sect-3.3): Change "as user" to "as the user".
  (svn-ch-6-sect-4): Remove unnecessary "which".
  (svn-ch-6-sect-4.4.2): Change "user" to "the user", and change a few other
  awkward phrases.

* doc/book/book/ch07.xml
  (svn-ch-7-sect-1.1): Remove unnecessary "again"
  (svn-ch-7-sect-1.3.1): Fix an incomplete sentence, and change "semi-colon
  delimited" to "semicolon-delimited".
  (svn-ch-7-sect-2.2): Change "lossage" to "loss".
  (svn-ch-7-sect-2.3.3): Break up run-on sentence with a colon.

* doc/book/book/ch08.xml
  (svn-ch-8-dia-2): Change "Revisioning" to "Versioning".
  (svn-ch-8-sect-1.1, svn-ch-8-sect-1.2.1, svn-ch-8-sect-1.2.3): Add a few
  words to make sentences read better.
  (svn-ch-8-sect-6.4): Remove redundant "actually".

* doc/book/book/ch09.xml
  (svn-ch-9-sect-1.2): Change "in working copy" to "in your working copy".
  Capitalize "id" where it occurs.  Add a few missing words and punctuation.
  (svn-ch-9-sect-3.2): Fix a misleading sentence: svnlook propget shows the
  property values of a file, not the value of the file itself.

r850257 | mthelen | 2004-07-08 19:31:19 +0000 (Thu, 08 Jul 2004)

Fix issue #1949.  Check COPY requests to make sure the user has read access to
the entire subtree of the path being copied.

Approved by sussman.

* subversion/mod_authz_svn/mod_authz_svn.c
  (AUTHZ_SVN_READ_TREE): New access type, requiring read access to a path and
    every location beneath that path.

  (sections_matching_prefix_baton): New baton type for finding config sections
    that match a prefix.

  (parse_authz_lines): Add parens to clarify precedence.

  (find_sections_matching_prefix): New callback function to determine whether
    a config section name matches a prefix.  If it matches, the section name
    is pushed onto an array in the baton.  This is used to find all config
    sections for locations beneath a particular path.

  (check_access_subtree): New function to check access to the subtree beneath
    a path.  Access to the path itself is not checked, and is assumed to be
    allowed.  Access to the subtree is considered to be disallowed only if it
    is restricted by a configuration option in the subtree.  Also, the actual
    existence of locations in the subtree is completely ignored.  If access to
    a location beneath the path is disallowed, all access to the subtree is
    disallowed regardless of whether the restricted location actually exists
    in the repository.

  (check_access): Rearrange the logic of a do-while loop to make it a while
    loop.  Also, if access of AUTHZ_SVN_READ_TREE is required, then call
    check_access_subtree after doing the normal check for read access.

  (req_check_access): Require AUTHZ_SVN_READ_TREE access for the source path
    of a COPY request.

* subversion/include/svn_config.h
  (svn_config_section_enumerator_t): New callback to be called for each
    section in a svn_config_t.

  (svn_config_enumerate_sections): New function that calls a callback for
    each section in a svn_config_t.

  (svn_config_enumerate): Fix a typo in the comment header.

* subversion/libsvn_subr/config.c
  (svn_config_enumerate_sections): New function that calls a callback for
    each section in a svn_config_t.

r850258 | mthelen | 2004-07-08 19:46:46 +0000 (Thu, 08 Jul 2004)

Update a doc comment to use the active voice.

Approved by sussman.

* subversion/mod_authz_svn/mod_authz_svn.c
  (check_access_subtree): Update doc comment to use the active voice rather
    than passive.

r850390 | mthelen | 2004-07-15 06:11:48 +0000 (Thu, 15 Jul 2004)

Fix issue #1805.  Consistently use /path/to/repos (with a leading slash)
throughout Chapter 5 of the book.

* doc/book/book/ch05.xml:
  Change all uses of "path/to/repos" to "/path/to/repos".

r850699 | mthelen | 2004-08-14 07:05:05 +0000 (Sat, 14 Aug 2004)

Add a warning about svnlook and svnadmin to the svn+ssh checklist.

Patch by: Andy Whitcroft <apw@shadowen.org>

* doc/book/book/ch06.xml
  (svn-ch-6-sect-5): Mention that svnlook and svnadmin need to access
   the repository with a sane umask, in addition to svnserve.

r850803 | mthelen | 2004-08-26 02:55:50 +0000 (Thu, 26 Aug 2004)

Fix a typo.

Suggested by: <rengmann@lycos.de>

* doc/book/book/ch03.xml
  (svn-ch-3-sect-5.2.1): Fix a typo.

r851021 | mthelen | 2004-09-14 05:02:22 +0000 (Tue, 14 Sep 2004)

Add a reference to Scmbug, a project that integrates software configuration
management with bug-tracking, and supports Subversion.  Thanks to Kristis
Makris <kristis.makris_at_asu.edu> for the patch.

* doc/book/book/appd.xml
  (svn-ap-d-sect-4): Add a reference to Scmbug.

r851419 | fitz | 2004-10-13 04:04:46 +0000 (Wed, 13 Oct 2004)

Fix typos.

Patch by: mthelen

* notes/locking/locking-functional-spec.txt,
  notes/locking/locking-ui.txt: Fix typos.

r851868 | mthelen | 2004-11-09 02:44:47 +0000 (Tue, 09 Nov 2004)

Fix a typo noticed by Yves Bergeron <yves.bergeron_at_shq.gouv.qc.ca>.

* doc/book/book/ch04.xml
  (svn-ch-4-sect-3.2.3): Fix a typo.

r852029 | mthelen | 2004-11-19 18:08:40 +0000 (Fri, 19 Nov 2004)

* COMMITTERS, HACKING: Update mthelen's email address.

r852794 | mthelen | 2005-01-14 03:38:32 +0000 (Fri, 14 Jan 2005)

Fix a typo.

Suggested by: Dennis Lundberg <dennis.lundberg@mdh.se>

* doc/book/book/ch03.xml
  (svn-ch-3-sect-5.5): Fix a typo.

r853342 | mthelen | 2005-03-05 06:01:04 +0000 (Sat, 05 Mar 2005)

* HACKING: Update the location of the SVN book source and translations,
  which are now located in their own repository.  Also update the example
  Emacs hook that pulls in svnbook.el for editing the book's source files.
  The Emacs hook change was written by kfogel.

  Approved by kfogel.

r854131 | mthelen | 2005-04-08 23:31:13 +0000 (Fri, 08 Apr 2005)

Fix a crash bug.

* subversion/libsvn_ra_dav/session.c (shim_svn_ra_dav__lock): Fix a
  crash by not passing NULL to apr_xml_quote_string when the comment
  is NULL. 

Approved by: lundblad

r854132 | mthelen | 2005-04-08 23:37:34 +0000 (Fri, 08 Apr 2005)

* STATUS: Add r14057.

Approved by: lundblad.

r855202 | mthelen | 2005-06-21 06:50:26 +0000 (Tue, 21 Jun 2005)

* CHANGES: Fix a typo.

Approved by: lundblad

r855460 | mthelen | 2005-07-22 03:20:55 +0000 (Fri, 22 Jul 2005)

* www/hacking.html: Set svn:mime-type to "text/html".

Approved by: kfogel

r855530 | mthelen | 2005-07-27 17:13:27 +0000 (Wed, 27 Jul 2005)

As a followup to r14858, replace some remaining <a> anchors with <div>
elements.  Also change "#wedged-repos" links to "#bdb-recovery".

Patch by: Joshua Varner <jlvarner@gmail.com>
Review by: maxb
Approved by: kfogel

* www/faq.html
  (bdb-recovery): Remove <a> anchor and add a backward compatibility div for
  (stuck-bdb-repos): Remove <a> anchor and add a backward compatibility div
    for "permissions".  Also update a "#wedged-repos" link to "#bdb-recovery".
  (bdblogs, bdb-cannot-allocate-memory, db-recover): Change "#wedged-repos"
    links to "#bdb-recovery".

r858171 | malcolm | 2006-01-13 21:51:59 +0000 (Fri, 13 Jan 2006)

Clarify help for the '--clean-logs' option of 'svnadmin hotcopy'.

Patch by: Mathias Weinert <mathias.weinert@gfa-net.de>
(Tweaked by me.)

Review by: Michael W Thelen <mike@pietdepsi.com>

* subversion/svnadmin/main.c
  (options_table): Make it clear that the --clean-logs option applies
    only to Berkeley DB repositories.

r861522 | mthelen | 2006-09-11 23:07:33 +0000 (Mon, 11 Sep 2006)

* www/hacking.html
  (patch-manager): Change to reflect Hyrum Wright as the new patch manager.