Jonathan Gilbert <>

Patch Review Suggested
r864935, r863824 r861533 r863568, r859379

r859379 | lundblad | 2006-04-11 07:01:02 +0000 (Tue, 11 Apr 2006)

On the nonxml-entries branch: Follow-up to r19299 with a stupid fix and minor

Suggested by: malcolm
              Jonathan Gilbert <>

* subversion/libsvn_wc/README
  (The entries file): Don't try to redefine the meaning of "ASCII control
  character".  Clarify that NULs are not allowed.

r861533 | dlr | 2006-09-12 17:09:23 +0000 (Tue, 12 Sep 2006)

On the merge-tracking branch: Simplify the range combining code by
leveraging a more standard alogrithm.

* subversion/libsvn_subr/mergeinfo.c
  (MIN): New macro.

  (combine_ranges): New simplified equivalent implementation based on
   range overlapping detection algorithm.

Patch by: philip
          Kamesh Jayachandran <>
Reviewed by: Jonathan Gilbert <>

r863568 | malcolm | 2007-02-24 22:10:01 +0000 (Sat, 24 Feb 2007)

svndumpfilter: don't use '%n' in printf strings.

In VS2005, Microsoft has deprecated the use of %n as 'inherently
insecure' and turning it back on requires a special function call.

Suggested by: djh
              Jonathan Gilbert <>

* subversion/svndumpfilter/main.c
  (write_prop_to_stringbuf, output_revision, output_node): Use the return
    value of sprintf() to determine how many characters were written, rather
    than using '%n' at the end of the string.

r863824 | danderson | 2007-03-09 15:16:38 +0000 (Fri, 09 Mar 2007)

Add token rules for authenticated only and anonymous only to the authz 
system, as well as inverted rules.

Patch by: Jonathan Gilbert <>
(Tweaked by me.)

* subversion/libsvn_repos/authz.c
  (authz_line_applies_to_user): New function, factored out of 
    authz_parse_line() and extended to support token authz rules and 
    inverted rules.
  (authz_validate_rule): Reject double negatives and unknown tokens in 

* subversion/libsvn_repos/repos.c
  (create_conf): Add the new authz syntax to the stock authz 
    configuration help text.

r864935 | ivan | 2007-05-01 13:59:04 +0000 (Tue, 01 May 2007)

Change of convention for multiline string literal. No semantics changes.

Patch by: Jonathan Gilbert <>
Tweaked by: me

* subversion/libsvn_repos/repos.c
* subversion/libsvn_subr/config_file.c
* subversion/tests/libsvn_diff/diff-diff3-test.c
* subversion/tests/libsvn_repos/repos-test.c
  (NL) Introduce shorter version of APR_EOL_STR.
  () Replace APR_EOL_STR with NL macro in string literals. Move it to line with
  text and align NL macro to end on the 79th column.