Prabhu Gnana Sundar <pprabhugs@gmail.com> (prabhugs)

r1044016 | philip | 2010-12-09 16:09:08 +0000 (Thu, 09 Dec 2010)

Fix a compiler warning.

* subversion/libsvn_client/update.c
  (update_internal): Call 'svn_client_relocate2' since 'svn_client_relocate'
   is deprecated.

Patch by: Prabhu Gnana Sundar <prabhugs@collab.net>
Suggested by: Kamesh Jayachandran <kamesh@collab.net>

r1049672 | cmpilato | 2010-12-15 19:24:18 +0000 (Wed, 15 Dec 2010)

Make svnrdump display online help a bit more consistently with our
other binaries.

* subversion/svnrdump/svnrdump.c
  (main): Remember whether --help was passed on the command-line, and be more
    intelligent about how help requests are handled, allowing svnrdump to
    show the subommand list and to provide subcommand-specific help, too.

Suggested by: Kamesh Jayachandran <kamesh@collab.net>
Patch by: Prabhu Gnana Sundar <prabhugs@collab.net>
          (Tweaked be me.)

r1049924 | kameshj | 2010-12-16 11:05:55 +0000 (Thu, 16 Dec 2010)

Clear a deprecation warning during "make".

* subversion/svnadmin/main.c
  (subcommand_lslocks): svn_repos_fs_get_locks is deprecated, hence using the
   new svn_repos_fs_get_locks2 with depth as infinity.

Patch by: Prabhu Gnana Sundar <prabhugs@collab.net>
Suggested by: me
Tweaked by: me

r1054583 | kameshj | 2011-01-03 11:11:49 +0000 (Mon, 03 Jan 2011)

Make a mention of '--version' in help command output.
Sanitize 'invalid' options passed after '--version' command.

* subversion/svnrdump/svnrdump.c
  (struct opt_baton_t): New member 'version'.
  (help_cmd): Now "svnrdump help" would display a better header.
  (main)    : Sanitize invalid options passed to "svnrdump --version".

Patch by: Prabhu Gnana Sundar <prabhugs@collab.net>
Suggested by: kameshj
Tweaked by: kameshj

r1055478 | cmpilato | 2011-01-05 15:01:52 +0000 (Wed, 05 Jan 2011)

Teach the --version output from svnadmin, svnlook, svnserve,
svnversion, svnsync, svndumpfilter, and svnrdump to accept --quiet,
which forces display of *only* the version number (the way 'svn
--version --quiet' behaves).

* subversion/svndumpfilter/main.c
  (subcommand_help): Pass option baton 'quiet' state to
    svn_opt_print_help3().
  (main): Handle the --quiet option when supplied with --version.

* subversion/svnversion/main.c
  (version): Add 'quiet' parameter, passed to svn_opt_print_help3().
  (main): Delay handling of --version until all options are parsed,
    and pass --quiet state to updated call to version().

* subversion/svnadmin/main.c
  (subcommand_help): Pass option baton 'quiet' state to
    svn_opt_print_help3().
  (main): Handle the --quiet option when supplied with --version.

* subversion/svnlook/main.c
  (options_table): Add support for --quiet/-q.
  (struct svnlook_opt_state): Add 'quiet' boolean member.
  (subcommand_help): Pass option baton 'quiet' state to
    svn_opt_print_help3().
  (main): Handled the --quiet/-q option in general, and specifically when
    supplied with --version.

* subversion/svnsync/main.c
  (help_cmd): Pass option baton 'quiet' state to svn_opt_print_help3().
  (main): Handle the --quiet option when supplied with --version.

* subversion/svnserve/main.c
  (svnserve__options): Add --quiet/-q option.
  (version): Add 'quiet' parameter, passed to svn_opt_print_help3().
  (main): Delay handling of --version until all options are parsed,
    and pass --quiet state to updated call to version().

* subversion/svnrdump/svnrdump.c
  (version): Add 'quiet' parameter, passed to svn_opt_print_help3().
  (main): Handle the --quiet option when supplied with --version.

Suggested by: kameshj
Patch by: Prabhu Gnana Sundar <prabhugs@collab.net>
          (Tweaked by me.)

r1068411 | kameshj | 2011-02-08 14:25:05 +0000 (Tue, 08 Feb 2011)

XFail testcase for the issue 3781

* subversion/tests/cmdline/authz_tests.py
  (case_sensitive_authz): New XFail test for the issue 3781
  (test_list): Add case_sensitive_authz.

Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
Tweaked by: kameshj

r1068802 | kameshj | 2011-02-09 09:20:34 +0000 (Wed, 09 Feb 2011)

Follow-up to r1068411

* subversion/tests/cmdline/authz_tests.py
  (case_sensitive_authz): Now handles the svnserve errors too.
   Prior to this commit the expected error was more specific to the http
   protocol and testing minute error codes which are *not* a real 
   concern for this test.

Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
Found by: rhuijben

r1126459 | kameshj | 2011-05-23 11:57:01 +0000 (Mon, 23 May 2011)

It has 2 changes.
When creating a repo svnadmin sends the 'config' parameter which is never used
since the 1.0.x and populating 'config' by reading from path where the user
lacks read-access causes vague permission error, hence passing NULL.

Remove the newly introduced(r1080198) --config-option parameter.

* subversion/svnadmin/main.c
  (subcommand_create): Passed NULL instead of the 'config' value since it is
                       never used.
  Pretty much revert r1080198 except for retaining named enum and one more 
  utf8 conversion unrelated to --config-option.

Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
Suggested by: markphip
              me

r1142557 | arwin | 2011-07-04 06:21:10 +0000 (Mon, 04 Jul 2011)

No need of a separate Branch-Milestone file

* BRANCH-README
  Added the milestones for this branch.

* BRANCH-MILESTONES
  Deleted the file and moved the contents to BRANCH-README file

Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>

r1165631 | kameshj | 2011-09-06 12:16:46 +0000 (Tue, 06 Sep 2011)

get-location-segments.py script would now work for self-signed ssl servers too

* tools/examples/get-location-segments.py
  (main): added few auth providers to enable authenticating
          against self-signed ssl servers too (in interactive mode).
  (prompt_func_ssl_unknown_cert): new callback function
  (prompt_func_simple_prompt): new callback function

Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
Reviewed by: me

r1178435 | kameshj | 2011-10-03 16:01:52 +0000 (Mon, 03 Oct 2011)

* tools/client-side/mergeinfo-sanitizer.py: 
  New mergeinfo sanitizer script.

Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
Tweaked/Reviewed by: me

r1189665 | danielsh | 2011-10-27 08:25:40 +0000 (Thu, 27 Oct 2011)

Unbreak the build on C89 platforms.

* subversion/svn/main.c,
  subversion/include/svn_wc.h,
  subversion/libsvn_ra_serf/merge.c,
  subversion/libsvn_ra_serf/locks.c,
  subversion/libsvn_ra_serf/getlocks.c,
  subversion/libsvn_ra_serf/getdate.c,
  subversion/libsvn_ra_serf/blame.c,
  subversion/libsvn_ra_serf/log.c,
  subversion/libsvn_ra_serf/get_deleted_rev.c,
  subversion/libsvn_ra_serf/update.c,
  subversion/libsvn_ra_serf/property.c,
  subversion/libsvn_ra_serf/options.c,
  subversion/libsvn_ra_serf/getlocations.c,
  subversion/libsvn_ra_serf/replay.c,
  subversion/svnsync/main.c,
  subversion/svnrdump/svnrdump.c:
    Remove trailing comma after the last member in enumator lists.

Found by: Peter Johansson <peterandrejohansson{_AT_}gmail.com>
Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
(log message adjusted by me)

r1302424 | cmpilato | 2012-03-19 13:31:19 +0000 (Mon, 19 Mar 2012)

Remove unused library and improve the usage description.

* tools/client-side/mergeinfo-sanitizer.py
  (): Set the 'executable' property, and don't import the unused 're' library.
  (usage): Mention "OPTIONS" in the usage syntax synopsis.

Patch by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>

r1438857 | prabhugs | 2013-01-26 05:42:13 +0000 (Sat, 26 Jan 2013)

* COMMITTERS : Add prabhugs as a partial committer (verify-keep-going branch)

r1439280 | prabhugs | 2013-01-28 07:32:53 +0000 (Mon, 28 Jan 2013)

Create the verify-keep-going branch.

r1439310 | prabhugs | 2013-01-28 09:13:11 +0000 (Mon, 28 Jan 2013)

Add branch readme document.

* BRANCH-README: New file to describe the purpose of the branch.

r1439765 | prabhugs | 2013-01-29 07:34:55 +0000 (Tue, 29 Jan 2013)

Merging r1439433 through r1439754 from trunk to verify-keep-going branch.

r1439801 | prabhugs | 2013-01-29 09:40:41 +0000 (Tue, 29 Jan 2013)

Reverse merged r1439765 and merging r1439280 through r1439797 from trunk into verify-keep-going branch.

r1439812 | prabhugs | 2013-01-29 10:14:37 +0000 (Tue, 29 Jan 2013)

Implement svnadmin verify --keep-going, which would continue the verification
even if there is some corruption, after printing the errors to stderr.

* subversion/svnadmin/svnadmin.c
  (svnadmin__cmdline_options_t): Add keep-going option.

  (svnadmin_opt_state): Add keep-going option.

  (subcommand_verify): Switch to the new svn_repos_verify_fs3 function instead
   of svn_repos_verify_fs2, and pass the keep-going option.

  (repos_notify_handler): Handle svn_repos_notify_failure notification by
   printing warnings to stderr with the respective revision number.

* subversion/include/svn_repos.h
  (svn_repos_notify_action_t): Add svn_repos_notify_failure to notify failure.

  (svn_repos_verify_fs3): Newly added to handle "--keep-going" option.

  (svn_repos_notify_t): Add "err", the error chain which indicates what went
   wrong during verification.

* subversion/libsvn_repos/dump.c
  (svn_repos_verify_fs3): Handle "keep-going". If "keep-going" is TRUE, the
  error message is notified and verification process continues.
  When a repository fails to verify, return an SVN_ERR_REPOS_CORRUPTED error
  message and return a non-zero exit code.

  (notify_verification_error): New function to notify the verification
  failure error message.

  (verify_one_revision): New wrapper function to perform all the error checks for
  a particular revision in one go.

* subversion/libsvn_repos/deprecated.c
  (svn_repos_verify_fs2): Deprecate. Call svn_repos_verify_fs3 with
   keep_going as FALSE by default to keep the old default implementation.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify_keep_going): New test case to test svnadmin verify and the new
  switch --keep-going.

* subversion/include/svn_fs.h 
  (svn_fs_verify_rev): Fix the document string.

r1443718 | julianfoad | 2013-02-07 20:49:42 +0000 (Thu, 07 Feb 2013)

Provide a RegexListOutput class in the test suite to match a list of regular
expressions.

See the dev@ email thread '[PATCH] Support regex in EXPECTED ERR list'
starting 2013-01-23, e.g. <http://svn.haxx.se/dev/archive-2013-01/0433.shtml>
or <http://mail-archives.apache.org/mod_mbox/subversion-dev/201301.mbox/%3C50FF938A.9040007%40collab.net%3E>.

Suggested by: Prabhu Gnana Sundar <prabhugs{_AT_}collab.net>
              breser

* subversion/tests/cmdline/svntest/verify.py
  (RegexListOutput): New class.
  (ExpectedOutput, UnorderedRegexOutput): Tweak comments.

r1445542 | prabhugs | 2013-02-13 10:21:33 +0000 (Wed, 13 Feb 2013)

Merging r1439798 through r1445531 from trunk to verify-keep-going branch.

r1457684 | prabhugs | 2013-03-18 09:35:24 +0000 (Mon, 18 Mar 2013)

Merging r1445532 through r1457675 from trunk to verify-keep-going branch.

r1457766 | prabhugs | 2013-03-18 13:48:55 +0000 (Mon, 18 Mar 2013)

Use RegexListOutput to generate the expected error so that the repository name
is not specified in the expected error list.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify_keep_going): Use RegexListOutput to generate the expected error
  list. The expected error list looks cleaner.

r1464833 | prabhugs | 2013-04-05 05:29:29 +0000 (Fri, 05 Apr 2013)

Merging from r1457676 into verify-keep-going branch.

r1465596 | prabhugs | 2013-04-08 11:47:02 +0000 (Mon, 08 Apr 2013)

Merging r1457676 through r1465586 from trunk into verify-keep-going branch.

r1466809 | prabhugs | 2013-04-11 09:19:27 +0000 (Thu, 11 Apr 2013)

Update the testcase to handle --quiet also.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify_keep_going): Check the behavior of --quiet option.

r1466832 | prabhugs | 2013-04-11 10:41:49 +0000 (Thu, 11 Apr 2013)

Update the BRANCH-README file.

r1489765 | prabhugs | 2013-06-05 09:22:43 +0000 (Wed, 05 Jun 2013)

Merging r1465587 through r1488969 from trunk to verify-keep-going branch.

r1491440 | prabhugs | 2013-06-10 12:49:22 +0000 (Mon, 10 Jun 2013)

Correct the error code value for SVN_ERR_REPOS_CORRUPTED.
Fix the verify-keep-going test case to compare actual stdout and expected stdout.

* subversion/include/svn_error_codes.h
  Set the correct error code value.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify-keep-going): Fix the error code value. Also compare actual stdout
  and expected stdout in addition to stderr comparison.

r1491857 | prabhugs | 2013-06-11 16:08:40 +0000 (Tue, 11 Jun 2013)

Syncing up with the trunk. Merge of r1488970 through r1491841 from trunk into verify-keep-going branch.

r1492238 | prabhugs | 2013-06-12 15:18:15 +0000 (Wed, 12 Jun 2013)

Formatting changes and no functional change except for the test-case.

* subversion/include/svn_error_codes.h
  Change "Repository has corruptions" to "Repository is corrupt", just
  a format change

* subversion/include/svn_repos.h
  (svn_repos_notify_t): Doc string change.
  (svn_repos_verify_fs3): Doc string change.

* subversion/libsvn_repos/dump.c
  (notify_verification_error): No functional change.
  verify_one_revision) Rename scratchpool to scratch_pool.

* subversion/svnadmin/svnadmin.c
  (repos_notify_handler): Formatting changes, no functional change.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify_keep_going): Just inject a new junk-line at the end of the rev 2 file
  to corrupt the revision to support future formats.

Suggested by: stsp

r1492617 | prabhugs | 2013-06-13 10:42:06 +0000 (Thu, 13 Jun 2013)

Formatting changes and no functional change except for the test-case.
Pass False to match_all to handle the debug traces when built with
--enable-maintainer-mode.

* subversion/libsvn_repos/dump.c
  (notify_verification_error) : Format to c90 standards. No functional change.
  (svn_repos_verify_fs3): Remove unused variables.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify_keep_going): Pass False for match_all in RegexListOutput to handle
  the debug traces when built with --enable-maintainer-mode.
  Delete the duplicate exp_err.

r1492637 | prabhugs | 2013-06-13 12:09:24 +0000 (Thu, 13 Jun 2013)

Remove blank lines.

* subversion/libsvn_repos/dump.c
  (verify_one_revision) : Remove blank line.
  (svn_repos_verify_fs3): Remove blank line.
  (svn_repos_verify_fs3): Remove blank line.

r1492651 | prabhugs | 2013-06-13 12:49:49 +0000 (Thu, 13 Jun 2013)

Merge the verify-keep-going branch to trunk.
Implement a new "--keep-going" switch to svnadmin verify. Use this switch to
continue verify even after a repository corruption is seen. Without this
switch the verify process would stop when it sees any repository corruption.

* subversion/include/svn_error_codes.h
  Add a new error code to describe the repository is corrupt.

* subversion/include/svn_repos.h
  (svn_repos_verify_fs3): New function to handle the keepg-goin switch.

* subversion/libsvn_repos/deprecated.c
  (svn_repos_verify_fs2): Deprecated. Call svn_repos_verify_fs3() with keep-going
  as False by default.

* subversion/libsvn_repos/dump.c
  (notify_verification_error): Notify upon repository verification failure.
  (verify_one_revision): Wrapper function to verify a revision.
  (svn_repos_verify_fs3): Handle the keep-going switch. If set True, continue
  the verify process and notify the corruption.

* subversion/svnadmin/svnadmin.c
  Handle keep-going switch.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify_keep_going): Add a few test cases to test the keept-going switch.

* tools/dist/make-deps-tarball.sh
  Just mergeinfo property change.

For a detailed log description refer the branch.

Approved by: stsp

r1493018 | prabhugs | 2013-06-14 10:29:04 +0000 (Fri, 14 Jun 2013)

Fix the build bot failure. Run verify-keep-going test only for fsfs filesystem
since junk value is inserted into rev file.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify_keep_going): Skip this test for bdb filesystem, atleast for now.

Suggested by: breser

r1495930 | prabhugs | 2013-06-24 05:52:34 +0000 (Mon, 24 Jun 2013)

Sync up the branch with trunk.

r1497757 | prabhugs | 2013-06-28 12:56:26 +0000 (Fri, 28 Jun 2013)

Show the summary of corrupt revisions if keep-going is enabled.
--quiet behaves the same irrespective of the value of keep-going.

* subversion/include/svn_repos.h
  (svn_repos_notify_action_t): Add svn_repos_notify_failure_summary and
  svn_repos_notify_summary to show the summary of corruptions.

* subversion/libsvn_repos/dump.c
  (notify_verification_summary): New function to notify the summary title.
  (notify_verification_error_summary): New function to notify the actual
  summary of the corrupt revisions.
  (error_list): New struct with the revnum and the err to show in summary.
  (err_cleanup): Function to cleanup the pool.
  (populate_summary): New function to populate an array of error_lists
  with the respective revnum and err to notify in the summary.
  (svn_repos_verify_fs3): Show the summary of corruptions.

* subversion/svnadmin/svnadmin.c
  (repos_notify_handler): Handle notification of corruption summary
  title and the actual summary of corrupt revisions.

r1498394 | prabhugs | 2013-07-01 12:01:38 +0000 (Mon, 01 Jul 2013)

Do not show summary header if there is no corruption. Also, show the full
error chain in summary.

* subversion/libsvn_repos/dump.c
  (svn_repos_verify_fs3): Show the summary header only if there are corruptions.

* subversion/svnadmin/svnadmin.c
  (repos_notify_handler): Show the full error chain in the error summary.

r1499315 | prabhugs | 2013-07-03 10:49:01 +0000 (Wed, 03 Jul 2013)

Format the summary of corrupt revisions.

* subversion/libsvn_repos/dump.c
  (notify_verification_error_summary): Show the best error message instead of
  the entire error chain in the summary.

* subversion/svnadmin/svnadmin.c
  (repos_notify_handler): Do not print the entire error chain in the summary
  of corrupt revisions.

r1499741 | prabhugs | 2013-07-04 13:11:03 +0000 (Thu, 04 Jul 2013)

Fix the test case to check for summary if keep-going is true.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify_keep_going): Fix the test case's expected output to check for
  the summary if keep-going is true.

* subversion/svnadmin/svnadmin.c
  (repos_notify_handler): Formatting tweak.

r1501136 | prabhugs | 2013-07-09 08:48:43 +0000 (Tue, 09 Jul 2013)

Merging r1495341 through r1501107 from trunk into keep-going branch.

r1584005 | prabhugs | 2014-04-02 12:39:12 +0000 (Wed, 02 Apr 2014)

* COMMITTERS : Changed my e-mail address.