Geoff Richards <>

r862406, r861568, r861552, r859386, r859277

r859277 | dlr | 2006-04-06 17:40:15 +0000 (Thu, 06 Apr 2006)

* subversion/include/svn_delta.h
  (svn_delta_editor_t): Clarify docs for the copyfrom_path parameter
   to vtable functions (it's actually a URI).

Patch by: Geoff Richards <>

r859386 | rooneg | 2006-04-11 20:39:34 +0000 (Tue, 11 Apr 2006)

Minor corrections to the Perl binding in SVN::Fs, with tests.

Patch by: Geoff Richards <>

* subversion/bindings/swig/perl/native/
  (_p_svn_fs_t): add missing 'path' method to bind svn_fs_path.
  (_p_svn_fs_root_t): add new method 'txn_name' as binding for
* subversion/bindings/swig/perl/native/t/2fs.t:
  added tests for the new path() and txn_name() methods, and
  also for the previously untested function SVN::Fs::type().

r861552 | djames | 2006-09-13 13:23:59 +0000 (Wed, 13 Sep 2006)

[ In subversion/bindings/swig/perl/native ]

    Add more documentation for some parts of the Perl API.
    No changes to the actual code, except for some tidying of whitespace.
    There are 'TODO' markers in some of this, but for the most part they
    act as warnings of unexpected behaviour and unimplemented features, so
    it's probably best to leave them in.

Patch by: Geoff Richards <>

r861568 | djames | 2006-09-14 05:54:56 +0000 (Thu, 14 Sep 2006)

Upgrade the SWIG/perl bindings to support binary properties, including 
null bytes. In swigutil_pl.c, we no longer treat "svn_string_t" objects
as null-terminated strings; instead, we look at the length parameter of 
the string to determine its length.

Patch by: Geoff Richards <>

[ In subversion/bindings/swig/perl ]

* libsvn_swig_perl/swigutil_pl.c
  (svn_swig_pl_callback_thunk): Add 't' format code for svn_string_t
  (thunk_change_dir_prop, thunk_change_file_prop): Use 't' format code
  for svn_string_t objects.
  (thunk_get_wc_prop): Don't treat the return value of get_wc_prop as a 
  null-terminated string when we convert it into an svn_string_t; 
  instead, look at its length field.

* native/t/6ra.t, native/t/2fs.t:
  Add a bunch of tests for binary properties. Add additional checks 
  throughout. Fix a few spots where the indentation was off. Some of 
  the new tests are skipped on Windows because they are dependent 
  on a pre-revprop-change hook. The pre-revprop-change hook is a bit
  trickier to setup on Windows and Mac OS 9, so I've punted on that for 
  now by skipping the tests on those platforms.

r862406 | clkao | 2006-11-18 02:50:21 +0000 (Sat, 18 Nov 2006)

Fix leak of space on the Perl argument stack when calling methods in
a Perl class acting as a commit editor.

* subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
  (svn_swig_pl_callback_thunk): Add additional 'PUTBACK' after the
  return value from the Perl function has been popped off the stack.

Patch by: Geoff Richards <>