Stefan Küng <tortoisesvn@gmail.com>


Found Patch Review Suggested
r28331, r27759, r27723, r27335, r25336, r20395, r19971, r19675, r19558, r18665, r18291, r18042, r16796, r16784 r32080, r28613, r28503, r28185, r27996, r27572, r26753, r25521, r24506, r23556, r23269, r22440, r22088, r19335, r18710, r17123, r16829, r16037, r16010, r15948, r6664, r5937, r5936 r28331 r23292, r19479, r17913, r17815, r16626, r13176, r6175, r3728

r32080 | stsp | 2008-07-13 04:02:42 -0500 (Sun, 13 Jul 2008)

* subversion/libsvn_wc/props.c
  (get_existing_prop_reject_file): apr_pstrcat takes varargs
   and needs a sentinel (i.e. terminating NULL) which we didn't pass
   for some reason. Fixes crashes seen by TortoiseSVN users.

Patch by: Stefan Küng <tortoisesvn@gmail.com>
(log message tweaked by me)


r28613 | cmpilato | 2007-12-20 16:04:55 -0600 (Thu, 20 Dec 2007)

Provide a better implementation of the clientstring feature which was
first introduced in r28503 but reverted in r28513 due to a circular
dependency.

The new implementation uses a callback to pull the string from the
client instead of using a static string.

* subversion/include/svn_client.h 
  (svn_client_ctx_t): Add new member variable 'client_name'.

* subversion/include/svn_ra.h
  (svn_ra_get_client_string_func_t): New callback type.
  (svn_ra_callbacks2_t): Add 'get_client_string' vtable member.

* subversion/libsvn_client/ra.c
  (get_client_string): New function.
  (svn_client__open_ra_session_internal): Populate get_client_string'
    vtable member.

* subversion/libsvn_ra_neon/session.c
  (svn_ra_neon__open): Fetch and use the custom client string.

* subversion/libsvn_ra_serf/ra_serf.h
  (svn_ra_serf__connection_t): Add new 'useragent' member.

* subversion/libsvn_ra_serf/serf.c
  (svn_ra_serf__open): Fetch and store the custom client string.

* subversion/libsvn_ra_serf/propfind_buckets.c
  (create_propfind_body): Use the session client string.

* subversion/libsvn_ra_serf/util.c
  (svn_ra_serf__setup_serf_req): Use the session client string.

Patch by: Stefan Kueng <tortoisesvn@gmail.com>
          me


r28503 | epg | 2007-12-15 14:33:37 -0600 (Sat, 15 Dec 2007)

Allow the user-agent string sent over http to be defined by the client.

* subversion/include/svn_ra.h
  (svn_ra_set_client_namestring): new function.
  (svn_ra_get_client_namestring): new function.

* subversion/libsvn_ra/clientstring.c : new file containing these new
                                        functions
* subversion/libsvn_ra_neon/session.c
  (svn_ra_neon__open) : use svn_ra_get_client_namestring to
                        create the useragent string.

* subversion/libsvn_ra_serf/ra_serf.h : add an entry for the useragent
                                        string to the connection struct.

* subversion/libsvn_ra_serf/propfind_buckets.c
  (become_request) : use the useragent string stored in the connection.

* subversion/libsvn_ra_serf/util.c
  (svn_ra_serf__conn_setup) : create the useragent string and store it
                              in the connection struct.
  (svn_ra_serf__setup_serf_req) : use the useragent string of the
                                  connection.

* subversion/bindings/swig/python/tests/ra.py
  (test_namestring): Test these new functions at least somewhat; when
    we can run these tests over non-local RA layers, I guess we could
    parse the request log to verify it's actually being sent...

Patch by: Stefan Kueng <tortoisesvn@gmail.com>
Slight tweaks and Python tests by me


r28331 | dlr | 2007-12-07 15:58:46 -0600 (Fri, 07 Dec 2007)

Fix a bug where the svn:eol-style property could be set to a bogus
value (e.g. via propset/propedit), with annoying repercussions.

Originally reported against TortoiseSVN at
<http://tortoisesvn.tigris.org/servlets/ReadMsg?list=users&msgNo=8535>:

  "When somebody went to switch from trunk to a tag (the tag did not
  have the property), SVN failed at the point that it tried to remove
  the property from their working copy (the error was something like
  "invalid eol-style").  So I removed this property from trunk, got
  the user to manually remove the property from their working copy and
  then they could switch successfully (the property is just merged
  away at that point)."

  But then things got much worse.  Now anyone on trunk who tries to
  update to the head revision is faced with the same error.  The
  work-around of course is that they must all manually delete this
  property."

Subsequently reported against Subversion's own libraries at
<http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=133402>.

* subversion/libsvn_wc/props.c
  (svn_wc_canonicalize_svn_prop): Error out if the value of the
   svn:eol-style property is set, but isn't recognized.

* subversion/tests/cmdline/prop_tests.py
  (inappropriate_props): Extend test to check that an invalid value
   for the svn:eol-style property results in an error.

Found by: Dave Lawrence <dlawrence@ad-holdings.co.uk>
          Stefan Kueng <tortoisesvn@gmail.com>
Reviewed by: Stefan Kueng <tortoisesvn@gmail.com>
             sussman
             dionisos
             glasser


r28185 | lgo | 2007-12-02 11:30:08 -0600 (Sun, 02 Dec 2007)

Fix the Windows build with IPv6 by including the required header files
before <windows.h>.

Patch by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_ra_serf/util.c, 
* subversion/libsvn_ra_serf/win32_auth_sspi.c
* subversion/libsvn_subr/config_win.c
* subversion/libsvn_subr/win32_xlate.c : Include required header files


r27996 | hwright | 2007-11-23 16:42:44 -0600 (Fri, 23 Nov 2007)

Doc string update.

Patch by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/include/svn_config.h
  (svn_config_set): Mention how to remove a config value.


r27759 | lgo | 2007-11-11 11:32:18 -0600 (Sun, 11 Nov 2007)

Fix segmentation violation in the switch client code when switching to the root
of a repository.

Found by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_client/switch.c
  (svn_client__switch_internal): Remove the 'Check to make sure that the switch
   target actually exists.' code. This is now redundant since we use 
   svn_client__ra_session_from_path call to open the ra session.

* subversion/tests/cmdline/switch_tests.py
  (switch_to_root): New test.
  (test_list): Run the new test.


r27723 | dlr | 2007-11-08 14:37:57 -0600 (Thu, 08 Nov 2007)

* subversion/include/svn_client.h
  (svn_client_merge_peg3): Clarify sorting (non-)requirement for the
   RANGES_TO_MERGE rangelist parameter.

Found by: Stefan Küng <tortoisesvn@gmail.com>


r27572 | djh | 2007-11-02 13:49:06 -0500 (Fri, 02 Nov 2007)

Fix to build Subversion with IPv6 support on Windows:
include the <winsock2.h> header file before <windows.h>.

* subversion/libsvn_subr/config_win.c,
  subversion/libsvn_subr/win32_xlate.c
  
Patch by: Stefan Küng <tortoisesvn@gmail.com>



r27335 | dlr | 2007-10-23 13:21:32 -0500 (Tue, 23 Oct 2007)

When merging property values, obtain any conflict resolution callback
supplied by the client, and use it for resolving any property conflicts.

* subversion/libsvn_client/merge.c
  (merge_props_changed): Introduce local variable "ctx" as shortcut
   for "merge_b->ctx".  Replace use of svn_wc_merge_props() with
   svn_wc_merge_props2(), and supply it with "ctx->conflict_func" and
   "ctx->conflict_baton".

Found by: Stefan Küng <tortoisesvn@gmail.com>
          dionisos


r26753 | lgo | 2007-09-22 11:12:18 -0500 (Sat, 22 Sep 2007)

* trunk: Add bugtraq:logregex and bugtraq:url properties to enable TSVN and 
   other svn GUI's to parse our 'Issue #0000' syntax to add a direct link to 
   the issue in the log window (and probably other features, but this is the 
   only one I tested).

Note: Accidental commit of svnsync_tests.py reverted in r26754.

Patch by: Stefan Kung <tortoisesvn@gmail.com>


r25521 | lgo | 2007-06-24 07:01:40 -0500 (Sun, 24 Jun 2007)

Make svn_client_info() return the size or working size of a file or
folder too since this information is already available and comes at no
cost. The information is only available through the API; it's not printed
by 'svn info'.

Patch by: Stefan Küng <tortoisesvn@gmail.com>
Review by: glasser
           dlr
           me
(Tweaked by dlr, me)

* subversion/include/svn_client.h
 (struct svn_info_t): Add members working_size and size.
 (global): Add new define SVN_INFO_SIZE_UNKNOWN for unknown size.

* subversion/libsvn_client/info.c
 (build_info_from_dirent, build_info_from_entry): Adjust accordingly.


r25336 | vgeorgescu | 2007-06-08 12:19:05 -0500 (Fri, 08 Jun 2007)

Fix a svn_depth_t/svn_boolean_t function argument incompatibility.

Found by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_client/externals.c:
  (switch_external): Update the call to svn_client__switch_internal() to pass
   a depth (svn_depth_infinity) instead of a boolean (TRUE).

* subversion/libsvn_client/client.h
  (svn_client__switch_internal): Update declaration to reflect the fact that
   the implementation now takes a depth parameter instead of a boolean.


r24506 | lgo | 2007-04-09 15:26:59 -0500 (Mon, 09 Apr 2007)

Fix an abort when getting status of a special file that is locally replaced by 
a directory (with the same name).

Patch by: Stefan Küng <tortoisesvn@gmail.com>
(tweaks and regression test by me)

* subversion/libsvn_wc/questions.c
  (svn_wc__text_modified_internal_p): finfo.filetype is an enum, not a bitmask.
   small comment fix.

* subversion/tests/cmdline/special_tests.py
  (replace_symlink_with_dir): new test that replaces a special file with a 
   directory. To make it run on Windows I reused the symlink.dump test 
   repository.
  (test_list): add the new test.


r23556 | dlr | 2007-03-02 17:52:45 -0600 (Fri, 02 Mar 2007)

Allow svn_opt_revision_working as svn_opt_revision_t parameter values
to svn_client_cat2().

* subversion/libsvn_client/cat.c
  (svn_client_cat2): Allow svn_opt_revision_working for PEG_REVISION
   and REVISION.

Patch by: Stefan Küng <tortoisesvn@gmail.com>


r23292 | lgo | 2007-01-30 13:13:52 -0600 (Tue, 30 Jan 2007)

Add a define SVN_USE_WIN32_CRASHHANDLER that enables building the crash 
handler, define it by default. 

Suggested by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_subr/cmdline.c
  (svn_cmdline_init): only attach the crash handler when wanted.

* subversion/libsvn_subr/win32_crashrpt.c
* subversion/libsvn_subr/win32_crashrpt.h
* subversion/libsvn_subr/win32_crashrpt_dll.h:
  Make the windows crash handler code conditional on the 
   SVN_USE_WIN32_CRASHHANDLER define.

* build/generator/gen_win.py
  (get_win_defines): add the SVN_USE_WIN32_CRASHHANDLER define on the 
   libsvn_subr target by default.


r23269 | zhakov | 2007-01-27 11:15:52 -0600 (Sat, 27 Jan 2007)

Fix for compiling Subversion on x64.

* subversion/libsvn_subr/config_win.c
  (svn_config__win_config_path, utf8_to_ucs2): Use apr_size_t instead of int.

Patch by: Stefan Küng <tortoisesvn@gmail.com>


r22440 | djh | 2006-11-26 15:09:24 -0600 (Sun, 26 Nov 2006)

Fix a crash bug when using automatic authentication protocols such as SSPI.

Neon automatically tries some auth protocols and bumps the attempt
count without using Subversion's callbacks, so we can't depend
on attempt == 0 the first time we are called.

Patch by: Stefan Kung <tortoisesvn@gmail.com>

* subversion/libsvn_ra_dav/session.c
  (request_auth): Don't depend on the attempt parameter being zero for
  the first auth callback we get from neon, just check the auth state itself.



r22088 | dlr | 2006-10-23 15:09:17 -0500 (Mon, 23 Oct 2006)

Update links to the TortoiseSVN web site.  The old links don't exist
anymore, or (if you're lucky) are forwarded.

* www/faq.html
  (sspi): Update links to the TortoiseSVN site.

Patch by: Stefan Küng <tortoisesvn@gmail.com>
(Tweaked by me.)


r20395 | lundblad | 2006-07-03 17:18:23 -0500 (Mon, 03 Jul 2006)

Don't error out in svn status if a file has inconsistent eol
style.  This was a regression from 1.3.x.

Found by: Stefan Küng <tortoisesvn@gmail.com>


* subversion/libsvn_wc/questions.c
  (compare_and_verify): Ignore inconsistent EOL markers in the
   versioned file (by setting the repair parameter to TRUE when
   creating the translated stream).

* subversion/tests/cmdline/stat_tests.py (inconsistent_eol): New test.
  (test_list): Run it.


r19971 | rooneg | 2006-06-06 14:48:38 -0500 (Tue, 06 Jun 2006)

Don't error out due to inconsistent EOLs when checking to see if a file
has been modified, since the addition of those inconsistent EOLs is in
and of itself a modification, and is sufficient to answer our question.

Found by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_wc/questions.c
  (compare_and_verify): Don't error out from svn_stream_contents_same
   if we get an SVN_ERR_IO_INCONSISTENT_EOL error.


r19675 | rooneg | 2006-05-17 15:01:20 -0500 (Wed, 17 May 2006)

Fix issue 2550, a bug in 'svn log file@BASE'.

Reviewed by: Madan U Sreenivasan <madan@collab.net>
Found by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_client/log.c
  (svn_client_log3): Error out gracefully if a base, committed, or previous
   revision is passed along with a URL.  Use a path to root the ra session
   for those types of revisions instead of a url.

* subversion/tests/cmdline/log_tests.py
  (log_base_peg): New test for logging with a peg rev of BASE.
  (test_list): Add new test.


r19558 | dlr | 2006-05-08 14:59:51 -0500 (Mon, 08 May 2006)

Rather than silently converting 'blame' of a WORKING revision to that
of BASE, return an error explicitly stating that 'blame' of WORKING is
unsupported.

In the future, 'blame' is likely to grow support for WORKING
revisions, with the output style corresponding that of 'cat'.

As this change can only be tested using the API, and the C testing
framework currently lacks support for setting up a WC, something like
the following patch can be used in conjunction with 'svn blame
-rWORKING file' to test:

  --- subversion/svn/main.c	(revision 19556)
  +++ subversion/svn/main.c	(working copy)
  @@ -966,6 +966,10 @@
                                      &(opt_state.end_revision),
                                      opt_arg, pool) != 0)
             {
  +            opt_state.start_revision.kind = svn_opt_revision_working;
  +            opt_state.end_revision.kind = svn_opt_revision_working;
  +            break;
  +
               err = svn_utf_cstring_to_utf8(&utf8_opt_arg, opt_arg, pool);
               if (! err)
                 err = svn_error_createf
  

* subversion/include/svn_client.h
  (svn_client_blame3): Update doc string to reflect the new behavior.


* subversion/libsvn_client/blame.c
  (svn_client_blame3): Return SVN_ERR_UNSUPPORTED_FEATURE for attempts
   to call 'blame' on the WORKING revision.


Found by: Stefan Küng <tortoisesvn@gmail.com>
Suggested by: julianfoad
              cmpilato
Review by: lundblad


r19479 | lundblad | 2006-05-01 11:33:20 -0500 (Mon, 01 May 2006)

In diff --summarize, don't show file with both text and prop modifications
as having only property modifications.

Suggested by: Stefan Küng <tortoisesvn@gmail.com>
              Martin Hauner <martin.hauner@gmx.net>

* subversion/libsvn_client/repos_diff_summarize.c
  (ensure_summarize): Drop the sum_kind parameter.  Initialize the kind to
  normal.
  (add_directory, add_file, apply_textdelta, change_prop): Initialize
  the summary kind if appropriate.


r19335 | rooneg | 2006-04-12 18:09:50 -0500 (Wed, 12 Apr 2006)

Mention the correct APIs that are replacing some functions.

Patch by: Stefan Küng <tortoisesvn@gmail.com>
Tweaked by: me

* subversion/include/svn_client.h
  (svn_client_merge, svn_client_merge_peg): These are replaced by functions
   from libsvn_client, not libsvn_wc...


r18710 | kfogel | 2006-03-03 17:39:15 -0600 (Fri, 03 Mar 2006)

* www/links.html (hosting): Add SourceForge.

Patch by: Stefan Küng <tortoisesvn@gmail.com>
(Edited down by me.)


r18665 | lundblad | 2006-03-01 16:15:32 -0600 (Wed, 01 Mar 2006)

Add a test that fails on the 1.3.x branch.  The bug is that svn list of a
path that is (or needs) URL-encoding won't show locked paths correctly.

Found by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/tests/cmdline/lock_tests.py
  ()ls_url_encoded): New test.
  (test_list): Run it.

r18291 | lundblad | 2006-01-30 08:32:54 -0600 (Mon, 30 Jan 2006)

Fix crash in svn status -u when an ignored directory is also in the repository.

Found by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_wc/status.c (make_dir_baton): Don't try to get status
  of ignored directory.

* subversion/tests/cmdline/stat_tests.py
  (status_ignored_dir): New test.
  (test_list): Run it.


r18042 | rooneg | 2006-01-10 13:56:39 -0600 (Tue, 10 Jan 2006)

Fix crash when trying to access a hTtpS:// URL (i.e. a https:// URL spelled
with some upper case letters).  The problem turns out to be that we use case
insensitive compares for URI schemes, but Neon uses case sensitive ones.

Found by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_ra_dav/session.c
  (svn_ra_dav__open): Force the URI scheme to all lower case before passing
   it on to Neon.


r17913 | djh | 2005-12-21 20:55:10 -0600 (Wed, 21 Dec 2005)

Add a libraries-only build target.

This is useful for GUI (TSVN) clients who may not need or want to
build all the exe's, tests, etc.

Suggested by: Stefan King <tortoisesvn@gmail.com>
Review by: Daniel Rall <dlr@collab.net>

* build.conf
 Add a __LIBS__ build target for our libraries and their dependencies.



r17815 | djh | 2005-12-16 17:12:08 -0600 (Fri, 16 Dec 2005)

Silence many, many warnings when building apr with VS2005.

Suggested by: Stefan King <tortoisesvn@gmail.com>

* build/generator/gen_uri_delims.vcproj.ezt
* build/generator/xml.vcproj.ezt
* build/generator/libaprutil.vcproj.ezt
* build/generator/libapriconv.vcproj.ezt
* build/generator/libapr.vcproj.ezt
  Set preprocessor macro to turn off 'unsafe function' warnings.



r17123 | lundblad | 2005-11-01 05:53:27 -0600 (Tue, 01 Nov 2005)

Make svn info not error out if a path does not exist in a future revision.

Patch by: Stefan Küng <tortoisesvn@gmail.com>
          me
(Test case by me)

NOTE: This cures a bug in libsvn_repos, that we have to work around for
compatibility reasons.

* subversion/libsvn_client/info.c
  (same_resources_in_head): Treat a future revision as unrelated if the path
  doesn't exist in that revision.

* subversion/libsvn_client/client.h (svn_client__repos_locations): Tweak
  docstring to mention another returned error code.

* subversion/tests/clients/cmdline/basic_tests.py
  (info_nonhead): New test.
  (test_list): Run it.


r16829 | rooneg | 2005-10-19 12:43:15 -0500 (Wed, 19 Oct 2005)

Fix broken svn_wc_dup_status2.

Patch by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_wc/status.c
  (svn_wc_dup_status2): copy the url and ood author too.


r16796 | dlr | 2005-10-18 15:58:39 -0500 (Tue, 18 Oct 2005)

A follow-up to r16784, which only fixed handling of directories (not
files).

* subversion/libsvn_wc/status.c
  (change_file_prop): Assure that we actually have a value for file
   properties sent from the repository before trying to use them.


Patch by: pburba
Found by: Stefan Küng <tortoisesvn@gmail.com>
          pburba
Review by: me


r16784 | dlr | 2005-10-18 12:16:47 -0500 (Tue, 18 Oct 2005)

* subversion/libsvn_wc/status.c
  (change_dir_prop): Assure that we actually have a value for
   properties sent from the repository before trying to use them
   (necessitated by r16344).  Only a deleted "svn:author" property has
   actually been known to trigger a problem here, but we guard against
   any NULL property to take a defensive stance against unexpected
   repository data.


Found by: Stefan Küng <tortoisesvn@gmail.com>
Review by: philip
           lundblad
           John Peacock <jpeacock@rowman.com>


r16626 | lundblad | 2005-10-10 07:36:02 -0500 (Mon, 10 Oct 2005)

Fix a bug in "svn info", where it tried to fetch a repository lock
for a path even if it was unrelated, or didn't exist in HEAD.

Suggested by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_client/info.c
  (same_resource_in_head): New function.
  (svn_client_info): Only ask for a lock if the URL exists in HEAD and
  refers to the same object as in the operative revision.

* subversion/libsvn_client/ra.c
  (svn_client__repos_locations): Return correct error code (as specified by the
  docstring) when the path isn't found in one of the revisions.
  (APR_EGENERAL doesn't seem like a good choice anyway:-)

* subversion/tests/clients/cmdline/lock_tests.py (info_moved_path(): New test.
  (test_list): Run it.


r16037 | danderson | 2005-09-03 17:58:25 -0500 (Sat, 03 Sep 2005)

Followup to r15948. Fix stack smashing bugs and other smaller issues.

Patch by: Stefan Küng <tortoisesvn@gmail.com>
(tweaked by me)
Suggested by: lundblad
(proposed the solution to avoid circular dependancy)

* subversion/include/svn_ra.h
  (svn_ra_progress_notify_func_t): Add an apr_pool_t to the callback
    prototype.
  (svn_ra_create_callbacks): New function to create and initialize the
    svn_ra_callbacks2_t object.
  (svn_ra_callbacks2_t): Add comment about svn_ra_create_callbacks().
  (svn_ra_callbacks_t): Change comment.

* subversion/libsvn_ra/ra_loader.c
  (svn_ra_create_callbacks): New function to create and initialize
    the svn_ra_callbacks2_t object.
  (svn_ra_open): Use the new svn_ra_create_callbacks().

* subversion/libsvn_ra/wrapper_template.h
  (compat_open): Allocate the svn_ra_callbacks2_t directly, to avoid
    introducing a circular dependancy.

* subversion/libsvn_ra_dav/session.c
  (neon_progress_baton_t): New structure to pass to the neon callback.
  (ra_dav_neonprogress): Pass the new apr_pool_t param to the progress
    callback.
  (svn_ra_dav__open): Use the new neon_progress_baton_t struct to pass
    to the neon callback function.


r16010 | danderson | 2005-08-30 18:58:16 -0500 (Tue, 30 Aug 2005)

Followup to r15948. Fix stack smashing bugs and other smaller issues.

Patch by: Stefan Küng <tortoisesvn@gmail.com>
Review by: danderson
(Patch also tweaked by me)

* subversion/include/svn_ra.h
  (svn_ra_progress_notify_func_t): Add an apr_pool_t to the callback
    prototype.
  (svn_ra_create_callbacks): New function to create and initialize the
    svn_ra_callbacks2_t object.
  (svn_ra_callbacks2_t): Add comment about svn_ra_create_callbacks().
  (svn_ra_callbacks_t): Change comment.

* subversion/libsvn_ra/ra_loader.c
  (svn_ra_create_callbacks): New function to create and initialize
    the svn_ra_callbacks2_t object.
  (svn_ra_open): Use the new svn_ra_create_callbacks().

* subversion/libsvn_ra/wrapper_template.h
  (compat_open): Use the new svn_ra_create_callbacks() function.

* subversion/libsvn_ra_dav/session.c
  (neon_progress_baton_t): New structure to pass to the neon callback.
  (ra_dav_neonprogress): Pass the new apr_pool_t param to the progress
    callback.
  (svn_ra_dav__open): Use the new neon_progress_baton_t struct to pass
    to the neon callback function.


r15948 | brane | 2005-08-28 08:03:41 -0500 (Sun, 28 Aug 2005)

Implement a reduced version of issue #901 for DAV connections.  Add a transfer
progress notification callback to the RA layer and call it from libsvn_ra_dav.

Patch by: Stefan Küng <tortoisesvn@gmail.com>
          brane

* subversion/include/svn_client.h: Explicitly include svn_ra.h.
  (svn_client_ctx_t): Extend the client context structure with the
   callback function and baton.
  (svn_client_open_ra_session): Update docstring.
* subversion/include/svn_ra.h
  (svn_ra_progress_notify_func_t): New. Notification callback function type.
  (svn_ra_callbacks_t): Deprecate the structure.
  (svn_ra_callbacks2_t): Same as svn_ra_callbacks_t, but with new
   progress notification callback and baton.
  (svn_ra_open2): New prototype.
  (svn_ra_open): Deprecate.
* subversion/libsvn_ra/ra_loader.h
  (svn_ra__vtable_t): Change signature of open() to use svn_ra_callbacks2_t.
* subversion/libsvn_ra/ra_loader.c
  (svn_ra_open): Deprecate function, calls svn_ra_open2().
  (svn_ra_open2): New function which takes an svn_ra_callbacks2_t
   instead of an svn_ra_callback_t.
* subversion/libsvn_client/ra.c (svn_client__open_ra_session_internal):
   Set the progress notification callback and baton, and call svn_ra_open2().
* subversion/libsvn_ra_dav/session.c
  (ra_dav_neonprogress): New function. The callback function neon calls
   during network data transfers.
  (svn_ra_dav__open): Set the neon callback function for the session.
* subversion/libsvn_ra_dav/ra_dav.h
  (svn_ra_dav__session_t): Use new svn_ra_callbacks2_t.
* subversion/libsvn_ra/wrapper_template.h
  (compat_open): Pass a svn_ra_callbacks2_t to the open() function.
* subversion/libsvn_ra_local/ra_local.h (svn_ra_local__session_baton_t),
  subversion/libsvn_ra_local/ra_plugin.c (svn_ra_local__open),
  subversion/libsvn_ra_svn/client.c (ra_svn_open):
  Use new svn_ra_callbacks2_t.
* subversion/libsvn_client/copy.c (repos_to_repos_copy): Correct comment.


r13176 | cmpilato | 2005-02-27 00:49:26 -0600 (Sun, 27 Feb 2005)

* subversion/include/svn_client.h
  (svn_client_status2): Fix a docco -- ignore_externals is set to
    FALSE, not TRUE.

Suggested by: Stefan Küng <steveking@gmx.ch>


r6664 | cmpilato | 2003-08-07 12:28:01 -0500 (Thu, 07 Aug 2003)

Finish issue #1296 for path->path exports.

Patch by: Stefan Küng <steveking@gmx.ch>
(Tweaked by me.)

* subversion/libsvn_client/export.c
  (copy_versioned_files): added "force" parameter which causes this
    function not to error out if a directory already exists.  Also,
    fix a place were an error was not cleared that should have been.
  (svn_client_export): pass the "force" parameter to 
    copy_versioned_files() too.


r6175 | mbk | 2003-06-09 06:40:08 -0500 (Mon, 09 Jun 2003)

Make svn_wc.h C++ friendly by renaming the "new" parameter to "URL".

Suggested by: Stefan Küng <steveking@gmx.ch>

* subversion/include/svn_wc.h
  (svn_wc_relocation_validator):  Update documentation, change parameter
   names.


r5937 | brane | 2003-05-14 15:51:55 -0500 (Wed, 14 May 2003)

Added a VS.Net project file for building neon.

Patch by: Stefan Küng <steveking@gmx.ch>

* build/win32/neon.vcproj: New.

* build/win32: Ignore the "msvc-dsp" and "vcnet-vcproj" subdirectories.


r5936 | brane | 2003-05-14 15:37:15 -0500 (Wed, 14 May 2003)

Change neon.dsp and build_neon.bat to assume this directory is the cwd
when the project is invoked, not the neon source directory. This presumably
makes build_neon.bat work with .vcproj files.

Patch by: Stefan Küng <steveking@gmx.ch>
          me

* build/win32/build_neon.bat: Change the working dir to ..\..\neon before
  doing anything else.
* build/win32/neon.dsp: Fix all relative paths to build_neon.bat, and
  remove the Target_Dir option.


r3728 | kfogel | 2002-11-11 13:26:58 -0600 (Mon, 11 Nov 2002)

* HACKING: Mention the need to call apr_initialize() first.

Suggested by: Stefan Küng <ichselbst@gmx.ch>